From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CF0FC6FD1C for ; Thu, 23 Mar 2023 02:58:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 447EB613B6; Thu, 23 Mar 2023 02:58:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 447EB613B6 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MR3wS8Fk X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rDYHl45dxq8p; Thu, 23 Mar 2023 02:58:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id D460460E44; Thu, 23 Mar 2023 02:58:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D460460E44 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A611DC0071; Thu, 23 Mar 2023 02:58:22 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 72627C0032 for ; Thu, 23 Mar 2023 02:58:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3E7AE40338 for ; Thu, 23 Mar 2023 02:58:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3E7AE40338 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MR3wS8Fk X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nMVY7MJvt2X5 for ; Thu, 23 Mar 2023 02:58:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 500C940332 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 500C940332 for ; Thu, 23 Mar 2023 02:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679540299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0VvJoT/In9zXsTG4Y/WHrDmIvI8+3uyMcN0Vni7Bkk=; b=MR3wS8FkkIgsoZBelJcZaUDuJkwcw4vhyLNFZvBUYWVrq2PPaqOc9+lJbPbFdHRCUXNqOi sQqPogTTI4b+B99Ug8TZGNnBxjDm3N7S5dbtmZm1Z1fNxvFrnEpCI4Yc2mi6SDNL2wLUh3 4/1GWbJj+D1ivhgFdgoaU5QzUUpd/Ik= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-soZMOjMtPUajkmXYI9JNgw-1; Wed, 22 Mar 2023 22:58:17 -0400 X-MC-Unique: soZMOjMtPUajkmXYI9JNgw-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-176347f3b28so10768291fac.23 for ; Wed, 22 Mar 2023 19:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679540297; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0VvJoT/In9zXsTG4Y/WHrDmIvI8+3uyMcN0Vni7Bkk=; b=QNGc0Gc1SXX/T7T/sFRSY0aNPJrO9vA166oIWpLGExVDLatsVPmb6/TkCgw0s9McEE jy1pszJf7KNypnRnytE+w7M81cYC3t0teK+z8kMsg+V402SpMMHwerLTcUVFctmH37Ku /pUaHc40OIfWp6L08sBiCfyDgNjFQEexhlWybfSkPOeg2i+fSYqxTFSqe5yzvSawsows 4xusGhW8KRbE7qdyt90i6Q7yKc58yRIbbsuF99Nxo9+1gVdImpwVk+rOKwqxoA8tlun7 u9NRq2iH1F9BCMOyFVMuleHgvJh09BaYH2e7mU1xJ6u8FVVjMfTyltcVQDpuX+Rey+1Q rY8A== X-Gm-Message-State: AO0yUKX4s0mXTKTdm1b/yp3VIzU8+8de2nl+6sA43oNkFqYTA8eS8IWq cXQCLyKsGiCbyz9ivkOj8O6ODPejusDFrh7udtRfJsTs51g5JGaqlm+cTnM44o5iLDUf7YEbpM6 obqkIHkByxAnbVkCXBHeRdnRedzV/RHb+NRFq4Yjnwn3myn7MCovxvEiB0A== X-Received: by 2002:a9d:66d1:0:b0:69f:bac:aa8a with SMTP id t17-20020a9d66d1000000b0069f0bacaa8amr1815481otm.2.1679540296924; Wed, 22 Mar 2023 19:58:16 -0700 (PDT) X-Google-Smtp-Source: AK7set/BWrafeE27f5b5IZId0P5hAaqy+ikMd7Pl7UM4zZNHvprQ9rbOtFWqSmX8VPoPdPkZ143ngQ4DrCO+EBX4+4A= X-Received: by 2002:a9d:66d1:0:b0:69f:bac:aa8a with SMTP id t17-20020a9d66d1000000b0069f0bacaa8amr1815470otm.2.1679540296705; Wed, 22 Mar 2023 19:58:16 -0700 (PDT) MIME-Version: 1.0 References: <20230321154228.182769-1-sgarzare@redhat.com> <20230321154228.182769-2-sgarzare@redhat.com> In-Reply-To: <20230321154228.182769-2-sgarzare@redhat.com> From: Jason Wang Date: Thu, 23 Mar 2023 10:58:05 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] vdpa: add bind_mm/unbind_mm callbacks To: Stefano Garzarella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Andrey Zhadchenko , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, eperezma@redhat.com, stefanha@redhat.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBNYXIgMjEsIDIwMjMgYXQgMTE6NDLigK9QTSBTdGVmYW5vIEdhcnphcmVsbGEgPHNn YXJ6YXJlQHJlZGhhdC5jb20+IHdyb3RlOgo+Cj4gVGhlc2UgbmV3IG9wdGlvbmFsIGNhbGxiYWNr cyBpcyB1c2VkIHRvIGJpbmQvdW5iaW5kIHRoZSBkZXZpY2UgdG8KPiBhIHNwZWNpZmljIGFkZHJl c3Mgc3BhY2Ugc28gdGhlIHZEUEEgZnJhbWV3b3JrIGNhbiB1c2UgVkEgd2hlbgo+IHRoZXNlIGNh bGxiYWNrcyBhcmUgaW1wbGVtZW50ZWQuCj4KPiBTdWdnZXN0ZWQtYnk6IEphc29uIFdhbmcgPGph c293YW5nQHJlZGhhdC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBHYXJ6YXJlbGxhIDxz Z2FyemFyZUByZWRoYXQuY29tPgoKQWNrZWQtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhh dC5jb20+CgpUaGFua3MKCj4gLS0tCj4KPiBOb3RlczoKPiAgICAgdjI6Cj4gICAgIC0gcmVtb3Zl ZCBgc3RydWN0IHRhc2tfc3RydWN0ICpvd25lcmAgcGFyYW0gKHVudXNlZCBmb3Igbm93LCBtYXli ZQo+ICAgICAgIHVzZWZ1bCB0byBzdXBwb3J0IGNncm91cHMpIFtKYXNvbl0KPiAgICAgLSBhZGQg dW5iaW5kX21tIGNhbGxiYWNrIFtKYXNvbl0KPgo+ICBpbmNsdWRlL2xpbnV4L3ZkcGEuaCB8IDEw ICsrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykKPgo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L3ZkcGEuaCBiL2luY2x1ZGUvbGludXgvdmRwYS5oCj4gaW5k ZXggNDNmNTllZjEwY2M5Li4zNjljMjEzOTQyODQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51 eC92ZHBhLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3ZkcGEuaAo+IEBAIC0yOTAsNiArMjkwLDE0 IEBAIHN0cnVjdCB2ZHBhX21hcF9maWxlIHsKPiAgICogICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEB2ZGV2OiB2ZHBhIGRldmljZQo+ICAgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg QGlkeDogdmlydHF1ZXVlIGluZGV4Cj4gICAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICBS ZXR1cm5zIHBvaW50ZXIgdG8gc3RydWN0dXJlIGRldmljZSBvciBlcnJvciAoTlVMTCkKPiArICog QGJpbmRfbW06ICAgICAgICAgICAgICAgICAgIEJpbmQgdGhlIGRldmljZSB0byBhIHNwZWNpZmlj IGFkZHJlc3Mgc3BhY2UKPiArICogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNvIHRoZSB2 RFBBIGZyYW1ld29yayBjYW4gdXNlIFZBIHdoZW4gdGhpcwo+ICsgKiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY2FsbGJhY2sgaXMgaW1wbGVtZW50ZWQuIChvcHRpb25hbCkKPiArICogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIEB2ZGV2OiB2ZHBhIGRldmljZQo+ICsgKiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgQG1tOiBhZGRyZXNzIHNwYWNlIHRvIGJpbmQKPiArICogQHVu YmluZF9tbTogICAgICAgICAgICAgICAgIFVuYmluZCB0aGUgZGV2aWNlIGZyb20gdGhlIGFkZHJl c3Mgc3BhY2UKPiArICogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvdW5kIHVzaW5nIHRo ZSBiaW5kX21tIGNhbGxiYWNrLiAob3B0aW9uYWwpCj4gKyAqICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBAdmRldjogdmRwYSBkZXZpY2UKPiAgICogQGZyZWU6ICAgICAgICAgICAgICAgICAg ICAgIEZyZWUgcmVzb3VyY2VzIHRoYXQgYmVsb25ncyB0byB2RFBBIChvcHRpb25hbCkKPiAgICog ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEB2ZGV2OiB2ZHBhIGRldmljZQo+ICAgKi8KPiBA QCAtMzUxLDYgKzM1OSw4IEBAIHN0cnVjdCB2ZHBhX2NvbmZpZ19vcHMgewo+ICAgICAgICAgaW50 ICgqc2V0X2dyb3VwX2FzaWQpKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldiwgdW5zaWduZWQgaW50 IGdyb3VwLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBhc2lk KTsKPiAgICAgICAgIHN0cnVjdCBkZXZpY2UgKigqZ2V0X3ZxX2RtYV9kZXYpKHN0cnVjdCB2ZHBh X2RldmljZSAqdmRldiwgdTE2IGlkeCk7Cj4gKyAgICAgICBpbnQgKCpiaW5kX21tKShzdHJ1Y3Qg dmRwYV9kZXZpY2UgKnZkZXYsIHN0cnVjdCBtbV9zdHJ1Y3QgKm1tKTsKPiArICAgICAgIHZvaWQg KCp1bmJpbmRfbW0pKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRldik7Cj4KPiAgICAgICAgIC8qIEZy ZWUgZGV2aWNlIHJlc291cmNlcyAqLwo+ICAgICAgICAgdm9pZCAoKmZyZWUpKHN0cnVjdCB2ZHBh X2RldmljZSAqdmRldik7Cj4gLS0KPiAyLjM5LjIKPgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1 YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE54FC6FD1C for ; Thu, 23 Mar 2023 02:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbjCWC7D (ORCPT ); Wed, 22 Mar 2023 22:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbjCWC7B (ORCPT ); Wed, 22 Mar 2023 22:59:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59D2AE18C for ; Wed, 22 Mar 2023 19:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679540299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0VvJoT/In9zXsTG4Y/WHrDmIvI8+3uyMcN0Vni7Bkk=; b=MR3wS8FkkIgsoZBelJcZaUDuJkwcw4vhyLNFZvBUYWVrq2PPaqOc9+lJbPbFdHRCUXNqOi sQqPogTTI4b+B99Ug8TZGNnBxjDm3N7S5dbtmZm1Z1fNxvFrnEpCI4Yc2mi6SDNL2wLUh3 4/1GWbJj+D1ivhgFdgoaU5QzUUpd/Ik= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-fFEv3554P4iTN7DXJAWBKQ-1; Wed, 22 Mar 2023 22:58:17 -0400 X-MC-Unique: fFEv3554P4iTN7DXJAWBKQ-1 Received: by mail-oo1-f69.google.com with SMTP id d2-20020a4a5202000000b0053b5874f94aso2641640oob.3 for ; Wed, 22 Mar 2023 19:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679540297; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0VvJoT/In9zXsTG4Y/WHrDmIvI8+3uyMcN0Vni7Bkk=; b=nxabUZ68G9i3ADUC3b6l8Ugy0S86l5ngVULTWPOvlU5k7xkA08CaRD4gyYIgXPkelz zPQcCELAGgz6+h6mTTlDTuUvRljsAlGRVvNT2o/HU/e5Beg23KvnOBTVKmdOsgs/vH05 fDPDtUWv1Gr+ZFqKhdwcLi3feA8IlSvSWVmrY0vmm7WNXRceCOK/TVbYQ+IhhMdZMDpv yHDoB2lIcxaOvK65pLzrP90BFhdl8cErotrSDGMUfvaBzjvlerGMcY6Zr70mMNebW9Zi UYAOmSWMv3Q6825C2PXl7wsn+xdV8kge3gXJrvXQpnJ589tDpq7eGAhcbovGvdN8iAED WLlg== X-Gm-Message-State: AO0yUKU+IAzj5Eyl78rGCR44Yfr+IRJ0m3knsaPVmR36Tk3A2rYV8XmF oKQJTAO8E9264avnadG3f2lMEooeVTfYlxmiDlLpSj1lHOCa77HLDMqZ4UEpKPyIo+B5GVISnh0 ioybty9yzoQQelzMe3589/0YelxH01Fj1Lgk12McGpaKA7yrT88nZjw== X-Received: by 2002:a9d:66d1:0:b0:69f:bac:aa8a with SMTP id t17-20020a9d66d1000000b0069f0bacaa8amr1815473otm.2.1679540296912; Wed, 22 Mar 2023 19:58:16 -0700 (PDT) X-Google-Smtp-Source: AK7set/BWrafeE27f5b5IZId0P5hAaqy+ikMd7Pl7UM4zZNHvprQ9rbOtFWqSmX8VPoPdPkZ143ngQ4DrCO+EBX4+4A= X-Received: by 2002:a9d:66d1:0:b0:69f:bac:aa8a with SMTP id t17-20020a9d66d1000000b0069f0bacaa8amr1815470otm.2.1679540296705; Wed, 22 Mar 2023 19:58:16 -0700 (PDT) MIME-Version: 1.0 References: <20230321154228.182769-1-sgarzare@redhat.com> <20230321154228.182769-2-sgarzare@redhat.com> In-Reply-To: <20230321154228.182769-2-sgarzare@redhat.com> From: Jason Wang Date: Thu, 23 Mar 2023 10:58:05 +0800 Message-ID: Subject: Re: [PATCH v3 1/8] vdpa: add bind_mm/unbind_mm callbacks To: Stefano Garzarella Cc: virtualization@lists.linux-foundation.org, stefanha@redhat.com, "Michael S. Tsirkin" , Andrey Zhadchenko , eperezma@redhat.com, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 11:42=E2=80=AFPM Stefano Garzarella wrote: > > These new optional callbacks is used to bind/unbind the device to > a specific address space so the vDPA framework can use VA when > these callbacks are implemented. > > Suggested-by: Jason Wang > Signed-off-by: Stefano Garzarella Acked-by: Jason Wang Thanks > --- > > Notes: > v2: > - removed `struct task_struct *owner` param (unused for now, maybe > useful to support cgroups) [Jason] > - add unbind_mm callback [Jason] > > include/linux/vdpa.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 43f59ef10cc9..369c21394284 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -290,6 +290,14 @@ struct vdpa_map_file { > * @vdev: vdpa device > * @idx: virtqueue index > * Returns pointer to structure device or er= ror (NULL) > + * @bind_mm: Bind the device to a specific address spa= ce > + * so the vDPA framework can use VA when thi= s > + * callback is implemented. (optional) > + * @vdev: vdpa device > + * @mm: address space to bind > + * @unbind_mm: Unbind the device from the address space > + * bound using the bind_mm callback. (option= al) > + * @vdev: vdpa device > * @free: Free resources that belongs to vDPA (opti= onal) > * @vdev: vdpa device > */ > @@ -351,6 +359,8 @@ struct vdpa_config_ops { > int (*set_group_asid)(struct vdpa_device *vdev, unsigned int grou= p, > unsigned int asid); > struct device *(*get_vq_dma_dev)(struct vdpa_device *vdev, u16 id= x); > + int (*bind_mm)(struct vdpa_device *vdev, struct mm_struct *mm); > + void (*unbind_mm)(struct vdpa_device *vdev); > > /* Free device resources */ > void (*free)(struct vdpa_device *vdev); > -- > 2.39.2 >