From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91E2C433F5 for ; Tue, 2 Nov 2021 04:57:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63B3360F36 for ; Tue, 2 Nov 2021 04:57:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63B3360F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 19C7560665; Tue, 2 Nov 2021 04:57:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0891LQ56ExXz; Tue, 2 Nov 2021 04:57:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2B09560655; Tue, 2 Nov 2021 04:57:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06EC7C0019; Tue, 2 Nov 2021 04:57:49 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C8AA1C000E for ; Tue, 2 Nov 2021 04:57:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AD9D280CA7 for ; Tue, 2 Nov 2021 04:57:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3UyMNMGoaG-7 for ; Tue, 2 Nov 2021 04:57:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1324B80C9E for ; Tue, 2 Nov 2021 04:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635829064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPxOPCRc3Z2/1ON035liOxmgokBJHX5NnrY+1zM54tQ=; b=jCaMfU1V/kPIiT/Vc1dTiS/0QSbPo83sik9Rqa2T/FjeG1/Jk72kuQw8ILaCqHK7EV1m1e hZRj1cJth2z73f0t98hJuyvOgELCO+DHDNoX3YT3JcZokO4mnJwRkJBJe75bf0f5wjLcpy DjWMDaqqsJoWu6uHolEQFZnOycL8fKs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-2AT6xD9kOna9giWMQEjhLQ-1; Tue, 02 Nov 2021 00:57:41 -0400 X-MC-Unique: 2AT6xD9kOna9giWMQEjhLQ-1 Received: by mail-lj1-f199.google.com with SMTP id bn14-20020a05651c178e00b002164a557684so1314567ljb.6 for ; Mon, 01 Nov 2021 21:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fPxOPCRc3Z2/1ON035liOxmgokBJHX5NnrY+1zM54tQ=; b=sTC99L1mNIZrzAdm7gh+Je++KvcvhyD13qYY+oLVnlcf8jMKyz53STKk+tADrl9Bb0 lwmJUdUpHgW3NVASS15PwsYS2cJAogyHL0tg4ThgR1N5KJ6d2kmijkzTSFg6zRoNT22p 6GoclH4ctKKt1fcLJ0k6PFsFBgEmOSI+mCVI5C0lVZrhzaSWLRgXNqyc1vAlQ4QUYjSE idhBNW8DKNFO856VQLKv/iLgafRB6bCwejikEUm7PDYv3nXxjgrutB7SiZdMoB9v5nYw 5R1nlIRaCvM89Aviakm7uVfKqDBgMwnSi/XKVDSf+h3KRHehtEHF+1U3qssV7xheZBu1 VlfA== X-Gm-Message-State: AOAM533LDihkSQRw2ZIiztQjwnFh1ZNgpyDl4pKh8Kea8Y+pV7LMmCXe KXxzIgN+CcNQWTXSfeOINjbej8Fi2lVOIti9ElNrIuJsEqsnrPeP5CRLzGYFsatWEfD80yCEAIH 6Czyx4FY4CQHlbdCFEsDJRfOj6EwGuZc363CkNVZwxZN03HvPD25NzLBH0A== X-Received: by 2002:a05:6512:110d:: with SMTP id l13mr30883198lfg.199.1635829059851; Mon, 01 Nov 2021 21:57:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2FLI/DDC4r0Zz7kO0JbzR7nV0V5lH9M3uGR5Y5AeohLGlQG14sh4TdH3r24iVDPQtW68o98ohqXgPTRrHm+k= X-Received: by 2002:a05:6512:110d:: with SMTP id l13mr30883164lfg.199.1635829059598; Mon, 01 Nov 2021 21:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-4-eperezma@redhat.com> In-Reply-To: <20211029183525.1776416-4-eperezma@redhat.com> From: Jason Wang Date: Tue, 2 Nov 2021 12:57:28 +0800 Message-ID: Subject: Re: [RFC PATCH v5 03/26] virtio: Add VIRTIO_F_QUEUE_STATE To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Eric Blake , virtualization , Parav Pandit X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gU2F0LCBPY3QgMzAsIDIwMjEgYXQgMjozNiBBTSBFdWdlbmlvIFDDqXJleiA8ZXBlcmV6bWFA cmVkaGF0LmNvbT4gd3JvdGU6Cj4KPiBJbXBsZW1lbnRhdGlvbiBvZiBSRkMgb2YgZGV2aWNlIHN0 YXRlIGNhcGFiaWxpdHk6Cj4gaHR0cHM6Ly9saXN0cy5vYXNpcy1vcGVuLm9yZy9hcmNoaXZlcy92 aXJ0aW8tY29tbWVudC8yMDIwMTIvbXNnMDAwMDUuaHRtbAoKQ29uc2lkZXJpbmcgdGhpcyBzdGls bCByZXF1aXJlcyB0aW1lIHRvIGJlIGRvbmUsIHdlIG5lZWQgdG8gdGhpbmsgb2YgYQp3YXkgdG8g Z28gd2l0aG91dCB0aGlzLgoKVGhhbmtzCgoKCj4KPiBXaXRoIHRoaXMgY2FwYWJpbGl0eSwgdmRw YSBkZXZpY2UgY2FuIHJlc2V0IGl0J3MgaW5kZXggc28gaXQgY2FuIHN0YXJ0Cj4gY29uc3VtaW5n IGZyb20gZ3Vlc3QgYWZ0ZXIgZGlzYWJsaW5nIHNoYWRvdyB2aXJ0cXVldWUgKFNWUSksIHdpdGgg c3RhdGUKPiBub3QgMC4KPgo+IFRoZSB1c2UgY2FzZSBpcyB0byB0ZXN0IFNWUSB3aXRoIHZpcnRp by1wY2kgdmRwYSAodnBfdmRwYSkgd2l0aCBuZXN0ZWQKPiB2aXJ0dWFsaXphdGlvbi4gU3Bhd25p bmcgYSBMMCBxZW11IHdpdGggYSB2aXJ0aW8tbmV0IGRldmljZSwgdXNlCj4gdnBfdmRwYSBkcml2 ZXIgdG8gaGFuZGxlIGl0IGluIHRoZSBndWVzdCwgYW5kIHRoZW4gc3Bhd24gYSBMMSBxZW11IHVz aW5nCj4gdGhhdCB2ZHBhIGRldmljZS4gV2hlbiBMMSBxZW11IGNhbGxzIGRldmljZSB0byBzZXQg YSBuZXcgc3RhdGUgdGhvdWdoCj4gdmRwYSBpb2N0bCwgdnBfdmRwYSBzaG91bGQgc2V0IGVhY2gg cXVldWUgc3RhdGUgdGhvdWdoIHZpcnRpbwo+IFZJUlRJT19QQ0lfQ09NTU9OX1FfQVZBSUxfU1RB VEUuCj4KPiBTaW5jZSB0aGlzIGlzIG9ubHkgZm9yIHRlc3Rpbmcgdmhvc3QtdmRwYSwgaXQncyBh ZGRlZCBoZXJlIGJlZm9yZSBvZgo+IHByb3Bvc2luZyB0byBrZXJuZWwgY29kZS4gTm8gZWZmb3J0 IGlzIGRvbmUgZm9yIGNoZWNraW5nIHRoYXQgZGV2aWNlCj4gY2FuIGFjdHVhbGx5IGNoYW5nZSBp dHMgc3RhdGUsIGl0cyBsYXlvdXQsIG9yIGlmIHRoZSBkZXZpY2UgZXZlbgo+IHN1cHBvcnRzIHRv IGNoYW5nZSBzdGF0ZSBhdCBhbGwuIFRoZXNlIHdpbGwgYmUgYWRkZWQgaW4gdGhlIGZ1dHVyZS4K Pgo+IEFsc28sIGEgbW9kaWZpZWQgdmVyc2lvbiBvZiB2cF92ZHBhIHRoYXQgYWxsb3dzIHRvIHNl dCB0aGVzZSBpbiBQQ0kKPiBjb25maWcgaXMgbmVlZGVkLgo+Cj4gVE9ETzogQ2hlY2sgZm9yIGZl YXR1cmUgZW5hYmxlZCBhbmQgc3BsaXQgaW4gdmlydGlvIHBjaSBjb25maWcKPgo+IFNpZ25lZC1v ZmYtYnk6IEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXptYUByZWRoYXQuY29tPgo+IC0tLQo+ICBody92 aXJ0aW8vdmlydGlvLXBjaS5oICAgICAgICAgICAgICAgICAgICAgICAgIHwgMSArCj4gIGluY2x1 ZGUvaHcvdmlydGlvL3ZpcnRpby5oICAgICAgICAgICAgICAgICAgICAgfCA0ICsrKy0KPiAgaW5j bHVkZS9zdGFuZGFyZC1oZWFkZXJzL2xpbnV4L3ZpcnRpb19jb25maWcuaCB8IDMgKysrCj4gIGlu Y2x1ZGUvc3RhbmRhcmQtaGVhZGVycy9saW51eC92aXJ0aW9fcGNpLmggICAgfCAyICsrCj4gIGh3 L3ZpcnRpby92aXJ0aW8tcGNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCA5ICsrKysrKysr Kwo+ICA1IGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+ IGRpZmYgLS1naXQgYS9ody92aXJ0aW8vdmlydGlvLXBjaS5oIGIvaHcvdmlydGlvL3ZpcnRpby1w Y2kuaAo+IGluZGV4IDI0NDZkY2Q5YWUuLjAxOWJhZGJkN2MgMTAwNjQ0Cj4gLS0tIGEvaHcvdmly dGlvL3ZpcnRpby1wY2kuaAo+ICsrKyBiL2h3L3ZpcnRpby92aXJ0aW8tcGNpLmgKPiBAQCAtMTIw LDYgKzEyMCw3IEBAIHR5cGVkZWYgc3RydWN0IFZpcnRJT1BDSVF1ZXVlIHsKPiAgICB1aW50MzJf dCBkZXNjWzJdOwo+ICAgIHVpbnQzMl90IGF2YWlsWzJdOwo+ICAgIHVpbnQzMl90IHVzZWRbMl07 Cj4gKyAgdWludDE2X3Qgc3RhdGU7Cj4gIH0gVmlydElPUENJUXVldWU7Cj4KPiAgc3RydWN0IFZp cnRJT1BDSVByb3h5IHsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody92aXJ0aW8vdmlydGlvLmgg Yi9pbmNsdWRlL2h3L3ZpcnRpby92aXJ0aW8uaAo+IGluZGV4IDhiYWI5Y2ZiNzUuLjVmZTU3NWI4 ZjAgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9ody92aXJ0aW8vdmlydGlvLmgKPiArKysgYi9pbmNs dWRlL2h3L3ZpcnRpby92aXJ0aW8uaAo+IEBAIC0yODksNyArMjg5LDkgQEAgdHlwZWRlZiBzdHJ1 Y3QgVmlydElPUk5HQ29uZiBWaXJ0SU9STkdDb25mOwo+ICAgICAgREVGSU5FX1BST1BfQklUNjQo ImlvbW11X3BsYXRmb3JtIiwgX3N0YXRlLCBfZmllbGQsIFwKPiAgICAgICAgICAgICAgICAgICAg ICAgIFZJUlRJT19GX0lPTU1VX1BMQVRGT1JNLCBmYWxzZSksIFwKPiAgICAgIERFRklORV9QUk9Q X0JJVDY0KCJwYWNrZWQiLCBfc3RhdGUsIF9maWVsZCwgXAo+IC0gICAgICAgICAgICAgICAgICAg ICAgVklSVElPX0ZfUklOR19QQUNLRUQsIGZhbHNlKQo+ICsgICAgICAgICAgICAgICAgICAgICAg VklSVElPX0ZfUklOR19QQUNLRUQsIGZhbHNlKSwgXAo+ICsgICAgREVGSU5FX1BST1BfQklUNjQo InNhdmVfcmVzdG9yZV9xX3N0YXRlIiwgX3N0YXRlLCBfZmllbGQsIFwKPiArICAgICAgICAgICAg ICAgICAgICAgIFZJUlRJT19GX1FVRVVFX1NUQVRFLCB0cnVlKQo+Cj4gIGh3YWRkciB2aXJ0aW9f cXVldWVfZ2V0X2Rlc2NfYWRkcihWaXJ0SU9EZXZpY2UgKnZkZXYsIGludCBuKTsKPiAgYm9vbCB2 aXJ0aW9fcXVldWVfZW5hYmxlZF9sZWdhY3koVmlydElPRGV2aWNlICp2ZGV2LCBpbnQgbik7Cj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvc3RhbmRhcmQtaGVhZGVycy9saW51eC92aXJ0aW9fY29uZmln LmggYi9pbmNsdWRlL3N0YW5kYXJkLWhlYWRlcnMvbGludXgvdmlydGlvX2NvbmZpZy5oCj4gaW5k ZXggMjJlM2E4NWY2Ny4uNTlmYWQzZWI0NSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3N0YW5kYXJk LWhlYWRlcnMvbGludXgvdmlydGlvX2NvbmZpZy5oCj4gKysrIGIvaW5jbHVkZS9zdGFuZGFyZC1o ZWFkZXJzL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+IEBAIC05MCw0ICs5MCw3IEBACj4gICAqIERv ZXMgdGhlIGRldmljZSBzdXBwb3J0IFNpbmdsZSBSb290IEkvTyBWaXJ0dWFsaXphdGlvbj8KPiAg ICovCj4gICNkZWZpbmUgVklSVElPX0ZfU1JfSU9WICAgICAgICAgICAgICAgICAgICAgICAgMzcK PiArCj4gKy8qIERldmljZSBzdXBwb3J0IHNhdmUgYW5kIHJlc3RvcmUgdmlydHF1ZXVlIHN0YXRl ICovCj4gKyNkZWZpbmUgVklSVElPX0ZfUVVFVUVfU1RBVEUgICAgICAgICAgICA0MAo+ICAjZW5k aWYgLyogX0xJTlVYX1ZJUlRJT19DT05GSUdfSCAqLwo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3N0 YW5kYXJkLWhlYWRlcnMvbGludXgvdmlydGlvX3BjaS5oIGIvaW5jbHVkZS9zdGFuZGFyZC1oZWFk ZXJzL2xpbnV4L3ZpcnRpb19wY2kuaAo+IGluZGV4IGRiN2E4ZTJmY2IuLmM4ZDk4MDJhODcgMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9zdGFuZGFyZC1oZWFkZXJzL2xpbnV4L3ZpcnRpb19wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvc3RhbmRhcmQtaGVhZGVycy9saW51eC92aXJ0aW9fcGNpLmgKPiBAQCAt MTY0LDYgKzE2NCw3IEBAIHN0cnVjdCB2aXJ0aW9fcGNpX2NvbW1vbl9jZmcgewo+ICAgICAgICAg dWludDMyX3QgcXVldWVfYXZhaWxfaGk7ICAgICAgICAgICAgICAgIC8qIHJlYWQtd3JpdGUgKi8K PiAgICAgICAgIHVpbnQzMl90IHF1ZXVlX3VzZWRfbG87ICAgICAgICAgLyogcmVhZC13cml0ZSAq Lwo+ICAgICAgICAgdWludDMyX3QgcXVldWVfdXNlZF9oaTsgICAgICAgICAvKiByZWFkLXdyaXRl ICovCj4gKyAgICAgICB1aW50MTZfdCBxdWV1ZV9hdmFpbF9zdGF0ZTsgICAgIC8qIHJlYWQtd3Jp dGUgKi8KPiAgfTsKPgo+ICAvKiBGaWVsZHMgaW4gVklSVElPX1BDSV9DQVBfUENJX0NGRzogKi8K PiBAQCAtMjAyLDYgKzIwMyw3IEBAIHN0cnVjdCB2aXJ0aW9fcGNpX2NmZ19jYXAgewo+ICAjZGVm aW5lIFZJUlRJT19QQ0lfQ09NTU9OX1FfQVZBSUxISSAgICA0NAo+ICAjZGVmaW5lIFZJUlRJT19Q Q0lfQ09NTU9OX1FfVVNFRExPICAgICA0OAo+ICAjZGVmaW5lIFZJUlRJT19QQ0lfQ09NTU9OX1Ff VVNFREhJICAgICA1Mgo+ICsjZGVmaW5lIFZJUlRJT19QQ0lfQ09NTU9OX1FfQVZBSUxfU1RBVEUg ICAgICAgIDU2Cj4KPiAgI2VuZGlmIC8qIFZJUlRJT19QQ0lfTk9fTU9ERVJOICovCj4KPiBkaWZm IC0tZ2l0IGEvaHcvdmlydGlvL3ZpcnRpby1wY2kuYyBiL2h3L3ZpcnRpby92aXJ0aW8tcGNpLmMK PiBpbmRleCA3NTBhYTQ3ZWMxLi5kN2JiNTQ5MDMzIDEwMDY0NAo+IC0tLSBhL2h3L3ZpcnRpby92 aXJ0aW8tcGNpLmMKPiArKysgYi9ody92aXJ0aW8vdmlydGlvLXBjaS5jCj4gQEAgLTEyNDQsNiAr MTI0NCw5IEBAIHN0YXRpYyB1aW50NjRfdCB2aXJ0aW9fcGNpX2NvbW1vbl9yZWFkKHZvaWQgKm9w YXF1ZSwgaHdhZGRyIGFkZHIsCj4gICAgICBjYXNlIFZJUlRJT19QQ0lfQ09NTU9OX1FfVVNFREhJ Ogo+ICAgICAgICAgIHZhbCA9IHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS51c2VkWzFdOwo+ ICAgICAgICAgIGJyZWFrOwo+ICsgICAgY2FzZSBWSVJUSU9fUENJX0NPTU1PTl9RX0FWQUlMX1NU QVRFOgo+ICsgICAgICAgIHZhbCA9IHZpcnRpb19xdWV1ZV9nZXRfbGFzdF9hdmFpbF9pZHgodmRl diwgdmRldi0+cXVldWVfc2VsKTsKPiArICAgICAgICBicmVhazsKPiAgICAgIGRlZmF1bHQ6Cj4g ICAgICAgICAgdmFsID0gMDsKPiAgICAgIH0KPiBAQCAtMTMzMCw2ICsxMzMzLDggQEAgc3RhdGlj IHZvaWQgdmlydGlvX3BjaV9jb21tb25fd3JpdGUodm9pZCAqb3BhcXVlLCBod2FkZHIgYWRkciwK PiAgICAgICAgICAgICAgICAgICAgICAgICBwcm94eS0+dnFzW3ZkZXYtPnF1ZXVlX3NlbF0uYXZh aWxbMF0sCj4gICAgICAgICAgICAgICAgICAgICAgICAgKCh1aW50NjRfdClwcm94eS0+dnFzW3Zk ZXYtPnF1ZXVlX3NlbF0udXNlZFsxXSkgPDwgMzIgfAo+ICAgICAgICAgICAgICAgICAgICAgICAg IHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS51c2VkWzBdKTsKPiArICAgICAgICAgICAgdmly dGlvX3F1ZXVlX3NldF9sYXN0X2F2YWlsX2lkeCh2ZGV2LCB2ZGV2LT5xdWV1ZV9zZWwsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgIHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS5zdGF0ZSk7 Cj4gICAgICAgICAgICAgIHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS5lbmFibGVkID0gMTsK PiAgICAgICAgICB9IGVsc2Ugewo+ICAgICAgICAgICAgICB2aXJ0aW9fZXJyb3IodmRldiwgIndy b25nIHZhbHVlIGZvciBxdWV1ZV9lbmFibGUgJSJQUkl4NjQsIHZhbCk7Cj4gQEAgLTEzNTMsNiAr MTM1OCw5IEBAIHN0YXRpYyB2b2lkIHZpcnRpb19wY2lfY29tbW9uX3dyaXRlKHZvaWQgKm9wYXF1 ZSwgaHdhZGRyIGFkZHIsCj4gICAgICBjYXNlIFZJUlRJT19QQ0lfQ09NTU9OX1FfVVNFREhJOgo+ ICAgICAgICAgIHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS51c2VkWzFdID0gdmFsOwo+ICAg ICAgICAgIGJyZWFrOwo+ICsgICAgY2FzZSBWSVJUSU9fUENJX0NPTU1PTl9RX0FWQUlMX1NUQVRF Ogo+ICsgICAgICAgIHByb3h5LT52cXNbdmRldi0+cXVldWVfc2VsXS5zdGF0ZSA9IHZhbDsKPiAr ICAgICAgICBicmVhazsKPiAgICAgIGRlZmF1bHQ6Cj4gICAgICAgICAgYnJlYWs7Cj4gICAgICB9 Cj4gQEAgLTE5NTEsNiArMTk1OSw3IEBAIHN0YXRpYyB2b2lkIHZpcnRpb19wY2lfcmVzZXQoRGV2 aWNlU3RhdGUgKnFkZXYpCj4gICAgICAgICAgcHJveHktPnZxc1tpXS5kZXNjWzBdID0gcHJveHkt PnZxc1tpXS5kZXNjWzFdID0gMDsKPiAgICAgICAgICBwcm94eS0+dnFzW2ldLmF2YWlsWzBdID0g cHJveHktPnZxc1tpXS5hdmFpbFsxXSA9IDA7Cj4gICAgICAgICAgcHJveHktPnZxc1tpXS51c2Vk WzBdID0gcHJveHktPnZxc1tpXS51c2VkWzFdID0gMDsKPiArICAgICAgICBwcm94eS0+dnFzW2ld LnN0YXRlID0gMDsKPiAgICAgIH0KPgo+ICAgICAgaWYgKHBjaV9pc19leHByZXNzKGRldikpIHsK PiAtLQo+IDIuMjcuMAo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321DCC433EF for ; Tue, 2 Nov 2021 04:59:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AE0360F0F for ; Tue, 2 Nov 2021 04:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AE0360F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhlt3-0001bL-DI for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 00:59:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhlro-0000v9-3q for qemu-devel@nongnu.org; Tue, 02 Nov 2021 00:57:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhlrk-0005M4-Jg for qemu-devel@nongnu.org; Tue, 02 Nov 2021 00:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635829063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fPxOPCRc3Z2/1ON035liOxmgokBJHX5NnrY+1zM54tQ=; b=SvvioHpAfT//n0d3vr9MLdBm+nQjEil4pq5oeAlgjSDymYKCo5dR8jtEO56/h5SNhWGZ1u r0tm6gmpOQ0BZEw4++WRLqfJYUxo/cyqjw3o9qtlMEBlmFmospmRmjjQZjFziY783drwmm L+jxcnUS4/uoQirG8qbw5sTxYbEnOnc= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-V9mTuxQhOgiERr_ijHGQLQ-1; Tue, 02 Nov 2021 00:57:41 -0400 X-MC-Unique: V9mTuxQhOgiERr_ijHGQLQ-1 Received: by mail-lj1-f200.google.com with SMTP id v13-20020a2e2f0d000000b0021126b5cca2so7131307ljv.19 for ; Mon, 01 Nov 2021 21:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fPxOPCRc3Z2/1ON035liOxmgokBJHX5NnrY+1zM54tQ=; b=RXsDYupb3MLPOr3LozBT+0PzL9aR6jLgBugFLO8A+VwBBaJnnZLPrZTWKHrBRwGFk2 Wul+L9y0hnwLSy0FZ6YlC+28ehy5FZD1jaD9MmzKMwhqKchg5aW31gUBJOCWwEDMtZ7V UpsyzJj2t716ZjlEZ3qt5EgjZ/j2FjSKjCDSzd3ADs3l/OFkGLgjgYeY6TFKnGMezdqI FKxnsp1AZBZwP6YUQfZ8wcdrTGNeRDuRGXALI0OvvvJl9fEIHDy8iBzqKzAU+LhG24kD ivJw7oig93Ww4yECwq95AhMAdviMr41UG7g+jDNMOglQB2/4FU34DVo93/fHgIz9CSHJ Zf8g== X-Gm-Message-State: AOAM532Na6dY64Z7Q0zSzSrVHlkog7fwCLZbEpuy9SYQDaNuJEaTq/cI 634g30ghS1ZyvT6/TbtH0ZtoguITle2FS4DAGkHWvapTU/PRK0iwrkjsMbkklCuYa9axMrYZ6JM PyV6/qwovDdTIuhWDMnn8fOcb/8eyzlk= X-Received: by 2002:a05:6512:110d:: with SMTP id l13mr30883202lfg.199.1635829059894; Mon, 01 Nov 2021 21:57:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2FLI/DDC4r0Zz7kO0JbzR7nV0V5lH9M3uGR5Y5AeohLGlQG14sh4TdH3r24iVDPQtW68o98ohqXgPTRrHm+k= X-Received: by 2002:a05:6512:110d:: with SMTP id l13mr30883164lfg.199.1635829059598; Mon, 01 Nov 2021 21:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-4-eperezma@redhat.com> In-Reply-To: <20211029183525.1776416-4-eperezma@redhat.com> From: Jason Wang Date: Tue, 2 Nov 2021 12:57:28 +0800 Message-ID: Subject: Re: [RFC PATCH v5 03/26] virtio: Add VIRTIO_F_QUEUE_STATE To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.734, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , qemu-devel , Peter Xu , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Stefano Garzarella , Eric Blake , virtualization , Parav Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Oct 30, 2021 at 2:36 AM Eugenio P=C3=A9rez wr= ote: > > Implementation of RFC of device state capability: > https://lists.oasis-open.org/archives/virtio-comment/202012/msg00005.html Considering this still requires time to be done, we need to think of a way to go without this. Thanks > > With this capability, vdpa device can reset it's index so it can start > consuming from guest after disabling shadow virtqueue (SVQ), with state > not 0. > > The use case is to test SVQ with virtio-pci vdpa (vp_vdpa) with nested > virtualization. Spawning a L0 qemu with a virtio-net device, use > vp_vdpa driver to handle it in the guest, and then spawn a L1 qemu using > that vdpa device. When L1 qemu calls device to set a new state though > vdpa ioctl, vp_vdpa should set each queue state though virtio > VIRTIO_PCI_COMMON_Q_AVAIL_STATE. > > Since this is only for testing vhost-vdpa, it's added here before of > proposing to kernel code. No effort is done for checking that device > can actually change its state, its layout, or if the device even > supports to change state at all. These will be added in the future. > > Also, a modified version of vp_vdpa that allows to set these in PCI > config is needed. > > TODO: Check for feature enabled and split in virtio pci config > > Signed-off-by: Eugenio P=C3=A9rez > --- > hw/virtio/virtio-pci.h | 1 + > include/hw/virtio/virtio.h | 4 +++- > include/standard-headers/linux/virtio_config.h | 3 +++ > include/standard-headers/linux/virtio_pci.h | 2 ++ > hw/virtio/virtio-pci.c | 9 +++++++++ > 5 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h > index 2446dcd9ae..019badbd7c 100644 > --- a/hw/virtio/virtio-pci.h > +++ b/hw/virtio/virtio-pci.h > @@ -120,6 +120,7 @@ typedef struct VirtIOPCIQueue { > uint32_t desc[2]; > uint32_t avail[2]; > uint32_t used[2]; > + uint16_t state; > } VirtIOPCIQueue; > > struct VirtIOPCIProxy { > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 8bab9cfb75..5fe575b8f0 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -289,7 +289,9 @@ typedef struct VirtIORNGConf VirtIORNGConf; > DEFINE_PROP_BIT64("iommu_platform", _state, _field, \ > VIRTIO_F_IOMMU_PLATFORM, false), \ > DEFINE_PROP_BIT64("packed", _state, _field, \ > - VIRTIO_F_RING_PACKED, false) > + VIRTIO_F_RING_PACKED, false), \ > + DEFINE_PROP_BIT64("save_restore_q_state", _state, _field, \ > + VIRTIO_F_QUEUE_STATE, true) > > hwaddr virtio_queue_get_desc_addr(VirtIODevice *vdev, int n); > bool virtio_queue_enabled_legacy(VirtIODevice *vdev, int n); > diff --git a/include/standard-headers/linux/virtio_config.h b/include/sta= ndard-headers/linux/virtio_config.h > index 22e3a85f67..59fad3eb45 100644 > --- a/include/standard-headers/linux/virtio_config.h > +++ b/include/standard-headers/linux/virtio_config.h > @@ -90,4 +90,7 @@ > * Does the device support Single Root I/O Virtualization? > */ > #define VIRTIO_F_SR_IOV 37 > + > +/* Device support save and restore virtqueue state */ > +#define VIRTIO_F_QUEUE_STATE 40 > #endif /* _LINUX_VIRTIO_CONFIG_H */ > diff --git a/include/standard-headers/linux/virtio_pci.h b/include/standa= rd-headers/linux/virtio_pci.h > index db7a8e2fcb..c8d9802a87 100644 > --- a/include/standard-headers/linux/virtio_pci.h > +++ b/include/standard-headers/linux/virtio_pci.h > @@ -164,6 +164,7 @@ struct virtio_pci_common_cfg { > uint32_t queue_avail_hi; /* read-write */ > uint32_t queue_used_lo; /* read-write */ > uint32_t queue_used_hi; /* read-write */ > + uint16_t queue_avail_state; /* read-write */ > }; > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > @@ -202,6 +203,7 @@ struct virtio_pci_cfg_cap { > #define VIRTIO_PCI_COMMON_Q_AVAILHI 44 > #define VIRTIO_PCI_COMMON_Q_USEDLO 48 > #define VIRTIO_PCI_COMMON_Q_USEDHI 52 > +#define VIRTIO_PCI_COMMON_Q_AVAIL_STATE 56 > > #endif /* VIRTIO_PCI_NO_MODERN */ > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 750aa47ec1..d7bb549033 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -1244,6 +1244,9 @@ static uint64_t virtio_pci_common_read(void *opaque= , hwaddr addr, > case VIRTIO_PCI_COMMON_Q_USEDHI: > val =3D proxy->vqs[vdev->queue_sel].used[1]; > break; > + case VIRTIO_PCI_COMMON_Q_AVAIL_STATE: > + val =3D virtio_queue_get_last_avail_idx(vdev, vdev->queue_sel); > + break; > default: > val =3D 0; > } > @@ -1330,6 +1333,8 @@ static void virtio_pci_common_write(void *opaque, h= waddr addr, > proxy->vqs[vdev->queue_sel].avail[0], > ((uint64_t)proxy->vqs[vdev->queue_sel].used[1]) <= < 32 | > proxy->vqs[vdev->queue_sel].used[0]); > + virtio_queue_set_last_avail_idx(vdev, vdev->queue_sel, > + proxy->vqs[vdev->queue_sel].state); > proxy->vqs[vdev->queue_sel].enabled =3D 1; > } else { > virtio_error(vdev, "wrong value for queue_enable %"PRIx64, v= al); > @@ -1353,6 +1358,9 @@ static void virtio_pci_common_write(void *opaque, h= waddr addr, > case VIRTIO_PCI_COMMON_Q_USEDHI: > proxy->vqs[vdev->queue_sel].used[1] =3D val; > break; > + case VIRTIO_PCI_COMMON_Q_AVAIL_STATE: > + proxy->vqs[vdev->queue_sel].state =3D val; > + break; > default: > break; > } > @@ -1951,6 +1959,7 @@ static void virtio_pci_reset(DeviceState *qdev) > proxy->vqs[i].desc[0] =3D proxy->vqs[i].desc[1] =3D 0; > proxy->vqs[i].avail[0] =3D proxy->vqs[i].avail[1] =3D 0; > proxy->vqs[i].used[0] =3D proxy->vqs[i].used[1] =3D 0; > + proxy->vqs[i].state =3D 0; > } > > if (pci_is_express(dev)) { > -- > 2.27.0 >