From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05785CCA47C for ; Mon, 27 Jun 2022 02:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbiF0Ca7 (ORCPT ); Sun, 26 Jun 2022 22:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbiF0Ca6 (ORCPT ); Sun, 26 Jun 2022 22:30:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF9272BE9 for ; Sun, 26 Jun 2022 19:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656297056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kJbcwB7EfNKpZ99plzFtpzkiIgmO0GfWqgxD6ydKGBA=; b=O+AVCCYAVcZ+unyq4WDBIyDHCnIFtjwZo6ua7+oY0je044DHpfBv0eDeF6Hz3+NTx89/1S 2yOBQnJsh5l/n1+5eSWxKWMcIuxw2OsDc75iVnp4Om5NxZxK6A893PBKr0Et8zHNpxxIiJ Wxeq0YhxOcC/pmsRN5NePbhyJaEOap4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-41-H6Et_PdTNEm1ZWdOtm8ErQ-1; Sun, 26 Jun 2022 22:30:54 -0400 X-MC-Unique: H6Et_PdTNEm1ZWdOtm8ErQ-1 Received: by mail-lf1-f71.google.com with SMTP id q22-20020a0565123a9600b0047f6b8e1babso4017743lfu.21 for ; Sun, 26 Jun 2022 19:30:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kJbcwB7EfNKpZ99plzFtpzkiIgmO0GfWqgxD6ydKGBA=; b=k7BTTYrstzly3+Br6RqJ0VVGiyraGdeyOKiwaEb+/U4lpqVDdEk1ID1sWWTXyLkWxO vnt5qk/kfa7D1UAUPAeC/FAB6He3tJEPTeBdx8/k8tU1AnKO7BIApThFxL6Eb2zt8HpQ QkdpLHMD5T+MsmGldpEZ1iy5VJqTXtaet5REViBtBZi9xYZVr0QytCwCwD/ty7thmyeA yX05RvXbfrjt9rojEnfxX2JlYKpszb2YjKHyzabsU5Sr0v6MILG0SoyvaNfBIu/Nhfv5 V8egrbCWFA6/LXYAYXlnHP+zyRimr5u/UOtaOoGkQ1z9H2z/pAIY2p9gNvTxqSnJMzx1 ilpA== X-Gm-Message-State: AJIora8UX72M6YwX+o3Iu6+fOA9MnoCwELJ9HTi7EtijayHN0IkFP6in MYLZOgRiVXydEAoyx1l25nv8QP03TQ6ltKNXqwDpmlWV7OqowQRBZgndLJujTabFTy8qV8oqJNV 02Dp47pS/KhqKh+4MMxBsdupl/lCFWjTtHkjkb6Doxdz/1Q== X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr6773777lfa.442.1656297053240; Sun, 26 Jun 2022 19:30:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ur82ARcDJaALzWVAunDCgq4vaJSklh1IynesHEAuaeWnmZYcX/Br+tGQmrs/x93fW3c+90sT9mKBAdQ35aQEI= X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr6773770lfa.442.1656297053073; Sun, 26 Jun 2022 19:30:53 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> In-Reply-To: <20220624025817-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 10:30:42 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data To: "Michael S. Tsirkin" Cc: Xuan Zhuo , virtualization , Richard Weinberger , Anton Ivanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm , "open list:XDP (eXpress Data Path)" , kangjie.xu@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > What exactly is meant by not breaking uABI? > Users are supposed to be prepared for struct size to change ... no? Not sure, any doc for this? Thanks > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > this patch first. > > > > Signed-off-by: Xuan Zhuo > > Acked-by: Jason Wang > > --- > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > --- a/include/uapi/linux/virtio_pci.h > > +++ b/include/uapi/linux/virtio_pci.h > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > __le32 queue_used_hi; /* read-write */ > > }; > > > > +struct virtio_pci_common_cfg_notify { > > + struct virtio_pci_common_cfg cfg; > > + > > + __le16 queue_notify_data; /* read-write */ > > + __le16 padding; > > +}; > > + > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > struct virtio_pci_cfg_cap { > > struct virtio_pci_cap cap; > > -- > > 2.31.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61B2CC43334 for ; Mon, 27 Jun 2022 02:31:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D94A960C0B; Mon, 27 Jun 2022 02:31:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D94A960C0B Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O+AVCCYA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTUTKfoooUMY; Mon, 27 Jun 2022 02:31:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4B50F6079E; Mon, 27 Jun 2022 02:31:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4B50F6079E Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 34263C007A; Mon, 27 Jun 2022 02:31:00 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E0445C002D for ; Mon, 27 Jun 2022 02:30:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AB19582ECF for ; Mon, 27 Jun 2022 02:30:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AB19582ECF Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O+AVCCYA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m_U46Omxgtgn for ; Mon, 27 Jun 2022 02:30:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B2FEC82EB6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id B2FEC82EB6 for ; Mon, 27 Jun 2022 02:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656297056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kJbcwB7EfNKpZ99plzFtpzkiIgmO0GfWqgxD6ydKGBA=; b=O+AVCCYAVcZ+unyq4WDBIyDHCnIFtjwZo6ua7+oY0je044DHpfBv0eDeF6Hz3+NTx89/1S 2yOBQnJsh5l/n1+5eSWxKWMcIuxw2OsDc75iVnp4Om5NxZxK6A893PBKr0Et8zHNpxxIiJ Wxeq0YhxOcC/pmsRN5NePbhyJaEOap4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-zl2VGBKtO2e3VlFT5qvWsg-1; Sun, 26 Jun 2022 22:30:54 -0400 X-MC-Unique: zl2VGBKtO2e3VlFT5qvWsg-1 Received: by mail-lf1-f71.google.com with SMTP id bq4-20020a056512150400b0047f7f36efc6so3971317lfb.9 for ; Sun, 26 Jun 2022 19:30:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kJbcwB7EfNKpZ99plzFtpzkiIgmO0GfWqgxD6ydKGBA=; b=w9QrZCDgo9oJVdJ6+aLzotiTb+8wVs5S6g7vW1EA4kmTY3y2BLryCvgyA0NYNUO+NZ xavW+/iMwlFMyvb6V0/MLPrgYUgmHpy3bPWWuLDBOwjnOKTjd0uLvxYPg75NVjisxa4r FJ31cLZc0Q6w3lnN56yU9E7YmDFP25Fdw/m0CX59gIDA0PvUxu1RtB1WHQXRAyfgmJyf CGT9uIy1G4Zw/E2kVURNqB8cuCOIrXHCnj1ZdT8bu2dXWX19ijlc2WWJ24w0zX/EpjUR 3shie99iAwhhRRzD6Ltfl9DGEjnSjwjWLHIanChOksKGuHUD5l6z+Mm1iSBRCQpsmn9p nAvA== X-Gm-Message-State: AJIora9MNTZRZ7BSNBeC4dVOPq/RVHkzo0nt9HFOe8Dm65XBhSf76WXc XS0RAozwW5LEuXySat3os7MExJYTeCiYxDJ+rDuuSRzEmVLOq4NxqVQCkWCn8xDNBR5f85VU0j0 SIMnJshVn7DCNQ3o0xsbi4I5/n2Dj0EXdypBjhDHroQWA+ZAHdBcpci/P6A== X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr6773785lfa.442.1656297053243; Sun, 26 Jun 2022 19:30:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ur82ARcDJaALzWVAunDCgq4vaJSklh1IynesHEAuaeWnmZYcX/Br+tGQmrs/x93fW3c+90sT9mKBAdQ35aQEI= X-Received: by 2002:a05:6512:13a5:b0:47d:c1d9:dea8 with SMTP id p37-20020a05651213a500b0047dc1d9dea8mr6773770lfa.442.1656297053073; Sun, 26 Jun 2022 19:30:53 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> In-Reply-To: <20220624025817-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 10:30:42 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Vadim Pasternak , linux-remoteproc@vger.kernel.org, Alexei Starovoitov , virtualization , Eric Dumazet , Alexander Gordeev , kangjie.xu@linux.alibaba.com, Anton Ivanov , kvm , Daniel Borkmann , Richard Weinberger , Vincent Whitchurch , John Fastabend , Halil Pasic , Jakub Kicinski , platform-driver-x86@vger.kernel.org, Eric Farman , Jesper Dangaard Brouer , Vasily Gorbik , linux-s390@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Mark Gross , Hans de Goede , Bjorn Andersson , "open list:XDP \(eXpress Data Path\)" , Paolo Abeni , Mathieu Poirier , netdev , Cornelia Huck , Sven Schnelle , Johannes Berg , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > What exactly is meant by not breaking uABI? > Users are supposed to be prepared for struct size to change ... no? Not sure, any doc for this? Thanks > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > this patch first. > > > > Signed-off-by: Xuan Zhuo > > Acked-by: Jason Wang > > --- > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > --- a/include/uapi/linux/virtio_pci.h > > +++ b/include/uapi/linux/virtio_pci.h > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > __le32 queue_used_hi; /* read-write */ > > }; > > > > +struct virtio_pci_common_cfg_notify { > > + struct virtio_pci_common_cfg cfg; > > + > > + __le16 queue_notify_data; /* read-write */ > > + __le16 padding; > > +}; > > + > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > struct virtio_pci_cfg_cap { > > struct virtio_pci_cap cap; > > -- > > 2.31.0 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5eWh-00Eg4k-Ak for linux-um@lists.infradead.org; Mon, 27 Jun 2022 02:31:00 +0000 Received: by mail-lf1-f71.google.com with SMTP id be18-20020a056512251200b0048120ff434dso186739lfb.19 for ; Sun, 26 Jun 2022 19:30:54 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> In-Reply-To: <20220624025817-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 10:30:42 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Michael S. Tsirkin" Cc: Xuan Zhuo , virtualization , Richard Weinberger , Anton Ivanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm , "open list:XDP (eXpress Data Path)" , kangjie.xu@linux.alibaba.com On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > What exactly is meant by not breaking uABI? > Users are supposed to be prepared for struct size to change ... no? Not sure, any doc for this? Thanks > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > this patch first. > > > > Signed-off-by: Xuan Zhuo > > Acked-by: Jason Wang > > --- > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > --- a/include/uapi/linux/virtio_pci.h > > +++ b/include/uapi/linux/virtio_pci.h > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > __le32 queue_used_hi; /* read-write */ > > }; > > > > +struct virtio_pci_common_cfg_notify { > > + struct virtio_pci_common_cfg cfg; > > + > > + __le16 queue_notify_data; /* read-write */ > > + __le16 padding; > > +}; > > + > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > struct virtio_pci_cfg_cap { > > struct virtio_pci_cap cap; > > -- > > 2.31.0 > _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um