From: Jason Wang <jasowang@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "lvivier@redhat.com" <lvivier@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"si-wei.liu@oracle.com" <si-wei.liu@oracle.com>,
Eli Cohen <elic@nvidia.com>
Subject: Re: [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0
Date: Tue, 4 Jan 2022 10:43:25 +0800 [thread overview]
Message-ID: <CACGkMEss0L9=PgT197mwPh-kFyKxnWLrtL-ypJ1doCGmJXVcyQ@mail.gmail.com> (raw)
In-Reply-To: <PH0PR12MB54817F9FCB3549B1677C8012DC459@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Dec 30, 2021 at 10:49 PM Parav Pandit <parav@nvidia.com> wrote:
>
>
> > From: Eli Cohen <elic@nvidia.com>
> > Sent: Thursday, December 30, 2021 7:50 PM
> >
> > Remove overriding of virtio_version_1_0 which forced the virtqueue object to
> > version 1.
> >
> > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5
> > devices")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 1eb473cb9d4d..e946a36bf7ee 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net
> > *ndev, struct mlx5_vdpa_virtque
> > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id);
> > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size);
> > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn);
> > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev,
> > eth_frame_offload_type))
> > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1);
> >
> > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out));
> > if (err)
> > --
> > 2.34.1
>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
>
Acked-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-01-04 2:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211230142024.142979-1-elic@nvidia.com>
2021-12-30 14:49 ` [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 Parav Pandit via Virtualization
2022-01-04 2:43 ` Jason Wang [this message]
2022-01-04 13:28 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEss0L9=PgT197mwPh-kFyKxnWLrtL-ypJ1doCGmJXVcyQ@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.