From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE94C433FE for ; Tue, 2 Nov 2021 05:26:16 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C827A60F70 for ; Tue, 2 Nov 2021 05:26:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C827A60F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 87A2A402D8; Tue, 2 Nov 2021 05:26:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GYU5u0uSiA64; Tue, 2 Nov 2021 05:26:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 35EDB402D1; Tue, 2 Nov 2021 05:26:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 17AD1C0012; Tue, 2 Nov 2021 05:26:14 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 838D3C000E for ; Tue, 2 Nov 2021 05:26:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 786F8606E7 for ; Tue, 2 Nov 2021 05:26:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9jye1m5alGRs for ; Tue, 2 Nov 2021 05:26:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 88834606CC for ; Tue, 2 Nov 2021 05:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635830768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bajX0FLkv/tXMkVBnTHf1Bd8wxQJJ2cX8rqdOASLHZs=; b=HtCCgkNBPm2a7MPmyeN504o+ZaTIN3/abLfVam6368OV5/q6r01llYyTp232YrKCmDEXKC pHAoiaHnNL6VMNjYGkt9KL97KFUwiRqD7Yv3Nlnx+na1V0/Y1/pvoY9pJa6MfjcsEXwH0U sq1KBt9Ie9QiZZC3YJ735rgrE3ToMiw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-v1lp2rn_N8e6VWCckw35GA-1; Tue, 02 Nov 2021 01:26:07 -0400 X-MC-Unique: v1lp2rn_N8e6VWCckw35GA-1 Received: by mail-lf1-f69.google.com with SMTP id bq29-20020a056512151d00b003ffce2467adso6574929lfb.3 for ; Mon, 01 Nov 2021 22:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bajX0FLkv/tXMkVBnTHf1Bd8wxQJJ2cX8rqdOASLHZs=; b=x0o799aO3CqPN51vDGGTefKP49XRY2y3B8UmnxWJILVf/93tM3MIOemDYvxxgqLTi5 vhNIz0Y2euQYFB6VuwPoWQlJhDIwwWL0QgM0+GM9eoE2FE5nyVKxIO2syKTFb4SXnhF7 +rz5Cgk0fTvwbWnYoG+EZxXpMx3Cc3YjQuGt21AjRxXYyAToIPIsdAY23/JuR7c5NRnd fqwqKqzBdQGY7bEHR42sCSp92cS3bXYyDXb7rdNQgVGWpVIcsr4lDPY1vsEK6sNeEZw+ vdndCZcY9WM/qCCbflXhi6ZNEwehAzpE2FYXDp3H1dY5IZQrT50PZpC4vu45VKnbfnqZ mnXw== X-Gm-Message-State: AOAM533Nu3RoRJLasmpQzEd7BCVUiorRD09YR4GmXAD10H4///0HA612 dAHBpFPJmrP2+U5U18xz6Oprbs7soKU5lIpoZBlvuL+g77WwwpCJq25ve4KMIpf89Xbr+FUa9G4 Ta6z/9xl4HjR6HImzb7nlYWJrl4HVchV3V6CVWi/8jfZZsVz6HAUUmlN5Jw== X-Received: by 2002:a05:651c:1254:: with SMTP id h20mr36382262ljh.420.1635830765673; Mon, 01 Nov 2021 22:26:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaDvnbh3/QxnYwKDlAGBulhKs/ymZFxgmAXKGQQ5IuYUOoQAtoot7ukBQPvQCm3+fRXhfU3cKGVoh91JJ3zgs= X-Received: by 2002:a05:651c:1254:: with SMTP id h20mr36382225ljh.420.1635830765441; Mon, 01 Nov 2021 22:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-22-eperezma@redhat.com> In-Reply-To: <20211029183525.1776416-22-eperezma@redhat.com> From: Jason Wang Date: Tue, 2 Nov 2021 13:25:54 +0800 Message-ID: Subject: Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Eric Blake , virtualization , Parav Pandit X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gU2F0LCBPY3QgMzAsIDIwMjEgYXQgMjo0NCBBTSBFdWdlbmlvIFDDqXJleiA8ZXBlcmV6bWFA cmVkaGF0LmNvbT4gd3JvdGU6Cj4KPiBUaGlzIGFsbG93cyBpdCB0byB0ZXN0IGlmIHRoZSBndWVz dCBoYXMgYWtub3dsZWRnZSBhbiBpbnZhbGlkIHRyYW5zcG9ydAo+IGZlYXR1cmUgZm9yIFNWUS4g VGhpcyB3aWxsIGluY2x1ZGUgcGFja2VkIHZxIGxheW91dCBvciBldmVudF9pZHgsCj4gd2hlcmUg VmlydElPIGRldmljZSBuZWVkcyBoZWxwIGZyb20gU1ZRLgo+Cj4gVGhlcmUgaXMgbm90IG5lZWRl ZCBhdCB0aGlzIG1vbWVudCwgYnV0IHNpbmNlIFNWUSB3aWxsIG5vdCByZS1uZWdvdGlhdGUKPiBm ZWF0dXJlcyBhZ2FpbiB3aXRoIHRoZSBndWVzdCwgYSBmYWlsdXJlIGluIGFja25vd2xlZGdlIHRo ZW0gaXMgZmF0YWwKPiBmb3IgU1ZRLgo+CgpJdCdzIG5vdCBjbGVhciB0byBtZSB3aHkgd2UgbmVl ZCB0aGlzLiBNYXliZSB5b3UgY2FuIGdpdmUgbWUgYW4KZXhhbXBsZS4gRS5nIGlzbid0IGl0IHN1 ZmZpY2llbnQgdG8gZmlsdGVyIG91dCB0aGUgZGV2aWNlIHdpdGgKZXZlbnRfaWR4PwoKVGhhbmtz Cgo+IFNpZ25lZC1vZmYtYnk6IEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXptYUByZWRoYXQuY29tPgo+ IC0tLQo+ICBody92aXJ0aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1ZS5oIHwgMSArCj4gIGh3L3Zp cnRpby92aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmMgfCA2ICsrKysrKwo+ICAyIGZpbGVzIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2h3L3ZpcnRpby92aG9zdC1zaGFk b3ctdmlydHF1ZXVlLmggYi9ody92aXJ0aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1ZS5oCj4gaW5k ZXggOTQ2YjJjNjI5NS4uYWM1NTU4ODAwOSAxMDA2NDQKPiAtLS0gYS9ody92aXJ0aW8vdmhvc3Qt c2hhZG93LXZpcnRxdWV1ZS5oCj4gKysrIGIvaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVl dWUuaAo+IEBAIC0xNiw2ICsxNiw3IEBACj4gIHR5cGVkZWYgc3RydWN0IFZob3N0U2hhZG93Vmly dHF1ZXVlIFZob3N0U2hhZG93VmlydHF1ZXVlOwo+Cj4gIGJvb2wgdmhvc3Rfc3ZxX3ZhbGlkX2Rl dmljZV9mZWF0dXJlcyh1aW50NjRfdCAqZmVhdHVyZXMpOwo+ICtib29sIHZob3N0X3N2cV92YWxp ZF9ndWVzdF9mZWF0dXJlcyh1aW50NjRfdCAqZmVhdHVyZXMpOwo+Cj4gIHZvaWQgdmhvc3Rfc3Zx X3NldF9zdnFfa2lja19mZChWaG9zdFNoYWRvd1ZpcnRxdWV1ZSAqc3ZxLCBpbnQgc3ZxX2tpY2tf ZmQpOwo+ICB2b2lkIHZob3N0X3N2cV9zZXRfZ3Vlc3RfY2FsbF9ub3RpZmllcihWaG9zdFNoYWRv d1ZpcnRxdWV1ZSAqc3ZxLCBpbnQgY2FsbF9mZCk7Cj4gZGlmZiAtLWdpdCBhL2h3L3ZpcnRpby92 aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmMgYi9ody92aXJ0aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1 ZS5jCj4gaW5kZXggNmUwNTA4YTIzMS4uY2I5ZmZjYjAxNSAxMDA2NDQKPiAtLS0gYS9ody92aXJ0 aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1ZS5jCj4gKysrIGIvaHcvdmlydGlvL3Zob3N0LXNoYWRv dy12aXJ0cXVldWUuYwo+IEBAIC02Miw2ICs2MiwxMiBAQCBib29sIHZob3N0X3N2cV92YWxpZF9k ZXZpY2VfZmVhdHVyZXModWludDY0X3QgKmRldl9mZWF0dXJlcykKPiAgICAgIHJldHVybiB0cnVl Owo+ICB9Cj4KPiArLyogSWYgdGhlIGd1ZXN0IGlzIHVzaW5nIHNvbWUgb2YgdGhlc2UsIFNWUSBj YW5ub3QgY29tbXVuaWNhdGUgKi8KPiArYm9vbCB2aG9zdF9zdnFfdmFsaWRfZ3Vlc3RfZmVhdHVy ZXModWludDY0X3QgKmd1ZXN0X2ZlYXR1cmVzKQo+ICt7Cj4gKyAgICByZXR1cm4gdHJ1ZTsKPiAr fQo+ICsKPiAgLyogRm9yd2FyZCBndWVzdCBub3RpZmljYXRpb25zICovCj4gIHN0YXRpYyB2b2lk IHZob3N0X2hhbmRsZV9ndWVzdF9raWNrKEV2ZW50Tm90aWZpZXIgKm4pCj4gIHsKPiAtLQo+IDIu MjcuMAo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpW aXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91 bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlz dGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35616C433EF for ; Tue, 2 Nov 2021 05:28:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C44EC61052 for ; Tue, 2 Nov 2021 05:28:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C44EC61052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhmLc-0001KB-RY for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 01:28:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhmJJ-0007VF-LX for qemu-devel@nongnu.org; Tue, 02 Nov 2021 01:26:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhmJG-0005jq-22 for qemu-devel@nongnu.org; Tue, 02 Nov 2021 01:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635830768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bajX0FLkv/tXMkVBnTHf1Bd8wxQJJ2cX8rqdOASLHZs=; b=HtCCgkNBPm2a7MPmyeN504o+ZaTIN3/abLfVam6368OV5/q6r01llYyTp232YrKCmDEXKC pHAoiaHnNL6VMNjYGkt9KL97KFUwiRqD7Yv3Nlnx+na1V0/Y1/pvoY9pJa6MfjcsEXwH0U sq1KBt9Ie9QiZZC3YJ735rgrE3ToMiw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-9PEuW6OROC2N-ry7x36Z5g-1; Tue, 02 Nov 2021 01:26:07 -0400 X-MC-Unique: 9PEuW6OROC2N-ry7x36Z5g-1 Received: by mail-lf1-f69.google.com with SMTP id b12-20020a0565120b8c00b003ffa7050931so6555522lfv.13 for ; Mon, 01 Nov 2021 22:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bajX0FLkv/tXMkVBnTHf1Bd8wxQJJ2cX8rqdOASLHZs=; b=7HFOR36inBy37Fzppmitv20oiO14MTMf5sG0XdNOsz6d84Q7IKHMSexvyJYyQfI5LB /KjaDtNlJdtDXRcjXKGnK3f1m3ar5L94gdmRL1HqFJLkBKRZQMjE+rt4X1RduvouYdss XZdbLIP3YA1p1IoIZHbsxXDGLh1ZsdLIKIpGtPW5zF8w+/Sl/Br7vzRK0zmjC78pQ2p7 XmMtWzlnd+/3WHrA4NBs0LTmwAOVcHxhcPuDzXkQMJAK0zbGRaJPFZP52eT3P0nOytfw h0TllxKaRy41+VEUBEadg3ZpjC7rOb3gKagQJy/GEd8HB5yUgBgipuoD5Pbtze7tz7pw ETmw== X-Gm-Message-State: AOAM530k7DPndK3oK/T1SV2dUhCWPo3qAjws/S0uzNw7S1u00oJASIPK 3iNg+F73qUbg/H+wBngCgJg19L9uw0t9YHABp0e8Kqp/Q7qo27DWWWnKs1uHDMbq8yRb+X6DR6L 99mcBwcD7/JcUmZvDOd2o3idwy0ASWu8= X-Received: by 2002:a05:651c:1254:: with SMTP id h20mr36382265ljh.420.1635830765684; Mon, 01 Nov 2021 22:26:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaDvnbh3/QxnYwKDlAGBulhKs/ymZFxgmAXKGQQ5IuYUOoQAtoot7ukBQPvQCm3+fRXhfU3cKGVoh91JJ3zgs= X-Received: by 2002:a05:651c:1254:: with SMTP id h20mr36382225ljh.420.1635830765441; Mon, 01 Nov 2021 22:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-22-eperezma@redhat.com> In-Reply-To: <20211029183525.1776416-22-eperezma@redhat.com> From: Jason Wang Date: Tue, 2 Nov 2021 13:25:54 +0800 Message-ID: Subject: Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.734, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , qemu-devel , Peter Xu , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Stefano Garzarella , Eric Blake , virtualization , Parav Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Oct 30, 2021 at 2:44 AM Eugenio P=C3=A9rez wr= ote: > > This allows it to test if the guest has aknowledge an invalid transport > feature for SVQ. This will include packed vq layout or event_idx, > where VirtIO device needs help from SVQ. > > There is not needed at this moment, but since SVQ will not re-negotiate > features again with the guest, a failure in acknowledge them is fatal > for SVQ. > It's not clear to me why we need this. Maybe you can give me an example. E.g isn't it sufficient to filter out the device with event_idx? Thanks > Signed-off-by: Eugenio P=C3=A9rez > --- > hw/virtio/vhost-shadow-virtqueue.h | 1 + > hw/virtio/vhost-shadow-virtqueue.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-= virtqueue.h > index 946b2c6295..ac55588009 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.h > +++ b/hw/virtio/vhost-shadow-virtqueue.h > @@ -16,6 +16,7 @@ > typedef struct VhostShadowVirtqueue VhostShadowVirtqueue; > > bool vhost_svq_valid_device_features(uint64_t *features); > +bool vhost_svq_valid_guest_features(uint64_t *features); > > void vhost_svq_set_svq_kick_fd(VhostShadowVirtqueue *svq, int svq_kick_f= d); > void vhost_svq_set_guest_call_notifier(VhostShadowVirtqueue *svq, int ca= ll_fd); > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-= virtqueue.c > index 6e0508a231..cb9ffcb015 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.c > +++ b/hw/virtio/vhost-shadow-virtqueue.c > @@ -62,6 +62,12 @@ bool vhost_svq_valid_device_features(uint64_t *dev_fea= tures) > return true; > } > > +/* If the guest is using some of these, SVQ cannot communicate */ > +bool vhost_svq_valid_guest_features(uint64_t *guest_features) > +{ > + return true; > +} > + > /* Forward guest notifications */ > static void vhost_handle_guest_kick(EventNotifier *n) > { > -- > 2.27.0 >