From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1D06C433EF for ; Thu, 24 Feb 2022 03:45:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 859EA400F1; Thu, 24 Feb 2022 03:45:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CsPMBQcco59n; Thu, 24 Feb 2022 03:45:50 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 76EFF400AF; Thu, 24 Feb 2022 03:45:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 42946C001A; Thu, 24 Feb 2022 03:45:49 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6459CC0011 for ; Thu, 24 Feb 2022 03:45:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 51CFF83118 for ; Thu, 24 Feb 2022 03:45:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vUYj0kn6G6lh for ; Thu, 24 Feb 2022 03:45:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4629583104 for ; Thu, 24 Feb 2022 03:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645674345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlyCYYWO+bFQxATNj+9uSCUV+uwf9bZAR7cI+BC5YII=; b=gaq60amJRhX5ACXZflfelBZDx4ZpQMaR2r8lRxo2AzZ8kGkvi4gqQy1BQmy6aJhlZ3o6vH 8ZpYRQ45vFhq7p7aAtG7f/3Er4c1QbAY4pWZWUZL2NsqZZhClnROe/hOGhn1OR6iPC6XJo bZ//xQF8zEqMLW2tjanA2kwENrXodUc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-516-7SYd0tevMqG5EiXZoIn4PA-1; Wed, 23 Feb 2022 22:45:44 -0500 X-MC-Unique: 7SYd0tevMqG5EiXZoIn4PA-1 Received: by mail-lf1-f72.google.com with SMTP id a5-20020ac25205000000b00443a34a9472so79727lfl.15 for ; Wed, 23 Feb 2022 19:45:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MlyCYYWO+bFQxATNj+9uSCUV+uwf9bZAR7cI+BC5YII=; b=Imo/DLaO7cVIL7tEIbiz7/eTnfiIwAuaBY2J/BELiimQg71vh33BUh6Igcx5RX4YS7 Wm+eQAvYTiK04Jz4uoE0zB6Bk2j/VGngyqERZil8qyq4HQ8+fPrtJaItKgDH82UqGWFF h0c5CmffOj/qiaMWFMd+cVS0+WPCBhVX5tBLU54vwdEo4C534dFwEM8SwYzmTcrxj3h+ iBX69isdpny4qdSfV6um+sENIM22vjEAt7tMlAbVSSUsxj9si5bPIPAsNI2ucJ9Z0elz esWkJnVTvsPl8hwyJ0HmwwJVZH4wAoW+VZPZE2GJhos/4pwO5e2miqZb7bcQ/CPcWHf/ 9Q4Q== X-Gm-Message-State: AOAM5308rqq5XToM4gRK98JRpwN3/md9+JTaO8p0EzKv+wVDM89awxJW kL76Y+PJ6JNOqdrnOCtxFNEtbaiCZ6xRF/jqvVZ1inj5VlrV+cAUbmnRIFhsAkY/vbzCy4hn0kQ bYcxlieMir6vKTXUAR9MRFSHLQw+EPaxHJaphozxxKK08FzyJRuH4uS70mQ== X-Received: by 2002:ac2:508a:0:b0:443:169a:b27 with SMTP id f10-20020ac2508a000000b00443169a0b27mr564255lfm.257.1645674342469; Wed, 23 Feb 2022 19:45:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4S0gyT5i8GJsMEhchNIn1a+cgAfIXEogTf9Mj7wnAyHyTReLgqY+kfFxUxZBS6Ut+KNWv46PrQsEgVbZ1vNA= X-Received: by 2002:ac2:508a:0:b0:443:169a:b27 with SMTP id f10-20020ac2508a000000b00443169a0b27mr564233lfm.257.1645674342219; Wed, 23 Feb 2022 19:45:42 -0800 (PST) MIME-Version: 1.0 References: <20220121202733.404989-1-eperezma@redhat.com> <20220121202733.404989-29-eperezma@redhat.com> <42664143-6d0c-b107-ec90-8e6336bae29b@redhat.com> <9b32f664-56a9-3718-cf48-49003f87d430@redhat.com> <0f0204f1-8b7f-a21e-495e-24443a63f026@redhat.com> In-Reply-To: From: Jason Wang Date: Thu, 24 Feb 2022 11:45:30 +0800 Message-ID: Subject: Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ To: Eugenio Perez Martin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Parav Pandit , Cindy Lu , "Michael S. Tsirkin" , Richard Henderson , qemu-level , Gautam Dawar , Markus Armbruster , Eduardo Habkost , Harpreet Singh Anand , Xiao W Wang , Stefan Hajnoczi , Eli Cohen , Paolo Bonzini , Zhu Lingshan , virtualization , Eric Blake X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBGZWIgMjMsIDIwMjIgYXQgNDowNiBQTSBFdWdlbmlvIFBlcmV6IE1hcnRpbgo8ZXBl cmV6bWFAcmVkaGF0LmNvbT4gd3JvdGU6Cj4KPiBPbiBXZWQsIEZlYiAyMywgMjAyMiBhdCA0OjQ3 IEFNIEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFR1 ZSwgRmViIDIyLCAyMDIyIGF0IDQ6MDYgUE0gRXVnZW5pbyBQZXJleiBNYXJ0aW4KPiA+IDxlcGVy ZXptYUByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gVHVlLCBGZWIgMjIsIDIwMjIg YXQgODo0MSBBTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4g Pgo+ID4gPiA+Cj4gPiA+ID4g5ZyoIDIwMjIvMi8xNyDkuIvljYg0OjIyLCBFdWdlbmlvIFBlcmV6 IE1hcnRpbiDlhpnpgZM6Cj4gPiA+ID4gPiBPbiBUaHUsIEZlYiAxNywgMjAyMiBhdCA3OjAyIEFN IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPiA+ID4+IE9uIFdl ZCwgRmViIDE2LCAyMDIyIGF0IDExOjU0IFBNIEV1Z2VuaW8gUGVyZXogTWFydGluCj4gPiA+ID4g Pj4gPGVwZXJlem1hQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPiA+ID4+PiBPbiBUdWUsIEZlYiA4 LCAyMDIyIGF0IDk6MjUgQU0gSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gPiA+ID4gPj4+Pgo+ID4gPiA+ID4+Pj4g5ZyoIDIwMjIvMi8xIOS4i+WNiDc6NDUsIEV1Z2Vu aW8gUGVyZXogTWFydGluIOWGmemBkzoKPiA+ID4gPiA+Pj4+PiBPbiBTdW4sIEphbiAzMCwgMjAy MiBhdCA3OjUwIEFNIEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4g PiA+ID4+Pj4+PiDlnKggMjAyMi8xLzIyIOS4iuWNiDQ6MjcsIEV1Z2VuaW8gUMOpcmV6IOWGmemB kzoKPiA+ID4gPiA+Pj4+Pj4+IFNWUSBpcyBhYmxlIHRvIGxvZyB0aGUgZGlydHkgYml0cyBieSBp dHNlbGYsIHNvIGxldCdzIHVzZSBpdCB0byBub3QKPiA+ID4gPiA+Pj4+Pj4+IGJsb2NrIG1pZ3Jh dGlvbi4KPiA+ID4gPiA+Pj4+Pj4+Cj4gPiA+ID4gPj4+Pj4+PiBBbHNvLCBpZ25vcmUgc2V0IGFu ZCBjbGVhciBvZiBWSE9TVF9GX0xPR19BTEwgb24gc2V0X2ZlYXR1cmVzIGlmIFNWUSBpcwo+ID4g PiA+ID4+Pj4+Pj4gZW5hYmxlZC4gRXZlbiBpZiB0aGUgZGV2aWNlIHN1cHBvcnRzIGl0LCB0aGUg cmVwb3J0cyB3b3VsZCBiZSBub25zZW5zZQo+ID4gPiA+ID4+Pj4+Pj4gYmVjYXVzZSBTVlEgbWVt b3J5IGlzIGluIHRoZSBxZW11IHJlZ2lvbi4KPiA+ID4gPiA+Pj4+Pj4+Cj4gPiA+ID4gPj4+Pj4+ PiBUaGUgbG9nIHJlZ2lvbiBpcyBzdGlsbCBhbGxvY2F0ZWQuIEZ1dHVyZSBjaGFuZ2VzIG1pZ2h0 IHNraXAgdGhhdCwgYnV0Cj4gPiA+ID4gPj4+Pj4+PiB0aGlzIHNlcmllcyBpcyBhbHJlYWR5IGxv bmcgZW5vdWdoLgo+ID4gPiA+ID4+Pj4+Pj4KPiA+ID4gPiA+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6 IEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXptYUByZWRoYXQuY29tPgo+ID4gPiA+ID4+Pj4+Pj4gLS0t Cj4gPiA+ID4gPj4+Pj4+PiAgICAgaHcvdmlydGlvL3Zob3N0LXZkcGEuYyB8IDIwICsrKysrKysr KysrKysrKysrKysrCj4gPiA+ID4gPj4+Pj4+PiAgICAgMSBmaWxlIGNoYW5nZWQsIDIwIGluc2Vy dGlvbnMoKykKPiA+ID4gPiA+Pj4+Pj4+Cj4gPiA+ID4gPj4+Pj4+PiBkaWZmIC0tZ2l0IGEvaHcv dmlydGlvL3Zob3N0LXZkcGEuYyBiL2h3L3ZpcnRpby92aG9zdC12ZHBhLmMKPiA+ID4gPiA+Pj4+ Pj4+IGluZGV4IGZiMGEzMzhiYWEuLjc1MDkwZDY1ZTggMTAwNjQ0Cj4gPiA+ID4gPj4+Pj4+PiAt LS0gYS9ody92aXJ0aW8vdmhvc3QtdmRwYS5jCj4gPiA+ID4gPj4+Pj4+PiArKysgYi9ody92aXJ0 aW8vdmhvc3QtdmRwYS5jCj4gPiA+ID4gPj4+Pj4+PiBAQCAtMTAyMiw2ICsxMDIyLDkgQEAgc3Rh dGljIGludCB2aG9zdF92ZHBhX2dldF9mZWF0dXJlcyhzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYsIHVp bnQ2NF90ICpmZWF0dXJlcykKPiA+ID4gPiA+Pj4+Pj4+ICAgICAgICAgaWYgKHJldCA9PSAwICYm IHYtPnNoYWRvd192cXNfZW5hYmxlZCkgewo+ID4gPiA+ID4+Pj4+Pj4gICAgICAgICAgICAgLyog RmlsdGVyIG9ubHkgZmVhdHVyZXMgdGhhdCBTVlEgY2FuIG9mZmVyIHRvIGd1ZXN0ICovCj4gPiA+ ID4gPj4+Pj4+PiAgICAgICAgICAgICB2aG9zdF9zdnFfdmFsaWRfZ3Vlc3RfZmVhdHVyZXMoZmVh dHVyZXMpOwo+ID4gPiA+ID4+Pj4+Pj4gKwo+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgLyogQWRk IFNWUSBsb2dnaW5nIGNhcGFiaWxpdGllcyAqLwo+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgKmZl YXR1cmVzIHw9IEJJVF9VTEwoVkhPU1RfRl9MT0dfQUxMKTsKPiA+ID4gPiA+Pj4+Pj4+ICAgICAg ICAgfQo+ID4gPiA+ID4+Pj4+Pj4KPiA+ID4gPiA+Pj4+Pj4+ICAgICAgICAgcmV0dXJuIHJldDsK PiA+ID4gPiA+Pj4+Pj4+IEBAIC0xMDM5LDggKzEwNDIsMjUgQEAgc3RhdGljIGludCB2aG9zdF92 ZHBhX3NldF9mZWF0dXJlcyhzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYsCj4gPiA+ID4gPj4+Pj4+Pgo+ ID4gPiA+ID4+Pj4+Pj4gICAgICAgICBpZiAodi0+c2hhZG93X3Zxc19lbmFibGVkKSB7Cj4gPiA+ ID4gPj4+Pj4+PiAgICAgICAgICAgICB1aW50NjRfdCBkZXZfZmVhdHVyZXMsIHN2cV9mZWF0dXJl cywgYWNrZWRfZmVhdHVyZXM7Cj4gPiA+ID4gPj4+Pj4+PiArICAgICAgICB1aW50OF90IHN0YXR1 cyA9IDA7Cj4gPiA+ID4gPj4+Pj4+PiAgICAgICAgICAgICBib29sIG9rOwo+ID4gPiA+ID4+Pj4+ Pj4KPiA+ID4gPiA+Pj4+Pj4+ICsgICAgICAgIHJldCA9IHZob3N0X3ZkcGFfY2FsbChkZXYsIFZI T1NUX1ZEUEFfR0VUX1NUQVRVUywgJnN0YXR1cyk7Cj4gPiA+ID4gPj4+Pj4+PiArICAgICAgICBp ZiAodW5saWtlbHkocmV0KSkgewo+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgICAgIHJldHVybiBy ZXQ7Cj4gPiA+ID4gPj4+Pj4+PiArICAgICAgICB9Cj4gPiA+ID4gPj4+Pj4+PiArCj4gPiA+ID4g Pj4+Pj4+PiArICAgICAgICBpZiAoc3RhdHVzICYgVklSVElPX0NPTkZJR19TX0RSSVZFUl9PSykg ewo+ID4gPiA+ID4+Pj4+Pj4gKyAgICAgICAgICAgIC8qCj4gPiA+ID4gPj4+Pj4+PiArICAgICAg ICAgICAgICogdmhvc3QgaXMgdHJ5aW5nIHRvIGVuYWJsZSBvciBkaXNhYmxlIF9GX0xPRywgYW5k IHRoZSBkZXZpY2UKPiA+ID4gPiA+Pj4+Pj4+ICsgICAgICAgICAgICAgKiB3b3VsZCByZXBvcnQg d3JvbmcgZGlydHkgcGFnZXMuIFNWUSBoYW5kbGVzIGl0Lgo+ID4gPiA+ID4+Pj4+Pj4gKyAgICAg ICAgICAgICAqLwo+ID4gPiA+ID4+Pj4+PiBJIGZhaWwgdG8gdW5kZXJzdGFuZCB0aGlzIGNvbW1l bnQsIEknZCB0aGluayB0aGVyZSdzIG5vIHdheSB0byBkaXNhYmxlCj4gPiA+ID4gPj4+Pj4+IGRp cnR5IHBhZ2UgdHJhY2tpbmcgZm9yIFNWUS4KPiA+ID4gPiA+Pj4+Pj4KPiA+ID4gPiA+Pj4+PiB2 aG9zdF9sb2dfZ2xvYmFsX3tzdGFydCxzdG9wfSBhcmUgY2FsbGVkIGF0IHRoZSBiZWdpbm5pbmcg YW5kIGVuZCBvZgo+ID4gPiA+ID4+Pj4+IG1pZ3JhdGlvbi4gVG8gaW5mb3JtIHRoZSBkZXZpY2Ug dGhhdCBpdCBzaG91bGQgc3RhcnQgbG9nZ2luZywgdGhleSBzZXQKPiA+ID4gPiA+Pj4+PiBvciBj bGVhbiBWSE9TVF9GX0xPR19BTEwgYXQgdmhvc3RfZGV2X3NldF9sb2cuCj4gPiA+ID4gPj4+Pgo+ ID4gPiA+ID4+Pj4gWWVzLCBidXQgZm9yIFNWUSwgd2UgY2FuJ3QgZGlzYWJsZSBkaXJ0eSBwYWdl IHRyYWNraW5nLCBpc24ndCBpdD8gVGhlCj4gPiA+ID4gPj4+PiBvbmx5IHRoaW5nIGlzIHRvIGln bm9yZSBvciBmaWx0ZXIgb3V0IHRoZSBGX0xPR19BTEwgYW5kIHByZXRlbmQgdG8gYmUKPiA+ID4g PiA+Pj4+IGVuYWJsZWQgYW5kIGRpc2FibGVkLgo+ID4gPiA+ID4+Pj4KPiA+ID4gPiA+Pj4gWWVz LCB0aGF0J3Mgd2hhdCB0aGlzIHBhdGNoIGRvZXMuCj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+Pj4g V2hpbGUgU1ZRIGRvZXMgbm90IHVzZSBWSE9TVF9GX0xPR19BTEwsIGl0IGV4cG9ydHMgdGhlIGZl YXR1cmUgYml0IHNvCj4gPiA+ID4gPj4+Pj4gdmhvc3QgZG9lcyBub3QgYmxvY2sgbWlncmF0aW9u LiBNYXliZSB3ZSBuZWVkIHRvIGxvb2sgZm9yIGFub3RoZXIgd2F5Cj4gPiA+ID4gPj4+Pj4gdG8g ZG8gdGhpcz8KPiA+ID4gPiA+Pj4+Cj4gPiA+ID4gPj4+PiBJJ20gZmluZSB3aXRoIGZpbHRlcmlu ZyBzaW5jZSBpdCdzIG11Y2ggbW9yZSBzaW1wbGVyLCBidXQgSSBmYWlsIHRvCj4gPiA+ID4gPj4+ PiB1bmRlcnN0YW5kIHdoeSB3ZSBuZWVkIHRvIGNoZWNrIERSSVZFUl9PSy4KPiA+ID4gPiA+Pj4+ Cj4gPiA+ID4gPj4+IE9rIG1heWJlIEkgY2FuIG1ha2UgdGhhdCBwYXJ0IG1vcmUgY2xlYXIsCj4g PiA+ID4gPj4+Cj4gPiA+ID4gPj4+IFNpbmNlIGJvdGggb3BlcmF0aW9ucyB1c2Ugdmhvc3RfdmRw YV9zZXRfZmVhdHVyZXMgd2UgbXVzdCBqdXN0IGZpbHRlcgo+ID4gPiA+ID4+PiB0aGUgb25lIHRo YXQgYWN0dWFsbHkgc2V0cyBvciByZW1vdmVzIFZIT1NUX0ZfTE9HX0FMTCwgd2l0aG91dAo+ID4g PiA+ID4+PiBhZmZlY3Rpbmcgb3RoZXIgZmVhdHVyZXMuCj4gPiA+ID4gPj4+Cj4gPiA+ID4gPj4+ IEluIHByYWN0aWNlLCB0aGF0IG1lYW5zIHRvIG5vdCBmb3J3YXJkIHRoZSBzZXQgZmVhdHVyZXMg YWZ0ZXIKPiA+ID4gPiA+Pj4gRFJJVkVSX09LLiBUaGUgZGV2aWNlIGlzIG5vdCBleHBlY3Rpbmcg dGhlbSBhbnltb3JlLgo+ID4gPiA+ID4+IEkgd29uZGVyIHdoYXQgaGFwcGVucyBpZiB3ZSBkb24n dCBkbyB0aGlzLgo+ID4gPiA+ID4+Cj4gPiA+ID4gPiBJZiB3ZSBzaW1wbHkgZGVsZXRlIHRoZSBj aGVjayB2aG9zdF9kZXZfc2V0X2ZlYXR1cmVzIHdpbGwgcmV0dXJuIGFuCj4gPiA+ID4gPiBlcnJv ciwgZmFpbGluZyB0aGUgc3RhcnQgb2YgdGhlIG1pZ3JhdGlvbi4gTW9yZSBvbiB0aGlzIGJlbG93 Lgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBPay4KPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4+IFNvIGtlcm5lbCBoYWQgdGhpcyBjaGVjazoKPiA+ID4gPiA+Pgo+ID4gPiA+ID4+ ICAgICAgICAgIC8qCj4gPiA+ID4gPj4gICAgICAgICAgICogSXQncyBub3QgYWxsb3dlZCB0byBj aGFuZ2UgdGhlIGZlYXR1cmVzIGFmdGVyIHRoZXkgaGF2ZQo+ID4gPiA+ID4+ICAgICAgICAgICAq IGJlZW4gbmVnb3RpYXRlZC4KPiA+ID4gPiA+PiAgICAgICAgICAgKi8KPiA+ID4gPiA+PiBpZiAo b3BzLT5nZXRfc3RhdHVzKHZkcGEpICYgVklSVElPX0NPTkZJR19TX0ZFQVRVUkVTX09LKQo+ID4g PiA+ID4+ICAgICAgICAgIHJldHVybiAtRUJVU1k7Cj4gPiA+ID4gPj4KPiA+ID4gPiA+PiBTbyBp cyBpdCBGRUFUVVJFU19PSyBhY3R1YWxseT8KPiA+ID4gPiA+Pgo+ID4gPiA+ID4gWWVzLCBGRUFU VVJFU19PSyBzZWVtcyBtb3JlIGFwcHJvcHJpYXRlIGFjdHVhbGx5IHNvIEkgd2lsbCBzd2l0Y2gg dG8KPiA+ID4gPiA+IGl0IGZvciB0aGUgbmV4dCB2ZXJzaW9uLgo+ID4gPiA+ID4KPiA+ID4gPiA+ IEJ1dCBpdCBzaG91bGQgYmUgZnVuY3Rpb25hbGx5IGVxdWl2YWxlbnQsIHNpbmNlCj4gPiA+ID4g PiB2aG9zdC5jOnZob3N0X2Rldl9zdGFydCBzZXRzIGJvdGggYW5kIHRoZSBzZXR0aW5nIG9mIF9G X0xPR19BTEwgY2Fubm90Cj4gPiA+ID4gPiBiZSBjb25jdXJyZW50IHdpdGggaXQuCj4gPiA+ID4K PiA+ID4gPgo+ID4gPiA+IFJpZ2h0Lgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4g Pj4gRm9yIHRoaXMgcGF0Y2gsIEkgd29uZGVyIGlmIHRoZSB0aGluZyB3ZSBuZWVkIHRvIGRvIGlz IHRvIHNlZSB3aGV0aGVyCj4gPiA+ID4gPj4gaXQgaXMgYSBlbmFibGUvZGlzYWJsZSBGX0xPR19B TEwgYW5kIHNpbXBseSByZXR1cm4uCj4gPiA+ID4gPj4KPiA+ID4gPiA+IFllcywgdGhhdCdzIHRo ZSBpbnRlbnRpb24gb2YgdGhlIHBhdGNoLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFdlIGhhdmUgNCBj YXNlcyBoZXJlOgo+ID4gPiA+ID4gYSkgV2UncmUgYmVpbmcgY2FsbGVkIGZyb20gdmhvc3RfZGV2 X3N0YXJ0LCB3aXRoIGVuYWJsZV9sb2cgPSBmYWxzZQo+ID4gPiA+ID4gYikgV2UncmUgYmVpbmcg Y2FsbGVkIGZyb20gdmhvc3RfZGV2X3N0YXJ0LCB3aXRoIGVuYWJsZV9sb2cgPSB0cnVlCj4gPiA+ ID4KPiA+ID4gPgo+ID4gPiA+IEFuZCB0aGlzIGNhc2UgbWFrZXMgdXMgY2FuJ3Qgc2ltcGx5IHJl dHVybiB3aXRob3V0IGNhbGxpbmcgdmhvc3QtdmRwYS4KPiA+ID4gPgo+ID4gPgo+ID4gPiBJdCBj YWxscyBiZWNhdXNlIHtGRUFUVVJFUyxEUklWRVJ9X09LIGlzIHN0aWxsIG5vdCBzZXQgYXQgdGhh dCBwb2ludC4KPiA+ID4KPiA+ID4gPgo+ID4gPiA+ID4gYykgV2UncmUgYmVpbmcgY2FsbGVkIGZy b20gdmhvc3RfZGV2X3NldF9sb2csIHdpdGggZW5hYmxlX2xvZyA9IGZhbHNlCj4gPiA+ID4gPiBk KSBXZSdyZSBiZWluZyBjYWxsZWQgZnJvbSB2aG9zdF9kZXZfc2V0X2xvZywgd2l0aCBlbmFibGVf bG9nID0gdHJ1ZQo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoZSB3YXkgdG8gdGVsbCB0aGUgZGlmZmVy ZW5jZSBiZXR3ZWVuIGEvYiBhbmQgYy9kIGlzIHRvIGNoZWNrIGlmCj4gPiA+ID4gPiB7RkVBVFVS RVMsRFJJVkVSfV9PSyBpcyBzZXQuIEFuZCwgYXMgeW91IHBvaW50IG91dCBpbiBwcmV2aW91cyBt YWlscywKPiA+ID4gPiA+IEZfTE9HX0FMTCBtdXN0IGJlIGZpbHRlcmVkIHVuY29uZGl0aW9uYWxs eSBzaW5jZSBTVlEgdHJhY2tzIGRpcnR5Cj4gPiA+ID4gPiBtZW1vcnkgdGhyb3VnaCB0aGUgbWVt b3J5IHVubWFwcGluZywgc28gd2UgY2xlYXIgdGhlIGJpdAo+ID4gPiA+ID4gdW5jb25kaXRpb25h bGx5IGlmIHdlIGRldGVjdCB0aGF0IFZIT1NUX1NFVF9GRUFUVVJFUyB3aWxsIGJlIGNhbGxlZAo+ ID4gPiA+ID4gKGNhc2VzIGEgYW5kIGIpLgo+ID4gPiA+ID4KPiA+ID4gPiA+IEFub3RoZXIgcG9z c2liaWxpdHkgaXMgdG8gdHJhY2sgaWYgZmVhdHVyZXMgaGF2ZSBiZWVuIHNldCB3aXRoIGEgYm9v bAo+ID4gPiA+ID4gaW4gdmhvc3RfdmRwYSBvciBzb21ldGhpbmcgbGlrZSB0aGF0LiBCdXQgaXQg c2VlbXMgY2xlYW5lciB0byBtZSB0bwo+ID4gPiA+ID4gb25seSBzdG9yZSB0aGF0IGluIHRoZSBh Y3R1YWwgZGV2aWNlLgo+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBTbyBJIHN1Z2dlc3QgdG8gbWFr ZSBzdXJlIGNvZGVzIG1hdGNoIHRoZSBjb21tZW50Ogo+ID4gPiA+Cj4gPiA+ID4gICAgICAgICAg aWYgKHN0YXR1cyAmIFZJUlRJT19DT05GSUdfU19EUklWRVJfT0spIHsKPiA+ID4gPiAgICAgICAg ICAgICAgLyoKPiA+ID4gPiAgICAgICAgICAgICAgICogdmhvc3QgaXMgdHJ5aW5nIHRvIGVuYWJs ZSBvciBkaXNhYmxlIF9GX0xPRywgYW5kIHRoZSBkZXZpY2UKPiA+ID4gPiAgICAgICAgICAgICAg ICogd291bGQgcmVwb3J0IHdyb25nIGRpcnR5IHBhZ2VzLiBTVlEgaGFuZGxlcyBpdC4KPiA+ID4g PiAgICAgICAgICAgICAgICovCj4gPiA+ID4gICAgICAgICAgICAgIHJldHVybiAwOwo+ID4gPiA+ ICAgICAgICAgIH0KPiA+ID4gPgo+ID4gPiA+IEl0IHdvdWxkIGJlIGJldHRlciB0byBjaGVjayB3 aGV0aGVyIHRoZSBjYWxsZXIgaXMgdG9nZ2xpbmcgX0ZfTE9HX0FMTCBpbgo+ID4gPiA+IHRoaXMg Y2FzZS4KPiA+ID4gPgo+ID4gPgo+ID4gPiBIb3cgdG8gZGV0ZWN0PyBXZSBjYW4gc2F2ZSBmZWF0 dXJlIGZsYWdzIGFuZCBjb21wYXJlLCBidXQgaWdub3JpbmcgYWxsCj4gPiA+IHNldF9mZWF0dXJl cyBhZnRlciBGRUFUVVJFU19PSyBzZWVtcyBzaW1wbGVyIHRvIG1lLgo+ID4KPiA+IFNvbWV0aGlu ZyBsaWtlOgo+ID4KPiA+IChzdGF0dXMgXiBzdGF0dXNfb2xkID09IF9GX0xPR19BTEwpID8KPiA+ Cj4KPiBzL3N0YXR1cy9mZWF0dXJlcy8gPwoKUmlnaHQuCgo+Cj4gPiBJdCBoZWxwcyB1cyB0byBy ZXR1cm4gZXJyb3JzIG9uIHdyb25nIGZlYXR1cmVzIHNldCBkdXJpbmcgRFJJVkVSX09LLgo+ID4K Pgo+IERvIHlvdSBtZWFuIHRvIHJldHVybiBlcnJvcnMgaW4gY2FzZSBvZiB0b2dnbGluZyBvdGhl ciBmZWF0dXJlcyB0aGFuCj4gX0ZfTE9HX0FMTCwgaXNuJ3QgaXQ/IFRoYXQncyBpbnRlcmVzdGlu ZyBhY3R1YWxseSwgYnV0IGl0IHNlZW1zIGl0Cj4gZm9yY2VzIHZob3N0X3ZkcGEgdG8gdHJhY2sg YWNrZWRfZmVhdHVyZXMgdG9vLgoKSSBtZWFudCB3ZSBjYW4gY2hhbmdlIHRoZSBjaGVjayBhIGxp dHRsZSBiaXQgbGlrZToKCmlmIChmZWF0dXJzIF4gZmVhdHVyZXNfb2xkID09IF9GX0xPR19BTEwg JiYgc3RhdHVzICYKVklSVElPX0NPTkZJR19TX0RSSVZFUl9PSykgewogICAgcmV0dXJuIDA7Cn0K CkZvciBvdGhlciBmZWF0dXJlcyBjaGFuZ2luZyB3ZSBhbmQgbGV0IGl0IGdvIGRvd24gdGhlIGxv Z2ljIGFzIHlvdQpwcm9wb3NlZCBpbiB0aGlzIHBhdGNoLgoKVGhhbmtzCgo+Cj4gQWN0dWFsbHks IGl0IHNlZW1zIHRvIG1lIHZob3N0X2Rldi0+YWNrZWRfZmVhdHVyZXMgd2lsbCByZXRhaW4gdGhl IGJhZAo+IGZlYXR1cmVzIGV2ZW4gb24gZXJyb3IuIEknbGwgaW52ZXN0aWdhdGUgaXQuCj4KPiBU aGFua3MhCj4KPgo+ID4gVGhhbmtzCj4gPgo+ID4gPgo+ID4gPiBXb3VsZCBjaGFuZ2luZyB0aGUg Y29tbWVudCB3b3JrPyBTb21ldGhpbmcgbGlrZSAic2V0X2ZlYXR1cmVzIGFmdGVyCj4gPiA+IF9T X0ZFQVRVUkVTX09LIG1lYW5zIHZob3N0IGlzIHRyeWluZyB0byBlbmFibGUgb3IgZGlzYWJsZSBf Rl9MT0csIGFuZAo+ID4gPiB0aGUgZGV2aWNlIHdvdWxkIHJlcG9ydCB3cm9uZyBkaXJ0eSBwYWdl cy4gU1ZRIGhhbmRsZXMgaXQuIgo+ID4gPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6 YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5k YXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E8BCC433EF for ; Thu, 24 Feb 2022 03:46:51 +0000 (UTC) Received: from localhost ([::1]:43816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nN55e-0004E4-9p for qemu-devel@archiver.kernel.org; Wed, 23 Feb 2022 22:46:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nN54h-0003YI-9H for qemu-devel@nongnu.org; Wed, 23 Feb 2022 22:45:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:37641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nN54c-00060X-Gp for qemu-devel@nongnu.org; Wed, 23 Feb 2022 22:45:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645674345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlyCYYWO+bFQxATNj+9uSCUV+uwf9bZAR7cI+BC5YII=; b=gaq60amJRhX5ACXZflfelBZDx4ZpQMaR2r8lRxo2AzZ8kGkvi4gqQy1BQmy6aJhlZ3o6vH 8ZpYRQ45vFhq7p7aAtG7f/3Er4c1QbAY4pWZWUZL2NsqZZhClnROe/hOGhn1OR6iPC6XJo bZ//xQF8zEqMLW2tjanA2kwENrXodUc= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-KWdsBWkgMiSkk0ktvD0rPg-1; Wed, 23 Feb 2022 22:45:44 -0500 X-MC-Unique: KWdsBWkgMiSkk0ktvD0rPg-1 Received: by mail-lj1-f200.google.com with SMTP id e9-20020a05651c090900b0024630875e4eso396603ljq.18 for ; Wed, 23 Feb 2022 19:45:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MlyCYYWO+bFQxATNj+9uSCUV+uwf9bZAR7cI+BC5YII=; b=WwEmyMK5rxaBxIO/jGIo+urpSEfqKb3wF/i8nC/IkzLNe86795dgZU2flDD8G1GsUK 7Xoe5TtbpYkPmjlwWDwsX/GL3GrmE90LyNAoenXIhPV2Ht+3cgk46tv1lCdWIAnCccQc KyLEx9BeG80koG/zkvO2/m3ObayDVOl+LwemcvqzBZv2k+3NzXkZlF9Q/cLQUj+sJCzw F/lD+yk2JQvy3NgxpzMl2USf/d1+SQlDlgsk3eH5k1upRORZzJkgRrTNejiCMAADekq2 bYQxsdpJA06NaqzgmzLAuJ7L4lm+7oFUM9IlAOQ2hFkJChJfC/sWFKYrB+fl6hAg43VX Llmg== X-Gm-Message-State: AOAM530fcZnHmx3qN4zFhfg2kGax65Zq0lN2MV0kOIkEGJVKnwtyW1bY b5t+lnFmH43dVUnJXl+hJgNXS8GJrbBF37nGYWt2Cn37hUKzy5pYLlY5xDgqVwEVttTZ+jJBCoN MwdALHq1LvINeF4Y3L0z6jaP93ZCaLCY= X-Received: by 2002:ac2:508a:0:b0:443:169a:b27 with SMTP id f10-20020ac2508a000000b00443169a0b27mr564263lfm.257.1645674342578; Wed, 23 Feb 2022 19:45:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4S0gyT5i8GJsMEhchNIn1a+cgAfIXEogTf9Mj7wnAyHyTReLgqY+kfFxUxZBS6Ut+KNWv46PrQsEgVbZ1vNA= X-Received: by 2002:ac2:508a:0:b0:443:169a:b27 with SMTP id f10-20020ac2508a000000b00443169a0b27mr564233lfm.257.1645674342219; Wed, 23 Feb 2022 19:45:42 -0800 (PST) MIME-Version: 1.0 References: <20220121202733.404989-1-eperezma@redhat.com> <20220121202733.404989-29-eperezma@redhat.com> <42664143-6d0c-b107-ec90-8e6336bae29b@redhat.com> <9b32f664-56a9-3718-cf48-49003f87d430@redhat.com> <0f0204f1-8b7f-a21e-495e-24443a63f026@redhat.com> In-Reply-To: From: Jason Wang Date: Thu, 24 Feb 2022 11:45:30 +0800 Message-ID: Subject: Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ To: Eugenio Perez Martin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Parav Pandit , Cindy Lu , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , qemu-level , Gautam Dawar , Markus Armbruster , Eduardo Habkost , Harpreet Singh Anand , Xiao W Wang , Peter Xu , Stefan Hajnoczi , Eli Cohen , Paolo Bonzini , Zhu Lingshan , virtualization , Eric Blake , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 23, 2022 at 4:06 PM Eugenio Perez Martin wrote: > > On Wed, Feb 23, 2022 at 4:47 AM Jason Wang wrote: > > > > On Tue, Feb 22, 2022 at 4:06 PM Eugenio Perez Martin > > wrote: > > > > > > On Tue, Feb 22, 2022 at 8:41 AM Jason Wang wrot= e: > > > > > > > > > > > > =E5=9C=A8 2022/2/17 =E4=B8=8B=E5=8D=884:22, Eugenio Perez Martin = =E5=86=99=E9=81=93: > > > > > On Thu, Feb 17, 2022 at 7:02 AM Jason Wang = wrote: > > > > >> On Wed, Feb 16, 2022 at 11:54 PM Eugenio Perez Martin > > > > >> wrote: > > > > >>> On Tue, Feb 8, 2022 at 9:25 AM Jason Wang = wrote: > > > > >>>> > > > > >>>> =E5=9C=A8 2022/2/1 =E4=B8=8B=E5=8D=887:45, Eugenio Perez Marti= n =E5=86=99=E9=81=93: > > > > >>>>> On Sun, Jan 30, 2022 at 7:50 AM Jason Wang wrote: > > > > >>>>>> =E5=9C=A8 2022/1/22 =E4=B8=8A=E5=8D=884:27, Eugenio P=C3=A9r= ez =E5=86=99=E9=81=93: > > > > >>>>>>> SVQ is able to log the dirty bits by itself, so let's use i= t to not > > > > >>>>>>> block migration. > > > > >>>>>>> > > > > >>>>>>> Also, ignore set and clear of VHOST_F_LOG_ALL on set_featur= es if SVQ is > > > > >>>>>>> enabled. Even if the device supports it, the reports would = be nonsense > > > > >>>>>>> because SVQ memory is in the qemu region. > > > > >>>>>>> > > > > >>>>>>> The log region is still allocated. Future changes might ski= p that, but > > > > >>>>>>> this series is already long enough. > > > > >>>>>>> > > > > >>>>>>> Signed-off-by: Eugenio P=C3=A9rez > > > > >>>>>>> --- > > > > >>>>>>> hw/virtio/vhost-vdpa.c | 20 ++++++++++++++++++++ > > > > >>>>>>> 1 file changed, 20 insertions(+) > > > > >>>>>>> > > > > >>>>>>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.= c > > > > >>>>>>> index fb0a338baa..75090d65e8 100644 > > > > >>>>>>> --- a/hw/virtio/vhost-vdpa.c > > > > >>>>>>> +++ b/hw/virtio/vhost-vdpa.c > > > > >>>>>>> @@ -1022,6 +1022,9 @@ static int vhost_vdpa_get_features(st= ruct vhost_dev *dev, uint64_t *features) > > > > >>>>>>> if (ret =3D=3D 0 && v->shadow_vqs_enabled) { > > > > >>>>>>> /* Filter only features that SVQ can offer to g= uest */ > > > > >>>>>>> vhost_svq_valid_guest_features(features); > > > > >>>>>>> + > > > > >>>>>>> + /* Add SVQ logging capabilities */ > > > > >>>>>>> + *features |=3D BIT_ULL(VHOST_F_LOG_ALL); > > > > >>>>>>> } > > > > >>>>>>> > > > > >>>>>>> return ret; > > > > >>>>>>> @@ -1039,8 +1042,25 @@ static int vhost_vdpa_set_features(s= truct vhost_dev *dev, > > > > >>>>>>> > > > > >>>>>>> if (v->shadow_vqs_enabled) { > > > > >>>>>>> uint64_t dev_features, svq_features, acked_feat= ures; > > > > >>>>>>> + uint8_t status =3D 0; > > > > >>>>>>> bool ok; > > > > >>>>>>> > > > > >>>>>>> + ret =3D vhost_vdpa_call(dev, VHOST_VDPA_GET_STATUS= , &status); > > > > >>>>>>> + if (unlikely(ret)) { > > > > >>>>>>> + return ret; > > > > >>>>>>> + } > > > > >>>>>>> + > > > > >>>>>>> + if (status & VIRTIO_CONFIG_S_DRIVER_OK) { > > > > >>>>>>> + /* > > > > >>>>>>> + * vhost is trying to enable or disable _F_LOG= , and the device > > > > >>>>>>> + * would report wrong dirty pages. SVQ handles= it. > > > > >>>>>>> + */ > > > > >>>>>> I fail to understand this comment, I'd think there's no way = to disable > > > > >>>>>> dirty page tracking for SVQ. > > > > >>>>>> > > > > >>>>> vhost_log_global_{start,stop} are called at the beginning and= end of > > > > >>>>> migration. To inform the device that it should start logging,= they set > > > > >>>>> or clean VHOST_F_LOG_ALL at vhost_dev_set_log. > > > > >>>> > > > > >>>> Yes, but for SVQ, we can't disable dirty page tracking, isn't = it? The > > > > >>>> only thing is to ignore or filter out the F_LOG_ALL and preten= d to be > > > > >>>> enabled and disabled. > > > > >>>> > > > > >>> Yes, that's what this patch does. > > > > >>> > > > > >>>>> While SVQ does not use VHOST_F_LOG_ALL, it exports the featur= e bit so > > > > >>>>> vhost does not block migration. Maybe we need to look for ano= ther way > > > > >>>>> to do this? > > > > >>>> > > > > >>>> I'm fine with filtering since it's much more simpler, but I fa= il to > > > > >>>> understand why we need to check DRIVER_OK. > > > > >>>> > > > > >>> Ok maybe I can make that part more clear, > > > > >>> > > > > >>> Since both operations use vhost_vdpa_set_features we must just = filter > > > > >>> the one that actually sets or removes VHOST_F_LOG_ALL, without > > > > >>> affecting other features. > > > > >>> > > > > >>> In practice, that means to not forward the set features after > > > > >>> DRIVER_OK. The device is not expecting them anymore. > > > > >> I wonder what happens if we don't do this. > > > > >> > > > > > If we simply delete the check vhost_dev_set_features will return = an > > > > > error, failing the start of the migration. More on this below. > > > > > > > > > > > > Ok. > > > > > > > > > > > > > > > > > >> So kernel had this check: > > > > >> > > > > >> /* > > > > >> * It's not allowed to change the features after they h= ave > > > > >> * been negotiated. > > > > >> */ > > > > >> if (ops->get_status(vdpa) & VIRTIO_CONFIG_S_FEATURES_OK) > > > > >> return -EBUSY; > > > > >> > > > > >> So is it FEATURES_OK actually? > > > > >> > > > > > Yes, FEATURES_OK seems more appropriate actually so I will switch= to > > > > > it for the next version. > > > > > > > > > > But it should be functionally equivalent, since > > > > > vhost.c:vhost_dev_start sets both and the setting of _F_LOG_ALL c= annot > > > > > be concurrent with it. > > > > > > > > > > > > Right. > > > > > > > > > > > > > > > > > >> For this patch, I wonder if the thing we need to do is to see wh= ether > > > > >> it is a enable/disable F_LOG_ALL and simply return. > > > > >> > > > > > Yes, that's the intention of the patch. > > > > > > > > > > We have 4 cases here: > > > > > a) We're being called from vhost_dev_start, with enable_log =3D f= alse > > > > > b) We're being called from vhost_dev_start, with enable_log =3D t= rue > > > > > > > > > > > > And this case makes us can't simply return without calling vhost-vd= pa. > > > > > > > > > > It calls because {FEATURES,DRIVER}_OK is still not set at that point. > > > > > > > > > > > > c) We're being called from vhost_dev_set_log, with enable_log =3D= false > > > > > d) We're being called from vhost_dev_set_log, with enable_log =3D= true > > > > > > > > > > The way to tell the difference between a/b and c/d is to check if > > > > > {FEATURES,DRIVER}_OK is set. And, as you point out in previous ma= ils, > > > > > F_LOG_ALL must be filtered unconditionally since SVQ tracks dirty > > > > > memory through the memory unmapping, so we clear the bit > > > > > unconditionally if we detect that VHOST_SET_FEATURES will be call= ed > > > > > (cases a and b). > > > > > > > > > > Another possibility is to track if features have been set with a = bool > > > > > in vhost_vdpa or something like that. But it seems cleaner to me = to > > > > > only store that in the actual device. > > > > > > > > > > > > So I suggest to make sure codes match the comment: > > > > > > > > if (status & VIRTIO_CONFIG_S_DRIVER_OK) { > > > > /* > > > > * vhost is trying to enable or disable _F_LOG, and th= e device > > > > * would report wrong dirty pages. SVQ handles it. > > > > */ > > > > return 0; > > > > } > > > > > > > > It would be better to check whether the caller is toggling _F_LOG_A= LL in > > > > this case. > > > > > > > > > > How to detect? We can save feature flags and compare, but ignoring al= l > > > set_features after FEATURES_OK seems simpler to me. > > > > Something like: > > > > (status ^ status_old =3D=3D _F_LOG_ALL) ? > > > > s/status/features/ ? Right. > > > It helps us to return errors on wrong features set during DRIVER_OK. > > > > Do you mean to return errors in case of toggling other features than > _F_LOG_ALL, isn't it? That's interesting actually, but it seems it > forces vhost_vdpa to track acked_features too. I meant we can change the check a little bit like: if (featurs ^ features_old =3D=3D _F_LOG_ALL && status & VIRTIO_CONFIG_S_DRIVER_OK) { return 0; } For other features changing we and let it go down the logic as you proposed in this patch. Thanks > > Actually, it seems to me vhost_dev->acked_features will retain the bad > features even on error. I'll investigate it. > > Thanks! > > > > Thanks > > > > > > > > Would changing the comment work? Something like "set_features after > > > _S_FEATURES_OK means vhost is trying to enable or disable _F_LOG, and > > > the device would report wrong dirty pages. SVQ handles it." > > > >