From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0D0C433F5 for ; Thu, 9 Sep 2021 09:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5603360E0B for ; Thu, 9 Sep 2021 09:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233004AbhIIJdo (ORCPT ); Thu, 9 Sep 2021 05:33:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41247 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbhIIJdn (ORCPT ); Thu, 9 Sep 2021 05:33:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631179953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l6oxYI9ut8npw7lFLZ/z3EUqhsCOkpfGiXzm3CrP2Pc=; b=hx8ktJsYHfshQC0D+JvZytQIVzVKJgiRIRKF2vk/Vhwzv40gxVeHHiVqGfkDSVuw5vRjff bw24jIqwaZMS/ImmOZeujXb8di+EFSnYIxRAonqT1D3pR8xnMBxB/VRhJUIsqCkC91yldT XGOikG1iOjW1+LoDY0zjtb+VkOZ7HCg= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-020vJ4ZGOtCbFQsYtFUdvQ-1; Thu, 09 Sep 2021 05:32:32 -0400 X-MC-Unique: 020vJ4ZGOtCbFQsYtFUdvQ-1 Received: by mail-lf1-f71.google.com with SMTP id bq3-20020a056512150300b003ee49c29389so496121lfb.15 for ; Thu, 09 Sep 2021 02:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l6oxYI9ut8npw7lFLZ/z3EUqhsCOkpfGiXzm3CrP2Pc=; b=WbWOiMpzsV8UO+rE68PUfH7+6VkgZ+LaeFeiXi6uDYuosMsDYoucFCDTKntZZ5k4Pn wT7hzYPnCugjAvUi0lXeElzgTUG/xvR2+nzimv41TqBcKVT0NwjpmEro+7cuWQ4Kte5C uGU3aDwckoYfNEoNzomcgvn5pkw+Z8GGVd4OuDFJdywNQvi+Y4mh3F2zn35YbTYO9MdT +zFbqQiuvSaO1442JD21T5fsDUbm1hMRx80ox4yXmF+B+8kbkDDf5jS36LwVxpO6TsoA 1CCQ/EnJvj6mfQhIOsEyeWCPn/jRABbOftt3kjq4y79NipYt73skL70WJiBXs9+JFcaQ Pxgg== X-Gm-Message-State: AOAM532maEe3/rRoQXX+DEM9B2MTEa7olR2M2aza0gOg61OxJXV8Kj21 TubbOEGd0vHX0kOac0GlhaBfWFGrWKGPTB/j60yPxjeZAcCm6bOBB8VbFj9cDfqcO0fNDyRhwu2 lP/0aHYQNZyAiQ+fGlBF6fPxZkB7yokRHVvOAdgkf X-Received: by 2002:a05:6512:2001:: with SMTP id a1mr1631116lfb.498.1631179950932; Thu, 09 Sep 2021 02:32:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl0hlu0tmaQ2CMyDCL+WTPdOq32+SzUOb2yeoKq+vIsS1TTq4pXoe92IahEto4NDmVJCxLKpcU5CL4QNu/9Hg= X-Received: by 2002:a05:6512:2001:: with SMTP id a1mr1631107lfb.498.1631179950780; Thu, 09 Sep 2021 02:32:30 -0700 (PDT) MIME-Version: 1.0 References: <20210909051706-mutt-send-email-mst@kernel.org> In-Reply-To: <20210909051706-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Thu, 9 Sep 2021 17:32:20 +0800 Message-ID: Subject: Re: [PATCH 5/6] vdpa: add get_vq_num_unchangeable callback in vdpa_config_ops To: "Michael S. Tsirkin" Cc: Wu Zongyong , virtualization , linux-kernel , wei.yang1@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 9, 2021 at 5:18 PM Michael S. Tsirkin wrote: > > On Thu, Sep 09, 2021 at 10:55:03AM +0800, Jason Wang wrote: > > On Wed, Sep 8, 2021 at 8:23 PM Wu Zongyong wrote: > > > > > > This new callback is used to indicate whether the vring size can be > > > change or not. It is useful when we have a legacy virtio pci device as > > > the vdpa device for there is no way to negotiate the vring num by the > > > specification. > > > > So I'm not sure it's worth bothering. E.g what if we just fail > > VHOST_SET_VRING_NUM it the value doesn't match what hardware has? > > > > Thanks > > More importantly is there and actual plan for supporting > legacy devices? I don't think they currently work at a number > of levels. I think the answer is no, it would introduce a lot of burdens. Thanks > > -- > MST > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FECDC433EF for ; Thu, 9 Sep 2021 09:32:39 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C222D611C0 for ; Thu, 9 Sep 2021 09:32:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C222D611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7E83460766; Thu, 9 Sep 2021 09:32:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GUjO9syplFzT; Thu, 9 Sep 2021 09:32:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4FD3F60ACB; Thu, 9 Sep 2021 09:32:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2FF76C0011; Thu, 9 Sep 2021 09:32:37 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B3240C000D for ; Thu, 9 Sep 2021 09:32:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 95549849B0 for ; Thu, 9 Sep 2021 09:32:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zBwm0EsA1RYO for ; Thu, 9 Sep 2021 09:32:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id E5D3080DD0 for ; Thu, 9 Sep 2021 09:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631179953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l6oxYI9ut8npw7lFLZ/z3EUqhsCOkpfGiXzm3CrP2Pc=; b=hx8ktJsYHfshQC0D+JvZytQIVzVKJgiRIRKF2vk/Vhwzv40gxVeHHiVqGfkDSVuw5vRjff bw24jIqwaZMS/ImmOZeujXb8di+EFSnYIxRAonqT1D3pR8xnMBxB/VRhJUIsqCkC91yldT XGOikG1iOjW1+LoDY0zjtb+VkOZ7HCg= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-KmPPBu7lN1Gvxq3Ls_fZpg-1; Thu, 09 Sep 2021 05:32:32 -0400 X-MC-Unique: KmPPBu7lN1Gvxq3Ls_fZpg-1 Received: by mail-lf1-f70.google.com with SMTP id bp18-20020a056512159200b003eb84833c98so500581lfb.14 for ; Thu, 09 Sep 2021 02:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l6oxYI9ut8npw7lFLZ/z3EUqhsCOkpfGiXzm3CrP2Pc=; b=lIGjU3tfg8rXJh7tI87Sy1rLlkiK1aO9BbSs2APOaYBT9Tj/Xp3TYqUN0Ze/Sab7hO xjT5oEQGs73xvGlHVvLTMYg6/sQDc9D5IEETosK3rMLDnbFZIzHlmF3TR1gePolZRGvX CMH6MOJNx/uY51uRbJuqLJlvfFgr1Y7xo56eVQ+MfXWNNlZfUPG5eJNZ53fCXDoV04+X OmBDb8WmS0ON+JnIagb7qtXX5XkuMNDgU5LUualyFoFmVGJ3L0pZ3Os5ijU5fk3/rQyV FdDD9mwgLberfx518nDXLSMFhXq666Z8xVjAdSRJ639q6HAAEf/wZjtt+n3Kq8jY2FlM 7Tow== X-Gm-Message-State: AOAM533vnqvjPvAsxIcuege6yrzuL9/U6pCsmm8n22oGaOMnvdgfay70 nDIFa8m4ylHWNIF7Xy9LuFf9G+ivqWvhrTuWsT2bxt7We+vGFNPN7a1EoCaP3kSLGHvzU7Rw8hn 2sYxkCbiq11ITL+q621bDLP1Hq/WSWeQbJPSbyk7solcxRTv5TeAF6EaDEg== X-Received: by 2002:a05:6512:2001:: with SMTP id a1mr1631115lfb.498.1631179950932; Thu, 09 Sep 2021 02:32:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl0hlu0tmaQ2CMyDCL+WTPdOq32+SzUOb2yeoKq+vIsS1TTq4pXoe92IahEto4NDmVJCxLKpcU5CL4QNu/9Hg= X-Received: by 2002:a05:6512:2001:: with SMTP id a1mr1631107lfb.498.1631179950780; Thu, 09 Sep 2021 02:32:30 -0700 (PDT) MIME-Version: 1.0 References: <20210909051706-mutt-send-email-mst@kernel.org> In-Reply-To: <20210909051706-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Thu, 9 Sep 2021 17:32:20 +0800 Message-ID: Subject: Re: [PATCH 5/6] vdpa: add get_vq_num_unchangeable callback in vdpa_config_ops To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: wei.yang1@linux.alibaba.com, Wu Zongyong , linux-kernel , virtualization X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, Sep 9, 2021 at 5:18 PM Michael S. Tsirkin wrote: > > On Thu, Sep 09, 2021 at 10:55:03AM +0800, Jason Wang wrote: > > On Wed, Sep 8, 2021 at 8:23 PM Wu Zongyong wrote: > > > > > > This new callback is used to indicate whether the vring size can be > > > change or not. It is useful when we have a legacy virtio pci device as > > > the vdpa device for there is no way to negotiate the vring num by the > > > specification. > > > > So I'm not sure it's worth bothering. E.g what if we just fail > > VHOST_SET_VRING_NUM it the value doesn't match what hardware has? > > > > Thanks > > More importantly is there and actual plan for supporting > legacy devices? I don't think they currently work at a number > of levels. I think the answer is no, it would introduce a lot of burdens. Thanks > > -- > MST > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization