From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7932BC433F5 for ; Mon, 9 May 2022 09:39:26 +0000 (UTC) Received: from localhost ([::1]:41084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnzrR-00036r-Eu for qemu-devel@archiver.kernel.org; Mon, 09 May 2022 05:39:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzo0-0000rZ-Pb for qemu-devel@nongnu.org; Mon, 09 May 2022 05:35:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzny-0002PH-DC for qemu-devel@nongnu.org; Mon, 09 May 2022 05:35:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652088949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vqVOvVE7jMIEY+2mVcDnfEvRD296hr9fZYZQEG751As=; b=gKpBqbhCOUUKjtN4LGRqZn3lfcMCc6zbL6i4FTE3mf2d8tGqXExT2dPf9esa5Zu64l7Hrd agkJYtu5ggoQCNKWzv7dngIqQDrWwSW07zgQviw/PBI2DG6LHafHodvtD87oe4JOE5A0ol 0R0Y9lAAw2f2CEoH75qnXLSyLYVoytU= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-442-UpxOGUbQOp6c1zgpDDazAA-1; Mon, 09 May 2022 05:35:47 -0400 X-MC-Unique: UpxOGUbQOp6c1zgpDDazAA-1 Received: by mail-lf1-f72.google.com with SMTP id e8-20020ac24e08000000b00473b1bae573so5595452lfr.3 for ; Mon, 09 May 2022 02:35:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vqVOvVE7jMIEY+2mVcDnfEvRD296hr9fZYZQEG751As=; b=LhpMu+CvrKMUL2TC9miVrvE+OnmtT6msiWZmRYxCi05+gLwrHAUJLaGkqI1rAqgyIQ Fzq5FcEzIJ8mQoO1A21TGXBctqW1DpLXrhFOK3AU7AlizLuvlJSRclB8xLxCpv71n/0K TI3ctIrhwfLtFsJhyV/56e+uQ3nB//x3oRuspUFrWEVZag51N+PCS2bENidgQ3Mxdblb 7aY7R12Tv91t4XGEELRT6lVLFXv5SXnrWspreHRuCCsAwsJkMD6GcLCb6KnmU0zpi8/F OinMGevk9awrsCOz6uKOft5z2OSeEJlctmVcyharieT1hLal/SMJW6UtTGzgkCO5TARR 89ow== X-Gm-Message-State: AOAM530eTRRqeIlo8qK7NGU3lZu1vL3zUcbdklzJlVwLp+IONQ8O6LqT NQxb6AAzwjQJvAQHCix6OZnqx3iyFMiBzHZZz/R8HQO6sPHhIq6ZJncK/sc6x48v6aFwmb1GBVU Vagx8sTKRlAKkP4p7CIrHQLJ7G8oR8Yc= X-Received: by 2002:a19:ca50:0:b0:471:f556:92b with SMTP id h16-20020a19ca50000000b00471f556092bmr11793077lfj.587.1652088946265; Mon, 09 May 2022 02:35:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaUesHD5TJAWy5mWb78K7kSsz/8XjnZu/GBhYu7y+T6l7TduogMREI3YfxFaTYakUnbu/Shcwulask7hvXU+g= X-Received: by 2002:a19:ca50:0:b0:471:f556:92b with SMTP id h16-20020a19ca50000000b00471f556092bmr11793063lfj.587.1652088946016; Mon, 09 May 2022 02:35:46 -0700 (PDT) MIME-Version: 1.0 References: <87a6bulueg.fsf@pond.sub.org> <8a8b144a-c9d6-41b0-71fd-c7850dce9c93@redhat.com> <87bkw7e0mc.fsf@pond.sub.org> In-Reply-To: From: Jason Wang Date: Mon, 9 May 2022 17:35:34 +0800 Message-ID: Subject: Re: ebpf/rss.bpf.skeleton.h generated by what? To: Peter Maydell Cc: Markus Armbruster , Paolo Bonzini , Andrew Melnychenko , qemu-devel Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 9, 2022 at 4:42 PM Peter Maydell wrote: > > On Mon, 9 May 2022 at 06:30, Markus Armbruster wrote: > > Always, always, *always* document your reasons for doing stuff right in > > the commit message, unless they are blindingly obvious. I understand > > reasons can be obvious enough to the author. Document them anyway if > > there is any chance they are not obvious to others. > > It's also nice for code-generators to say who they are > in this kind of "this file is autogenerated" comment. > For instance our own decodetree script's comments read > /* This file is autogenerated by scripts/decodetree.py. */ Unfortunately, this is not what bpftool did right now. Have posted a patch (with Markus and you cced). Thanks > > -- PMM >