From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A120C433F5 for ; Thu, 4 Nov 2021 02:34:45 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D1D56113B for ; Thu, 4 Nov 2021 02:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D1D56113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0D4A340368; Thu, 4 Nov 2021 02:34:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MSfRcul-5Afe; Thu, 4 Nov 2021 02:34:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8E346402A4; Thu, 4 Nov 2021 02:34:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 702DCC0019; Thu, 4 Nov 2021 02:34:43 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CEA72C000E for ; Thu, 4 Nov 2021 02:34:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A594F402EA for ; Thu, 4 Nov 2021 02:34:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BysZwDc53qd7 for ; Thu, 4 Nov 2021 02:34:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id DA3A0402A4 for ; Thu, 4 Nov 2021 02:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635993279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F0blnMfu1IPQFo5xoG5T4IPh8ZDv7m3+nQiHK+FEm10=; b=RBnF7nvI4iFCLI5ECSeoDx3rfFg/naiNGlbw58PwDeQCnFQebcT6q/F98NHNitaFT4vqqo 38Jx5ryIZjOEQ0o3RL8JkMsBnjfY9tKotc7p/ze9PtrLgn+c8i3wXnyQc6xmPg6witVJ87 roaAUCUvqflY9EUtdY2LK2WGVx9gZVE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-3zNqjCqwP0iQCaD-68epuQ-1; Wed, 03 Nov 2021 22:34:36 -0400 X-MC-Unique: 3zNqjCqwP0iQCaD-68epuQ-1 Received: by mail-lj1-f199.google.com with SMTP id h14-20020a2ea48e000000b0021789353d84so1771137lji.15 for ; Wed, 03 Nov 2021 19:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=F0blnMfu1IPQFo5xoG5T4IPh8ZDv7m3+nQiHK+FEm10=; b=pQx7Ht00uU2qqoeSjEGxuZhw29lWVBsGPMIY0ZlyDGAk+I/BwaGLX4yS0Bihb/4Cqs DFYPvZ3RZKncAkI8WO5q9Yf0XOzJ+9BEYsvkACi+pFH6FCpPR6KnNn+yMNQjst+yigxA FotGhquffIu5VuhdnPJHfcMp2ZknoraGE/YXNk+//N/742XbM3cdZPLu4ZHZPr6FzqN+ 1IMqf+FA+wlMdMUet76Cz9xhzbyuSE3/xtw9gRJVXqONd5bnhWuDzAtEjUZTHjH3FnJ5 siWppjiAr2Q86/q8SKjA2EJzY/1od94jbvafKS10NS9L6s3vCTSGRL2UtpdQcjcUYSHz hplQ== X-Gm-Message-State: AOAM533EqAqSN9dZqpgvYWm7KI40/aJoytygPJrGhAV0YHbAOd8PHjnu 9MeDWQGudyoARc0xGUunqgvSyY+r5Z6YtKRTbCHpgLv3gzmO5WIcMPDxa+B4czUxi2VRUhTmgc/ BJ6FVLQYYKl0KJhhF46AgnHHLVwFTAyi7PDL4N3H5LGwUz179DW1wbkInwA== X-Received: by 2002:a05:6512:1291:: with SMTP id u17mr46252359lfs.84.1635993275198; Wed, 03 Nov 2021 19:34:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz13yriHYCo2BzwTEWmGSIV5YjpmbLvEcqatDb5pcm/JxzUwbVtdNSkaMFWdLtsl72unSlkVIHOqUaALstfQuE= X-Received: by 2002:a05:6512:1291:: with SMTP id u17mr46252324lfs.84.1635993274974; Wed, 03 Nov 2021 19:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-22-eperezma@redhat.com> In-Reply-To: From: Jason Wang Date: Thu, 4 Nov 2021 10:34:24 +0800 Message-ID: Subject: Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq To: Eugenio Perez Martin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson , qemu-devel , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Eric Blake , virtualization , Parav Pandit X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBOb3YgMywgMjAyMSBhdCAzOjQ0IFBNIEV1Z2VuaW8gUGVyZXogTWFydGluIDxlcGVy ZXptYUByZWRoYXQuY29tPiB3cm90ZToKPgo+IE9uIFdlZCwgTm92IDMsIDIwMjEgYXQgNDoxOCBB TSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBUdWUs IE5vdiAyLCAyMDIxIGF0IDQ6MTAgUE0gRXVnZW5pbyBQZXJleiBNYXJ0aW4gPGVwZXJlem1hQHJl ZGhhdC5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBUdWUsIE5vdiAyLCAyMDIxIGF0IDY6MjYg QU0gSmFzb24gV2FuZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4g PiBPbiBTYXQsIE9jdCAzMCwgMjAyMSBhdCAyOjQ0IEFNIEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXpt YUByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGlzIGFsbG93cyBpdCB0 byB0ZXN0IGlmIHRoZSBndWVzdCBoYXMgYWtub3dsZWRnZSBhbiBpbnZhbGlkIHRyYW5zcG9ydAo+ ID4gPiA+ID4gZmVhdHVyZSBmb3IgU1ZRLiBUaGlzIHdpbGwgaW5jbHVkZSBwYWNrZWQgdnEgbGF5 b3V0IG9yIGV2ZW50X2lkeCwKPiA+ID4gPiA+IHdoZXJlIFZpcnRJTyBkZXZpY2UgbmVlZHMgaGVs cCBmcm9tIFNWUS4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGVyZSBpcyBub3QgbmVlZGVkIGF0IHRo aXMgbW9tZW50LCBidXQgc2luY2UgU1ZRIHdpbGwgbm90IHJlLW5lZ290aWF0ZQo+ID4gPiA+ID4g ZmVhdHVyZXMgYWdhaW4gd2l0aCB0aGUgZ3Vlc3QsIGEgZmFpbHVyZSBpbiBhY2tub3dsZWRnZSB0 aGVtIGlzIGZhdGFsCj4gPiA+ID4gPiBmb3IgU1ZRLgo+ID4gPiA+ID4KPiA+ID4gPgo+ID4gPiA+ IEl0J3Mgbm90IGNsZWFyIHRvIG1lIHdoeSB3ZSBuZWVkIHRoaXMuIE1heWJlIHlvdSBjYW4gZ2l2 ZSBtZSBhbgo+ID4gPiA+IGV4YW1wbGUuIEUuZyBpc24ndCBpdCBzdWZmaWNpZW50IHRvIGZpbHRl ciBvdXQgdGhlIGRldmljZSB3aXRoCj4gPiA+ID4gZXZlbnRfaWR4Pwo+ID4gPiA+Cj4gPiA+Cj4g PiA+IElmIHRoZSBndWVzdCBkaWQgbmVnb3RpYXRlIF9GX0VWRU5UX0lEWCwgaXQgZXhwZWN0cyB0 byBiZSBub3RpZmllZAo+ID4gPiBvbmx5IHdoZW4gZGV2aWNlIG1hcmtzIGFzIHVzZWQgYSBzcGVj aWZpYyBudW1iZXIgb2YgZGVzY3JpcHRvcnMuCj4gPiA+Cj4gPiA+IElmIHdlIHVzZSBWaXJ0UXVl dWUgbm90aWZpY2F0aW9uLCB0aGUgVmlydFF1ZXVlIGNvZGUgaGFuZGxlcyBpdAo+ID4gPiB0cmFu c3BhcmVudGx5LiBCdXQgaWYgd2Ugd2FudCB0byBiZSBhYmxlIHRvIGNoYW5nZSB0aGUgZ3Vlc3Qg VlEncwo+ID4gPiBjYWxsX2ZkLCB3ZSBjYW5ub3QgdXNlIFZpcnRRdWV1ZSdzLCBzbyB0aGlzIG5l ZWRzIHRvIGJlIGhhbmRsZWQgYnkgU1ZRCj4gPiA+IGNvZGUuIEFuZCB0aGF0IGlzIHN0aWxsIG5v dCBpbXBsZW1lbnRlZC4KPiA+ID4KPiA+ID4gT2YgY291cnNlIGluIHRoZSBldmVudF9pZHggY2Fz ZSB3ZSBjb3VsZCBqdXN0IGlnbm9yZSBpdCBhbmQgbm90aWZ5IGluCj4gPiA+IGFsbCB1c2VkIGRl c2NyaXB0b3JzLCBidXQgaXQgc2VlbXMgbm90IHBvbGl0ZSB0byBtZSA6KS4gSSB3aWxsIGRldmVs b3AKPiA+ID4gZXZlbnRfaWR4IG9uIHRvcCBvZiB0aGlzLCBlaXRoZXIgZXhwb3NpbmcgdGhlIG5l ZWRlZCBwaWVjZXMgaW4KPiA+ID4gVmlydFF1ZXVlIChJIHByZWZlciB0aGlzKSBvciByb2xsaW5n IG91ciBvd24gaW4gU1ZRLgo+ID4KPiA+IFllcywgYnV0IHdoYXQgSSBtZWFudCBpcywgd2UgY2Fu IGZhaWwgdGhlIFNWUSBlbmFibGluZyBpZiB0aGUgZGV2aWNlCj4gPiBzdXBwb3J0cyBldmVudF9p ZHguIFRoZW4gd2UncmUgc3VyZSBndWVzdHMgd29uJ3QgbmVnb3RpYXRlIGV2ZW50X2lkeC4KPiA+ Cj4KPiBXZSBjYW4gZ28gdGhhdCB3YXkgZm9yIHN1cmUsIGJ1dCB0aGVuIHdlIGxlYXZlIG91dCB0 aGUgc2NlbmFyaW8gd2hlcmUKPiB0aGUgZGV2aWNlIHN1cHBvcnRzIGV2ZW50X2lkeCBidXQgdGhl IGd1ZXN0IGhhcyBub3QgYWNrZWQgaXQuIFRoaXMgaXMKPiBhIHZhbGlkIHNjZW5hcmlvIGZvciBT VlEgdG8gd29yayBpbi4KCklmIFNWUSBzdXBwb3J0cyBldmVudCBpZHggaW4gdGhlIGZ1dHVyZSwg d2UgY2FuIHJlbW92ZSBpdCBmcm9tIHRoZQpibGFja2xpc3QuIEJ1dCBJIHRoaW5rIGl0IHNob3Vs ZCBiZSBzaW1wbGVyIHRvIGxldCBTVlEgdXNlIHRoZSBzYW1lCmZlYXR1cmVzIGFzIGd1ZXN0cy4g U28gaW4gdGhpcyBjYXNlIFNWUSB3b24ndCB1c2UgdGhlIGV2ZW50IGluZGV4LgoKVGhhbmtzCgo+ Cj4gVGhhbmtzIQo+Cj4gPiBUaGFua3MKPiA+Cj4gPiA+Cj4gPiA+IFNhbWUgcmVhc29uaW5nIGNh biBiZSBhcHBsaWVkIHRvIHVua25vd24gdHJhbnNwb3J0IGZlYXR1cmVzLgo+ID4gPgo+ID4gPiBU aGFua3MhCj4gPiA+Cj4gPiA+ID4gVGhhbmtzCj4gPiA+ID4KPiA+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXptYUByZWRoYXQuY29tPgo+ID4gPiA+ID4gLS0tCj4g PiA+ID4gPiAgaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUuaCB8IDEgKwo+ID4gPiA+ ID4gIGh3L3ZpcnRpby92aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmMgfCA2ICsrKysrKwo+ID4gPiA+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4gPiA+ID4gPgo+ID4gPiA+ID4g ZGlmZiAtLWdpdCBhL2h3L3ZpcnRpby92aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmggYi9ody92aXJ0 aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1ZS5oCj4gPiA+ID4gPiBpbmRleCA5NDZiMmM2Mjk1Li5h YzU1NTg4MDA5IDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12 aXJ0cXVldWUuaAo+ID4gPiA+ID4gKysrIGIvaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVl dWUuaAo+ID4gPiA+ID4gQEAgLTE2LDYgKzE2LDcgQEAKPiA+ID4gPiA+ICB0eXBlZGVmIHN0cnVj dCBWaG9zdFNoYWRvd1ZpcnRxdWV1ZSBWaG9zdFNoYWRvd1ZpcnRxdWV1ZTsKPiA+ID4gPiA+Cj4g PiA+ID4gPiAgYm9vbCB2aG9zdF9zdnFfdmFsaWRfZGV2aWNlX2ZlYXR1cmVzKHVpbnQ2NF90ICpm ZWF0dXJlcyk7Cj4gPiA+ID4gPiArYm9vbCB2aG9zdF9zdnFfdmFsaWRfZ3Vlc3RfZmVhdHVyZXMo dWludDY0X3QgKmZlYXR1cmVzKTsKPiA+ID4gPiA+Cj4gPiA+ID4gPiAgdm9pZCB2aG9zdF9zdnFf c2V0X3N2cV9raWNrX2ZkKFZob3N0U2hhZG93VmlydHF1ZXVlICpzdnEsIGludCBzdnFfa2lja19m ZCk7Cj4gPiA+ID4gPiAgdm9pZCB2aG9zdF9zdnFfc2V0X2d1ZXN0X2NhbGxfbm90aWZpZXIoVmhv c3RTaGFkb3dWaXJ0cXVldWUgKnN2cSwgaW50IGNhbGxfZmQpOwo+ID4gPiA+ID4gZGlmZiAtLWdp dCBhL2h3L3ZpcnRpby92aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmMgYi9ody92aXJ0aW8vdmhvc3Qt c2hhZG93LXZpcnRxdWV1ZS5jCj4gPiA+ID4gPiBpbmRleCA2ZTA1MDhhMjMxLi5jYjlmZmNiMDE1 IDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUu Ywo+ID4gPiA+ID4gKysrIGIvaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUuYwo+ID4g PiA+ID4gQEAgLTYyLDYgKzYyLDEyIEBAIGJvb2wgdmhvc3Rfc3ZxX3ZhbGlkX2RldmljZV9mZWF0 dXJlcyh1aW50NjRfdCAqZGV2X2ZlYXR1cmVzKQo+ID4gPiA+ID4gICAgICByZXR1cm4gdHJ1ZTsK PiA+ID4gPiA+ICB9Cj4gPiA+ID4gPgo+ID4gPiA+ID4gKy8qIElmIHRoZSBndWVzdCBpcyB1c2lu ZyBzb21lIG9mIHRoZXNlLCBTVlEgY2Fubm90IGNvbW11bmljYXRlICovCj4gPiA+ID4gPiArYm9v bCB2aG9zdF9zdnFfdmFsaWRfZ3Vlc3RfZmVhdHVyZXModWludDY0X3QgKmd1ZXN0X2ZlYXR1cmVz KQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsgICAgcmV0dXJuIHRydWU7Cj4gPiA+ID4gPiArfQo+ ID4gPiA+ID4gKwo+ID4gPiA+ID4gIC8qIEZvcndhcmQgZ3Vlc3Qgbm90aWZpY2F0aW9ucyAqLwo+ ID4gPiA+ID4gIHN0YXRpYyB2b2lkIHZob3N0X2hhbmRsZV9ndWVzdF9raWNrKEV2ZW50Tm90aWZp ZXIgKm4pCj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gLS0KPiA+ID4gPiA+IDIuMjcuMAo+ID4gPiA+ ID4KPiA+ID4gPgo+ID4gPgo+ID4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9u QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9u Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE39C433F5 for ; Thu, 4 Nov 2021 02:37:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D82C66113B for ; Thu, 4 Nov 2021 02:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D82C66113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miSce-0003IF-Rx for qemu-devel@archiver.kernel.org; Wed, 03 Nov 2021 22:37:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miSaS-0001ke-NG for qemu-devel@nongnu.org; Wed, 03 Nov 2021 22:34:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miSaP-0004rX-1J for qemu-devel@nongnu.org; Wed, 03 Nov 2021 22:34:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635993279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F0blnMfu1IPQFo5xoG5T4IPh8ZDv7m3+nQiHK+FEm10=; b=RBnF7nvI4iFCLI5ECSeoDx3rfFg/naiNGlbw58PwDeQCnFQebcT6q/F98NHNitaFT4vqqo 38Jx5ryIZjOEQ0o3RL8JkMsBnjfY9tKotc7p/ze9PtrLgn+c8i3wXnyQc6xmPg6witVJ87 roaAUCUvqflY9EUtdY2LK2WGVx9gZVE= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-0WkrvrJIOqCDMwfrSYMaSA-1; Wed, 03 Nov 2021 22:34:36 -0400 X-MC-Unique: 0WkrvrJIOqCDMwfrSYMaSA-1 Received: by mail-lf1-f72.google.com with SMTP id c40-20020a05651223a800b004018e2f2512so815414lfv.11 for ; Wed, 03 Nov 2021 19:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=F0blnMfu1IPQFo5xoG5T4IPh8ZDv7m3+nQiHK+FEm10=; b=a5VIIMMZKiy/iwi14a/jMX5p+5xr6dkTsURuJPNyzGwZdeOXpUB4FfMagxRWH77jO4 FlQ+wJdVsAFXYSvlc/wz6C1qq7MsagXG/KVBMNPWkQMeK6gzwVAQ8JX/GPKDrQ88Cp4Y 1UB8TmIYYYz+H6BIAjdKwWq/SEIS+eA9MD7hXoLYKUUtJPMtB0UH/jt/O5b9DFmE01tk 5g4tcWh6Bt8rv1BC4YJxwCD9SjGu/6dt0fIzVIatV4f+64V96NtURGn7zNh+9PE2fLpM 5yFFN+IITgjRRULkRGZXXKwkvy905EO3yxfnHV/7gW2TM7sPYPwCuZSiRq2gBU2dFv0q ZR/w== X-Gm-Message-State: AOAM532o/G8CP7T8DeMj6fII33iz8UrPC7ockm2KkAyqFCNKq0L3TwoG Av3DMb7Oi9VVK4bJDPyWlMBMjo5rWru15HK2C60opi6ivYuZ8mPFl2NLoSCTEb+MeKe9Dn/84QJ kf3+t01YXgMQuExZWfFktrbxOmlbJDeI= X-Received: by 2002:a05:6512:1291:: with SMTP id u17mr46252345lfs.84.1635993275174; Wed, 03 Nov 2021 19:34:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz13yriHYCo2BzwTEWmGSIV5YjpmbLvEcqatDb5pcm/JxzUwbVtdNSkaMFWdLtsl72unSlkVIHOqUaALstfQuE= X-Received: by 2002:a05:6512:1291:: with SMTP id u17mr46252324lfs.84.1635993274974; Wed, 03 Nov 2021 19:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20211029183525.1776416-1-eperezma@redhat.com> <20211029183525.1776416-22-eperezma@redhat.com> In-Reply-To: From: Jason Wang Date: Thu, 4 Nov 2021 10:34:24 +0800 Message-ID: Subject: Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq To: Eugenio Perez Martin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , qemu-devel , Peter Xu , Markus Armbruster , Stefan Hajnoczi , Xiao W Wang , Harpreet Singh Anand , Eli Cohen , Paolo Bonzini , Stefano Garzarella , Eric Blake , virtualization , Parav Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 3, 2021 at 3:44 PM Eugenio Perez Martin w= rote: > > On Wed, Nov 3, 2021 at 4:18 AM Jason Wang wrote: > > > > On Tue, Nov 2, 2021 at 4:10 PM Eugenio Perez Martin wrote: > > > > > > On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote= : > > > > > > > > On Sat, Oct 30, 2021 at 2:44 AM Eugenio P=C3=A9rez wrote: > > > > > > > > > > This allows it to test if the guest has aknowledge an invalid tra= nsport > > > > > feature for SVQ. This will include packed vq layout or event_idx, > > > > > where VirtIO device needs help from SVQ. > > > > > > > > > > There is not needed at this moment, but since SVQ will not re-neg= otiate > > > > > features again with the guest, a failure in acknowledge them is f= atal > > > > > for SVQ. > > > > > > > > > > > > > It's not clear to me why we need this. Maybe you can give me an > > > > example. E.g isn't it sufficient to filter out the device with > > > > event_idx? > > > > > > > > > > If the guest did negotiate _F_EVENT_IDX, it expects to be notified > > > only when device marks as used a specific number of descriptors. > > > > > > If we use VirtQueue notification, the VirtQueue code handles it > > > transparently. But if we want to be able to change the guest VQ's > > > call_fd, we cannot use VirtQueue's, so this needs to be handled by SV= Q > > > code. And that is still not implemented. > > > > > > Of course in the event_idx case we could just ignore it and notify in > > > all used descriptors, but it seems not polite to me :). I will develo= p > > > event_idx on top of this, either exposing the needed pieces in > > > VirtQueue (I prefer this) or rolling our own in SVQ. > > > > Yes, but what I meant is, we can fail the SVQ enabling if the device > > supports event_idx. Then we're sure guests won't negotiate event_idx. > > > > We can go that way for sure, but then we leave out the scenario where > the device supports event_idx but the guest has not acked it. This is > a valid scenario for SVQ to work in. If SVQ supports event idx in the future, we can remove it from the blacklist. But I think it should be simpler to let SVQ use the same features as guests. So in this case SVQ won't use the event index. Thanks > > Thanks! > > > Thanks > > > > > > > > Same reasoning can be applied to unknown transport features. > > > > > > Thanks! > > > > > > > Thanks > > > > > > > > > Signed-off-by: Eugenio P=C3=A9rez > > > > > --- > > > > > hw/virtio/vhost-shadow-virtqueue.h | 1 + > > > > > hw/virtio/vhost-shadow-virtqueue.c | 6 ++++++ > > > > > 2 files changed, 7 insertions(+) > > > > > > > > > > diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost= -shadow-virtqueue.h > > > > > index 946b2c6295..ac55588009 100644 > > > > > --- a/hw/virtio/vhost-shadow-virtqueue.h > > > > > +++ b/hw/virtio/vhost-shadow-virtqueue.h > > > > > @@ -16,6 +16,7 @@ > > > > > typedef struct VhostShadowVirtqueue VhostShadowVirtqueue; > > > > > > > > > > bool vhost_svq_valid_device_features(uint64_t *features); > > > > > +bool vhost_svq_valid_guest_features(uint64_t *features); > > > > > > > > > > void vhost_svq_set_svq_kick_fd(VhostShadowVirtqueue *svq, int sv= q_kick_fd); > > > > > void vhost_svq_set_guest_call_notifier(VhostShadowVirtqueue *svq= , int call_fd); > > > > > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost= -shadow-virtqueue.c > > > > > index 6e0508a231..cb9ffcb015 100644 > > > > > --- a/hw/virtio/vhost-shadow-virtqueue.c > > > > > +++ b/hw/virtio/vhost-shadow-virtqueue.c > > > > > @@ -62,6 +62,12 @@ bool vhost_svq_valid_device_features(uint64_t = *dev_features) > > > > > return true; > > > > > } > > > > > > > > > > +/* If the guest is using some of these, SVQ cannot communicate *= / > > > > > +bool vhost_svq_valid_guest_features(uint64_t *guest_features) > > > > > +{ > > > > > + return true; > > > > > +} > > > > > + > > > > > /* Forward guest notifications */ > > > > > static void vhost_handle_guest_kick(EventNotifier *n) > > > > > { > > > > > -- > > > > > 2.27.0 > > > > > > > > > > > > > > >