From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C628C433F5 for ; Wed, 27 Oct 2021 07:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FC1460F5A for ; Wed, 27 Oct 2021 07:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240465AbhJ0H1j (ORCPT ); Wed, 27 Oct 2021 03:27:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48998 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240384AbhJ0H1h (ORCPT ); Wed, 27 Oct 2021 03:27:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635319512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DbPmqjJWgzA3Y/zZgHiZJYXUBsMyJrhMz63cdq96J9s=; b=R7gecuaI1c2ZHQjqbNvjR4nldc0VjNw49LkLIi+QrbmzHT569LRL8b/ehAR5vzmAQA2p+g l4/HGtACQkvHLfTAarnNiEHvSTmyKaX298elpvj5r6YYQhJ3CnmzX+quydpFYT9t+7vBEC ZdZpY2YeZXRzm/mXhbc9ieCc+7z9XJw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-0greNRMIOsSXl936zLwNxw-1; Wed, 27 Oct 2021 03:25:08 -0400 X-MC-Unique: 0greNRMIOsSXl936zLwNxw-1 Received: by mail-lf1-f72.google.com with SMTP id f13-20020a056512228d00b003ffd53671d8so313543lfu.14 for ; Wed, 27 Oct 2021 00:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DbPmqjJWgzA3Y/zZgHiZJYXUBsMyJrhMz63cdq96J9s=; b=GsRXMIn8MWQ+2XCLZaTlSQ3qlKkIIKOwoLAMB8Aku/IwNHFrt3LhRXfcb0inPI+5ZV Np2mex8gikddoLJ+SmzWzpPUpqOZ9hBUS6ZeWvylFf9L/DnVRPZlSV8cXmqeIg0zc16r vhck1lSf6j54wyqdUpk42U07DnPXJAicrrzynJGIUSkpUgF8VIoHI3mzwWDJeqgFQgDd Mji5T1ZE0S+wJfy3nKrGkeRdrTK43V62TOex1mIzpoiQ0Ne98pU81/ypFLrSCPza5lkD HPOzSqJKG4o3m1s+qmUOPRes0ilMGHOc2ZJefC3mjt0NGURgqmAh/kkCvORr3MW9edTI dHKQ== X-Gm-Message-State: AOAM533otgQFWTu4i1816FsXkHmRl7mVANVot7fAClgCMTy7X32QRoNZ foYUnZluZGdmRhM/+Q4/W1/U2kFaKLjrApPVlASs/P/EvSplZXdp1Sp49sM7gPgRp8UUPV5mAUC fxnFWwfWQbp2QJ2dS2T7lKeENDj2pK+Vw X-Received: by 2002:a2e:5344:: with SMTP id t4mr31144647ljd.362.1635319506837; Wed, 27 Oct 2021 00:25:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx60K3agBV72twigmEzIG4Fvw5bMCI5GhxSGQ19U5tE6uaE7t6SoxPwUooNXl7eML2YSuLhLTyhqBbs6SAqrUA= X-Received: by 2002:a2e:5344:: with SMTP id t4mr31144627ljd.362.1635319506634; Wed, 27 Oct 2021 00:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20211026175634.3198477-1-kuba@kernel.org> In-Reply-To: From: Jason Wang Date: Wed, 27 Oct 2021 15:24:55 +0800 Message-ID: Subject: Re: [PATCH net-next] net: virtio: use eth_hw_addr_set() To: Jakub Kicinski Cc: davem , netdev , mst , virtualization Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 27, 2021 at 10:45 AM Jason Wang wrote: > > On Wed, Oct 27, 2021 at 1:56 AM Jakub Kicinski wrote: > > > > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount > > of VLANs...") introduced a rbtree for faster Ethernet address look > > up. To maintain netdev->dev_addr in this tree we need to make all > > the writes to it go through appropriate helpers. > > I think the title should be "net: virtio: use eth_hw_addr_set()" I meant "dev_addr_set()" actually. Thanks > > > > > Signed-off-by: Jakub Kicinski > > --- > > CC: mst@redhat.com > > CC: jasowang@redhat.com > > CC: virtualization@lists.linux-foundation.org > > --- > > drivers/net/virtio_net.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index c501b5974aee..b7f35aff8e82 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -3177,12 +3177,16 @@ static int virtnet_probe(struct virtio_device *vdev) > > dev->max_mtu = MAX_MTU; > > > > /* Configuration may specify what MAC to use. Otherwise random. */ > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) { > > + u8 addr[MAX_ADDR_LEN]; > > + > > virtio_cread_bytes(vdev, > > offsetof(struct virtio_net_config, mac), > > - dev->dev_addr, dev->addr_len); > > - else > > + addr, dev->addr_len); > > + dev_addr_set(dev, addr); > > + } else { > > eth_hw_addr_random(dev); > > + } > > Do we need to change virtnet_set_mac_address() as well? > > Thanks > > > > > /* Set up our device-specific information */ > > vi = netdev_priv(dev); > > -- > > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C5AC433FE for ; Wed, 27 Oct 2021 07:25:16 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C4706109E for ; Wed, 27 Oct 2021 07:25:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C4706109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 08B0380D9E; Wed, 27 Oct 2021 07:25:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uTFrCalMjhxE; Wed, 27 Oct 2021 07:25:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id BB66B80D8C; Wed, 27 Oct 2021 07:25:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8D105C0012; Wed, 27 Oct 2021 07:25:14 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B096AC000E for ; Wed, 27 Oct 2021 07:25:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 99547606D9 for ; Wed, 27 Oct 2021 07:25:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qH6OOOnkGIvJ for ; Wed, 27 Oct 2021 07:25:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0459660676 for ; Wed, 27 Oct 2021 07:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635319510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DbPmqjJWgzA3Y/zZgHiZJYXUBsMyJrhMz63cdq96J9s=; b=imsanZlIUuTx0b31Hdsfo8zscFxaPSw4fFuGPIxb3p88A25DVe6bcYxgVosG8dPN3li/9N mAAfyVNEltsXUw2oJnuIQXv0sAh7/Dy8CSgdzxfBaCIpSuXZsqIIhxk7+a7MHTVbIV+DKg 6hExEqOjS+GFZUjoQhXkfVR49Qt6sco= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-nCkxWB8OMlqZGSw8AeuKoA-1; Wed, 27 Oct 2021 03:25:08 -0400 X-MC-Unique: nCkxWB8OMlqZGSw8AeuKoA-1 Received: by mail-lj1-f200.google.com with SMTP id d24-20020a2eb058000000b00211892e18f2so293500ljl.8 for ; Wed, 27 Oct 2021 00:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DbPmqjJWgzA3Y/zZgHiZJYXUBsMyJrhMz63cdq96J9s=; b=F+XJ03JFRjaZma/VjkkMjYYJ5f6gBdHmSO4nhbXNpz4D3W2s6gcQWDy/XkDTeZJCws FYk3SgbClxA6yxR+AanR43NNVncUbt6tfrpSjqs9EsEdlzMIosQEVIqss5M9o7TJCGat OCDP9m6I1rexPm2krA5l/enJlWbAGQlb09Uupc+yyrBewdlGNWl/lY1ilYgIT5Awuest M77tL+wmAXCT7qltT4Z6rOUaZ836OIzSZCC1yjsrWO/Twoo3hjU1LOF9VhaoK3sV1jFL 4Za5OsrVOLeAqJDU0m1i85ioe9KaSXm/7iZDbCeFpQ6/qzz6njaywsRLB4KT693lmVqh HQOw== X-Gm-Message-State: AOAM5319ZM37Mrg3a/VOKA1eEHi1K/dMKxcvIl5YuomNF5hHhi1tF4/P dOlLIpNM0wca09A3vpmABPWJ9tR4L8KanNJQmUXrzshre9rHohfOq5iAdHBpOCLA0Lu7Wh44pqy jAfI7o+UPomW5+w+GO/2R2M/0MeuCTZNHGUmCrqBMmi7F7zD/TCEjD7F9cw== X-Received: by 2002:a2e:5344:: with SMTP id t4mr31144648ljd.362.1635319506837; Wed, 27 Oct 2021 00:25:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx60K3agBV72twigmEzIG4Fvw5bMCI5GhxSGQ19U5tE6uaE7t6SoxPwUooNXl7eML2YSuLhLTyhqBbs6SAqrUA= X-Received: by 2002:a2e:5344:: with SMTP id t4mr31144627ljd.362.1635319506634; Wed, 27 Oct 2021 00:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20211026175634.3198477-1-kuba@kernel.org> In-Reply-To: From: Jason Wang Date: Wed, 27 Oct 2021 15:24:55 +0800 Message-ID: Subject: Re: [PATCH net-next] net: virtio: use eth_hw_addr_set() To: Jakub Kicinski Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: netdev , virtualization , davem , mst X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Oct 27, 2021 at 10:45 AM Jason Wang wrote: > > On Wed, Oct 27, 2021 at 1:56 AM Jakub Kicinski wrote: > > > > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount > > of VLANs...") introduced a rbtree for faster Ethernet address look > > up. To maintain netdev->dev_addr in this tree we need to make all > > the writes to it go through appropriate helpers. > > I think the title should be "net: virtio: use eth_hw_addr_set()" I meant "dev_addr_set()" actually. Thanks > > > > > Signed-off-by: Jakub Kicinski > > --- > > CC: mst@redhat.com > > CC: jasowang@redhat.com > > CC: virtualization@lists.linux-foundation.org > > --- > > drivers/net/virtio_net.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index c501b5974aee..b7f35aff8e82 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -3177,12 +3177,16 @@ static int virtnet_probe(struct virtio_device *vdev) > > dev->max_mtu = MAX_MTU; > > > > /* Configuration may specify what MAC to use. Otherwise random. */ > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) { > > + u8 addr[MAX_ADDR_LEN]; > > + > > virtio_cread_bytes(vdev, > > offsetof(struct virtio_net_config, mac), > > - dev->dev_addr, dev->addr_len); > > - else > > + addr, dev->addr_len); > > + dev_addr_set(dev, addr); > > + } else { > > eth_hw_addr_random(dev); > > + } > > Do we need to change virtnet_set_mac_address() as well? > > Thanks > > > > > /* Set up our device-specific information */ > > vi = netdev_priv(dev); > > -- > > 2.31.1 > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization