All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Eli Cohen <elic@nvidia.com>, mst <mst@redhat.com>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH linux-next v7 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit
Date: Wed, 27 Oct 2021 14:04:48 +0800	[thread overview]
Message-ID: <CACGkMEvvLADu3jCzBv-+2DuXisD2HC5oXCTY1q22pqpK6PH-dA@mail.gmail.com> (raw)
In-Reply-To: <20211026175519.87795-7-parav@nvidia.com>

On Wed, Oct 27, 2021 at 1:56 AM Parav Pandit <parav@nvidia.com> wrote:
>
> Cited patch in the fixes tag clears the features bit during reset.
> mlx5 vdpa device feature bits are static decided by device capabilities.
> These feature bits (including VIRTIO_NET_F_MAC) are initialized during
> device addition time.
>
> Clearing features bit in reset callback cleared the VIRTIO_NET_F_MAC. Due
> to this, MAC address provided by the device is not honored.
>
> Fix it by not clearing the static feature bits during reset.
>
> Fixes: 0686082dbf7a ("vdpa: Add reset callback in vdpa_config_ops")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Eli Cohen <elic@nvidia.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 6bbdc0ece707..8d1539728a59 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -2194,7 +2194,6 @@ static int mlx5_vdpa_reset(struct vdpa_device *vdev)
>         clear_vqs_ready(ndev);
>         mlx5_vdpa_destroy_mr(&ndev->mvdev);
>         ndev->mvdev.status = 0;
> -       ndev->mvdev.mlx_features = 0;
>         memset(ndev->event_cbs, 0, sizeof(ndev->event_cbs));
>         ndev->mvdev.actual_features = 0;
>         ++mvdev->generation;
> --
> 2.25.4
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2021-10-27  6:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 17:55 [PATCH linux-next v7 0/8] vdpa: enable user to set mac, mtu Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 1/8] vdpa: Introduce and use vdpa device get, set config helpers Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 2/8] vdpa: Introduce query of device config layout Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 3/8] vdpa: Use kernel coding style for structure comments Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 4/8] vdpa: Enable user to set mac and mtu of vdpa device Parav Pandit via Virtualization
2021-10-27  7:40   ` Stefano Garzarella
2021-10-26 17:55 ` [PATCH linux-next v7 5/8] vdpa_sim_net: Enable user to set mac address and mtu Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 6/8] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit Parav Pandit via Virtualization
2021-10-27  6:04   ` Jason Wang [this message]
2021-10-26 17:55 ` [PATCH linux-next v7 7/8] vdpa/mlx5: Support configuration of MAC Parav Pandit via Virtualization
2021-10-26 17:55 ` [PATCH linux-next v7 8/8] vdpa/mlx5: Forward only packets with allowed MAC address Parav Pandit via Virtualization
2021-10-27  6:14   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACGkMEvvLADu3jCzBv-+2DuXisD2HC5oXCTY1q22pqpK6PH-dA@mail.gmail.com \
    --to=jasowang@redhat.com \
    --cc=elic@nvidia.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.