From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B77C433EF for ; Mon, 27 Jun 2022 07:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233105AbiF0Hps (ORCPT ); Mon, 27 Jun 2022 03:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233096AbiF0Hpr (ORCPT ); Mon, 27 Jun 2022 03:45:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 554E460E9 for ; Mon, 27 Jun 2022 00:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656315944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJ8lTv8mNQFqfIpLLTdJ5wTzmtewiqdkMpwZ7L0k0po=; b=CvbzazEhsnrxYlxxmqXKq/wjdpjt4q5JJ31r+UR+Ij8/avZTeFuFOdeNX48Nv4Xn6IDWrN SHSE1HW0dgpkA9BVDWgLHCxZZiPe367TXVSyHAPXs3mJlc8BtGzamdkLRoZe9vtIsSaiaa L3yhwunItgVpG8j5fcrHpaCNKGtcnFw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-73-OKkpq-4rNP2PFdGlgU2Ang-1; Mon, 27 Jun 2022 03:45:42 -0400 X-MC-Unique: OKkpq-4rNP2PFdGlgU2Ang-1 Received: by mail-lf1-f69.google.com with SMTP id y8-20020ac24208000000b0047f9fc8f632so4331153lfh.11 for ; Mon, 27 Jun 2022 00:45:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DJ8lTv8mNQFqfIpLLTdJ5wTzmtewiqdkMpwZ7L0k0po=; b=2Dufbhcqgy7ZROe8FW2C5/5IyvJYFlVFdKqNfW9dLtqT3ukPJb27VbuM7VYUmbNmI9 gTbbXCvstDTQwlQUFlBdvgwSCl/hbWV85W7urBNGrcIgcYAi43Tdf5746M/EonWEZolF oRzoS9k8OsIsmgPRXOOCkaksiFBDvdONumD9LJtLJwru0hm4qVaagRwR38F3XuDdh8zb EZ/h/f3t+Yt1VsS+eTne0GKQuFHQr02e2TOujNjM78xaL8D6UVZkhXYcwdRD/7NFGhh2 ezD3yeMZq0MaPR3+nqUGCV3W9hFlR/QRL9CZajEz3eIbq7flTQuOgGUHn560a8gJcLoR m6Zg== X-Gm-Message-State: AJIora8tO9ghuXiMMgCd/XqDSj5RUviM9vG8ws9C55/lS3cw0Gc1PXHO a3nRbY9vHVIZH3mE9LPCGg7mjK3TdNB8N1dwp1jHajEXMYYtN8toCydlCOohs/kZjKkEdqcnK4t eSQEIfkG6cER/AnToftjXUUWy/wRs5ARsn8vXHtvTyTofEQ== X-Received: by 2002:a2e:aaa5:0:b0:25b:ae57:4ad7 with SMTP id bj37-20020a2eaaa5000000b0025bae574ad7mr6113601ljb.323.1656315941393; Mon, 27 Jun 2022 00:45:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vViYYUTuYJvHrB7a6J1t+RbESIVnJ/fW5l8pDtbVNhAjJvWLMAazge0YptM+fayabkTwGDETijvn1jNEjsB7g= X-Received: by 2002:a2e:aaa5:0:b0:25b:ae57:4ad7 with SMTP id bj37-20020a2eaaa5000000b0025bae574ad7mr6113578ljb.323.1656315941180; Mon, 27 Jun 2022 00:45:41 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> <20220627023841-mutt-send-email-mst@kernel.org> In-Reply-To: <20220627023841-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 15:45:30 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data To: "Michael S. Tsirkin" Cc: Xuan Zhuo , virtualization , Richard Weinberger , Anton Ivanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm , "open list:XDP (eXpress Data Path)" , kangjie.xu@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Jun 27, 2022 at 2:39 PM Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2022 at 10:30:42AM +0800, Jason Wang wrote: > > On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > > > > > What exactly is meant by not breaking uABI? > > > Users are supposed to be prepared for struct size to change ... no? > > > > Not sure, any doc for this? > > > > Thanks > > > Well we have this: > > The drivers SHOULD only map part of configuration structure > large enough for device operation. The drivers MUST handle > an unexpectedly large \field{length}, but MAY check that \field{length} > is large enough for device operation. Yes, but that's the device/driver interface. What's done here is the userspace/kernel. Userspace may break if it uses e.g sizeof(struct virtio_pci_common_cfg)? Thanks > > > > > > > > > > > > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > > > this patch first. > > > > > > > > Signed-off-by: Xuan Zhuo > > > > Acked-by: Jason Wang > > > > --- > > > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > > > --- a/include/uapi/linux/virtio_pci.h > > > > +++ b/include/uapi/linux/virtio_pci.h > > > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > > > __le32 queue_used_hi; /* read-write */ > > > > }; > > > > > > > > +struct virtio_pci_common_cfg_notify { > > > > + struct virtio_pci_common_cfg cfg; > > > > + > > > > + __le16 queue_notify_data; /* read-write */ > > > > + __le16 padding; > > > > +}; > > > > + > > > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > > > struct virtio_pci_cfg_cap { > > > > struct virtio_pci_cap cap; > > > > -- > > > > 2.31.0 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE91DC433EF for ; Mon, 27 Jun 2022 07:45:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 62F0582D14; Mon, 27 Jun 2022 07:45:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 62F0582D14 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CvbzazEh X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GT4j8jg67lBA; Mon, 27 Jun 2022 07:45:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id CDEDD82D12; Mon, 27 Jun 2022 07:45:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CDEDD82D12 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A6986C0032; Mon, 27 Jun 2022 07:45:48 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5919C002D for ; Mon, 27 Jun 2022 07:45:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B20226104C for ; Mon, 27 Jun 2022 07:45:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B20226104C Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CvbzazEh X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fKj0xjmW1FOC for ; Mon, 27 Jun 2022 07:45:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org ABD9F60D4C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id ABD9F60D4C for ; Mon, 27 Jun 2022 07:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656315944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJ8lTv8mNQFqfIpLLTdJ5wTzmtewiqdkMpwZ7L0k0po=; b=CvbzazEhsnrxYlxxmqXKq/wjdpjt4q5JJ31r+UR+Ij8/avZTeFuFOdeNX48Nv4Xn6IDWrN SHSE1HW0dgpkA9BVDWgLHCxZZiPe367TXVSyHAPXs3mJlc8BtGzamdkLRoZe9vtIsSaiaa L3yhwunItgVpG8j5fcrHpaCNKGtcnFw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-w-tTwB-gM7mdRy94rXGnfQ-1; Mon, 27 Jun 2022 03:45:42 -0400 X-MC-Unique: w-tTwB-gM7mdRy94rXGnfQ-1 Received: by mail-lf1-f71.google.com with SMTP id e10-20020a19674a000000b0047f8d95f43cso4342379lfj.0 for ; Mon, 27 Jun 2022 00:45:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DJ8lTv8mNQFqfIpLLTdJ5wTzmtewiqdkMpwZ7L0k0po=; b=j4KroxvX1tT8NkZVKdSyQMawDSzby/8dEhesZxBPKNmDqg22e+hIF+Hzt2jT+bBuD9 RxxhH3jsVTr8LiG88UxwtfBl4a2YuBBlVBjpa0K5GPWgD+QR/+OHxKKdBpEG9esabp5j yHFbUmsQmpbdwTNHT5H3/hD85nlroxOhagecvT90K3Uin63MK0wDNeAapcx7oY09RvzR mcTGF0/BE6zKu/k+PuC9dtpUZz1XXoqN0PFGisw8wT1XCyDYiz1CLdXYh1A9D6HyRV21 YmOtX0Fr9NdUD17+Ir/+7Y6Ux9IwpQBr9yT2m4zna1KAvMytNXJmKhDRO/+ciEj2W1Ky 9D1Q== X-Gm-Message-State: AJIora/xcgb+ZZPZ8aIZlqiCI3zcJLmNfu6AID5BFFrjLgPe41AVG2XZ 2d7p1FFPdsVRnD4W61xb0SVfkzEm/7QfEByylOf6lL+b5vSnCVvO5QX5VuI0AMTTfM8VpFFhYiF RjgeZBDyjPLEf0tr3g3oBFz903v+6q6NsuMCTgeh4xOjI0+lBJbktlU21aQ== X-Received: by 2002:a2e:aaa5:0:b0:25b:ae57:4ad7 with SMTP id bj37-20020a2eaaa5000000b0025bae574ad7mr6113588ljb.323.1656315941392; Mon, 27 Jun 2022 00:45:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vViYYUTuYJvHrB7a6J1t+RbESIVnJ/fW5l8pDtbVNhAjJvWLMAazge0YptM+fayabkTwGDETijvn1jNEjsB7g= X-Received: by 2002:a2e:aaa5:0:b0:25b:ae57:4ad7 with SMTP id bj37-20020a2eaaa5000000b0025bae574ad7mr6113578ljb.323.1656315941180; Mon, 27 Jun 2022 00:45:41 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> <20220627023841-mutt-send-email-mst@kernel.org> In-Reply-To: <20220627023841-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 15:45:30 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Vadim Pasternak , linux-remoteproc@vger.kernel.org, Alexei Starovoitov , virtualization , Eric Dumazet , Alexander Gordeev , kangjie.xu@linux.alibaba.com, Anton Ivanov , kvm , Daniel Borkmann , Richard Weinberger , Vincent Whitchurch , John Fastabend , Halil Pasic , Jakub Kicinski , platform-driver-x86@vger.kernel.org, Eric Farman , Jesper Dangaard Brouer , Vasily Gorbik , linux-s390@vger.kernel.org, Heiko Carstens , linux-um@lists.infradead.org, Mark Gross , Hans de Goede , Bjorn Andersson , "open list:XDP \(eXpress Data Path\)" , Paolo Abeni , Mathieu Poirier , netdev , Cornelia Huck , Sven Schnelle , Johannes Berg , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Jun 27, 2022 at 2:39 PM Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2022 at 10:30:42AM +0800, Jason Wang wrote: > > On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > > > > > What exactly is meant by not breaking uABI? > > > Users are supposed to be prepared for struct size to change ... no? > > > > Not sure, any doc for this? > > > > Thanks > > > Well we have this: > > The drivers SHOULD only map part of configuration structure > large enough for device operation. The drivers MUST handle > an unexpectedly large \field{length}, but MAY check that \field{length} > is large enough for device operation. Yes, but that's the device/driver interface. What's done here is the userspace/kernel. Userspace may break if it uses e.g sizeof(struct virtio_pci_common_cfg)? Thanks > > > > > > > > > > > > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > > > this patch first. > > > > > > > > Signed-off-by: Xuan Zhuo > > > > Acked-by: Jason Wang > > > > --- > > > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > > > --- a/include/uapi/linux/virtio_pci.h > > > > +++ b/include/uapi/linux/virtio_pci.h > > > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > > > __le32 queue_used_hi; /* read-write */ > > > > }; > > > > > > > > +struct virtio_pci_common_cfg_notify { > > > > + struct virtio_pci_common_cfg cfg; > > > > + > > > > + __le16 queue_notify_data; /* read-write */ > > > > + __le16 padding; > > > > +}; > > > > + > > > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > > > struct virtio_pci_cfg_cap { > > > > struct virtio_pci_cap cap; > > > > -- > > > > 2.31.0 > > > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5jRK-00GUj1-AG for linux-um@lists.infradead.org; Mon, 27 Jun 2022 07:45:50 +0000 Received: by mail-lf1-f70.google.com with SMTP id f29-20020a19dc5d000000b004811c8d1918so682945lfj.2 for ; Mon, 27 Jun 2022 00:45:42 -0700 (PDT) MIME-Version: 1.0 References: <20220624025621.128843-1-xuanzhuo@linux.alibaba.com> <20220624025621.128843-26-xuanzhuo@linux.alibaba.com> <20220624025817-mutt-send-email-mst@kernel.org> <20220627023841-mutt-send-email-mst@kernel.org> In-Reply-To: <20220627023841-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 27 Jun 2022 15:45:30 +0800 Message-ID: Subject: Re: [PATCH v10 25/41] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Michael S. Tsirkin" Cc: Xuan Zhuo , virtualization , Richard Weinberger , Anton Ivanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev , platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm , "open list:XDP (eXpress Data Path)" , kangjie.xu@linux.alibaba.com On Mon, Jun 27, 2022 at 2:39 PM Michael S. Tsirkin wrote: > > On Mon, Jun 27, 2022 at 10:30:42AM +0800, Jason Wang wrote: > > On Fri, Jun 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jun 24, 2022 at 10:56:05AM +0800, Xuan Zhuo wrote: > > > > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > > > > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > > > > > > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > > > > > What exactly is meant by not breaking uABI? > > > Users are supposed to be prepared for struct size to change ... no? > > > > Not sure, any doc for this? > > > > Thanks > > > Well we have this: > > The drivers SHOULD only map part of configuration structure > large enough for device operation. The drivers MUST handle > an unexpectedly large \field{length}, but MAY check that \field{length} > is large enough for device operation. Yes, but that's the device/driver interface. What's done here is the userspace/kernel. Userspace may break if it uses e.g sizeof(struct virtio_pci_common_cfg)? Thanks > > > > > > > > > > > > > > > Since I want to add queue_reset after queue_notify_data, I submitted > > > > this patch first. > > > > > > > > Signed-off-by: Xuan Zhuo > > > > Acked-by: Jason Wang > > > > --- > > > > include/uapi/linux/virtio_pci.h | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > > > > index 3a86f36d7e3d..22bec9bd0dfc 100644 > > > > --- a/include/uapi/linux/virtio_pci.h > > > > +++ b/include/uapi/linux/virtio_pci.h > > > > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > > > > __le32 queue_used_hi; /* read-write */ > > > > }; > > > > > > > > +struct virtio_pci_common_cfg_notify { > > > > + struct virtio_pci_common_cfg cfg; > > > > + > > > > + __le16 queue_notify_data; /* read-write */ > > > > + __le16 padding; > > > > +}; > > > > + > > > > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > > > > struct virtio_pci_cfg_cap { > > > > struct virtio_pci_cap cap; > > > > -- > > > > 2.31.0 > > > > _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um