Hi Denis,

I'm sorry, I really messed up with my last mails with the header and
description of the commits.

I tryed your change, and indeed it seems to work properly now, so I think
you can apply it.

Thank you !

Florent

2018-05-23 16:44 GMT+02:00 Denis Kenzior <denkenz@gmail.com>:

> Hi Florent,
>
> On 05/22/2018 08:08 AM, Florent Beillonnet wrote:
>
>> ---
>>   plugins/gemalto.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>
> You really shouldn't need to do this given that you have a URC inside
> gemalto_ciev_notify() that does exactly this already.
>
> No, I think there's a tiny bug in the core introduced by the commit you
> reference above.  Try this change?
>
> @@ -847,7 +847,7 @@ static void sim_enter_pin_cb(const struct ofono_error
> *error, void *data)
>
>         __ofono_dbus_pending_reply(&sim->pending, reply);
>
> -       if (sim->initialized)
> +       if (sim->initialized || error->type != OFONO_ERROR_TYPE_NO_ERROR)
>                 goto recheck;
>
>         if (sim->pin_type == OFONO_SIM_PASSWORD_SIM_PIN ||
>
> Regards,
> -Denis
>