From: Haomai Wang <haomai@xsky.com>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: About thread_local and TmapMigratePP.DataScan case
Date: Thu, 30 Jun 2016 10:16:36 +0800 [thread overview]
Message-ID: <CACJqLyZ64uMF=JrXOyUQQa_YOz+PB=ybKwHLd4sgOy7z=p7E7g@mail.gmail.com> (raw)
In-Reply-To: <CAAM7YAm6uPjm_aY0Upw7qjCc0b4PRQZisu-K73ZQEu7TCKUodQ@mail.gmail.com>
On Thu, Jun 30, 2016 at 10:13 AM, Yan, Zheng <ukernel@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 2:04 AM, Haomai Wang <haomai@xsky.com> wrote:
>> Hi all,
>>
>> anyone who knows what's the special thing with TmapMigratePP.DataScan
>> case. When I introduce thread_local variable in
>> PR(https://github.com/ceph/ceph/pull/9783/files#diff-254a8401d238ec25c714a5596f85b5ebL64),
>> it always failed because the thread local variable is assigned to zero
>> when execute this test!
>>
>
> thread_local is not portable. In your case, using thread_local
> variable is not necessary, you can use pthread_self() directly.
>
> As I know pthread_self() return 0 if the program isn't linked to libpthread.so
>
yes, I have changed to pthread_self
>
>> For example, when tid == 512596224 local_center should be 5fed4e48,
>> but after begin this test case, this thread_local variable is assigned
>> to zero!:
>> tid=-512596224 local_center=5fed4e48 this=5fed4e48
>> [New Thread 0x7fffdef21700 (LWP 11835)]
>> tid=-512596224 local_center=5fed4e48 this=5fed4e48
>> [New Thread 0x7fffde720700 (LWP 11836)]
>> [New Thread 0x7fffddf1f700 (LWP 11837)]
>> [New Thread 0x7fffdd71e700 (LWP 11838)]
>> [New Thread 0x7fffdcf1d700 (LWP 11839)]
>> [New Thread 0x7fffdc71c700 (LWP 11840)]
>> [New Thread 0x7fffdbf1b700 (LWP 11841)]
>> tid=-134366272 local_center=0 this=5fed4e48
>> tid=-134366272 local_center=0 this=5fed4e48
>> tid=-134366272 local_center=0 this=5fed4e48
>> tid=-512596224 local_center=0 this=5fed4e48
>>
>>
>> QA job:http://qa-proxy.ceph.com/teuthology/haomai-2016-06-27_03:55:04-rados-wip-haomai-testing---basic-smithi/279412/teuthology.log
>>
>> This can be repeated locally and I want to know what's the difference
>> this case introduced
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-06-30 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 18:04 About thread_local and TmapMigratePP.DataScan case Haomai Wang
2016-06-28 9:45 ` John Spray
2016-06-30 2:13 ` Yan, Zheng
2016-06-30 2:16 ` Haomai Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACJqLyZ64uMF=JrXOyUQQa_YOz+PB=ybKwHLd4sgOy7z=p7E7g@mail.gmail.com' \
--to=haomai@xsky.com \
--cc=ceph-devel@vger.kernel.org \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.