From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35DAC433E0 for ; Mon, 6 Jul 2020 22:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9837720723 for ; Mon, 6 Jul 2020 22:17:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vNzVRDUl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727008AbgGFWRV (ORCPT ); Mon, 6 Jul 2020 18:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbgGFWRV (ORCPT ); Mon, 6 Jul 2020 18:17:21 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29529C061794 for ; Mon, 6 Jul 2020 15:17:21 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id g2so23603502lfb.0 for ; Mon, 06 Jul 2020 15:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VcTg7znjs5NM9gvezTd2PmxFMdpOTVCMT/3yPB+Qgb4=; b=vNzVRDUl4U537XT+jFySQw2TYQYIYbNVvMi2vI75OS8G/oHkzYqETbWDdsyWrqnJvB ZDagRVkHhKD8zrtLYJJ8qIXo0AuuWaJckY5WFye6ln6rpJlD+AplVS4Ho5fxKhazVYd+ WwNgl/fOyzqH2mIWWEgJom7RS2Ys5J/RcL078JbEZFoB+AoMeXlDAL/+dvD25aT6hP7g cRY8zFElRYhBxqOzi9A+D7S29ctaddBPIC5OT/Ic4cekOp6Ldlh3Lmc0aMJePc/BbAgT 305sc89OsH87ksxbW1okc8uaJtthTw6avN9JtPmDdA9CbRbhBy4vF/SiokD2ssfDaKPU KjfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VcTg7znjs5NM9gvezTd2PmxFMdpOTVCMT/3yPB+Qgb4=; b=acWrMbz3v+6697GYQv5FWn+ZuFAkaJcVihkRdP/JgrjTefsFAakL0V1MNN/ppoedNO 81u7pGYH90BOhpWDU/Y7ZDj5nDjhjcuPyWlhvDA3oPU5EKFTQLWkjAyeIXoMYAt8wlEq 5821xn/auC8FvTJSq64gkLmoumOGenh7ef0bSWSzYvQegbJ7MvqTSoDf2PD8CBE+UdN2 vZdwCQlEeA2EHvLIobP2jNVLUeN+JIhJEk8TfI7xp7GEsVRlCKLoxOgRbwqMdB3ZjiS5 aZPFwnKqVfn0FEwBUw+ZkHofThH7otK8hhbvkpeuLGskbJ8lNHVU6IMroO2QZbsNQe51 98uw== X-Gm-Message-State: AOAM530G/uoSa78JCXIa2aGDVOtXEiEUutwPQKDOTqxDbRJ58DZY2xRL vwOIT6F1EXriCiy9USxxYb3EiFxoSiKwVViC6Cd+NQ== X-Google-Smtp-Source: ABdhPJwe3ex8kcVRA0T8G22gfsoP7JF+/rquu8J+b6ju8abD2HlCAo8f1V+eED2pMxSAfWVXjFqnh6BvhytT/R+z9+8= X-Received: by 2002:a19:435b:: with SMTP id m27mr31417703lfj.40.1594073839263; Mon, 06 Jul 2020 15:17:19 -0700 (PDT) MIME-Version: 1.0 References: <20200630044943.3425049-2-rajatja@google.com> <20200706155815.GA119406@bjorn-Precision-5520> In-Reply-To: <20200706155815.GA119406@bjorn-Precision-5520> From: Rajat Jain Date: Mon, 6 Jul 2020 15:16:42 -0700 Message-ID: Subject: Re: [PATCH v2 1/7] PCI: Keep the ACS capability offset in device To: Bjorn Helgaas Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , "open list:AMD IOMMU (AMD-VI)" , Linux Kernel Mailing List , linux-pci , ACPI Devel Maling List , Raj Ashok , "Krishnakumar, Lalithambika" , Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , Greg Kroah-Hartman , "Oliver O'Halloran" , Saravana Kannan , Suzuki K Poulose , Arnd Bergmann , Heikki Krogerus Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Bjorn, Thanks for taking a look. On Mon, Jul 6, 2020 at 8:58 AM Bjorn Helgaas wrote: > > On Mon, Jun 29, 2020 at 09:49:37PM -0700, Rajat Jain wrote: > > Currently this is being looked up at a number of places. Read and store= it > > once at bootup so that it can be used by all later. > > Write the commit log so it is complete even without the subject. > Right now, you have to read the subject to know what "this" refers to. > > The subject is like the title; the log is like the body of an article. > The title isn't *part* of the article, so the article has to make > sense all by itself. Fixed. > > > +static void pci_enable_acs(struct pci_dev *dev); > > I don't think we need this forward declaration, do we? We need it unless we move its definition further up in the file: drivers/pci/pci.c: In function =E2=80=98pci_restore_state=E2=80=99: drivers/pci/pci.c:1551:2: error: implicit declaration of function =E2=80=98pci_enable_acs=E2=80=99; did you mean =E2=80=98pci_enable_ats=E2= =80=99? [-Werror=3Dimplicit-function-declaration] 1551 | pci_enable_acs(dev); Do you want me to move it up in the file so that we do not need the forward declaration? > > > @@ -4653,7 +4653,7 @@ static int pci_quirk_intel_spt_pch_acs(struct pci= _dev *dev, u16 acs_flags) > > if (!pci_quirk_intel_spt_pch_acs_match(dev)) > > return -ENOTTY; > > > > - pos =3D pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS); > > + pos =3D dev->acs_cap; > > I assume you verified that all these quirks are FINAL quirks, since > pci_init_capabilities() is called after HEADER quirks. I'll > double-check before applying this. None of these quirks are applied via DECLARE_PCI_FIXUP_*(). All these quirks are called (directly or indirectly) from either pci_enable_acs() or pci_acs_enabled(), EXCEPT pci_idt_bus_quirk(). That one is called from pci_bus_read_dev_vendor_id() which should be called only after the parent bridge has been added and setup correctly. So it looks all good to me. Thanks, Rajat > > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F7EBC433E1 for ; Mon, 6 Jul 2020 22:17:25 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0381E20720 for ; Mon, 6 Jul 2020 22:17:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="vNzVRDUl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0381E20720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lists.linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D13E786C8C; Mon, 6 Jul 2020 22:17:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xMsV3eL96EuE; Mon, 6 Jul 2020 22:17:23 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id B807486B9E; Mon, 6 Jul 2020 22:17:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A9237C0891; Mon, 6 Jul 2020 22:17:23 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A7019C016F for ; Mon, 6 Jul 2020 22:17:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 932C486C15 for ; Mon, 6 Jul 2020 22:17:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LQyAOPW04r-f for ; Mon, 6 Jul 2020 22:17:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by fraxinus.osuosl.org (Postfix) with ESMTPS id BA59186B9E for ; Mon, 6 Jul 2020 22:17:21 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id s16so18119013lfp.12 for ; Mon, 06 Jul 2020 15:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VcTg7znjs5NM9gvezTd2PmxFMdpOTVCMT/3yPB+Qgb4=; b=vNzVRDUl4U537XT+jFySQw2TYQYIYbNVvMi2vI75OS8G/oHkzYqETbWDdsyWrqnJvB ZDagRVkHhKD8zrtLYJJ8qIXo0AuuWaJckY5WFye6ln6rpJlD+AplVS4Ho5fxKhazVYd+ WwNgl/fOyzqH2mIWWEgJom7RS2Ys5J/RcL078JbEZFoB+AoMeXlDAL/+dvD25aT6hP7g cRY8zFElRYhBxqOzi9A+D7S29ctaddBPIC5OT/Ic4cekOp6Ldlh3Lmc0aMJePc/BbAgT 305sc89OsH87ksxbW1okc8uaJtthTw6avN9JtPmDdA9CbRbhBy4vF/SiokD2ssfDaKPU KjfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VcTg7znjs5NM9gvezTd2PmxFMdpOTVCMT/3yPB+Qgb4=; b=cUbxeStXas4cxeZVdiNUj7FLsmjcZoSI6eUz8T0wmogTOeEWSyxSa/nJRdLsbVQaEL 3i/VLb1cWbusCJFFdccZ3f/H48N2eDPkcnB0uW3tQEZshZA8SmSxxqOzt4OI2JogBGJA 9oUdvB/LjyseLjKgfgG7i0q0pTDMVeSPL1WOW4e0YIlgJyyZAS1qnELP2EdJlK1Y/X4w nMV30o2hnfaWKMpwyT6tJrJVDBjnQ6CjjnsQEI1FLh8cUZcWa+Mzkc2faxXSSlihZTIz R/uAen1ZioFCK2LyruF2ML0heZMCf1WaYPW1g8ga9A8rAclrbES/JGX2mYzU3VVBwz0H TV0A== X-Gm-Message-State: AOAM530Xk0R//D1w7WmT8MZ8k/rzw4K2CSuxmXdBZi5ADX5av+3sxj5t PYlK2hjpFAV+6IvllPcmu0tbK6jv4AJ9G+ttQUrFXQ== X-Google-Smtp-Source: ABdhPJwe3ex8kcVRA0T8G22gfsoP7JF+/rquu8J+b6ju8abD2HlCAo8f1V+eED2pMxSAfWVXjFqnh6BvhytT/R+z9+8= X-Received: by 2002:a19:435b:: with SMTP id m27mr31417703lfj.40.1594073839263; Mon, 06 Jul 2020 15:17:19 -0700 (PDT) MIME-Version: 1.0 References: <20200630044943.3425049-2-rajatja@google.com> <20200706155815.GA119406@bjorn-Precision-5520> In-Reply-To: <20200706155815.GA119406@bjorn-Precision-5520> Date: Mon, 6 Jul 2020 15:16:42 -0700 Message-ID: Subject: Re: [PATCH v2 1/7] PCI: Keep the ACS capability offset in device To: Bjorn Helgaas Cc: Todd Broch , linux-pci , "Krishnakumar, Lalithambika" , Heikki Krogerus , Diego Rivas , Jean-Philippe Brucker , Furquan Shaikh , Raj Ashok , Saravana Kannan , ACPI Devel Maling List , Christian Kellner , Mattias Nissler , Jesse Barnes , Len Brown , Rajat Jain , Prashant Malani , Suzuki K Poulose , Aaron Durbin , Alex Williamson , Bjorn Helgaas , Mika Westerberg , Bernie Keany , Duncan Laurie , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , "open list:AMD IOMMU \(AMD-VI\)" , Arnd Bergmann , Oliver O'Halloran , Benson Leung , David Woodhouse , Alex Levin X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Rajat Jain via iommu Reply-To: Rajat Jain Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgQmpvcm4sCgpUaGFua3MgZm9yIHRha2luZyBhIGxvb2suCgpPbiBNb24sIEp1bCA2LCAyMDIw IGF0IDg6NTggQU0gQmpvcm4gSGVsZ2FhcyA8aGVsZ2Fhc0BrZXJuZWwub3JnPiB3cm90ZToKPgo+ IE9uIE1vbiwgSnVuIDI5LCAyMDIwIGF0IDA5OjQ5OjM3UE0gLTA3MDAsIFJhamF0IEphaW4gd3Jv dGU6Cj4gPiBDdXJyZW50bHkgdGhpcyBpcyBiZWluZyBsb29rZWQgdXAgYXQgYSBudW1iZXIgb2Yg cGxhY2VzLiBSZWFkIGFuZCBzdG9yZSBpdAo+ID4gb25jZSBhdCBib290dXAgc28gdGhhdCBpdCBj YW4gYmUgdXNlZCBieSBhbGwgbGF0ZXIuCj4KPiBXcml0ZSB0aGUgY29tbWl0IGxvZyBzbyBpdCBp cyBjb21wbGV0ZSBldmVuIHdpdGhvdXQgdGhlIHN1YmplY3QuCj4gUmlnaHQgbm93LCB5b3UgaGF2 ZSB0byByZWFkIHRoZSBzdWJqZWN0IHRvIGtub3cgd2hhdCAidGhpcyIgcmVmZXJzIHRvLgo+Cj4g VGhlIHN1YmplY3QgaXMgbGlrZSB0aGUgdGl0bGU7IHRoZSBsb2cgaXMgbGlrZSB0aGUgYm9keSBv ZiBhbiBhcnRpY2xlLgo+IFRoZSB0aXRsZSBpc24ndCAqcGFydCogb2YgdGhlIGFydGljbGUsIHNv IHRoZSBhcnRpY2xlIGhhcyB0byBtYWtlCj4gc2Vuc2UgYWxsIGJ5IGl0c2VsZi4KCkZpeGVkLgoK Pgo+ID4gK3N0YXRpYyB2b2lkIHBjaV9lbmFibGVfYWNzKHN0cnVjdCBwY2lfZGV2ICpkZXYpOwo+ Cj4gSSBkb24ndCB0aGluayB3ZSBuZWVkIHRoaXMgZm9yd2FyZCBkZWNsYXJhdGlvbiwgZG8gd2U/ CgpXZSBuZWVkIGl0IHVubGVzcyB3ZSBtb3ZlIGl0cyBkZWZpbml0aW9uIGZ1cnRoZXIgdXAgaW4g dGhlIGZpbGU6Cgpkcml2ZXJzL3BjaS9wY2kuYzogSW4gZnVuY3Rpb24g4oCYcGNpX3Jlc3RvcmVf c3RhdGXigJk6CmRyaXZlcnMvcGNpL3BjaS5jOjE1NTE6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xh cmF0aW9uIG9mIGZ1bmN0aW9uCuKAmHBjaV9lbmFibGVfYWNz4oCZOyBkaWQgeW91IG1lYW4g4oCY cGNpX2VuYWJsZV9hdHPigJk/ClstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9u XQogMTU1MSB8ICBwY2lfZW5hYmxlX2FjcyhkZXYpOwoKRG8geW91IHdhbnQgbWUgdG8gbW92ZSBp dCB1cCBpbiB0aGUgZmlsZSBzbyB0aGF0IHdlIGRvIG5vdCBuZWVkIHRoZQpmb3J3YXJkIGRlY2xh cmF0aW9uPwoKPgo+ID4gQEAgLTQ2NTMsNyArNDY1Myw3IEBAIHN0YXRpYyBpbnQgcGNpX3F1aXJr X2ludGVsX3NwdF9wY2hfYWNzKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHUxNiBhY3NfZmxhZ3MpCj4g PiAgICAgICBpZiAoIXBjaV9xdWlya19pbnRlbF9zcHRfcGNoX2Fjc19tYXRjaChkZXYpKQo+ID4g ICAgICAgICAgICAgICByZXR1cm4gLUVOT1RUWTsKPiA+Cj4gPiAtICAgICBwb3MgPSBwY2lfZmlu ZF9leHRfY2FwYWJpbGl0eShkZXYsIFBDSV9FWFRfQ0FQX0lEX0FDUyk7Cj4gPiArICAgICBwb3Mg PSBkZXYtPmFjc19jYXA7Cj4KPiBJIGFzc3VtZSB5b3UgdmVyaWZpZWQgdGhhdCBhbGwgdGhlc2Ug cXVpcmtzIGFyZSBGSU5BTCBxdWlya3MsIHNpbmNlCj4gcGNpX2luaXRfY2FwYWJpbGl0aWVzKCkg aXMgY2FsbGVkIGFmdGVyIEhFQURFUiBxdWlya3MuICBJJ2xsCj4gZG91YmxlLWNoZWNrIGJlZm9y ZSBhcHBseWluZyB0aGlzLgoKTm9uZSBvZiB0aGVzZSBxdWlya3MgYXJlIGFwcGxpZWQgdmlhIERF Q0xBUkVfUENJX0ZJWFVQXyooKS4gQWxsIHRoZXNlCnF1aXJrcyBhcmUgY2FsbGVkIChkaXJlY3Rs eSBvciBpbmRpcmVjdGx5KSBmcm9tIGVpdGhlcgpwY2lfZW5hYmxlX2FjcygpIG9yIHBjaV9hY3Nf ZW5hYmxlZCgpLAoKRVhDRVBUCgpwY2lfaWR0X2J1c19xdWlyaygpLiBUaGF0IG9uZSBpcyBjYWxs ZWQgZnJvbQpwY2lfYnVzX3JlYWRfZGV2X3ZlbmRvcl9pZCgpIHdoaWNoIHNob3VsZCBiZSBjYWxs ZWQgb25seSBhZnRlciB0aGUKcGFyZW50IGJyaWRnZSBoYXMgYmVlbiBhZGRlZCBhbmQgc2V0dXAg Y29ycmVjdGx5LgoKU28gaXQgbG9va3MgYWxsIGdvb2QgdG8gbWUuCgpUaGFua3MsCgpSYWphdAoK Cgo+Cj4gQmpvcm4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11