From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5412DC433EF for ; Fri, 7 Jan 2022 19:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232416AbiAGTF0 (ORCPT ); Fri, 7 Jan 2022 14:05:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232026AbiAGTFX (ORCPT ); Fri, 7 Jan 2022 14:05:23 -0500 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8792C061574 for ; Fri, 7 Jan 2022 11:05:22 -0800 (PST) Received: by mail-pf1-x431.google.com with SMTP id 196so5878449pfw.10 for ; Fri, 07 Jan 2022 11:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+S72sOYOwXg9RPix1lZvjtLtkj3XFLsZ4gEDpSvt8vs=; b=UNlRvA2ZuRZGr24qbY8d8HRyinc6EpOYSKt7DfYa7U+pylhqD10egaBHZVcWbFvg+d HZZoCKimfsUYVZ6hLdx9fE8635nsrgDrj+L00L/QA/Cjac6/OItLx2Gm1LMQY7kdBjlm gUl11sQ+hRSXhsijE3Lz0JsafCc/WMzMcjN+p2ZjS7WJkqTYR8lO8OzMXzBLllf3FZN8 6SuFHJFHb0+VTxIFi9KbZl/oUBDvS7ua7q/kqOUOmGT9RC+dhhVS1J2U1EpVpDJqJhew Efg7LRldeNgMVDWyPjGhSj7BNZ5UuIesQ0y/zYKcFCgYdMO4ccJ3NrTfKraxrHj6N1TQ QivQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+S72sOYOwXg9RPix1lZvjtLtkj3XFLsZ4gEDpSvt8vs=; b=WxNsCOmSHemOFdN2BS4LpjP0wvNrkWDQm4XO7+rRC5req7pH8T2UF5sGWl0KP7mzNs Q0TklaVmez354TZ8q4wP1oJEc0UEQN5DSxSo6ptLvyaeM4lRhcXYTr9JgwGJViL5wzad qXDB6bqn+HyK02jC+zMWe/c6+cBOTRJc59cTarUCGn5Hrw0ojXUFWT81vzm7biSonqCL bxplVt2g/Utxl4gBVS+FAwyj7PEeFFQ1zLglzhVbpeT0zwsHzFk9OikAHnlXf9+ehXh7 +Qey3wyJKY6oJY1mhcDGGd4dc2FUHhqRw9QBmRbaa0dv66gAxfeeJ83hp5u4wXP2WpgO CJUA== X-Gm-Message-State: AOAM5334zJRY7UmIzzWUuDw6V175TFktjESWXwQd7rTjEJzl8CTcgUxs bfQ3Icj4DT4vLAX/c4ihxIMN+a7TRhD0UUOkxsNCdA== X-Google-Smtp-Source: ABdhPJybEblBw8MdINxXy3+9JK7qlDbdUwo1shN48fzEsrE5iAHxprn/bdZ6bdR1DoPb8Rx12GSfNjxZRna6xpg2RNM= X-Received: by 2002:a05:6a00:1249:b0:4bb:4a31:1e0a with SMTP id u9-20020a056a00124900b004bb4a311e0amr65535466pfi.81.1641582321973; Fri, 07 Jan 2022 11:05:21 -0800 (PST) MIME-Version: 1.0 References: <20211222001127.3337471-1-rajatja@google.com> <20211222001127.3337471-2-rajatja@google.com> In-Reply-To: From: Rajat Jain Date: Fri, 7 Jan 2022 11:04:46 -0800 Message-ID: Subject: Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen To: Dmitry Torokhov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Hans de Goede , David Airlie , Daniel Vetter , Benson Leung , Henrique de Moraes Holschuh , Mark Gross , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, gwendal@google.com, seanpaul@google.com, marcheu@google.com, rajatxjain@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Benson, On Fri, Jan 7, 2022 at 9:43 AM Dmitry Torokhov wrote: > > Hi Rajat, > > On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote: > > +static int chromeos_privacy_screen_remove(struct acpi_device *adev) > > +{ > > + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); > > Please add an empty line here: > > WARNING: Missing a blank line after declarations > #292: FILE: drivers/platform/chrome/chromeos_privacy_screen.c:129: > + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); > + drm_privacy_screen_unregister(drm_privacy_screen); > > > + drm_privacy_screen_unregister(drm_privacy_screen); > > + return 0; > > +} > > + > > +static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = { > > + {"GOOG0010", 0}, /* Google's electronic privacy screen for eDP-1 */ > > + {} > > +}; > > +MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids); > > + > > +static struct acpi_driver chromeos_privacy_screen_driver = { > > + .name = "chromeos_privacy_screen_drvr", > > Could I buy 2 move vowels? ;) > > > + .class = "ChromeOS", > > + .ids = chromeos_privacy_screen_device_ids, > > + .ops = { > > + .add = chromeos_privacy_screen_add, > > + .remove = chromeos_privacy_screen_remove, > > + }, > > +}; > > + > > +module_acpi_driver(chromeos_privacy_screen_driver); > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver"); > > +MODULE_AUTHOR("Rajat Jain "); > > Otherwise > > Reviewed-by: Dmitry Torokhov Thanks! I took care of your comments and posted a v5: https://patchwork.kernel.org/project/platform-driver-x86/patch/20220107190208.95479-2-rajatja@google.com/ Thanks & Best Regards, Rajat > > Thanks. > > -- > Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34A16C433EF for ; Fri, 7 Jan 2022 19:05:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CCBC10E4D3; Fri, 7 Jan 2022 19:05:24 +0000 (UTC) Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by gabe.freedesktop.org (Postfix) with ESMTPS id B08A610E584 for ; Fri, 7 Jan 2022 19:05:22 +0000 (UTC) Received: by mail-pg1-x52a.google.com with SMTP id g2so6182491pgo.9 for ; Fri, 07 Jan 2022 11:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+S72sOYOwXg9RPix1lZvjtLtkj3XFLsZ4gEDpSvt8vs=; b=UNlRvA2ZuRZGr24qbY8d8HRyinc6EpOYSKt7DfYa7U+pylhqD10egaBHZVcWbFvg+d HZZoCKimfsUYVZ6hLdx9fE8635nsrgDrj+L00L/QA/Cjac6/OItLx2Gm1LMQY7kdBjlm gUl11sQ+hRSXhsijE3Lz0JsafCc/WMzMcjN+p2ZjS7WJkqTYR8lO8OzMXzBLllf3FZN8 6SuFHJFHb0+VTxIFi9KbZl/oUBDvS7ua7q/kqOUOmGT9RC+dhhVS1J2U1EpVpDJqJhew Efg7LRldeNgMVDWyPjGhSj7BNZ5UuIesQ0y/zYKcFCgYdMO4ccJ3NrTfKraxrHj6N1TQ QivQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+S72sOYOwXg9RPix1lZvjtLtkj3XFLsZ4gEDpSvt8vs=; b=jbGG0UeA8xVjM5/A47fwqcyClZNwRcUkpJhRgGJoKXrcFqUAkgiYtTxC3K3Z7pq7EX 44EjbQto3jIk5JcpD0tZ64wUOjDYiPRbMjJGh2gHEM+rLWa8RggEJ+YylV93N7wmNO47 CJVAVbh04JKLN35EVAHeNK36aj7IsP2aSLRTv6CQZkSZVTDcfJPTRV8UvQcbK9vjkg5s LKYPWnplZwfh/yn12ewDhXXET1HX3jkcm5bexXFusopJtzjxYzDqAod8AANX/hQFB/QM 9RbIfoLKykziuBi0BCfJY8dGkPEqvDOoxFVj/KyDFwylFtV3OZEWSI1+5/ShIUB0wYdd A5zA== X-Gm-Message-State: AOAM532Hi63neX9X6ekRW907xBYKQmceXWJ2lZO6uXz38emgAwA59v/O tK2y2cEQCdRaPaZCAibHtw83C2xZ8lzDR5rIThlcOA== X-Google-Smtp-Source: ABdhPJybEblBw8MdINxXy3+9JK7qlDbdUwo1shN48fzEsrE5iAHxprn/bdZ6bdR1DoPb8Rx12GSfNjxZRna6xpg2RNM= X-Received: by 2002:a05:6a00:1249:b0:4bb:4a31:1e0a with SMTP id u9-20020a056a00124900b004bb4a311e0amr65535466pfi.81.1641582321973; Fri, 07 Jan 2022 11:05:21 -0800 (PST) MIME-Version: 1.0 References: <20211222001127.3337471-1-rajatja@google.com> <20211222001127.3337471-2-rajatja@google.com> In-Reply-To: From: Rajat Jain Date: Fri, 7 Jan 2022 11:04:46 -0800 Message-ID: Subject: Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen To: Dmitry Torokhov Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gwendal@google.com, marcheu@google.com, Thomas Zimmermann , seanpaul@google.com, ibm-acpi-devel@lists.sourceforge.net, David Airlie , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Mark Gross , Hans de Goede , dri-devel@lists.freedesktop.org, Henrique de Moraes Holschuh , rajatxjain@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dmitry, Benson, On Fri, Jan 7, 2022 at 9:43 AM Dmitry Torokhov wrote: > > Hi Rajat, > > On Tue, Dec 21, 2021 at 04:11:26PM -0800, Rajat Jain wrote: > > +static int chromeos_privacy_screen_remove(struct acpi_device *adev) > > +{ > > + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); > > Please add an empty line here: > > WARNING: Missing a blank line after declarations > #292: FILE: drivers/platform/chrome/chromeos_privacy_screen.c:129: > + struct drm_privacy_screen *drm_privacy_screen = acpi_driver_data(adev); > + drm_privacy_screen_unregister(drm_privacy_screen); > > > + drm_privacy_screen_unregister(drm_privacy_screen); > > + return 0; > > +} > > + > > +static const struct acpi_device_id chromeos_privacy_screen_device_ids[] = { > > + {"GOOG0010", 0}, /* Google's electronic privacy screen for eDP-1 */ > > + {} > > +}; > > +MODULE_DEVICE_TABLE(acpi, chromeos_privacy_screen_device_ids); > > + > > +static struct acpi_driver chromeos_privacy_screen_driver = { > > + .name = "chromeos_privacy_screen_drvr", > > Could I buy 2 move vowels? ;) > > > + .class = "ChromeOS", > > + .ids = chromeos_privacy_screen_device_ids, > > + .ops = { > > + .add = chromeos_privacy_screen_add, > > + .remove = chromeos_privacy_screen_remove, > > + }, > > +}; > > + > > +module_acpi_driver(chromeos_privacy_screen_driver); > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver"); > > +MODULE_AUTHOR("Rajat Jain "); > > Otherwise > > Reviewed-by: Dmitry Torokhov Thanks! I took care of your comments and posted a v5: https://patchwork.kernel.org/project/platform-driver-x86/patch/20220107190208.95479-2-rajatja@google.com/ Thanks & Best Regards, Rajat > > Thanks. > > -- > Dmitry