All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Netdev <netdev@vger.kernel.org>,
	Satish Baddipadige <satish.baddipadige@broadcom.com>,
	Siva Reddy Kallam <siva.kallam@broadcom.com>
Subject: Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0
Date: Thu, 1 Sep 2016 07:39:47 -0700	[thread overview]
Message-ID: <CACKFLi=cdxQhAjx=yXcKrkguFkooz7G5P-RztYMDpZcSWHiSbw@mail.gmail.com> (raw)
In-Reply-To: <1472722139-22806-1-git-send-email-ivecera@redhat.com>

On Thu, Sep 1, 2016 at 2:28 AM, Ivan Vecera <ivecera@redhat.com> wrote:
> The recent commit 087d7a8c9174 "tg3: Fix for diasllow rx coalescing
> time to be 0" disallow to set Rx coalescing time to be 0 as this stops
> generating interrupts for the incoming packets. I found the zero
> Tx coalescing time stops generating interrupts for outgoing packets
> as well and fires Tx watchdog later. To avoid this, don't allow to set
> Tx coalescing time to 0 and also remove subsequent checks that become
> senseless.
>
> Cc: satish.baddipadige@broadcom.com
> Cc: siva.kallam@broadcom.com
> Cc: michael.chan@broadcom.com
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Acked-by: Michael Chan <michael.chan@broadcom.com>

  reply	other threads:[~2016-09-01 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01  9:28 [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0 Ivan Vecera
2016-09-01 14:39 ` Michael Chan [this message]
2016-09-01 16:58 ` David Miller
2016-09-01  9:38 Siva Reddy Kallam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACKFLi=cdxQhAjx=yXcKrkguFkooz7G5P-RztYMDpZcSWHiSbw@mail.gmail.com' \
    --to=michael.chan@broadcom.com \
    --cc=ivecera@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=satish.baddipadige@broadcom.com \
    --cc=siva.kallam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.