All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: "Peter Münster" <pm@a16n.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v4] net: b44: set pause params only when interface is up
Date: Wed, 24 Apr 2024 09:37:29 -0700	[thread overview]
Message-ID: <CACKFLik=ZiFd2hS8Nt+pd-mYboFb5sypW8vpe_9NXD4W7yHv6A@mail.gmail.com> (raw)
In-Reply-To: <87y192oolj.fsf@a16n.net>

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On Wed, Apr 24, 2024 at 6:51 AM Peter Münster <pm@a16n.net> wrote:
>
> b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
> unconditionally, but b44::rx_buffers is only valid when the
> device is up (they get allocated in b44_open(), and deallocated
> again in b44_close()), any other time these are just a NULL pointers.
>
> So if you try to change the pause params while the network interface
> is disabled/administratively down, everything explodes (which likely
> netifd tries to do).
>
> Link: https://github.com/openwrt/openwrt/issues/13789
> Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
> Cc: stable@vger.kernel.org
> Reported-by: Peter Münster <pm@a16n.net>
> Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: Vaclav Svoboda <svoboda@neng.cz>
> Tested-by: Peter Münster <pm@a16n.net>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Peter Münster <pm@a16n.net>

Reviewed-by: Michael Chan <michael.chan@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

  reply	other threads:[~2024-04-24 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 13:51 [PATCH net v4] net: b44: set pause params only when interface is up Peter Münster
2024-04-24 16:37 ` Michael Chan [this message]
2024-04-25  5:20 ` Hariprasad Kelam
2024-04-25 15:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACKFLik=ZiFd2hS8Nt+pd-mYboFb5sypW8vpe_9NXD4W7yHv6A@mail.gmail.com' \
    --to=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pm@a16n.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.