From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC46C10DCE for ; Tue, 10 Mar 2020 06:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73BE924679 for ; Tue, 10 Mar 2020 06:16:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YKRUbXaT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726271AbgCJGQX (ORCPT ); Tue, 10 Mar 2020 02:16:23 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:33616 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbgCJGQX (ORCPT ); Tue, 10 Mar 2020 02:16:23 -0400 Received: by mail-qt1-f193.google.com with SMTP id d22so8907863qtn.0 for ; Mon, 09 Mar 2020 23:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zqMAcVJ3pxiogTCVRmCnWcqLUai74h88UlP3PJcB88Y=; b=YKRUbXaTC/WT+6jRST9JO4e43dxrmgDQ6nRbZ4k+nKDaKuMafS7WUMv7N7IdRF4r6M 8eCMnWjXCczRLC9NMrmvaorG8LTkl4zlOHp7MJlzsdGhK8vghb765zbt3eDmjisqHJZz rY0vi5GTxWf7RHioX70bsNPYyQWLzns1wAxqw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zqMAcVJ3pxiogTCVRmCnWcqLUai74h88UlP3PJcB88Y=; b=gXJLXKRqgivON6bOpnrxn7rrlaDG7ZbkIWckJYm+HFqwD2sRFesVIg5KPhXoUNQYcB 2C+RVFz7RN8wKres4ElUU8IBxNeAYS9LN9bY3vQNx5W1ztRHTh3o3hjxLKuqGoCfgsW6 rMNrpt+CvHWvs2692KyU7i0bVhjHhTyXQTFWUDuby15Oeb+tc+TJCk1jmBp8VAicYG/M IT1uDX4gh8R9muZSMZW172S0lTtfY8J6f/bsv9LOHw7AzVa/0vz5bgKNLBygy4EAfdFE /qOHMoQmijeN/U3IFwi8hXF66VKxBsgUZ/NF5lqb76RWxjlR7biCAoq/9jQXDqSRm2V+ LDlw== X-Gm-Message-State: ANhLgQ1Jg4vC1gbQ0ZWuU7KN4cHAhJf6p0l2fiwV/0ZaZyiCU66zFD5W xY3UPs0IqB9FK93NA52LgBvswedTczlE6DJhjCWR4i79 X-Google-Smtp-Source: ADFU+vuRo9OAYjxJE0Ukal34OU1v8TJg2GBG19jTfkCALSroNTFd2cCA3F8A6KOru57kudUguZcG53aFfeEV5kUFfWc= X-Received: by 2002:aed:3c4b:: with SMTP id u11mr8366757qte.208.1583820981960; Mon, 09 Mar 2020 23:16:21 -0700 (PDT) MIME-Version: 1.0 References: <20200310021512.1861626-1-kuba@kernel.org> <20200310021512.1861626-8-kuba@kernel.org> In-Reply-To: <20200310021512.1861626-8-kuba@kernel.org> From: Michael Chan Date: Mon, 9 Mar 2020 23:16:09 -0700 Message-ID: Subject: Re: [PATCH net-next 07/15] net: tg3: reject unsupported coalescing params To: Jakub Kicinski Cc: David Miller , Netdev , akiyano@amazon.com, netanel@amazon.com, gtzalik@amazon.com, irusskikh@marvell.com, Florian Fainelli , bcm-kernel-feedback-list , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, aelior@marvell.com, skalluru@marvell.com, GR-everest-linux-l2@marvell.com, opendmb@gmail.com, Siva Reddy Kallam , "prashant.sreedharan@broadcom.com" , "michael.chan@broadcom.com" , dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, Tariq Toukan , vishal@chelsio.com, leedom@chelsio.com, ulli.kroll@googlemail.com, linus.walleij@linaro.org Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 9, 2020 at 7:15 PM Jakub Kicinski wrote: > > Set ethtool_ops->supported_coalesce_params to let > the core reject unsupported coalescing parameters. > > This driver did not previously reject unsupported parameters. > > Signed-off-by: Jakub Kicinski Reviewed-by: Michael Chan Thanks.