From: javier Martin <javier.martin@vista-silicon.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bo Shen <voice.shen@atmel.com>,
khali@linux-fr.org, w.sang@pengutronix.de, jm.lin@atmel.com,
linux-input@vger.kernel.org
Subject: Re: [RFC] QT1070: change the trigger mode of QT1070
Date: Fri, 11 May 2012 11:13:41 +0200 [thread overview]
Message-ID: <CACKLOr0_ztBXfTwa1R_yLzf6wEABENf=-MzYHd-J5YQtEmQt9w@mail.gmail.com> (raw)
In-Reply-To: <4FACCDA6.7040506@atmel.com>
Hi all,
let's take a chip which presents a similar issue like the pca953x [1].
This chip has an IRQ line that is meant to be connected to a SoC input
like the qt1070.
The flags that are used for pca953x are: (IRQF_TRIGGER_LOW | IRQF_ONESHOT)
Can't we do the same for qt1070?
And even more important, can you give me an example of an architecture
in mainline which cannot support these irq flags and still be able to
detect a change from high to low in a GPIO as qt1070 requires?
Moreover, if you try a grep for IRQ_TRIGGER_NONE in the kernel tree
you won't find any driver doing this strange thing.
Do you agree at least that we must change IRQ_TRIGGER_NONE flag into a
more sensible choice?
Regards.
[1] http://lxr.linux.no/#linux+v3.3.4/drivers/gpio/gpio-pca953x.c#L495
--
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
next prev parent reply other threads:[~2012-05-11 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 2:27 [RFC] QT1070: change the trigger mode of QT1070 Bo Shen
2012-05-07 7:04 ` Dmitry Torokhov
2012-05-07 7:09 ` javier Martin
2012-05-08 7:45 ` Shen, Voice
2012-05-11 8:28 ` Josh Wu
2012-05-11 9:13 ` javier Martin [this message]
2012-05-11 11:33 ` Josh Wu
2012-05-11 12:47 ` javier Martin
2012-05-14 2:57 ` Bo Shen
2012-05-14 6:59 ` javier Martin
2012-05-14 7:21 ` javier Martin
2012-05-11 16:06 ` Dmitry Torokhov
2012-05-11 16:08 ` Dmitry Torokhov
2012-05-14 2:54 ` Bo Shen
2012-05-11 8:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACKLOr0_ztBXfTwa1R_yLzf6wEABENf=-MzYHd-J5YQtEmQt9w@mail.gmail.com' \
--to=javier.martin@vista-silicon.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jm.lin@atmel.com \
--cc=josh.wu@atmel.com \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=voice.shen@atmel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.