From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Puiu Subject: Re: [PATCH] vmxnet3: fix Rx deadlock Date: Mon, 12 Dec 2016 10:27:29 +0200 Message-ID: References: <1479120376-48723-1-git-send-email-stefan.puiu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , "mac_leehk@yahoo.com.hk" To: Yong Wang Return-path: Received: from mail-io0-f193.google.com (mail-io0-f193.google.com [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 543BC10A7 for ; Mon, 12 Dec 2016 09:27:30 +0100 (CET) Received: by mail-io0-f193.google.com with SMTP id b194so20028250ioa.3 for ; Mon, 12 Dec 2016 00:27:30 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello and thanks for reviewing the patch. On Wed, Nov 30, 2016 at 6:59 AM, Yong Wang wrote: [...] > I think a more accurate description is that the particular descriptor's generation bit never got flipped properly when an mbuf failed to be refilled which caused the rx stuck, rather than vmxnet3_post_rx_bufs() not being called afterwards. > Not sure if this kind of level of detail is useful, but if you can think of a better explanation to put in the changelist, I can add it. I see the generation bit not flipping as a symptom, while the core problem is the hardware can't write to the descriptor. I felt the explanation was going into too much detail anyway, so I've reworded it a bit for v2. Let me know what you think. Thanks, Stefan.