Re: [meta-virtualization][PATCH v2 3/3] grub-efi: Add xen_boot support when 'xen' is in DISTRO_FEATURES for aarch64

From: Christopher Clark <christopher.w.clark@gmail.com>
To: Kamil Dziezyk <kamil.dziezyk@arm.com>
Cc: meta-virtualization@lists.yoctoproject.org, nd <nd@arm.com>,
	Bruce Ashfield <bruce.ashfield@gmail.com>,
	Doug Goldstein <cardoe@gentoo.org>
Subject: Re: [meta-virtualization][PATCH v2 3/3] grub-efi: Add xen_boot support when 'xen' is in DISTRO_FEATURES for aarch64
Date: Mon, 20 Dec 2021 20:52:40 -0800	[thread overview]
Message-ID: <CACMJ4GZTYOUMZcuVgB16ureKef2J2hfFJqVJ8SW+hjArYf2W1w@mail.gmail.com> (raw)
In-Reply-To: <20211209135752.6872-3-kamil.dziezyk@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On Thu, Dec 9, 2021 at 5:59 AM Kamil Dziezyk <kamil.dziezyk@arm.com> wrote:

> Signed-off-by: Kamil Dziezyk <kamil.dziezyk@arm.com>
>

I think this might be better changed in the grub-efi recipe in OE core
instead, where the GRUB recipe maintainer can review it?

Should this xen_boot build-in feature be enabled for more architectures
than just aarch64?

Christopher

> ---
>  recipes-bsp/grub/grub-efi_%.bbappend | 1 +
>  recipes-bsp/grub/grub-efi_xen.inc    | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 100644 recipes-bsp/grub/grub-efi_%.bbappend
>  create mode 100644 recipes-bsp/grub/grub-efi_xen.inc
>
> diff --git a/recipes-bsp/grub/grub-efi_%.bbappend
> b/recipes-bsp/grub/grub-efi_%.bbappend
> new file mode 100644
> index 0000000..df2b688
> --- /dev/null
> +++ b/recipes-bsp/grub/grub-efi_%.bbappend
> @@ -0,0 +1 @@
> +require ${@bb.utils.contains('DISTRO_FEATURES', 'xen', '${BPN}_xen.inc',
> '', d)}
> diff --git a/recipes-bsp/grub/grub-efi_xen.inc
> b/recipes-bsp/grub/grub-efi_xen.inc
> new file mode 100644
> index 0000000..5aa0958
> --- /dev/null
> +++ b/recipes-bsp/grub/grub-efi_xen.inc
> @@ -0,0 +1 @@
> +GRUB_BUILDIN:append:aarch64 = "${@bb.utils.contains('DISTRO_FEATURES',
> 'xen', ' xen_boot', '', d)}"
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6974):
> https://lists.yoctoproject.org/g/meta-virtualization/message/6974
> Mute This Topic: https://lists.yoctoproject.org/mt/87611988/3619037
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> christopher.w.clark@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 2892 bytes --]