From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79982C433E1 for ; Thu, 13 Aug 2020 17:20:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41E8F20774 for ; Thu, 13 Aug 2020 17:20:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bvDXfG6H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41E8F20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27A4B6EA77; Thu, 13 Aug 2020 17:20:03 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35E9B6EA77 for ; Thu, 13 Aug 2020 17:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597339200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G/EOnB2RxemqEsc0Lz/9tRxhhxIO1iGweDetCw8VNOk=; b=bvDXfG6HJmEABDciVUF8WnN+63uZtuknL2q+Z+MeCbOl1MY2jWYNqFLmQIhDYKwgBXoZmx 08o5whQrfwSUt9cTIR/pTduSlVWfOCoQYwOn7lmw6OsY5If7inQO5fPG0443lmrmpQUjxW BNfpJKxbYle0VWisCwhEgkiTUSxfMhs= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-4wJvb1WxMvWEp-hxJvr1oA-1; Thu, 13 Aug 2020 13:19:53 -0400 X-MC-Unique: 4wJvb1WxMvWEp-hxJvr1oA-1 Received: by mail-qk1-f199.google.com with SMTP id d6so4382657qkg.6 for ; Thu, 13 Aug 2020 10:19:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G/EOnB2RxemqEsc0Lz/9tRxhhxIO1iGweDetCw8VNOk=; b=NWsuQ6S5D8zHEI9JEXMZODfuW4xA6NGaix9Xz9V4FYPLlJYCxEvp1+nCjNRJ3j8H8Q o+l77RLpICScl9DN8F3uYJY8VMsJmS45ZKaxOwC2kwdhXZrkjGOw7OqsL3As766xQJr2 JvnlOQNfT1GG9C6KD/pH8RwQiYzkHtZh/TRt454uX1QJlnFdCJOIZqJShJ5W819uzlMu W4zzu/xNbwumXAsij6NbRhw1LKutfxxfim8p0QH6UIuN3G05wdGAZZ88a+6F3b05BdK9 0jVYSDPGIySOYVWOky00mIN4YsvU/2mtWIR6tsSpaiHyzZzr43qQrDKURhVIllEFU8Lm /NDQ== X-Gm-Message-State: AOAM5317EeBEzJ25s3ekMUV7Ty0nS74WkerRkJZwBEMML+DnM7nhdunT 26jYn5iIaD+IwOjcvzLdkv8FyL0lckYn2q6CbC2zSTxgIU6s0axzFc+7/m+MHf0UvOYLEscrUXZ qOjLu/uoqJmXx8rpdu8AbpM/sN2LT4NkQq8/Etk5S1bcR X-Received: by 2002:aed:24f2:: with SMTP id u47mr6455421qtc.137.1597339192535; Thu, 13 Aug 2020 10:19:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5/rxIPyvX3mFsOIM/xCnNYHWroj5erwBSgbu19Y9GAs8GMDpNwUvnwra7bv0nvbg3BrNZPUcmfTHZU3mqLRo= X-Received: by 2002:aed:24f2:: with SMTP id u47mr6455391qtc.137.1597339192217; Thu, 13 Aug 2020 10:19:52 -0700 (PDT) MIME-Version: 1.0 References: <261cd7c9-6853-3d5f-3a3e-86b65c9dba71@nvidia.com> <0e882aa7-d0ea-19b0-a13d-4f7bc0d384aa@nvidia.com> <785eb70c-d9e7-dbdf-b044-337618fcea1a@nvidia.com> <20200812174005.GA1705@kevin> <2c5cf2e8-afd2-446d-1f27-2c225c65d447@nvidia.com> In-Reply-To: From: Karol Herbst Date: Thu, 13 Aug 2020 19:19:40 +0200 Message-ID: Subject: Re: [git pull] drm for 5.8-rc1 To: James Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , Thierry Reding , Alyssa Rosenzweig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" another thing: with gsettings set org.gnome.mutter experimental-features '["kms-modifiers"]' it all just works out of the box with wayland, but that won't be enabled for quite some time, so we need to figure out what is broken (less so with my patch) under wayland with gnome :) On Thu, Aug 13, 2020 at 5:39 PM Karol Herbst wrote: > > btw, I just noticed that wayland with gnome-shell is totally busted. > With this MR it at least displays something, but without it doesn't > work at all. > > On Thu, Aug 13, 2020 at 3:00 PM Karol Herbst wrote: > > > > At least for now I've created an MR to revert the change: > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6300 > > > > But it seems like there was probably a good reason why it got added? > > Happy to have better fixes, but that's the best we've got so far I > > think? > > > > Thierry, what do you think? > > > > On Wed, Aug 12, 2020 at 8:51 PM Karol Herbst wrote: > > > > > > in case you all were wondering, it works on xorg-server git because of > > > this commit: https://gitlab.freedesktop.org/xorg/xserver/-/commit/9b8999411033c9473cd68e92e4690a91aecf5b95 > > > > > > On Wed, Aug 12, 2020 at 8:25 PM James Jones wrote: > > > > > > > > On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote: > > > > >> ...and in merging my code with Alyssa's new panfrost format modifier > > > > >> support, I see panfrost does the opposite of this and treats a format > > > > >> modifier list of only INVALID as "don't care". I modeled the new nouveau > > > > >> behavior on the Iris driver. Now I'm not sure which is correct :-( > > > > > > > > > > ....and neither am I. Uh-oh. > > > > > > > > > > I modeled the panfrost code after v3d_resource_create_with_modifiers, > > > > > which treats INVALID as "don't care". I can confirm the panfrost code > > > > > works (in the sense that it's functional on the machines I've tested), > > > > > but I don't know if it is actually correct. I think it is, since > > > > > otherwise you end up using linear in places it's unnecessary, but I'm > > > > > not sure where this is spec'd. > > > > > > > > It would depend on whether an app actually calls the function this way, > > > > and whether that app was tested I suppose. If I'm interpreting the Iris > > > > code correctly and it doesn't break anything, then I'm assuming both > > > > implementations are equally valid in that nothing exercises this path, > > > > but it would be good to have the intended behavior documented somewhere > > > > so we can try to work towards consistent in case someone tries it in the > > > > future. > > > > > > > > My nouveau change runs afoul of assumptions in the tegra driver, but > > > > that's easy enough to fix in lockstep if desired. > > > > > > > > Also, heads up: I'll ping you on my format modifier cleanup MR once I've > > > > pushed the latest version. The panfrost modifier usage was harder to > > > > merge into the refactoring than most, so it'll be good to have your > > > > review and if you have time, some testing. I think I landed on an > > > > elegant solution, but open to suggestions. > > > > > > > > Thanks, > > > > -James > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel