From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0CBC433DF for ; Thu, 13 Aug 2020 15:40:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5992520829 for ; Thu, 13 Aug 2020 15:40:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CScTnG42" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5992520829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68C816EA0F; Thu, 13 Aug 2020 15:39:59 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F5DC6EA0C for ; Thu, 13 Aug 2020 15:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597333197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ruL7c684x1j6etwdxHOsLPx/m5deCb4xICXgWudjtoM=; b=CScTnG42K1f2YvizYvIM5dJJ5csQh4oMfyJeS05axEfvaaOkl4tKrjSU3Rn0IcU5YVPU21 sYU66h4D4oe8G+3VTwqGo/Dc4Q8jckVq1WGFhd8mSHMFH7x5egai1MTRAZOvrWJf14iMk3 0Ku39wOhSMUWWr2NwO/UlOeWU1DaWRM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-oGmLNUG3NkW2kqE2kvuxzg-1; Thu, 13 Aug 2020 11:39:52 -0400 X-MC-Unique: oGmLNUG3NkW2kqE2kvuxzg-1 Received: by mail-qv1-f70.google.com with SMTP id n5so4195738qvx.2 for ; Thu, 13 Aug 2020 08:39:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ruL7c684x1j6etwdxHOsLPx/m5deCb4xICXgWudjtoM=; b=eZprdFtZCLIiyItZ0tiS8IdOUtnsVNeeFHNczLxEgD3yaR/h1ha/CoUu/C8FPXV/0f IWq51sKgmLnfzao9YlIxi5iAj4LpC3ciZe39r+PUy9Yk5A35YQH/CZUjLMJSkONfIPAW F+LY1nV5ReraTTE+ygdCgPhD42Gj4MJFRlPrbYLuPpKauA9K9IVZKs/oesN6rfJhuFPb DFWX8b8BN9biYQqLYkhIRYD9FU2nw7ZUvqknKU3Z8wD9BduWrx2U+9F4R+kNy5TL8Kwv Jl5ignL9KrLtfDERmKIR1sCHo1NFvEjgiiuryxh2DoHtuG0nTwFUMUL8ReH2e3Pt0WSe ndKg== X-Gm-Message-State: AOAM531Mi7+2PGHcsW/YrvtTz/6/5ACuHjJWtCy4VS2IQf1PXU+v0fAI XW7+ke4JNe+3aIO/NyFkfwLCuU9leKpJmzu45zd9xuP22oRcJCBxklvfqCrXEMkuQwXASld19FX jFyHE7w+0KdfbNg1JvgpC0oIb54sG0cT5taO53nNt1R2O X-Received: by 2002:a0c:9cc4:: with SMTP id j4mr4975440qvf.230.1597333191284; Thu, 13 Aug 2020 08:39:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvtbhnOitzX2S+/S7IubavMiKUWvFZdfRYtd2facOx7kqG4OYd3DGV0dClwHExYW+xMO9IMzeewGQrr9DNMmM= X-Received: by 2002:a0c:9cc4:: with SMTP id j4mr4975411qvf.230.1597333190980; Thu, 13 Aug 2020 08:39:50 -0700 (PDT) MIME-Version: 1.0 References: <261cd7c9-6853-3d5f-3a3e-86b65c9dba71@nvidia.com> <0e882aa7-d0ea-19b0-a13d-4f7bc0d384aa@nvidia.com> <785eb70c-d9e7-dbdf-b044-337618fcea1a@nvidia.com> <20200812174005.GA1705@kevin> <2c5cf2e8-afd2-446d-1f27-2c225c65d447@nvidia.com> In-Reply-To: From: Karol Herbst Date: Thu, 13 Aug 2020 17:39:39 +0200 Message-ID: Subject: Re: [git pull] drm for 5.8-rc1 To: James Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel , Thierry Reding , Alyssa Rosenzweig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" btw, I just noticed that wayland with gnome-shell is totally busted. With this MR it at least displays something, but without it doesn't work at all. On Thu, Aug 13, 2020 at 3:00 PM Karol Herbst wrote: > > At least for now I've created an MR to revert the change: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6300 > > But it seems like there was probably a good reason why it got added? > Happy to have better fixes, but that's the best we've got so far I > think? > > Thierry, what do you think? > > On Wed, Aug 12, 2020 at 8:51 PM Karol Herbst wrote: > > > > in case you all were wondering, it works on xorg-server git because of > > this commit: https://gitlab.freedesktop.org/xorg/xserver/-/commit/9b8999411033c9473cd68e92e4690a91aecf5b95 > > > > On Wed, Aug 12, 2020 at 8:25 PM James Jones wrote: > > > > > > On 8/12/20 10:40 AM, Alyssa Rosenzweig wrote: > > > >> ...and in merging my code with Alyssa's new panfrost format modifier > > > >> support, I see panfrost does the opposite of this and treats a format > > > >> modifier list of only INVALID as "don't care". I modeled the new nouveau > > > >> behavior on the Iris driver. Now I'm not sure which is correct :-( > > > > > > > > ....and neither am I. Uh-oh. > > > > > > > > I modeled the panfrost code after v3d_resource_create_with_modifiers, > > > > which treats INVALID as "don't care". I can confirm the panfrost code > > > > works (in the sense that it's functional on the machines I've tested), > > > > but I don't know if it is actually correct. I think it is, since > > > > otherwise you end up using linear in places it's unnecessary, but I'm > > > > not sure where this is spec'd. > > > > > > It would depend on whether an app actually calls the function this way, > > > and whether that app was tested I suppose. If I'm interpreting the Iris > > > code correctly and it doesn't break anything, then I'm assuming both > > > implementations are equally valid in that nothing exercises this path, > > > but it would be good to have the intended behavior documented somewhere > > > so we can try to work towards consistent in case someone tries it in the > > > future. > > > > > > My nouveau change runs afoul of assumptions in the tegra driver, but > > > that's easy enough to fix in lockstep if desired. > > > > > > Also, heads up: I'll ping you on my format modifier cleanup MR once I've > > > pushed the latest version. The panfrost modifier usage was harder to > > > merge into the refactoring than most, so it'll be good to have your > > > review and if you have time, some testing. I think I landed on an > > > elegant solution, but open to suggestions. > > > > > > Thanks, > > > -James > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel