From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FF4C77B76 for ; Mon, 17 Apr 2023 16:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbjDQQ0W (ORCPT ); Mon, 17 Apr 2023 12:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjDQQ0U (ORCPT ); Mon, 17 Apr 2023 12:26:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC41C4ECE for ; Mon, 17 Apr 2023 09:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681748732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=gW1lfeOJYshbxFj0ArHC728OX3BXQemBoXmU9DR3insObejwiVonjSE2xu/CYwpIlYpjEX U4gV8LwCVLP6GVKzgCqyFvvKpbiOf9UkFN5P/yk9rTZltLsolduaMORy6pLvNESMwLWvl9 HYp6vS/1UR/HPJ+iFgHfFImm541TMy4= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-0KrpzXowPgK6T4SoglSG0Q-1; Mon, 17 Apr 2023 12:25:30 -0400 X-MC-Unique: 0KrpzXowPgK6T4SoglSG0Q-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2a8bba7dd2cso4950451fa.2 for ; Mon, 17 Apr 2023 09:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681748725; x=1684340725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=iSmsolYiCt31cqBfeZM1guoZ556ccPUCM/1lFdi1O+C8NJJB34xPyH5IXlIXUIz30H WF8xVO5PJzZEqi5KjIZluM3hwJ5y4/NR05Ht/iGY9wUh4qsLBVvfzHeMdXcpH/qvYTSt 6bel/9Ev7FIMqPUcfM7uDgyBINxqfzpMdcpm1hK+01LtzJjQCGE5KvdqqnEA90jbdmHt qTE/WxBlWJSSmHWqKeqPkDGwhG0GUhp/dF7/hmURrmirKjCCqKGIZ8j78jrvZO++zRvd 7PRpzWOpaHl3ak35Rkfa9VQPOreEitUVESYBHzgj5Bra3D8/ihX94UdhhlNdJnGNq2vN LWIA== X-Gm-Message-State: AAQBX9cO2Eg9Tqucse1NIlnTt2zfd6jN9JYRJd+GfCY+/9nOKqYWaKBc ijoIOQ1wPyPl/KSxzEkw0ad5NXMQG3t09AdFoXPhIfeMesX4A87u3SIN16Ku42tSh6HldIVuGAs /5bY6TQxClPn3ORDukjiaaeY2Thf+/j1g1A+0GcPt X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308536lfq.11.1681748725392; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+bsYZfdQ0YbXRNUdAiXrEC617Co8M6Ae9OYtGyQ7Z0JTehg+Oxteoxe+dPaIDFHLfU5sWj8/W0mxSAgomtgA= X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308529lfq.11.1681748725093; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) MIME-Version: 1.0 References: <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de> <1a11455f-ab57-dce0-1677-6beb8492a257@web.de> <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> In-Reply-To: <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> From: Karol Herbst Date: Mon, 17 Apr 2023 18:25:13 +0200 Message-ID: Subject: Re: [PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations To: Markus Elfring Cc: kernel-janitors@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Ben Skeggs , Daniel Vetter , David Airlie , Lyude Paul , LKML , cocci@inria.fr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 16, 2023 at 11:30=E2=80=AFAM Markus Elfring wrote: > > Date: Sun, 16 Apr 2023 11:22:23 +0200 > > Several update suggestions were taken into account > from static source code analysis. > Reviewed-by: Karol Herbst > Markus Elfring (9): > debugfs: Move an expression into a function call parameter > in nouveau_debugfs_pstate_set() > debugfs: Move a variable assignment behind a null pointer check > in nouveau_debugfs_pstate_get() > debugfs: Use seq_putc() > in nouveau_debugfs_pstate_get() > debugfs: Replace five seq_printf() calls by seq_puts() > in nouveau_debugfs_pstate_get() > power_budget: Move an expression into a macro call parameter > in nvbios_power_budget_header() > clk: Move a variable assignment behind a null pointer check > in nvkm_pstate_new() > pci: Move a variable assignment behind condition checks > in nvkm_pcie_set_link() > pci: Move an expression into a function call parameter > in nvkm_pcie_set_link() > therm: Move an assignment statement behind a null pointer check > in two functions > > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 19 ++++++++++--------- > .../nouveau/nvkm/subdev/bios/power_budget.c | 3 +-- > .../gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +- > .../gpu/drm/nouveau/nvkm/subdev/pci/pcie.c | 7 +++---- > .../drm/nouveau/nvkm/subdev/therm/fanpwm.c | 2 +- > .../drm/nouveau/nvkm/subdev/therm/fantog.c | 2 +- > 6 files changed, 17 insertions(+), 18 deletions(-) > > -- > 2.40.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E69BC77B7C for ; Mon, 17 Apr 2023 16:25:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 943B310E479; Mon, 17 Apr 2023 16:25:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25F6310E46F for ; Mon, 17 Apr 2023 16:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681748729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=ZwsKl/5UUOyYlSorUGUChmq8A6rrpghmc98BzeGhATVFyE0KEkKuAZGLrAfQF0dFx4S6Ct L+t24zDOJ+1t1RAG0o3v7FWuOeDp9PgnY3VewvgxhHYJxTKlCO/UDwoE4c+QnyX3JdIxgC R3/ikYSBE2+gMlBtU5SbSPDHcOObwOQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-HlJw-pvXPKuLqeySiGqWYA-1; Mon, 17 Apr 2023 12:25:28 -0400 X-MC-Unique: HlJw-pvXPKuLqeySiGqWYA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4ec8149ff85so583293e87.1 for ; Mon, 17 Apr 2023 09:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681748725; x=1684340725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=gYExHyOYX6ERqTtUkClZc+i/Dq8pIQ1EQv2m6SRDXHo4pScktYWFyVX8JTtJcLIf1U +VDcymVYcQ2p1vc2mJdaIBwp+C4pGabFtx9GIRY1rSKv/lkGoQ/TpBbyXTsjgvmgKJ9p KgS/0enLn/fnMGFSsEfUL0qBNi8YACGqfY3gOQTEt984zFOcuapozkq9+bnyDm9gWwct mgUHseRl5YKwgYgNDbp/+7ICTfgQp4ROvqyHsyuuo0+0R6SzO5T3TFFgLCxgZBF796nY iDvzTb3D+GJnI2sem3lSyzwjpk4Gp0yUjd4tDhM0jAhewOCJXjJlcOi3OLT274vnGN8z zuSw== X-Gm-Message-State: AAQBX9cSS+gDQghe4FVWi807NAsSAqo1ZmNKq+b3CT5nI5ZHQVvluUcU SUmmXxg08CKzPmDKm1Q/uoSHpZFPBgjf/6u2J025p9z7IP4nr+XIJK9cwCiEx0oitKxFZ1QjXvb tx3IetZ9zRv1CUTBdpvy8jwV06MkTVu7Rn4IttKHgog== X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308538lfq.11.1681748725393; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+bsYZfdQ0YbXRNUdAiXrEC617Co8M6Ae9OYtGyQ7Z0JTehg+Oxteoxe+dPaIDFHLfU5sWj8/W0mxSAgomtgA= X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308529lfq.11.1681748725093; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) MIME-Version: 1.0 References: <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de> <1a11455f-ab57-dce0-1677-6beb8492a257@web.de> <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> In-Reply-To: <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> From: Karol Herbst Date: Mon, 17 Apr 2023 18:25:13 +0200 Message-ID: To: Markus Elfring X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Nouveau] [PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Ben Skeggs , Daniel Vetter , cocci@inria.fr Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Sun, Apr 16, 2023 at 11:30=E2=80=AFAM Markus Elfring wrote: > > Date: Sun, 16 Apr 2023 11:22:23 +0200 > > Several update suggestions were taken into account > from static source code analysis. > Reviewed-by: Karol Herbst > Markus Elfring (9): > debugfs: Move an expression into a function call parameter > in nouveau_debugfs_pstate_set() > debugfs: Move a variable assignment behind a null pointer check > in nouveau_debugfs_pstate_get() > debugfs: Use seq_putc() > in nouveau_debugfs_pstate_get() > debugfs: Replace five seq_printf() calls by seq_puts() > in nouveau_debugfs_pstate_get() > power_budget: Move an expression into a macro call parameter > in nvbios_power_budget_header() > clk: Move a variable assignment behind a null pointer check > in nvkm_pstate_new() > pci: Move a variable assignment behind condition checks > in nvkm_pcie_set_link() > pci: Move an expression into a function call parameter > in nvkm_pcie_set_link() > therm: Move an assignment statement behind a null pointer check > in two functions > > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 19 ++++++++++--------- > .../nouveau/nvkm/subdev/bios/power_budget.c | 3 +-- > .../gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +- > .../gpu/drm/nouveau/nvkm/subdev/pci/pcie.c | 7 +++---- > .../drm/nouveau/nvkm/subdev/therm/fanpwm.c | 2 +- > .../drm/nouveau/nvkm/subdev/therm/fantog.c | 2 +- > 6 files changed, 17 insertions(+), 18 deletions(-) > > -- > 2.40.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F86C77B7A for ; Mon, 17 Apr 2023 16:25:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5608710E47E; Mon, 17 Apr 2023 16:25:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA8BA10E467 for ; Mon, 17 Apr 2023 16:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681748731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=XalNanORxrz8GQFbP/b9m/q6unvFauLBOaGQljALOXGdyfIGdtZXUSsGgdXXs2QdyhQgiw gt1KSXb82CiVfRQ4izQ0Xu3nZMWMsKZsEcAHL3UlMd8j7DBWapyqay8PVdmYY4v/oQ7WD5 IGIzrjO4W5sG4faxgnZJ8LD8LY1GDmY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-nQjJ-0ndPH62AY5P0lw1DQ-1; Mon, 17 Apr 2023 12:25:30 -0400 X-MC-Unique: nQjJ-0ndPH62AY5P0lw1DQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2a8a54fc72cso5671431fa.3 for ; Mon, 17 Apr 2023 09:25:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681748725; x=1684340725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTTtRzBVTjjwCLzyfJV4ohTaunXWOeVeAb2RjGQ5vZ8=; b=ON+nTOch4qYHjNjeOH8A3G5Wjz5X+qUDH6u8QvV9MBdPeuwy7QkYIgAAtCyV23rvjy qFsQjtRJZGJweOmsbTRi49w8T3Wj0KG5X9UYTqX4Rf198rr7YiVO7JlGBXntqAAwKNch V80Ry2JnTuQEziuD+7mp9fEo7qFqwmR1yHDyZxrMiJyQzXsyvkCjE6FkgO+48AX3N1sv 0XzdiCppHU7n0po79qeq/j9SJ8x+8KzAPa7oECmo5zZYVwqapNuzAnbVel0oNq+RNbhK P6FfHOfaiGDaZLo5G7Syakuj6sPD4jx5rrJaT6ou9Ne38Z8JQnKquWUiXhqE/KpoZD+x zVbA== X-Gm-Message-State: AAQBX9einr7jyK+0B7EaNuLUJU3shFX6O3ywa1eXu3MpZW0fQP/HIOX8 SzwL/QHeaZft/cp7lGdrwMSyRKHl/qEmQJ6fqnM6medi82QQf/7vQEfmzYXz4Ru66BG+3lbME02 QlvLgdpcQRBibE2oTae9TlQeodoxEXP3GQ+voyZhNCiYz X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308541lfq.11.1681748725393; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+bsYZfdQ0YbXRNUdAiXrEC617Co8M6Ae9OYtGyQ7Z0JTehg+Oxteoxe+dPaIDFHLfU5sWj8/W0mxSAgomtgA= X-Received: by 2002:ac2:5dea:0:b0:4ec:e32f:3d1f with SMTP id z10-20020ac25dea000000b004ece32f3d1fmr2308529lfq.11.1681748725093; Mon, 17 Apr 2023 09:25:25 -0700 (PDT) MIME-Version: 1.0 References: <40c60719-4bfe-b1a4-ead7-724b84637f55@web.de> <1a11455f-ab57-dce0-1677-6beb8492a257@web.de> <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> In-Reply-To: <2a746461-844a-2ad6-7b52-03f13fe1b9bf@web.de> From: Karol Herbst Date: Mon, 17 Apr 2023 18:25:13 +0200 Message-ID: Subject: Re: [PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations To: Markus Elfring X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Ben Skeggs , cocci@inria.fr Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Apr 16, 2023 at 11:30=E2=80=AFAM Markus Elfring wrote: > > Date: Sun, 16 Apr 2023 11:22:23 +0200 > > Several update suggestions were taken into account > from static source code analysis. > Reviewed-by: Karol Herbst > Markus Elfring (9): > debugfs: Move an expression into a function call parameter > in nouveau_debugfs_pstate_set() > debugfs: Move a variable assignment behind a null pointer check > in nouveau_debugfs_pstate_get() > debugfs: Use seq_putc() > in nouveau_debugfs_pstate_get() > debugfs: Replace five seq_printf() calls by seq_puts() > in nouveau_debugfs_pstate_get() > power_budget: Move an expression into a macro call parameter > in nvbios_power_budget_header() > clk: Move a variable assignment behind a null pointer check > in nvkm_pstate_new() > pci: Move a variable assignment behind condition checks > in nvkm_pcie_set_link() > pci: Move an expression into a function call parameter > in nvkm_pcie_set_link() > therm: Move an assignment statement behind a null pointer check > in two functions > > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 19 ++++++++++--------- > .../nouveau/nvkm/subdev/bios/power_budget.c | 3 +-- > .../gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +- > .../gpu/drm/nouveau/nvkm/subdev/pci/pcie.c | 7 +++---- > .../drm/nouveau/nvkm/subdev/therm/fanpwm.c | 2 +- > .../drm/nouveau/nvkm/subdev/therm/fantog.c | 2 +- > 6 files changed, 17 insertions(+), 18 deletions(-) > > -- > 2.40.0 >