From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6752AC43460 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44EAF61246 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238835AbhDSLqq (ORCPT ); Mon, 19 Apr 2021 07:46:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21944 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233653AbhDSLqp (ORCPT ); Mon, 19 Apr 2021 07:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=GV5b9jgOPC6wyHw6L97sPQJ1K9s0dHlGDCdfs9aLhVycdXXr9qGdvvWO0qg0ZMi2+Bye65 SVod2wF3HcciilqSc+6P+GG20OY+WQ/m+ah1xdregCx9lV2IbXXyfgfH+2C0G9e2oaBiGW juE/yN84nX1hUZZg91ptzMsjO8m/OrA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-UQGv7nCgNn6_pQ-cn_t30g-1; Mon, 19 Apr 2021 07:46:13 -0400 X-MC-Unique: UQGv7nCgNn6_pQ-cn_t30g-1 Received: by mail-wr1-f69.google.com with SMTP id t14-20020a5d6a4e0000b029010277dcae0fso8885641wrw.22 for ; Mon, 19 Apr 2021 04:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=dMoP6gj0+i2taU+OboVKaKn/7M3DnQwk4MgWjzqqZY7w9kr91cs+YgtdzpzhobWLSA 5hmIN42n5j0v/9TG4wymTWKhORLzO0r3ZV/Pm/7Ro8Uw4QdSnAB/lHcW8NgUqkrVFp1q rVqMN9295POnCvXh/4NCG4UZYLPkE5YacXQ/zprZEMQJ0HGyKIrTHpn50sCw7Dkc7SB4 MZ7xTHX3IhMHzRco6FoL/vK0h6+KB7grwB626x4hEc4m+h6WUeu8yk4/6nm2eCXeiAOF 3JMfSYZY+onBYouFHHJpbA8HILs8CJmgzh5nb6PNl6cIwzQT4QO9cA0BsmsWTgzmzQcL 6t9A== X-Gm-Message-State: AOAM533ag6dw0n2cns3QJB4Sa8pkPzoA4jWKnaXDGMZ0r3qqFXW819kA HZgTuxhnxKKAFkoEsj4jTkYcSuY8lFdDhgUEfcefSCk+NQewnX8imgJeHnMZjflUPUF8g8nM+YV K1nCjPoqYvG5JCPeFb7c3nfxVzLksLatFcGFN7sgA X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220078wmf.163.1618832772824; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyc36e3XbifOKjDUWSKMAEVxvDyobteKY+iWwQTENq4j97KWY9GuD+Osi2UrIND/jrqWxZZjJydw+YBSnHR6jQ= X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220070wmf.163.1618832772716; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-11-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-11-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:46:02 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void To: Lee Jones Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 4:38 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c: In function =E2=80=98nv50_mstm_= cleanup=E2=80=99: > drivers/gpu/drm/nouveau/dispnv50/disp.c:1357:6: warning: variable =E2=80= =98ret=E2=80=99 set but not used [-Wunused-but-set-variable] > same comment here: we should really check if it's better to handle the error and report it back that something failed or so.. > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/no= uveau/dispnv50/disp.c > index 4801aafd9552b..351f954989530 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -1386,12 +1386,11 @@ nv50_mstm_cleanup(struct nv50_mstm *mstm) > { > struct nouveau_drm *drm =3D nouveau_drm(mstm->outp->base.base.dev= ); > struct drm_encoder *encoder; > - int ret; > > NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name); > - ret =3D drm_dp_check_act_status(&mstm->mgr); > + drm_dp_check_act_status(&mstm->mgr); > > - ret =3D drm_dp_update_payload_part2(&mstm->mgr); > + drm_dp_update_payload_part2(&mstm->mgr); > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > if (encoder->encoder_type =3D=3D DRM_MODE_ENCODER_DPMST) = { > -- > 2.27.0 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC27C43461 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38A7561166 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38A7561166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E06DC6E252; Mon, 19 Apr 2021 11:46:17 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99B906E252 for ; Mon, 19 Apr 2021 11:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=GV5b9jgOPC6wyHw6L97sPQJ1K9s0dHlGDCdfs9aLhVycdXXr9qGdvvWO0qg0ZMi2+Bye65 SVod2wF3HcciilqSc+6P+GG20OY+WQ/m+ah1xdregCx9lV2IbXXyfgfH+2C0G9e2oaBiGW juE/yN84nX1hUZZg91ptzMsjO8m/OrA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-JmrwEXPeOSOrijJODaOJhg-1; Mon, 19 Apr 2021 07:46:14 -0400 X-MC-Unique: JmrwEXPeOSOrijJODaOJhg-1 Received: by mail-wr1-f71.google.com with SMTP id d15-20020a5d538f0000b02901027c18c581so8853277wrv.3 for ; Mon, 19 Apr 2021 04:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=N0cN9G4noPQxF5LVmcLFMM0xFn6+gmHqsp9JnDclZ1uGMrkvfkSzJfWjHHmCE1qwcU qbPaG+emidUo/AjNSoC1Hg1aZsDP/ujJLRIQw4zapkRpI1+IbZruGGiwKdFxa9ufqTZg b9CNq+R0494sKk+Xq/aU/XF8YDAHuu20nZhEStNq2cOaBE7oMbauPSj8xg9nbWoSkfrs u3XU6F1W+Kz2EZGRcO3Zh74D2Sh991bxt5IFZcq12I6dYdUvTzftKO1UtLsm6eF/NYeQ vrWw/h9d/hvDcek6kV5b465Qo0G0qjTh3ECXJ+oibs2IWVs0lhj386W2PSnINNkFk6/j Es2A== X-Gm-Message-State: AOAM531br+NPomUAKBBVWh3LERQIsqOJ/7zxOdhw7OCiv4qP1BFAFh8v QLe0MJBHC9TttUnoMcYsRmnX6FaU4EaviB8cDQrpC/U6LMv46aiK7SFsVD09KBMVmM3ygIBgLXt /7/+qhg9iLIKmIPOtyzJoNwcqp7JkpYaoBeGuPnY0RQ== X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220082wmf.163.1618832772826; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyc36e3XbifOKjDUWSKMAEVxvDyobteKY+iWwQTENq4j97KWY9GuD+Osi2UrIND/jrqWxZZjJydw+YBSnHR6jQ= X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220070wmf.163.1618832772716; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-11-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-11-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:46:02 +0200 Message-ID: To: Lee Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" T24gRnJpLCBBcHIgMTYsIDIwMjEgYXQgNDozOCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzog SW4gZnVuY3Rpb24g4oCYbnY1MF9tc3RtX2NsZWFudXDigJk6Cj4gIGRyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzoxMzU3OjY6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJldOKA mSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+CgpzYW1lIGNv bW1lbnQgaGVyZTogd2Ugc2hvdWxkIHJlYWxseSBjaGVjayBpZiBpdCdzIGJldHRlciB0byBoYW5k bGUgdGhlCmVycm9yIGFuZCByZXBvcnQgaXQgYmFjayB0aGF0IHNvbWV0aGluZyBmYWlsZWQgb3Ig c28uLgoKPiBDYzogQmVuIFNrZWdncyA8YnNrZWdnc0ByZWRoYXQuY29tPgo+IENjOiBEYXZpZCBB aXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZnds bC5jaD4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBub3V2ZWF1 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpv bmVzQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUw L2Rpc3AuYyB8IDUgKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNw bnY1MC9kaXNwLmMgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiBp bmRleCA0ODAxYWFmZDk1NTJiLi4zNTFmOTU0OTg5NTMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYwo+IEBAIC0xMzg2LDEyICsxMzg2LDExIEBAIG52NTBfbXN0 bV9jbGVhbnVwKHN0cnVjdCBudjUwX21zdG0gKm1zdG0pCj4gIHsKPiAgICAgICAgIHN0cnVjdCBu b3V2ZWF1X2RybSAqZHJtID0gbm91dmVhdV9kcm0obXN0bS0+b3V0cC0+YmFzZS5iYXNlLmRldik7 Cj4gICAgICAgICBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gLSAgICAgICBpbnQgcmV0 Owo+Cj4gICAgICAgICBOVl9BVE9NSUMoZHJtLCAiJXM6IG1zdG0gY2xlYW51cFxuIiwgbXN0bS0+ b3V0cC0+YmFzZS5iYXNlLm5hbWUpOwo+IC0gICAgICAgcmV0ID0gZHJtX2RwX2NoZWNrX2FjdF9z dGF0dXMoJm1zdG0tPm1ncik7Cj4gKyAgICAgICBkcm1fZHBfY2hlY2tfYWN0X3N0YXR1cygmbXN0 bS0+bWdyKTsKPgo+IC0gICAgICAgcmV0ID0gZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQyKCZt c3RtLT5tZ3IpOwo+ICsgICAgICAgZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQyKCZtc3RtLT5t Z3IpOwo+Cj4gICAgICAgICBkcm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBtc3RtLT5vdXRw LT5iYXNlLmJhc2UuZGV2KSB7Cj4gICAgICAgICAgICAgICAgIGlmIChlbmNvZGVyLT5lbmNvZGVy X3R5cGUgPT0gRFJNX01PREVfRU5DT0RFUl9EUE1TVCkgewo+IC0tCj4gMi4yNy4wCj4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IE5vdXZlYXUgbWFp bGluZyBsaXN0Cj4gTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBsaXN0Ck5v dXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACCAC43462 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679FD61362 for ; Mon, 19 Apr 2021 11:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679FD61362 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D0656E24E; Mon, 19 Apr 2021 11:46:17 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87E5B6E24E for ; Mon, 19 Apr 2021 11:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=GV5b9jgOPC6wyHw6L97sPQJ1K9s0dHlGDCdfs9aLhVycdXXr9qGdvvWO0qg0ZMi2+Bye65 SVod2wF3HcciilqSc+6P+GG20OY+WQ/m+ah1xdregCx9lV2IbXXyfgfH+2C0G9e2oaBiGW juE/yN84nX1hUZZg91ptzMsjO8m/OrA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-O9XEQ1ZdOYyH7RqFyXVxCQ-1; Mon, 19 Apr 2021 07:46:13 -0400 X-MC-Unique: O9XEQ1ZdOYyH7RqFyXVxCQ-1 Received: by mail-wr1-f72.google.com with SMTP id l18-20020a0560000232b02901026f4b8548so8936831wrz.10 for ; Mon, 19 Apr 2021 04:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZNNDgS/DJt2QoriZuV2s4KpJFXyuczWKmKTdkPTzwJc=; b=mCT7YBOxsgYCssh5vQQEp3DIu8R/CudS9zNztPxP18t/5vvX5nVpyPPyQMbuI4e5Eb EhWCW2Reyo6fhBXvjiDzg8MVxWjBvuZyfi8W199vMqJIrxUxy8i2eqNR5MJEBxvwkroh iHJyYrRpygkZiVWOU8F51DxTPSQoS3wnpXdqS+sAWb77iLuoKOslt/ThbcWkoh6BkCxR 5yW0WqrW4xdXVRrTtIO1+ITb7Ggi5LTGjSeuJAFncOK9nyFkNroUq9E9QitdJe/MGcA6 waGk8EPPtCEHj+AKgTs9n+03d5K4dxHdl7+uUIkiLHMrcS6FzUt90DLSICPe1OjeHTGV m9AA== X-Gm-Message-State: AOAM5316+e+eugPpFFK3bLJirOUCQ6FkBt3XPq/1iE1qGE2Ks5m6sEbx J4lDyQnycxeCMCVdN0UbbwY2YSZB9ZgCIZeRhFJaVp2Jz2ygCK4Oxz/8Lg1lM8pfASkxkXz4MHl 1+HHPaMTXcodK6e2zSfuJHXXdVIlEpsqQ/ZCnRXjMjHbk X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220079wmf.163.1618832772824; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyc36e3XbifOKjDUWSKMAEVxvDyobteKY+iWwQTENq4j97KWY9GuD+Osi2UrIND/jrqWxZZjJydw+YBSnHR6jQ= X-Received: by 2002:a1c:b656:: with SMTP id g83mr21220070wmf.163.1618832772716; Mon, 19 Apr 2021 04:46:12 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-11-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-11-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:46:02 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void To: Lee Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBcHIgMTYsIDIwMjEgYXQgNDozOCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzog SW4gZnVuY3Rpb24g4oCYbnY1MF9tc3RtX2NsZWFudXDigJk6Cj4gIGRyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzoxMzU3OjY6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJldOKA mSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+CgpzYW1lIGNv bW1lbnQgaGVyZTogd2Ugc2hvdWxkIHJlYWxseSBjaGVjayBpZiBpdCdzIGJldHRlciB0byBoYW5k bGUgdGhlCmVycm9yIGFuZCByZXBvcnQgaXQgYmFjayB0aGF0IHNvbWV0aGluZyBmYWlsZWQgb3Ig c28uLgoKPiBDYzogQmVuIFNrZWdncyA8YnNrZWdnc0ByZWRoYXQuY29tPgo+IENjOiBEYXZpZCBB aXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZnds bC5jaD4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBub3V2ZWF1 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpv bmVzQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUw L2Rpc3AuYyB8IDUgKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNw bnY1MC9kaXNwLmMgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiBp bmRleCA0ODAxYWFmZDk1NTJiLi4zNTFmOTU0OTg5NTMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9u b3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYwo+IEBAIC0xMzg2LDEyICsxMzg2LDExIEBAIG52NTBfbXN0 bV9jbGVhbnVwKHN0cnVjdCBudjUwX21zdG0gKm1zdG0pCj4gIHsKPiAgICAgICAgIHN0cnVjdCBu b3V2ZWF1X2RybSAqZHJtID0gbm91dmVhdV9kcm0obXN0bS0+b3V0cC0+YmFzZS5iYXNlLmRldik7 Cj4gICAgICAgICBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gLSAgICAgICBpbnQgcmV0 Owo+Cj4gICAgICAgICBOVl9BVE9NSUMoZHJtLCAiJXM6IG1zdG0gY2xlYW51cFxuIiwgbXN0bS0+ b3V0cC0+YmFzZS5iYXNlLm5hbWUpOwo+IC0gICAgICAgcmV0ID0gZHJtX2RwX2NoZWNrX2FjdF9z dGF0dXMoJm1zdG0tPm1ncik7Cj4gKyAgICAgICBkcm1fZHBfY2hlY2tfYWN0X3N0YXR1cygmbXN0 bS0+bWdyKTsKPgo+IC0gICAgICAgcmV0ID0gZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQyKCZt c3RtLT5tZ3IpOwo+ICsgICAgICAgZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQyKCZtc3RtLT5t Z3IpOwo+Cj4gICAgICAgICBkcm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBtc3RtLT5vdXRw LT5iYXNlLmJhc2UuZGV2KSB7Cj4gICAgICAgICAgICAgICAgIGlmIChlbmNvZGVyLT5lbmNvZGVy X3R5cGUgPT0gRFJNX01PREVfRU5DT0RFUl9EUE1TVCkgewo+IC0tCj4gMi4yNy4wCj4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IE5vdXZlYXUgbWFp bGluZyBsaXN0Cj4gTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=