From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933A6C433B4 for ; Mon, 19 Apr 2021 11:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76CDD61166 for ; Mon, 19 Apr 2021 11:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238250AbhDSLnn (ORCPT ); Mon, 19 Apr 2021 07:43:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38468 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhDSLni (ORCPT ); Mon, 19 Apr 2021 07:43:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=dvOaGU3Xjwelx3vXo09K4YYf5HZxBiYt4QCGGFyPQrJmkpgqqpCaDVvALwBUhij3+Mv2PN mrWNCGFejujNXVFjp3fiGkW1JOezJQGzGlFE87l7aMmyz/rZBAQyBukVWHYI0A8mIBHp/8 lpFqcLhE0Lu3Mdbu16PxnykNP3RHypI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-63bsHF2fO9SlcUIZJb7FVQ-1; Mon, 19 Apr 2021 07:43:05 -0400 X-MC-Unique: 63bsHF2fO9SlcUIZJb7FVQ-1 Received: by mail-wr1-f69.google.com with SMTP id h3-20020adfa4c30000b02901027da44a81so8852820wrb.19 for ; Mon, 19 Apr 2021 04:43:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=hr+i9lb2eB+VazIWwZscivIbEDkj4VScBQSusLGSf5m5wmN41DZ1dgVNjGP1C8ERVg 2sqUlViOuFulCwhwvOzex35R3y44khmWLomkflgLbg3kQQXQPNC511wz8F7eUYVTDTNJ jvbxXM21sNJts1hf1RZXS0C1Lva5udA0F34z8I5PSvhcvmYO2uALnZm3X5WozkEKpCwD j022SoXdqCiKAEuDye82K+XlcpkbN/o1irleXWTw+omXIi6RENdHIf1TnrnUQj5o+3Rl sMRjb+OMiDWs//P/lIt6clhnhu7VoTDkq/fiFc99ZXDNp4Ql+jq3NOmFWokevix7u5Br +LHQ== X-Gm-Message-State: AOAM5329qWWA7KooywHBS8WOZiwiqarEYOBWdqscqEQr0V0TNGKqScD/ nRdPpVUGDAR4V8ABKN3/DcJM8Hw8BdsHxzeh+hvWjAWBX/+0+Krjg2vUkFz2ze47pcLT17L/2gP gagNXGTRA1jUojj0gOG1UF4tbo1RMCBp9UUGeM/kd X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538358wrd.177.1618832584174; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfQUBy2vieiz4RATYX7I0oL2DB8pFKAjVreQXmtZ/buDJbNPRvIUWMiZeyhXngE0AQn6P4cMUuzFKThM/G5Hg= X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538343wrd.177.1618832584067; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-3-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-3-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:42:53 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' To: Lee Jones Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 16, 2021 at 4:37 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable =E2=80= =98ret=E2=80=99 set but not used [-Wunused-but-set-variable] > not a big fan of just ignoring return codes, I'd rather see it handled somehow, unless somebody knowing more about the details here says it's okay. > Cc: Ben Skeggs > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/no= uveau/dispnv50/disp.c > index 1c9c0cdf85dbc..4801aafd9552b 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c > @@ -1410,10 +1410,9 @@ nv50_mstm_prepare(struct nv50_mstm *mstm) > { > struct nouveau_drm *drm =3D nouveau_drm(mstm->outp->base.base.dev= ); > struct drm_encoder *encoder; > - int ret; > > NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name); > - ret =3D drm_dp_update_payload_part1(&mstm->mgr); > + drm_dp_update_payload_part1(&mstm->mgr); > > drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { > if (encoder->encoder_type =3D=3D DRM_MODE_ENCODER_DPMST) = { > -- > 2.27.0 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AF3C433B4 for ; Mon, 19 Apr 2021 11:43:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9B20611CE for ; Mon, 19 Apr 2021 11:43:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9B20611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7496588ED6; Mon, 19 Apr 2021 11:43:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 744756E214 for ; Mon, 19 Apr 2021 11:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=dvOaGU3Xjwelx3vXo09K4YYf5HZxBiYt4QCGGFyPQrJmkpgqqpCaDVvALwBUhij3+Mv2PN mrWNCGFejujNXVFjp3fiGkW1JOezJQGzGlFE87l7aMmyz/rZBAQyBukVWHYI0A8mIBHp/8 lpFqcLhE0Lu3Mdbu16PxnykNP3RHypI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-_u1PDmCuMHWkqXO5jclwtg-1; Mon, 19 Apr 2021 07:43:05 -0400 X-MC-Unique: _u1PDmCuMHWkqXO5jclwtg-1 Received: by mail-wr1-f71.google.com with SMTP id p10-20020a5d68ca0000b0290102982b78eeso8938765wrw.16 for ; Mon, 19 Apr 2021 04:43:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=DjB/u/R+HpehD7IcKyCPCzORVrW7GMIio2czagdYS4H50tzaWZCbG+6B4g9sBoB4Ck 9Juab+kmzC+zMCTfeP4k7oNyFhWvmPHXalq178LDDq6VQ/RmGNEArufpvuQ2vRMx5ioi JAfxTDopaMzk6+VwMfadmBLHfu0Ja3sp70EQCRBgGiaEnLXpVEb+3P7vQUKoQymbH2X3 irp3Aw5SLRT+D/7LXjerYjlQlUwLshzXAvxf9i5s8TvCUJZx2gs3LdyblJzWBolKvCuT MZ2YL6+E2aUbitAK7zSRN4jDM3qoBhhTk54/WvFBblfVE0QzGGhzZHi+AshPLT1X+ppU y59A== X-Gm-Message-State: AOAM532v41dqigFllYKJYtYQ2CPdWOqMjXm4L0MVn/cetXSxpXw4KnxG iLThy5sw8PF3JhH6o0zm3jVyy5sJJdgl6XABKd8whGIkvp8wQaSxrhhHUODZ0/D7Cl0+4iGhi3X +MVfNoxPuPF0oyKjNvUvpCZm2WgG8qYG4T0kBR4vA1A== X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538359wrd.177.1618832584174; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfQUBy2vieiz4RATYX7I0oL2DB8pFKAjVreQXmtZ/buDJbNPRvIUWMiZeyhXngE0AQn6P4cMUuzFKThM/G5Hg= X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538343wrd.177.1618832584067; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-3-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-3-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:42:53 +0200 Message-ID: To: Lee Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Nouveau] [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" T24gRnJpLCBBcHIgMTYsIDIwMjEgYXQgNDozNyBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzox MzgxOjY6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJldOKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3Vu dXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+Cgpub3QgYSBiaWcgZmFuIG9mIGp1c3QgaWdub3Jpbmcg cmV0dXJuIGNvZGVzLCBJJ2QgcmF0aGVyIHNlZSBpdCBoYW5kbGVkCnNvbWVob3csIHVubGVzcyBz b21lYm9keSBrbm93aW5nIG1vcmUgYWJvdXQgdGhlIGRldGFpbHMgaGVyZSBzYXlzIGl0J3MKb2th eS4KCj4gQ2M6IEJlbiBTa2VnZ3MgPGJza2VnZ3NAcmVkaGF0LmNvbT4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogbm91dmVhdUBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9k aXNwLmMgfCAzICstLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAv ZGlzcC5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAvZGlzcC5jCj4gaW5kZXgg MWM5YzBjZGY4NWRiYy4uNDgwMWFhZmQ5NTUyYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVh dS9kaXNwbnY1MC9kaXNwLmMKPiBAQCAtMTQxMCwxMCArMTQxMCw5IEBAIG52NTBfbXN0bV9wcmVw YXJlKHN0cnVjdCBudjUwX21zdG0gKm1zdG0pCj4gIHsKPiAgICAgICAgIHN0cnVjdCBub3V2ZWF1 X2RybSAqZHJtID0gbm91dmVhdV9kcm0obXN0bS0+b3V0cC0+YmFzZS5iYXNlLmRldik7Cj4gICAg ICAgICBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gLSAgICAgICBpbnQgcmV0Owo+Cj4g ICAgICAgICBOVl9BVE9NSUMoZHJtLCAiJXM6IG1zdG0gcHJlcGFyZVxuIiwgbXN0bS0+b3V0cC0+ YmFzZS5iYXNlLm5hbWUpOwo+IC0gICAgICAgcmV0ID0gZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3Bh cnQxKCZtc3RtLT5tZ3IpOwo+ICsgICAgICAgZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQxKCZt c3RtLT5tZ3IpOwo+Cj4gICAgICAgICBkcm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBtc3Rt LT5vdXRwLT5iYXNlLmJhc2UuZGV2KSB7Cj4gICAgICAgICAgICAgICAgIGlmIChlbmNvZGVyLT5l bmNvZGVyX3R5cGUgPT0gRFJNX01PREVfRU5DT0RFUl9EUE1TVCkgewo+IC0tCj4gMi4yNy4wCj4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IE5vdXZl YXUgbWFpbGluZyBsaXN0Cj4gTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5vdXZlYXUgbWFpbGluZyBs aXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C2CC433ED for ; Mon, 19 Apr 2021 11:43:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85E9061166 for ; Mon, 19 Apr 2021 11:43:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85E9061166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D36D26E241; Mon, 19 Apr 2021 11:43:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEA8A6E241 for ; Mon, 19 Apr 2021 11:43:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618832588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=dvOaGU3Xjwelx3vXo09K4YYf5HZxBiYt4QCGGFyPQrJmkpgqqpCaDVvALwBUhij3+Mv2PN mrWNCGFejujNXVFjp3fiGkW1JOezJQGzGlFE87l7aMmyz/rZBAQyBukVWHYI0A8mIBHp/8 lpFqcLhE0Lu3Mdbu16PxnykNP3RHypI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-3bJocYFbMU66JFFFA2eJpg-1; Mon, 19 Apr 2021 07:43:05 -0400 X-MC-Unique: 3bJocYFbMU66JFFFA2eJpg-1 Received: by mail-wm1-f69.google.com with SMTP id x20-20020a7bc2140000b029012bb4d2b5d6so4480459wmi.1 for ; Mon, 19 Apr 2021 04:43:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C8Y5CVyN1MP/Z8t2JSwEW5URSTlMomMVuaaYfv0oBM0=; b=TRRmbOl1PYvf6JfejKuopvMrzGl/XKUf5KfzwCcxF3A//yhbWX1r9DARaup6E5uFnF 7UQA2BvvyD+IlnK/bcRGW5iVYDi6zVnqjqIToZ1TbMoBjXrOdvkWlZ9Hx5QPmB53JnqG exOKy2yy53OfNuwmJurdLi1LUOJC1IITVxf0vpIv4sQ1dndFZLd9QXZujHONMg0klHHM Uke3UPj2sLofYKM0xZeI9bq7lO5ieU2t1j6ZV4GeNvPLVXEHOOz/VSZtMhVXUKDlPfMZ 9XfFzbOSxrWX3FumkhmEDzCbAau2gTms2fgV8IeTHZbW69XSmVOl+9xsiYSPX5NreFu0 P6nw== X-Gm-Message-State: AOAM5310Hl0LDo+5kKwp6r3CMpVO3Dml/aiGx5WdB/KXaswh9xVAfwST piFVxaqej1UZsP2dr1qKyD0ZUq3/sw3PQLR5biDpn4B1d3B3x8oBacKBfGPd+cTjx9tGsvs849o m84eBM0+ZoEBy8u5jB46txCIR9LIxzhyZS9Q0x89R2rZ6 X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538366wrd.177.1618832584262; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfQUBy2vieiz4RATYX7I0oL2DB8pFKAjVreQXmtZ/buDJbNPRvIUWMiZeyhXngE0AQn6P4cMUuzFKThM/G5Hg= X-Received: by 2002:a5d:58fa:: with SMTP id f26mr13538343wrd.177.1618832584067; Mon, 19 Apr 2021 04:43:04 -0700 (PDT) MIME-Version: 1.0 References: <20210416143725.2769053-1-lee.jones@linaro.org> <20210416143725.2769053-3-lee.jones@linaro.org> In-Reply-To: <20210416143725.2769053-3-lee.jones@linaro.org> From: Karol Herbst Date: Mon, 19 Apr 2021 13:42:53 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' To: Lee Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBcHIgMTYsIDIwMjEgYXQgNDozNyBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L2Rpc3BudjUwL2Rpc3AuYzox MzgxOjY6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHJldOKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3Vu dXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+Cgpub3QgYSBiaWcgZmFuIG9mIGp1c3QgaWdub3Jpbmcg cmV0dXJuIGNvZGVzLCBJJ2QgcmF0aGVyIHNlZSBpdCBoYW5kbGVkCnNvbWVob3csIHVubGVzcyBz b21lYm9keSBrbm93aW5nIG1vcmUgYWJvdXQgdGhlIGRldGFpbHMgaGVyZSBzYXlzIGl0J3MKb2th eS4KCj4gQ2M6IEJlbiBTa2VnZ3MgPGJza2VnZ3NAcmVkaGF0LmNvbT4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogbm91dmVhdUBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9kaXNwbnY1MC9k aXNwLmMgfCAzICstLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAv ZGlzcC5jIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvZGlzcG52NTAvZGlzcC5jCj4gaW5kZXgg MWM5YzBjZGY4NWRiYy4uNDgwMWFhZmQ5NTUyYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vbm91dmVhdS9kaXNwbnY1MC9kaXNwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVh dS9kaXNwbnY1MC9kaXNwLmMKPiBAQCAtMTQxMCwxMCArMTQxMCw5IEBAIG52NTBfbXN0bV9wcmVw YXJlKHN0cnVjdCBudjUwX21zdG0gKm1zdG0pCj4gIHsKPiAgICAgICAgIHN0cnVjdCBub3V2ZWF1 X2RybSAqZHJtID0gbm91dmVhdV9kcm0obXN0bS0+b3V0cC0+YmFzZS5iYXNlLmRldik7Cj4gICAg ICAgICBzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gLSAgICAgICBpbnQgcmV0Owo+Cj4g ICAgICAgICBOVl9BVE9NSUMoZHJtLCAiJXM6IG1zdG0gcHJlcGFyZVxuIiwgbXN0bS0+b3V0cC0+ YmFzZS5iYXNlLm5hbWUpOwo+IC0gICAgICAgcmV0ID0gZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3Bh cnQxKCZtc3RtLT5tZ3IpOwo+ICsgICAgICAgZHJtX2RwX3VwZGF0ZV9wYXlsb2FkX3BhcnQxKCZt c3RtLT5tZ3IpOwo+Cj4gICAgICAgICBkcm1fZm9yX2VhY2hfZW5jb2RlcihlbmNvZGVyLCBtc3Rt LT5vdXRwLT5iYXNlLmJhc2UuZGV2KSB7Cj4gICAgICAgICAgICAgICAgIGlmIChlbmNvZGVyLT5l bmNvZGVyX3R5cGUgPT0gRFJNX01PREVfRU5DT0RFUl9EUE1TVCkgewo+IC0tCj4gMi4yNy4wCj4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IE5vdXZl YXUgbWFpbGluZyBsaXN0Cj4gTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=