From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79414C432C0 for ; Fri, 22 Nov 2019 11:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5062420674 for ; Fri, 22 Nov 2019 11:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="am0gFJ8o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbfKVLbP (ORCPT ); Fri, 22 Nov 2019 06:31:15 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:30247 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726417AbfKVLbO (ORCPT ); Fri, 22 Nov 2019 06:31:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574422273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fk7+9wRBOnitbINGrkgws0BRV6i2F3wIBf4jxMH1Ew8=; b=am0gFJ8oeeamkBk6LbGJJjIR16i4lD2AgkGK/Lew+mQJu3LeF0QjX6EedNCirWm1GcTCpN +r0+Wp+OShB7sFTxB2hFN280xwYt5/5tz3phIZ0YCwEzZsArAgOndBUz0KE5CeaoFf0l5/ hooHNre2ZCJbLrwGTKvPwP7W4hKHQWM= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-SgPYKJRZPECIjFEnqzMu7A-1; Fri, 22 Nov 2019 06:31:04 -0500 Received: by mail-qk1-f198.google.com with SMTP id q125so4125610qka.1 for ; Fri, 22 Nov 2019 03:31:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aur9rsWegbHLh3oY6ky2CGYiseXs+N84XUMnQYfdl6g=; b=g0d7x3X+kH3EO6ndr68V1fdyWmKM9/vWdjs4tS1D/nE1P4HCaWTYcLsWTLDU99Nrl5 8ob8sE623q46ys0CLilW9JWvlImwM32QMZV0O3nWX36Q+24VhvvCgz2EB/v++SBdt4d+ 5XoZ5JcFnpoTtx7k5wxq3t73V9f9ZVjDdASI3JhSwrmnDEElMIcVSuGC3JKebO5LVS7p oQ8Yuxl7vWvupS3+A0UoSW7KP96CmD1FieWplMjNSGSoTl/fLG2xbKdEtqwzEBVFhnnH 7pOqbvRXlqMv3HARBL82hU5BqYRKxfJ2CZYc9eaSCaACPuMiX0SMOnrOvoCflT81Y9Hr NaeQ== X-Gm-Message-State: APjAAAX73H8BowJ1YAH2uoam4K28830JQqLX/NpMfbfO5qEJktsxrXaE eJpirp9z8of4Gpls6qjlgN1T7swMYdH5XVHJUyR4xd4zLexSS3jas5Po6URYbkAz7ODsNKkbleQ vVeJqF44lbLUTRlWWvcZRm6QvA/XZ3iwjdkbF5MVA X-Received: by 2002:ac8:5557:: with SMTP id o23mr13894108qtr.378.1574422264297; Fri, 22 Nov 2019 03:31:04 -0800 (PST) X-Google-Smtp-Source: APXvYqz4tUnanEcz7OF5qm09oSIPeTrgesqROQcAYMdb3VQX3IrvgvC0XjOQgTAq+ByslNwLSUis/BX58JFkAfiwgdw= X-Received: by 2002:ac8:5557:: with SMTP id o23mr13894072qtr.378.1574422264060; Fri, 22 Nov 2019 03:31:04 -0800 (PST) MIME-Version: 1.0 References: <20191120155301.GL11621@lahna.fi.intel.com> <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191121125236.GX11621@lahna.fi.intel.com> <20191121194942.GY11621@lahna.fi.intel.com> In-Reply-To: From: Karol Herbst Date: Fri, 22 Nov 2019 12:30:52 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: "Rafael J. Wysocki" Cc: Mika Westerberg , Bjorn Helgaas , LKML , Lyude Paul , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello X-MC-Unique: SgPYKJRZPECIjFEnqzMu7A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2019 at 10:07 AM Rafael J. Wysocki wrot= e: > > On Fri, Nov 22, 2019 at 1:13 AM Karol Herbst wrote: > > > > so while trying to test with d3cold disabled, I noticed that I run > > into the exact same error. > > Does this mean that you disabled d3cold on the GPU via sysfs (the > "d3cold_allowed" attribute was 0) and the original problem still > occurred in that configuration? > yes. In my previous testing I was poking into the PCI registers of the bridge controller and the GPU directly and that never caused any issues as long as I limited it to putting the devices into D3hot. > > And I verified that the > > \_SB.PCI0.PEG0.PG00._STA returns 1, which indicates it should still be > > turned on. > > I don't really understand this comment, so can you explain it a bit to > me, please? > that's the ACPI method to fetch the "status" of the power resource, it should return 0 when the device was powered off (the GPU) and 1 otherwise. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karol Herbst Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Fri, 22 Nov 2019 12:30:52 +0100 Message-ID: References: <20191120155301.GL11621@lahna.fi.intel.com> <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191121125236.GX11621@lahna.fi.intel.com> <20191121194942.GY11621@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: "Rafael J. Wysocki" Cc: Linux PM , Linux PCI , Mika Westerberg , Mario Limonciello , "Rafael J . Wysocki" , LKML , dri-devel , Bjorn Helgaas , nouveau List-Id: nouveau.vger.kernel.org T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMTA6MDcgQU0gUmFmYWVsIEouIFd5c29ja2kgPHJhZmFl bEBrZXJuZWwub3JnPiB3cm90ZToKPgo+IE9uIEZyaSwgTm92IDIyLCAyMDE5IGF0IDE6MTMgQU0g S2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IHNvIHdoaWxl IHRyeWluZyB0byB0ZXN0IHdpdGggZDNjb2xkIGRpc2FibGVkLCBJIG5vdGljZWQgdGhhdCBJIHJ1 bgo+ID4gaW50byB0aGUgZXhhY3Qgc2FtZSBlcnJvci4KPgo+IERvZXMgdGhpcyBtZWFuIHRoYXQg eW91IGRpc2FibGVkIGQzY29sZCBvbiB0aGUgR1BVIHZpYSBzeXNmcyAodGhlCj4gImQzY29sZF9h bGxvd2VkIiBhdHRyaWJ1dGUgd2FzIDApIGFuZCB0aGUgb3JpZ2luYWwgcHJvYmxlbSBzdGlsbAo+ IG9jY3VycmVkIGluIHRoYXQgY29uZmlndXJhdGlvbj8KPgoKeWVzLiBJbiBteSBwcmV2aW91cyB0 ZXN0aW5nIEkgd2FzIHBva2luZyBpbnRvIHRoZSBQQ0kgcmVnaXN0ZXJzIG9mIHRoZQpicmlkZ2Ug Y29udHJvbGxlciBhbmQgdGhlIEdQVSBkaXJlY3RseSBhbmQgdGhhdCBuZXZlciBjYXVzZWQgYW55 Cmlzc3VlcyBhcyBsb25nIGFzIEkgbGltaXRlZCBpdCB0byBwdXR0aW5nIHRoZSBkZXZpY2VzIGlu dG8gRDNob3QuCgo+ID4gQW5kIEkgdmVyaWZpZWQgdGhhdCB0aGUKPiA+IFxfU0IuUENJMC5QRUcw LlBHMDAuX1NUQSByZXR1cm5zIDEsIHdoaWNoIGluZGljYXRlcyBpdCBzaG91bGQgc3RpbGwgYmUK PiA+IHR1cm5lZCBvbi4KPgo+IEkgZG9uJ3QgcmVhbGx5IHVuZGVyc3RhbmQgdGhpcyBjb21tZW50 LCBzbyBjYW4geW91IGV4cGxhaW4gaXQgYSBiaXQgdG8KPiBtZSwgcGxlYXNlPwo+Cgp0aGF0J3Mg dGhlIEFDUEkgbWV0aG9kIHRvIGZldGNoIHRoZSAic3RhdHVzIiBvZiB0aGUgcG93ZXIgcmVzb3Vy Y2UsIGl0CnNob3VsZCByZXR1cm4gMCB3aGVuIHRoZSBkZXZpY2Ugd2FzIHBvd2VyZWQgb2ZmICh0 aGUgR1BVKSBhbmQgMQpvdGhlcndpc2UuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L25vdXZlYXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405B3C432C0 for ; Fri, 22 Nov 2019 11:31:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AF8E20679 for ; Fri, 22 Nov 2019 11:31:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF8E20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 92C0C6F52F; Fri, 22 Nov 2019 11:31:12 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 463996F531 for ; Fri, 22 Nov 2019 11:31:11 +0000 (UTC) Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-UJ9MdNhLNtyRE04btTG3PA-1; Fri, 22 Nov 2019 06:31:04 -0500 Received: by mail-qv1-f70.google.com with SMTP id b1so4498293qvm.0 for ; Fri, 22 Nov 2019 03:31:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aur9rsWegbHLh3oY6ky2CGYiseXs+N84XUMnQYfdl6g=; b=rIAU+WePowbZUh5SgZOt8Xd8qyePXpAa5jcI/kfQdu/A+gcaItwpvHZijtPdpu10u+ FTUaKvj/MDk1v2/QvNWtp7HvHEhocindJkXPFl8PPQ7CGM7GFCTGUVRDllMyvXHAwTK6 RP26lmnGz8Kv8H4f4sqQu1m23YvWzK2SAqe/+i/PRyxJUoK3s6crZGk1FCi51Xa1JMSF 2T01zmaiMqPq3ocOH1d6OE2KSSLwrslT69N/9nHhNcKdX3jDb68PfTusEaW7agrNhtgN 4KuAh0CjODemxF8TlbrtE28HedxPa60lJkhgEmug7gLajwJpxigy3nHjZVprEJdjxHkI VSHA== X-Gm-Message-State: APjAAAVmtytie/G9K/0GHsxM+MdX07BS73S1P/SkLscvUiwjjQoa5Efh +nUcwb7U8MHkRIWnB8KHRGC7X9BzoGaS0fwUXPHR3bBuw/S8nR8ypiQLtkvl03csbm1oZRO6C0o biOKkJTvk6LikBbw8k85aiYvg6lbJ5RYhMXl8d+amcSvj X-Received: by 2002:ac8:5557:: with SMTP id o23mr13894112qtr.378.1574422264298; Fri, 22 Nov 2019 03:31:04 -0800 (PST) X-Google-Smtp-Source: APXvYqz4tUnanEcz7OF5qm09oSIPeTrgesqROQcAYMdb3VQX3IrvgvC0XjOQgTAq+ByslNwLSUis/BX58JFkAfiwgdw= X-Received: by 2002:ac8:5557:: with SMTP id o23mr13894072qtr.378.1574422264060; Fri, 22 Nov 2019 03:31:04 -0800 (PST) MIME-Version: 1.0 References: <20191120155301.GL11621@lahna.fi.intel.com> <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191121125236.GX11621@lahna.fi.intel.com> <20191121194942.GY11621@lahna.fi.intel.com> In-Reply-To: From: Karol Herbst Date: Fri, 22 Nov 2019 12:30:52 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: "Rafael J. Wysocki" X-MC-Unique: UJ9MdNhLNtyRE04btTG3PA-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574422270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fk7+9wRBOnitbINGrkgws0BRV6i2F3wIBf4jxMH1Ew8=; b=PjU/zwZcbUKB3DZyMu/Ouatzj4jkGDoKDh41bHxvRRkyCr5UbkrcPuTeN+NVTopyVNAhno Q6MsdizMQkULvYniLD0khvXZIT+06MoKMpMiCFcEDAA8l/VgU5p8Q56eMTOknNaECMYdDy ixYPZN3drhhi0dRntEYvH3GqbuoOUGE= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux PM , Linux PCI , Mika Westerberg , Mario Limonciello , "Rafael J . Wysocki" , LKML , dri-devel , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191122113052.zqHgAX-iGXcNncokQGvqWbKhJaqGSWhM72wOH2UPD9Q@z> T24gRnJpLCBOb3YgMjIsIDIwMTkgYXQgMTA6MDcgQU0gUmFmYWVsIEouIFd5c29ja2kgPHJhZmFl bEBrZXJuZWwub3JnPiB3cm90ZToKPgo+IE9uIEZyaSwgTm92IDIyLCAyMDE5IGF0IDE6MTMgQU0g S2Fyb2wgSGVyYnN0IDxraGVyYnN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IHNvIHdoaWxl IHRyeWluZyB0byB0ZXN0IHdpdGggZDNjb2xkIGRpc2FibGVkLCBJIG5vdGljZWQgdGhhdCBJIHJ1 bgo+ID4gaW50byB0aGUgZXhhY3Qgc2FtZSBlcnJvci4KPgo+IERvZXMgdGhpcyBtZWFuIHRoYXQg eW91IGRpc2FibGVkIGQzY29sZCBvbiB0aGUgR1BVIHZpYSBzeXNmcyAodGhlCj4gImQzY29sZF9h bGxvd2VkIiBhdHRyaWJ1dGUgd2FzIDApIGFuZCB0aGUgb3JpZ2luYWwgcHJvYmxlbSBzdGlsbAo+ IG9jY3VycmVkIGluIHRoYXQgY29uZmlndXJhdGlvbj8KPgoKeWVzLiBJbiBteSBwcmV2aW91cyB0 ZXN0aW5nIEkgd2FzIHBva2luZyBpbnRvIHRoZSBQQ0kgcmVnaXN0ZXJzIG9mIHRoZQpicmlkZ2Ug Y29udHJvbGxlciBhbmQgdGhlIEdQVSBkaXJlY3RseSBhbmQgdGhhdCBuZXZlciBjYXVzZWQgYW55 Cmlzc3VlcyBhcyBsb25nIGFzIEkgbGltaXRlZCBpdCB0byBwdXR0aW5nIHRoZSBkZXZpY2VzIGlu dG8gRDNob3QuCgo+ID4gQW5kIEkgdmVyaWZpZWQgdGhhdCB0aGUKPiA+IFxfU0IuUENJMC5QRUcw LlBHMDAuX1NUQSByZXR1cm5zIDEsIHdoaWNoIGluZGljYXRlcyBpdCBzaG91bGQgc3RpbGwgYmUK PiA+IHR1cm5lZCBvbi4KPgo+IEkgZG9uJ3QgcmVhbGx5IHVuZGVyc3RhbmQgdGhpcyBjb21tZW50 LCBzbyBjYW4geW91IGV4cGxhaW4gaXQgYSBiaXQgdG8KPiBtZSwgcGxlYXNlPwo+Cgp0aGF0J3Mg dGhlIEFDUEkgbWV0aG9kIHRvIGZldGNoIHRoZSAic3RhdHVzIiBvZiB0aGUgcG93ZXIgcmVzb3Vy Y2UsIGl0CnNob3VsZCByZXR1cm4gMCB3aGVuIHRoZSBkZXZpY2Ugd2FzIHBvd2VyZWQgb2ZmICh0 aGUgR1BVKSBhbmQgMQpvdGhlcndpc2UuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWw=