From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB27C4708F for ; Wed, 2 Jun 2021 00:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9181613CC for ; Wed, 2 Jun 2021 00:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235476AbhFBAMc (ORCPT ); Tue, 1 Jun 2021 20:12:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43561 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235491AbhFBAMP (ORCPT ); Tue, 1 Jun 2021 20:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622592633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=gHzuf6Hw2lU19oYQ5/H0pQmCLiFaNJ4IdTE86ya3ezqiXE8RewfmzAnbwtIlLzGb3tjtL/ hx0Wk6x7e/8aoy7irkgxFDmtdO3uxpB1+t66PaHXhMNfGLOxTx5POCN0aXOBhd/JMsWtv+ PcUp2PriRFBW24O5t+X7zh1PCx+Weg8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-UFLtpwN_MTmP5N7pCWkR3w-1; Tue, 01 Jun 2021 20:10:31 -0400 X-MC-Unique: UFLtpwN_MTmP5N7pCWkR3w-1 Received: by mail-wm1-f70.google.com with SMTP id r15-20020a05600c35cfb029017cc4b1e9faso1506967wmq.8 for ; Tue, 01 Jun 2021 17:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=nwlgrrDROLDcX/ktoD6PbHDi01R7FFQDC5AZjoNN+4kkFv9NbC+YIB9SJHrhmCpair dn8OibDqGF83rUNy2x0TU4mAF+U8swEVcpGhrGUgTaNSP1rRb1dn9KjAVvBvBXfrHkbi BlCBCtFuNQs1xjd6vRBsUdndpwHbs54ZQJWBzZe4Du+5vJZhmwEiuviPKS/0uBDvg7kE MTqh5SsmAJY8KnMpZeF0DVy85Pehzxl8JvGIlqsiYL13WHh5nhXWjNlfea7mXPW8L3aw Guo709waqW6cLiqQkk8Ikc1lp/zHHAmXuHU/jqtWLx+UZ9qzJ9DHnQqx0y/nd5oGvc/8 9m2Q== X-Gm-Message-State: AOAM532do1dXrGncipdKf7pzgT0muBp8rb5af4wUynt/wrN+mVVFsYWU FAD82zYpyEj/Dq7sHe+/0le3lzOmKLyOjlsAiKvWyA8gda88w5tYHwdSJvM1I+3VGrf2f8YEDds /3XgyM4l1JmE23mlb3bYTqhW/18vsAyA4irPvzshM X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763243wrm.177.1622592629521; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7ytifh8Tq7X7nnucf7aYm2Vw3csWvxa0+c2QJbbdpuaVNF93Pvls4Lv1rmxm1PeJU5y+Ay/NirV8hdJrDSY= X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763219wrm.177.1622592629297; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20210305095657.GA142006@embeddedor> <79ff569a-5828-ef21-538b-12d07d34a4ff@embeddedor.com> <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> In-Reply-To: <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> From: Karol Herbst Date: Wed, 2 Jun 2021 02:10:18 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Cc: "Gustavo A. R. Silva" , Ben Skeggs , David Airlie , Daniel Vetter , Kees Cook , nouveau , LKML , dri-devel , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01123C4708F for ; Wed, 2 Jun 2021 00:10:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFA7D613CD for ; Wed, 2 Jun 2021 00:10:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFA7D613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71D486E2D5; Wed, 2 Jun 2021 00:10:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17E096EB3D for ; Wed, 2 Jun 2021 00:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622592634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=ZCSLw/lyvlQACVz8Hr6sOBefF39Tz+PZebRYr8i/WAZZWDD8I3teL6OusznVFkOpZHBQ/G ybbXxN/4GM1J7G0t4CKVj5rrEIta/fUyne3LLgZ5lhKPz/WLVaYukAqnm2PNJOIJ99QfhF S9aFIWzskRlJziD74aL8Q7G1HBE67dw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-W5N6uAKIP0C-RGL1V8InmQ-1; Tue, 01 Jun 2021 20:10:31 -0400 X-MC-Unique: W5N6uAKIP0C-RGL1V8InmQ-1 Received: by mail-wm1-f69.google.com with SMTP id 18-20020a05600c0252b029019a0ce35d36so1512088wmj.4 for ; Tue, 01 Jun 2021 17:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=pnwlcmOgCGecDVzd07K50S4JaskgxpJWHdAYkaD6sWeaSEATe7Pt3+9cgrEQ+a94NT Jfjax73NwL6vvONt2szumacolmGAJiTI9mX20eSd+QJ7ixWqVJX/5bLOX24kxhZw4FII amWD30EGIU8Pm77wPwJu/KKxM1yC3OVNsQxB1Y4+iOuegIw+o5SqS85I12vgJhkITZ7D GGykwGTGHKdNAQog8saDdxRJb2ZkYMzbJxKqdcBQN2Kg6/XuY0ciQ8MTuFS17+0NW3fX 1hEgCXI4KpNS9eMMoHOE6GMZSkR7ejs/ow8s4nJqp7SA0XMppWImV1k2yRB51ZnnQoHm I8Cg== X-Gm-Message-State: AOAM533+Eo1HjpLlOzmNfZLfAqCY/zvmdzzFuJyI3VAlpwDNYh1jyOnf rnvNQs40hDQkU22AufG7pMWfpgWCcyEDHYdTx2D7j3viJH+zhYyGRy3cFkW4s82eqkjh6MTd1Gp XkbZZFhfVA5OWN1IdCZc2uHvWdba4AXCuBe3aRCdWmg== X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763240wrm.177.1622592629494; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7ytifh8Tq7X7nnucf7aYm2Vw3csWvxa0+c2QJbbdpuaVNF93Pvls4Lv1rmxm1PeJU5y+Ay/NirV8hdJrDSY= X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763219wrm.177.1622592629297; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20210305095657.GA142006@embeddedor> <79ff569a-5828-ef21-538b-12d07d34a4ff@embeddedor.com> <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> In-Reply-To: <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> From: Karol Herbst Date: Wed, 2 Jun 2021 02:10:18 +0200 Message-ID: To: "Gustavo A. R. Silva" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , David Airlie , nouveau , "Gustavo A. R. Silva" , dri-devel , LKML , Ben Skeggs , Daniel Vetter , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B24C4708F for ; Wed, 2 Jun 2021 00:10:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C39F4613BD for ; Wed, 2 Jun 2021 00:10:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C39F4613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 432A06E2A3; Wed, 2 Jun 2021 00:10:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1815D6EB3E for ; Wed, 2 Jun 2021 00:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622592634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=ZCSLw/lyvlQACVz8Hr6sOBefF39Tz+PZebRYr8i/WAZZWDD8I3teL6OusznVFkOpZHBQ/G ybbXxN/4GM1J7G0t4CKVj5rrEIta/fUyne3LLgZ5lhKPz/WLVaYukAqnm2PNJOIJ99QfhF S9aFIWzskRlJziD74aL8Q7G1HBE67dw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-f-9waTJINKC-iPzDIt5ewA-1; Tue, 01 Jun 2021 20:10:31 -0400 X-MC-Unique: f-9waTJINKC-iPzDIt5ewA-1 Received: by mail-wr1-f70.google.com with SMTP id x10-20020adfc18a0000b029010d83c83f2aso210104wre.8 for ; Tue, 01 Jun 2021 17:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g6XERwupFZipcAmg6D1I1zxjEbLYz5zppsdgraxGF7Q=; b=IcPYCUnSk2MJJoxwxTBeMwFSIZiXkt+twVxwEEDcCvwnJ384nu8S+4gJDyZGP294HN 0vlqhi6bi6bx8sP55Jzo2DS84Lfu9JbskbIPM635wZm2eqYuxbwbijEM8ScgffR817KI bgoniwxJgrQRxWeCdQbykX5HzMGNhHVyXpsZG3AEo1Vhe0JlPYs8uFTCkUye25Kiqwaa HuqlDaV265zn8uhCMx46JtjXs0w6Ts+Y9nTTct+x6eN+bTQU9nJnBxWncerkxMvH1oH1 3Gcau8BYqXpDeyk90koC2OzDxNtMunL3qEESfgZDJtTxnqoQObQEJxzk+zQF16uqiqEX eLbA== X-Gm-Message-State: AOAM530fm9VWM2npQUA8n+izDbMbkz12k+Onviyl6lnVGYOUS/axZUJT YVjrztJTVLt0q3nttnhuGXNavyrK61qnJz0G76QgMXdSNYnqPZqtRimq38iLgQ3LeHpIMc9QyBc S27bmgeMWtuiYoqEp2l4Fz33jLZnzfuTiZJlS5ghP6AhX X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763245wrm.177.1622592629526; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7ytifh8Tq7X7nnucf7aYm2Vw3csWvxa0+c2QJbbdpuaVNF93Pvls4Lv1rmxm1PeJU5y+Ay/NirV8hdJrDSY= X-Received: by 2002:adf:dcc3:: with SMTP id x3mr8763219wrm.177.1622592629297; Tue, 01 Jun 2021 17:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20210305095657.GA142006@embeddedor> <79ff569a-5828-ef21-538b-12d07d34a4ff@embeddedor.com> <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> In-Reply-To: <1ec627af-514e-b24a-da88-13eb561ccb15@embeddedor.com> From: Karol Herbst Date: Wed, 2 Jun 2021 02:10:18 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang To: "Gustavo A. R. Silva" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , David Airlie , nouveau , "Gustavo A. R. Silva" , dri-devel , LKML , Ben Skeggs , linux-hardening@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" all three nouveau patches are Reviewed-by: Karol Herbst and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau >