All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karol Herbst <kherbst@redhat.com>
To: Lyude Paul <lyude@redhat.com>
Cc: Ben Skeggs <bskeggs@redhat.com>, nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1)
Date: Fri, 12 Aug 2022 01:07:51 +0200	[thread overview]
Message-ID: <CACO55tvBR5exrpMP=mKhxZjfJVQxuvQoYApnwFZjQWxFv_6msQ@mail.gmail.com> (raw)
In-Reply-To: <31a134642314b288771637610659a4f50f971f27.camel@redhat.com>

On Thu, Aug 11, 2022 at 11:20 PM Lyude Paul <lyude@redhat.com> wrote:
>
> On Thu, 2022-08-11 at 00:08 +0200, Karol Herbst wrote:
> > the thing is, without this patch, the "hw path" fails with a timeout
> > of... 30 seconds?, the code falls back to sw and it takes up to 2-3
> > minutes to finish up. So even if this solution is overkill, it fixes a
> > real issue. I suspect _something_ is bonkers with the fencing we do
> > here and we don't see that the stuff is actually finished or whatever,
> > or maybe we never emit the fence in the first place.. I didn't dig
> > deep enough.
> >
> > With this, it's really quick and everything.
>
> I guess with a todo comment this is probably fine then, since this would only
> really be affecting GPUs using m2mf anyway
>

I was mostly wondering if this is safe, but it probably is and it does
fix real user issues. I don't have a better solution at the moment
anyway.

> --
> Cheers,
>  Lyude Paul (she/her)
>  Software Engineer at Red Hat
>


  reply	other threads:[~2022-08-11 23:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 17:31 [Nouveau] Advice about debugging nouveau driver suspend issue (init_on_alloc=1 and init_on_free=1) Computer Enthusiastic
2021-10-13 17:43 ` Ilia Mirkin
2021-10-14 16:51   ` Computer Enthusiastic
2021-10-14 18:07     ` Ilia Mirkin
2022-01-24 23:19       ` computer enthusiastic
2022-08-10 10:41         ` Computer Enthusiastic
2022-08-10 11:59           ` Karol Herbst
2022-08-10 21:35             ` Lyude Paul
2022-08-10 22:08               ` Karol Herbst
2022-08-11 21:19                 ` Lyude Paul
2022-08-11 23:07                   ` Karol Herbst [this message]
2022-08-18 20:39                     ` Lyude Paul
2022-08-18 21:17                       ` Karol Herbst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACO55tvBR5exrpMP=mKhxZjfJVQxuvQoYApnwFZjQWxFv_6msQ@mail.gmail.com' \
    --to=kherbst@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.