From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9747C04AAC for ; Mon, 20 May 2019 13:23:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8316021479 for ; Mon, 20 May 2019 13:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731711AbfETNXa (ORCPT ); Mon, 20 May 2019 09:23:30 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:36657 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727319AbfETNX3 (ORCPT ); Mon, 20 May 2019 09:23:29 -0400 Received: by mail-io1-f65.google.com with SMTP id e19so11011042iob.3 for ; Mon, 20 May 2019 06:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UBrVfji9g8YN1QxOchrV6NTuPqjMFHnp9eL00F6ULiM=; b=uPBKQaU/Gs78fOO5tYFi9pCrANsy7VFoxklZXwgJs+BGkEw1ZjRxlPq6/iH6MdreyY 8IgWooKRVe9uqcPlelOF0oau1h2/t5bkdKw18XliUpWqzolxccMdLG4inazGI66W1u59 B2gp8QQV84XyW3MGps/oOFZlE0iwWO9IxqN7N3DzhvZv8YDPO9qgEluTDfiMBPbycx0e F1tXY4QRWTCLpCOO5e/VDyhYkFzxWI3l2fb4YMejd8HbEOkvnaLUFoG6DXVjJHBWHRx3 qBFsN/K7WBtvXDStohGgZIO+D2ucHXl8rGMzF8AOfBfHroOvkVku5auhm8RpafsN6j1i cXfg== X-Gm-Message-State: APjAAAVMn5/g6cfGPZm7DbRpwh50RNv8N9Dj3i5Y+nOIhAww9BX5yx4x jjMaQYVcEDadgHD3i4wRApsFVFAQto7eOdRmRQpGAg== X-Google-Smtp-Source: APXvYqxgDIcPYHned1Xf/yYTEvrJIkIzs5wwpGhhFrfdvsPzxJrN7oiVZo0mO0/H8oor3x/E5Q58SxszabJc2I1Kqfw= X-Received: by 2002:a5e:a919:: with SMTP id c25mr17203847iod.166.1558358608788; Mon, 20 May 2019 06:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20190507201245.9295-1-kherbst@redhat.com> In-Reply-To: <20190507201245.9295-1-kherbst@redhat.com> From: Karol Herbst Date: Mon, 20 May 2019 15:23:17 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] Potential fix for runpm issues on various laptops To: nouveau Cc: Lyude Paul , linux-pci@vger.kernel.org, Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org ping to the pci folks? I really would like to know what you make out of it. In fact, this kind of looks like a pcie issue, but I just don't know enough to really be able to tell. I am mainly wondering why putting the device with a 2.5 vs a 8.0 link into d3cold makes the resume path break? Any ideas? broken pcie controller? broken implementation on the gpu? On Tue, May 7, 2019 at 10:12 PM Karol Herbst wrote: > > CCing linux-pci and Bjorn Helgaas. Maybe we could get better insights on > how a reasonable fix would look like. > > Anyway, to me this entire issue looks like something which has to be fixed > on a PCI level instead of inside a driver, so it makes sense to ask the > pci folks if they have any better suggestions. > > Original cover letter: > While investigating the runpm issues on my GP107 I noticed that something > inside devinit makes runpm break. If Nouveau loads up to the point right > before doing devinit, runpm works without any issues, if devinit is ran, > not anymore. > > Out of curiousity I even tried to "bisect" devinit by not running it on > vbios provided signed PMU image, but on the devinit parser we have inside > Nouveau. > Allthough this one isn't as feature complete as the vbios one, I was able > to reproduce the runpm issues as well. From that point I was able to only > run a certain amount of commands until I got to some PCIe initialization > code inside devinit which trigger those runpm issues. > > Devinit on my GPU was changing the PCIe link from 8.0 to 2.5, reversing > that on the fini path makes runpm work again. > > There are a few other things going on, but with my limited knowledge about > PCIe in general, the change in the link speed sounded like it could cause > issues on resume if the controller and the device disagree on the actual > link. > > Maybe this is just a bug within the PCI subsystem inside linux instead and > the controller has to be forced to do _something_? > > Anyway, with this runpm seems to work nicely on my machine. Secure booting > the gr (even with my workaround applied I need anyway) might fail after > the GPU got runtime resumed though... > > Karol Herbst (4): > drm: don't set the pci power state if the pci subsystem handles the > ACPI bits > pci: enable pcie link changes for pascal > pci: add nvkm_pcie_get_speed > pci: save the boot pcie link speed and restore it on fini > > drm/nouveau/include/nvkm/subdev/pci.h | 6 +++-- > drm/nouveau/nouveau_acpi.c | 7 +++++- > drm/nouveau/nouveau_acpi.h | 2 ++ > drm/nouveau/nouveau_drm.c | 14 +++++++++--- > drm/nouveau/nouveau_drv.h | 2 ++ > drm/nouveau/nvkm/subdev/pci/base.c | 9 ++++++-- > drm/nouveau/nvkm/subdev/pci/gk104.c | 8 +++---- > drm/nouveau/nvkm/subdev/pci/gp100.c | 10 +++++++++ > drm/nouveau/nvkm/subdev/pci/pcie.c | 32 +++++++++++++++++++++++---- > drm/nouveau/nvkm/subdev/pci/priv.h | 7 ++++++ > 10 files changed, 81 insertions(+), 16 deletions(-) > > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karol Herbst Subject: Re: [PATCH v2 0/4] Potential fix for runpm issues on various laptops Date: Mon, 20 May 2019 15:23:17 +0200 Message-ID: References: <20190507201245.9295-1-kherbst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190507201245.9295-1-kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Helgaas List-Id: nouveau.vger.kernel.org cGluZyB0byB0aGUgcGNpIGZvbGtzPyBJIHJlYWxseSB3b3VsZCBsaWtlIHRvIGtub3cgd2hhdCB5 b3UgbWFrZSBvdXQgb2YgaXQuCgpJbiBmYWN0LCB0aGlzIGtpbmQgb2YgbG9va3MgbGlrZSBhIHBj aWUgaXNzdWUsIGJ1dCBJIGp1c3QgZG9uJ3Qga25vdwplbm91Z2ggdG8gcmVhbGx5IGJlIGFibGUg dG8gdGVsbC4gSSBhbSBtYWlubHkgd29uZGVyaW5nIHdoeSBwdXR0aW5nCnRoZSBkZXZpY2Ugd2l0 aCBhIDIuNSB2cyBhIDguMCBsaW5rIGludG8gZDNjb2xkIG1ha2VzIHRoZSByZXN1bWUgcGF0aApi cmVhaz8gQW55IGlkZWFzPyBicm9rZW4gcGNpZSBjb250cm9sbGVyPyBicm9rZW4gaW1wbGVtZW50 YXRpb24gb24gdGhlCmdwdT8KCk9uIFR1ZSwgTWF5IDcsIDIwMTkgYXQgMTA6MTIgUE0gS2Fyb2wg SGVyYnN0IDxraGVyYnN0QHJlZGhhdC5jb20+IHdyb3RlOgo+Cj4gQ0NpbmcgbGludXgtcGNpIGFu ZCBCam9ybiBIZWxnYWFzLiBNYXliZSB3ZSBjb3VsZCBnZXQgYmV0dGVyIGluc2lnaHRzIG9uCj4g aG93IGEgcmVhc29uYWJsZSBmaXggd291bGQgbG9vayBsaWtlLgo+Cj4gQW55d2F5LCB0byBtZSB0 aGlzIGVudGlyZSBpc3N1ZSBsb29rcyBsaWtlIHNvbWV0aGluZyB3aGljaCBoYXMgdG8gYmUgZml4 ZWQKPiBvbiBhIFBDSSBsZXZlbCBpbnN0ZWFkIG9mIGluc2lkZSBhIGRyaXZlciwgc28gaXQgbWFr ZXMgc2Vuc2UgdG8gYXNrIHRoZQo+IHBjaSBmb2xrcyBpZiB0aGV5IGhhdmUgYW55IGJldHRlciBz dWdnZXN0aW9ucy4KPgo+IE9yaWdpbmFsIGNvdmVyIGxldHRlcjoKPiBXaGlsZSBpbnZlc3RpZ2F0 aW5nIHRoZSBydW5wbSBpc3N1ZXMgb24gbXkgR1AxMDcgSSBub3RpY2VkIHRoYXQgc29tZXRoaW5n Cj4gaW5zaWRlIGRldmluaXQgbWFrZXMgcnVucG0gYnJlYWsuIElmIE5vdXZlYXUgbG9hZHMgdXAg dG8gdGhlIHBvaW50IHJpZ2h0Cj4gYmVmb3JlIGRvaW5nIGRldmluaXQsIHJ1bnBtIHdvcmtzIHdp dGhvdXQgYW55IGlzc3VlcywgaWYgZGV2aW5pdCBpcyByYW4sCj4gbm90IGFueW1vcmUuCj4KPiBP dXQgb2YgY3VyaW91c2l0eSBJIGV2ZW4gdHJpZWQgdG8gImJpc2VjdCIgZGV2aW5pdCBieSBub3Qg cnVubmluZyBpdCBvbgo+IHZiaW9zIHByb3ZpZGVkIHNpZ25lZCBQTVUgaW1hZ2UsIGJ1dCBvbiB0 aGUgZGV2aW5pdCBwYXJzZXIgd2UgaGF2ZSBpbnNpZGUKPiBOb3V2ZWF1Lgo+IEFsbHRob3VnaCB0 aGlzIG9uZSBpc24ndCBhcyBmZWF0dXJlIGNvbXBsZXRlIGFzIHRoZSB2YmlvcyBvbmUsIEkgd2Fz IGFibGUKPiB0byByZXByb2R1Y2UgdGhlIHJ1bnBtIGlzc3VlcyBhcyB3ZWxsLiBGcm9tIHRoYXQg cG9pbnQgSSB3YXMgYWJsZSB0byBvbmx5Cj4gcnVuIGEgY2VydGFpbiBhbW91bnQgb2YgY29tbWFu ZHMgdW50aWwgSSBnb3QgdG8gc29tZSBQQ0llIGluaXRpYWxpemF0aW9uCj4gY29kZSBpbnNpZGUg ZGV2aW5pdCB3aGljaCB0cmlnZ2VyIHRob3NlIHJ1bnBtIGlzc3Vlcy4KPgo+IERldmluaXQgb24g bXkgR1BVIHdhcyBjaGFuZ2luZyB0aGUgUENJZSBsaW5rIGZyb20gOC4wIHRvIDIuNSwgcmV2ZXJz aW5nCj4gdGhhdCBvbiB0aGUgZmluaSBwYXRoIG1ha2VzIHJ1bnBtIHdvcmsgYWdhaW4uCj4KPiBU aGVyZSBhcmUgYSBmZXcgb3RoZXIgdGhpbmdzIGdvaW5nIG9uLCBidXQgd2l0aCBteSBsaW1pdGVk IGtub3dsZWRnZSBhYm91dAo+IFBDSWUgaW4gZ2VuZXJhbCwgdGhlIGNoYW5nZSBpbiB0aGUgbGlu ayBzcGVlZCBzb3VuZGVkIGxpa2UgaXQgY291bGQgY2F1c2UKPiBpc3N1ZXMgb24gcmVzdW1lIGlm IHRoZSBjb250cm9sbGVyIGFuZCB0aGUgZGV2aWNlIGRpc2FncmVlIG9uIHRoZSBhY3R1YWwKPiBs aW5rLgo+Cj4gTWF5YmUgdGhpcyBpcyBqdXN0IGEgYnVnIHdpdGhpbiB0aGUgUENJIHN1YnN5c3Rl bSBpbnNpZGUgbGludXggaW5zdGVhZCBhbmQKPiB0aGUgY29udHJvbGxlciBoYXMgdG8gYmUgZm9y Y2VkIHRvIGRvIF9zb21ldGhpbmdfPwo+Cj4gQW55d2F5LCB3aXRoIHRoaXMgcnVucG0gc2VlbXMg dG8gd29yayBuaWNlbHkgb24gbXkgbWFjaGluZS4gU2VjdXJlIGJvb3RpbmcKPiB0aGUgZ3IgKGV2 ZW4gd2l0aCBteSB3b3JrYXJvdW5kIGFwcGxpZWQgSSBuZWVkIGFueXdheSkgbWlnaHQgZmFpbCBh ZnRlcgo+IHRoZSBHUFUgZ290IHJ1bnRpbWUgcmVzdW1lZCB0aG91Z2guLi4KPgo+IEthcm9sIEhl cmJzdCAoNCk6Cj4gICBkcm06IGRvbid0IHNldCB0aGUgcGNpIHBvd2VyIHN0YXRlIGlmIHRoZSBw Y2kgc3Vic3lzdGVtIGhhbmRsZXMgdGhlCj4gICAgIEFDUEkgYml0cwo+ICAgcGNpOiBlbmFibGUg cGNpZSBsaW5rIGNoYW5nZXMgZm9yIHBhc2NhbAo+ICAgcGNpOiBhZGQgbnZrbV9wY2llX2dldF9z cGVlZAo+ICAgcGNpOiBzYXZlIHRoZSBib290IHBjaWUgbGluayBzcGVlZCBhbmQgcmVzdG9yZSBp dCBvbiBmaW5pCj4KPiAgZHJtL25vdXZlYXUvaW5jbHVkZS9udmttL3N1YmRldi9wY2kuaCB8ICA2 ICsrKy0tCj4gIGRybS9ub3V2ZWF1L25vdXZlYXVfYWNwaS5jICAgICAgICAgICAgfCAgNyArKysr Ky0KPiAgZHJtL25vdXZlYXUvbm91dmVhdV9hY3BpLmggICAgICAgICAgICB8ICAyICsrCj4gIGRy bS9ub3V2ZWF1L25vdXZlYXVfZHJtLmMgICAgICAgICAgICAgfCAxNCArKysrKysrKystLS0KPiAg ZHJtL25vdXZlYXUvbm91dmVhdV9kcnYuaCAgICAgICAgICAgICB8ICAyICsrCj4gIGRybS9ub3V2 ZWF1L252a20vc3ViZGV2L3BjaS9iYXNlLmMgICAgfCAgOSArKysrKystLQo+ICBkcm0vbm91dmVh dS9udmttL3N1YmRldi9wY2kvZ2sxMDQuYyAgIHwgIDggKysrLS0tLQo+ICBkcm0vbm91dmVhdS9u dmttL3N1YmRldi9wY2kvZ3AxMDAuYyAgIHwgMTAgKysrKysrKysrCj4gIGRybS9ub3V2ZWF1L252 a20vc3ViZGV2L3BjaS9wY2llLmMgICAgfCAzMiArKysrKysrKysrKysrKysrKysrKysrKy0tLS0K PiAgZHJtL25vdXZlYXUvbnZrbS9zdWJkZXYvcGNpL3ByaXYuaCAgICB8ICA3ICsrKysrKwo+ICAx MCBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPgo+IC0t Cj4gMi4yMS4wCj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1