From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E48DC433E0 for ; Fri, 22 Jan 2021 01:37:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD0A322B43 for ; Fri, 22 Jan 2021 01:37:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726525AbhAVBh4 (ORCPT ); Thu, 21 Jan 2021 20:37:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbhAVBhw (ORCPT ); Thu, 21 Jan 2021 20:37:52 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43D16C06174A for ; Thu, 21 Jan 2021 17:37:11 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id p13so4764386ljg.2 for ; Thu, 21 Jan 2021 17:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=kPdBhtV7sb5FmbpskgX47ayA3XzZpJ5sLr7ZfFQ16YmFKe3uuPeDHLlKAiKTyKbytn GpXdQKeYqValccp0PzOV9ES0Kap5PeiAXfaG0obsgUetZSHOd+NXcGxOELpamALCiUcw XmviFURFgWxBWx3eGtnH7nk9+4ttuO/h7NrKV3MDEXIKBo7dhcWlJPjTa188Y8ZSqFOv tVXuzdwmpaAI4wDpujmMWWMKYrzF1pjtjOhblEZdWogxYRUv4l4vsSL+mmC/HjSTyKWv alYQfPWGE0Ub4R36MSVmFI/V9PaBqNaftB/nmQO5/iRYAElHJwK+/+cUqfqG6ILw230T 25LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=Vbb/RCkTACA8NRFvpXgOIW55hzhZQLVaytxD66mkdxLVbvAF2D9DJ6saMK2ey5UUKM QmEDlA6B/TqRJ+q4sjeTFXV+rFfvwZ1VhdIvPR0paS51IKH8eCRLuEI1TGd3BRKzM/2P tORNkGiEfzHUB+TdaibildZkdJZQ+Pvvhh4usIn9FNjOtiEbMXswuN9WJeNEYSEwDwLd q8pBQcZL/+rZxtzsU80beQDwKYSUgO4IM2QiH8557yqwV2BdKliEMk05AlWyZIIfeJNF 27E6ld1AdO/e8gNM1INwdGxvis4zS4Yb8x5oF6SrS15RzOB8lAb3iILrmiCGudX2tC8a aNyA== X-Gm-Message-State: AOAM533hpiG7h33a5hhYQhOPxAkS1jMxcADQGdptDAXuaVTCR/sBZbeF 7OXLHY1V6MSg46K10bAa6krWvUvK8kmcOlYy8dB8H2WOtZs= X-Google-Smtp-Source: ABdhPJzkG8y52oDdMWe+BHOq2aGa4/Niet2z6/DpC1s6GUzZ60Uy5fGhzwpqrcf8kVyaUzS7LNejFdcL8MHbUVpQxvo= X-Received: by 2002:a2e:b8c5:: with SMTP id s5mr19875ljp.335.1611279429763; Thu, 21 Jan 2021 17:37:09 -0800 (PST) MIME-Version: 1.0 References: <20210121134529.1201249-1-daeho43@gmail.com> <6e4996f8-fdf0-93dd-8253-9e8f5e6fca06@huawei.com> In-Reply-To: <6e4996f8-fdf0-93dd-8253-9e8f5e6fca06@huawei.com> From: Daeho Jeong Date: Fri, 22 Jan 2021 10:36:58 +0900 Message-ID: Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: introduce checkpoint=merge mount option To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Sungjong Seo , Daeho Jeong Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Got it~! :) 2021=EB=85=84 1=EC=9B=94 22=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 9:55, C= hao Yu =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > If there is no update in v5, it will be better to include my Reviewed-by > tag, please note that. :) > > Thanks, > > On 2021/1/21 21:45, Daeho Jeong wrote: > > From: Daeho Jeong > > > > We've added a new mount option "checkpoint=3Dmerge", which creates a > > kernel daemon and makes it to merge concurrent checkpoint requests as > > much as possible to eliminate redundant checkpoint issues. Plus, we > > can eliminate the sluggish issue caused by slow checkpoint operation > > when the checkpoint is done in a process context in a cgroup having > > low i/o budget and cpu shares. To make this do better, we set the > > default i/o priority of the kernel daemon to "3", to give one higher > > priority than other kernel threads. The below verification result > > explains this. > > The basic idea has come fromhttps://opensource.samsung.com. > > > > [Verification] > > Android Pixel Device(ARM64, 7GB RAM, 256GB UFS) > > Create two I/O cgroups (fg w/ weight 100, bg w/ wight 20) > > Set "strict_guarantees" to "1" in BFQ tunables > > > > In "fg" cgroup, > > - thread A =3D> trigger 1000 checkpoint operations > > "for i in `seq 1 1000`; do touch test_dir1/file; fsync test_dir1; > > done" > > - thread B =3D> gererating async. I/O > > "fio --rw=3Dwrite --numjobs=3D1 --bs=3D128k --runtime=3D3600 --time_= based=3D1 > > --filename=3Dtest_img --name=3Dtest" > > > > In "bg" cgroup, > > - thread C =3D> trigger repeated checkpoint operations > > "echo $$ > /dev/blkio/bg/tasks; while true; do touch test_dir2/file; > > fsync test_dir2; done" > > > > We've measured thread A's execution time. > > > > [ w/o patch ] > > Elapsed Time: Avg. 68 seconds > > [ w/ patch ] > > Elapsed Time: Avg. 48 seconds > > > > Signed-off-by: Daeho Jeong > > Signed-off-by: Sungjong Seo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BADC433E0 for ; Fri, 22 Jan 2021 01:37:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF5C8223C8; Fri, 22 Jan 2021 01:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF5C8223C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1l2lOC-0002r3-B0; Fri, 22 Jan 2021 01:37:28 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2lOA-0002qs-TG for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Jan 2021 01:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:Cc:To: Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=V2mD9xSlF74BFJ1uJjlB4FuUB2 N2TIAV8240+HqhJml15iVd5Mw1wswqPC3+cJwDgVZFoFUKzq26yTFjOVZEhfFTNS3mOpLZ4/E1VNG BUD7NbCZpi4jcBb0tJzYfDVvYk0sV75sw8YhCwdYq07kMKQxuA5blg86IqcQNawF0VIE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:Cc:To:Subject:Message-ID:Date:From :In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=iSjd338Fq9kRsYJseeO4Wr15Fm phxUY4kTHRv+sRfUNhAIy54o2dwl+INWsIDk7oi+bvm4ozAdKxYG5ogOn9F6qzUr5ZnunGDAuvAdX DtE/Vmoest/aixJXvbpudL0Uzl9saToLxhig37Fm9JYjU7XulFpB+lHZv1JbBvvdlyWY=; Received: from mail-lj1-f182.google.com ([209.85.208.182]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1l2lO0-006vCb-DJ for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Jan 2021 01:37:26 +0000 Received: by mail-lj1-f182.google.com with SMTP id x23so4726437lji.7 for ; Thu, 21 Jan 2021 17:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=kPdBhtV7sb5FmbpskgX47ayA3XzZpJ5sLr7ZfFQ16YmFKe3uuPeDHLlKAiKTyKbytn GpXdQKeYqValccp0PzOV9ES0Kap5PeiAXfaG0obsgUetZSHOd+NXcGxOELpamALCiUcw XmviFURFgWxBWx3eGtnH7nk9+4ttuO/h7NrKV3MDEXIKBo7dhcWlJPjTa188Y8ZSqFOv tVXuzdwmpaAI4wDpujmMWWMKYrzF1pjtjOhblEZdWogxYRUv4l4vsSL+mmC/HjSTyKWv alYQfPWGE0Ub4R36MSVmFI/V9PaBqNaftB/nmQO5/iRYAElHJwK+/+cUqfqG6ILw230T 25LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zSsmz7M3XSK6HCpP5SpXph6fwHlQF1RHiR3CvF0f+mQ=; b=ozYAcGy4kF5DH9L5f+XIfiWZSp/mYcP1XNoNcty73XwxBh0FV20uGWGnJ76PC/9VCy kFIsOblr3GxIS5maW3cqmAqDMMF+Ew5GzodjHWOILa5Dw6EuReHoOCvbaeBSmDJU6fbY dS45Z1aJ8XwFP3Qqla7bss5LzLnEFsPJIU8tnYlslYMGPU2lgwCbAhbehvrl057Cmb8a ifVRdO5a+bFI/aeb2TJRwmwR6E6EVGN1TPmt5fSSAM36KIdo7AJmgwxs8ymrOjmuzam5 WM/DHZP+hyNmFenb9Hy1z+R5VEkZTrsEPy7LQw979Z91dZv0PWCWTdGnurm7CxKvYtly 5cGA== X-Gm-Message-State: AOAM531r1wdt36EWo4xMwQyyzU6Mr7aDRIKIUJoZ9cWzwXDbM3uaVGZj GgbA2wkAEou9dSxj92LHH48LmMNkBOrZH2/996k= X-Google-Smtp-Source: ABdhPJzkG8y52oDdMWe+BHOq2aGa4/Niet2z6/DpC1s6GUzZ60Uy5fGhzwpqrcf8kVyaUzS7LNejFdcL8MHbUVpQxvo= X-Received: by 2002:a2e:b8c5:: with SMTP id s5mr19875ljp.335.1611279429763; Thu, 21 Jan 2021 17:37:09 -0800 (PST) MIME-Version: 1.0 References: <20210121134529.1201249-1-daeho43@gmail.com> <6e4996f8-fdf0-93dd-8253-9e8f5e6fca06@huawei.com> In-Reply-To: <6e4996f8-fdf0-93dd-8253-9e8f5e6fca06@huawei.com> From: Daeho Jeong Date: Fri, 22 Jan 2021 10:36:58 +0900 Message-ID: To: Chao Yu X-Headers-End: 1l2lO0-006vCb-DJ Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: introduce checkpoint=merge mount option X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , Sungjong Seo , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net R290IGl0fiEgOikKCjIwMjHrhYQgMeyblCAyMuydvCAo6riIKSDsmKTsoIQgOTo1NSwgQ2hhbyBZ dSA8eXVjaGFvMEBodWF3ZWkuY29tPuuLmOydtCDsnpHshLE6Cj4KPiBJZiB0aGVyZSBpcyBubyB1 cGRhdGUgaW4gdjUsIGl0IHdpbGwgYmUgYmV0dGVyIHRvIGluY2x1ZGUgbXkgUmV2aWV3ZWQtYnkK PiB0YWcsIHBsZWFzZSBub3RlIHRoYXQuIDopCj4KPiBUaGFua3MsCj4KPiBPbiAyMDIxLzEvMjEg MjE6NDUsIERhZWhvIEplb25nIHdyb3RlOgo+ID4gRnJvbTogRGFlaG8gSmVvbmc8ZGFlaG9qZW9u Z0Bnb29nbGUuY29tPgo+ID4KPiA+IFdlJ3ZlIGFkZGVkIGEgbmV3IG1vdW50IG9wdGlvbiAiY2hl Y2twb2ludD1tZXJnZSIsIHdoaWNoIGNyZWF0ZXMgYQo+ID4ga2VybmVsIGRhZW1vbiBhbmQgbWFr ZXMgaXQgdG8gbWVyZ2UgY29uY3VycmVudCBjaGVja3BvaW50IHJlcXVlc3RzIGFzCj4gPiBtdWNo IGFzIHBvc3NpYmxlIHRvIGVsaW1pbmF0ZSByZWR1bmRhbnQgY2hlY2twb2ludCBpc3N1ZXMuIFBs dXMsIHdlCj4gPiBjYW4gZWxpbWluYXRlIHRoZSBzbHVnZ2lzaCBpc3N1ZSBjYXVzZWQgYnkgc2xv dyBjaGVja3BvaW50IG9wZXJhdGlvbgo+ID4gd2hlbiB0aGUgY2hlY2twb2ludCBpcyBkb25lIGlu IGEgcHJvY2VzcyBjb250ZXh0IGluIGEgY2dyb3VwIGhhdmluZwo+ID4gbG93IGkvbyBidWRnZXQg YW5kIGNwdSBzaGFyZXMuIFRvIG1ha2UgdGhpcyBkbyBiZXR0ZXIsIHdlIHNldCB0aGUKPiA+IGRl ZmF1bHQgaS9vIHByaW9yaXR5IG9mIHRoZSBrZXJuZWwgZGFlbW9uIHRvICIzIiwgdG8gZ2l2ZSBv bmUgaGlnaGVyCj4gPiBwcmlvcml0eSB0aGFuIG90aGVyIGtlcm5lbCB0aHJlYWRzLiBUaGUgYmVs b3cgdmVyaWZpY2F0aW9uIHJlc3VsdAo+ID4gZXhwbGFpbnMgdGhpcy4KPiA+IFRoZSBiYXNpYyBp ZGVhIGhhcyBjb21lIGZyb21odHRwczovL29wZW5zb3VyY2Uuc2Ftc3VuZy5jb20uCj4gPgo+ID4g W1ZlcmlmaWNhdGlvbl0KPiA+IEFuZHJvaWQgUGl4ZWwgRGV2aWNlKEFSTTY0LCA3R0IgUkFNLCAy NTZHQiBVRlMpCj4gPiBDcmVhdGUgdHdvIEkvTyBjZ3JvdXBzIChmZyB3LyB3ZWlnaHQgMTAwLCBi ZyB3LyB3aWdodCAyMCkKPiA+IFNldCAic3RyaWN0X2d1YXJhbnRlZXMiIHRvICIxIiBpbiBCRlEg dHVuYWJsZXMKPiA+Cj4gPiBJbiAiZmciIGNncm91cCwKPiA+IC0gdGhyZWFkIEEgPT4gdHJpZ2dl ciAxMDAwIGNoZWNrcG9pbnQgb3BlcmF0aW9ucwo+ID4gICAgImZvciBpIGluIGBzZXEgMSAxMDAw YDsgZG8gdG91Y2ggdGVzdF9kaXIxL2ZpbGU7IGZzeW5jIHRlc3RfZGlyMTsKPiA+ICAgICBkb25l Igo+ID4gLSB0aHJlYWQgQiA9PiBnZXJlcmF0aW5nIGFzeW5jLiBJL08KPiA+ICAgICJmaW8gLS1y dz13cml0ZSAtLW51bWpvYnM9MSAtLWJzPTEyOGsgLS1ydW50aW1lPTM2MDAgLS10aW1lX2Jhc2Vk PTEKPiA+ICAgICAgICAgLS1maWxlbmFtZT10ZXN0X2ltZyAtLW5hbWU9dGVzdCIKPiA+Cj4gPiBJ biAiYmciIGNncm91cCwKPiA+IC0gdGhyZWFkIEMgPT4gdHJpZ2dlciByZXBlYXRlZCBjaGVja3Bv aW50IG9wZXJhdGlvbnMKPiA+ICAgICJlY2hvICQkID4gL2Rldi9ibGtpby9iZy90YXNrczsgd2hp bGUgdHJ1ZTsgZG8gdG91Y2ggdGVzdF9kaXIyL2ZpbGU7Cj4gPiAgICAgZnN5bmMgdGVzdF9kaXIy OyBkb25lIgo+ID4KPiA+IFdlJ3ZlIG1lYXN1cmVkIHRocmVhZCBBJ3MgZXhlY3V0aW9uIHRpbWUu Cj4gPgo+ID4gWyB3L28gcGF0Y2ggXQo+ID4gRWxhcHNlZCBUaW1lOiBBdmcuIDY4IHNlY29uZHMK PiA+IFsgdy8gIHBhdGNoIF0KPiA+IEVsYXBzZWQgVGltZTogQXZnLiA0OCBzZWNvbmRzCj4gPgo+ ID4gU2lnbmVkLW9mZi1ieTogRGFlaG8gSmVvbmc8ZGFlaG9qZW9uZ0Bnb29nbGUuY29tPgo+ID4g U2lnbmVkLW9mZi1ieTogU3VuZ2pvbmcgU2VvPHNqMTU1Ny5zZW9Ac2Ftc3VuZy5jb20+CgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1k ZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQK aHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1k ZXZlbAo=