From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB5A9C433E0 for ; Sun, 5 Jul 2020 23:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8521D2074F for ; Sun, 5 Jul 2020 23:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WNPph1Rn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbgGEXrW (ORCPT ); Sun, 5 Jul 2020 19:47:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727970AbgGEXrV (ORCPT ); Sun, 5 Jul 2020 19:47:21 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EAEBC061794 for ; Sun, 5 Jul 2020 16:47:20 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id g139so21589424lfd.10 for ; Sun, 05 Jul 2020 16:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=WNPph1Rnfmu9y42wUJuMYOQV7Xxxcg/Ad/Vu9/PaQV2YOJMQVNnHf0Fs88lAv3CnFL 9xR+pATJo3x4tN55YQG/TXCBad3pmyGqmA5fPyMXpF+qlIb3XLN3p5G0wVIv7tbvr1Wu 5LKC9INYTOeYYMgE0O1rzTcifWTtOb9YDy9J4KjiAtkFhgFxNCnntWdneCq0V7PFMz0H lkd0TdbUniexNcGPTGfLovLYCeYAjT6NCwsPjmeDgOHAR7YTu0EKLqllwIaaDjs6EO/4 ynDAM1q/wv7+wIfZNT6VIbEjQdVwjvTTfbqnvs8V9HBvv4a8HXZ5SV/jUJI+YVlJ7xK2 bU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=jV9fzjKQBua2GvxnR9z/1rBaYh4uuGzcgWPh1E+ksbLh23tsEsASUQwdFul118rVSz h3vBEnh3G3ogHwCXKygmvWWfnaO3QRqai9NxUIOcQtzS8nvUmPMgVXtbZw9k9IgLFtHv J1QHBCvWA/y3cc+rgkOB1NRQcvEcZ4EOq/dWVTvA38JE4TYo9Woh5wXk/77vqAHKxNWN H2CnO9A3fKFe5L2LaSbgyie3/S/gYt8JX+IHRoCwAyARwoBjlf7u/1qHLnyccmOtKSoG 4VNumbRIMEYYeHs2LEdH4+HhSuSiiM9X2J+bDxxAKWK/bcY6oSGM01EvvEe7k/METc1v SJZw== X-Gm-Message-State: AOAM533Lg5bvuuTq9cLOwMbSHYHLj4udgQf3bOn/S8hMz4yo4EkVTQYu tZFs0Hkj+BH6rYcfnPg4Iuctg32aXqoCyV38bCQ= X-Google-Smtp-Source: ABdhPJzSw1PL3kqgRpbbKJVwUy9vBzKOUowhbkDVg/jU/+Mzwe3KjxXCyBTInrASBs/BoC7LUWZ1diVxdKI2qtUtk4U= X-Received: by 2002:ac2:5443:: with SMTP id d3mr28104550lfn.121.1593992838852; Sun, 05 Jul 2020 16:47:18 -0700 (PDT) MIME-Version: 1.0 References: <20200703065420.3544269-1-daeho43@gmail.com> <20200703141359.GA2953162@kroah.com> In-Reply-To: <20200703141359.GA2953162@kroah.com> From: Daeho Jeong Date: Mon, 6 Jul 2020 08:47:07 +0900 Message-ID: Subject: Re: [PATCH v3] f2fs: add symbolic link to kobject in sysfs To: Greg KH Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No Documentation/ABI/ entry for your new sysfs file/link? This is for adding a symbolic link to a pre-existed /sys/fs/f2fs/ directory and it means /sys/fs/f2fs/ points to /sys/fs/f2fs/. I already added the description of this in Documentation/filesystems/f2fs.rst. > > And what does this help with? Some system daemons in Android access with the pre-defined sysfs entry name in the json file. So whenever the project changes and the partition layout is changed, we have to follow up the changes and modify /sys/fs/f2fs/ name in the json file accordingly. This will help them access all the f2fs sysfs entries consistently without requiring to know those changes. > > If it's really needed, why don't we do this for all filesystem types? This is for the daemon to change the mode of only F2FS with the power hint of Android. > > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5290EC433DF for ; Sun, 5 Jul 2020 23:47:39 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E5D02074F; Sun, 5 Jul 2020 23:47:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="KpbC+R8X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="BjzmbAX3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WNPph1Rn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E5D02074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jsEMB-0003KV-TO; Sun, 05 Jul 2020 23:47:35 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsEMA-0003KN-GO for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Jul 2020 23:47:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=KpbC+R8XBRsQqUioFCSXsrVEcZ dn9IPeNY2CuoozNFISLPvZJLa2lBQuJ96leqGM8YGOg3MVdi9k1dok0cBdkaeLXF/2h7BFyOO5L4y ZvaU9YdBt5S+JN4t2VXY3CJJlGdaw9bh4AjnpX5TovQVg15fpGCBagSijZ1lQ3zJCNwE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=BjzmbAX3eA2rL8AzJWiXRXzS79 YgciT3pBPkkUMYBdjGTWtHmDV9XNZxgxUw1948L57HVi6dCI8WZcqxCNy0zU3VCVTdw7oOEPSkeds VsUAQDEKnnpC7DzExUCiEIe3O7mVPqPeS0zougcni6hYc1Jy+oDCuDWBjLbfFGpOnx40=; Received: from mail-lf1-f65.google.com ([209.85.167.65]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jsEM8-00EMgP-KD for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Jul 2020 23:47:34 +0000 Received: by mail-lf1-f65.google.com with SMTP id k17so8812086lfg.3 for ; Sun, 05 Jul 2020 16:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=WNPph1Rnfmu9y42wUJuMYOQV7Xxxcg/Ad/Vu9/PaQV2YOJMQVNnHf0Fs88lAv3CnFL 9xR+pATJo3x4tN55YQG/TXCBad3pmyGqmA5fPyMXpF+qlIb3XLN3p5G0wVIv7tbvr1Wu 5LKC9INYTOeYYMgE0O1rzTcifWTtOb9YDy9J4KjiAtkFhgFxNCnntWdneCq0V7PFMz0H lkd0TdbUniexNcGPTGfLovLYCeYAjT6NCwsPjmeDgOHAR7YTu0EKLqllwIaaDjs6EO/4 ynDAM1q/wv7+wIfZNT6VIbEjQdVwjvTTfbqnvs8V9HBvv4a8HXZ5SV/jUJI+YVlJ7xK2 bU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPQESZvLzBCiWC6EG5DKB+ET67N7b5/1MLY//mTPGek=; b=V+dF/CCP3pA16HUwKdBzQPR0k4vXw+pjz0p66QsUr1qcCKxbvndARfXCxYdDDlXPDS No8Y3GGLDKi2GY6xlXe/HFW+zuzEnx0dx1txqPS4q1sqq9bxAN+nczyHLo8wrq82lUYn HckAnyuOp8BCOYV/8uM2QiZnnK2s7mR3eE5gNnnEMPVUAcpyJdI2XoW+8qKNeyV/wfi0 379FlzjMDx7FeJmHOI5VlHBLoP1J0UeQc5Qw70R4QC78fJsUhYvX3IaButB+6V5Pgq5b nHuWg5KkFsqdHRnw5ZdU62Nf6z871bIQ7FemONwLrmoeBE3E7ie1LFMi8/J3Rx0RQ7/O Msig== X-Gm-Message-State: AOAM532C8CI4xF9kp0wNxdnpRJhSwveE3H79agbo89YtlrU+Oo2fSFE8 hfN6I7NCFQTUUSvIaJeYEILu9st9C4nW/lqLqu4= X-Google-Smtp-Source: ABdhPJzSw1PL3kqgRpbbKJVwUy9vBzKOUowhbkDVg/jU/+Mzwe3KjxXCyBTInrASBs/BoC7LUWZ1diVxdKI2qtUtk4U= X-Received: by 2002:ac2:5443:: with SMTP id d3mr28104550lfn.121.1593992838852; Sun, 05 Jul 2020 16:47:18 -0700 (PDT) MIME-Version: 1.0 References: <20200703065420.3544269-1-daeho43@gmail.com> <20200703141359.GA2953162@kroah.com> In-Reply-To: <20200703141359.GA2953162@kroah.com> From: Daeho Jeong Date: Mon, 6 Jul 2020 08:47:07 +0900 Message-ID: To: Greg KH X-Headers-End: 1jsEM8-00EMgP-KD Subject: Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > No Documentation/ABI/ entry for your new sysfs file/link? This is for adding a symbolic link to a pre-existed /sys/fs/f2fs/ directory and it means /sys/fs/f2fs/ points to /sys/fs/f2fs/. I already added the description of this in Documentation/filesystems/f2fs.rst. > > And what does this help with? Some system daemons in Android access with the pre-defined sysfs entry name in the json file. So whenever the project changes and the partition layout is changed, we have to follow up the changes and modify /sys/fs/f2fs/ name in the json file accordingly. This will help them access all the f2fs sysfs entries consistently without requiring to know those changes. > > If it's really needed, why don't we do this for all filesystem types? This is for the daemon to change the mode of only F2FS with the power hint of Android. > > thanks, > > greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel