From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB50C433EF for ; Fri, 5 Nov 2021 01:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C22761246 for ; Fri, 5 Nov 2021 01:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbhKEBm7 (ORCPT ); Thu, 4 Nov 2021 21:42:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbhKEBm4 (ORCPT ); Thu, 4 Nov 2021 21:42:56 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A243C061714 for ; Thu, 4 Nov 2021 18:40:18 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id s9so6482267qvk.12 for ; Thu, 04 Nov 2021 18:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuiu0Wf4u9BEGXBoIO9WIUY1RtGLPv3KstdNH+skVn4=; b=OlHZHpMMlHlA2mvNmNLMVYTBkYoOu+wuDTNv26+y/aJr0eHbC+oJ3i8677sqJTiFUB kZAqRUaI8Q6V6+kY6V4NK/At2bdGiTfcJOC9WS5kJ1FLTQiZNgKrHm0bU7MQi+LOFOTK UScPeAhF0wmBZeDCZ4h5BYhKBppp4cAGLcT3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuiu0Wf4u9BEGXBoIO9WIUY1RtGLPv3KstdNH+skVn4=; b=W7tjR7WI0cNiKmxgI+QlQr7NIcn/5/ry+y3FY+nZMp+Tl2xCZUq0PCLePR9JL5cxDQ eqaVxJZ9p/ZHnh3vTDulEPJaJncQtNmDkwkC2TpxWgAistLGadXAIwE+ODIDX4SacKlI VXF7Jwq2CMJkNBT9tsVQpdTI1oAxP5ddf2KJFx/ntuOGdpjUcMHnCWxH4IlqkWmIx4Tx wr+H3kx4Q0NmOXmrRTZ1lc8cEt/4sU42v9qCHQnLWEyHc6A7goSEGAsAHMSEgNepICbv zOjh7jQgwEPkuaGNrjDwDKfVMLkjW2EiypRYgSdi4hrYXFds0mJgtGhR/y0wtpv9RRHF l/Sg== X-Gm-Message-State: AOAM530HBG9RFiAVcokHl5A1Uf0QNG2A7rUqRVkyKnG6snYcEXdHry+M PwllhnOSkdTWQksylv8TcgqBGIX6n+6D+7l2sxI= X-Google-Smtp-Source: ABdhPJwn7ltINiaTnafuAfwJf+9xnaLsMQM755UKrybz+o6veGW29/K/cs79Ln231Xya3DTp+gpEIBBL8k1kZK/4deQ= X-Received: by 2002:a0c:c784:: with SMTP id k4mr53964077qvj.43.1636076417159; Thu, 04 Nov 2021 18:40:17 -0700 (PDT) MIME-Version: 1.0 References: <20211105005955.107419-1-osk@google.com> In-Reply-To: <20211105005955.107419-1-osk@google.com> From: Joel Stanley Date: Fri, 5 Nov 2021 01:40:05 +0000 Message-ID: Subject: Re: [PATCH v2] ARM: dts: aspeed: tyan-s7106: Update nct7802 config To: Oskar Senft Cc: Linux ARM , linux-aspeed , Linux Kernel Mailing List , Rob Herring , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Nov 2021 at 01:00, Oskar Senft wrote: > > This change updates the configuration for the nct7802 hardware > monitor to correctly configure its temperature sensors. > > Signed-off-by: Oskar Senft I applied this and tried comple testing, and got this warning: DTC arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:217.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:220.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:226.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:232.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:216.13-218.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:216.13-218.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:219.13-223.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:219.13-223.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:225.13-229.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:225.13-229.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:231.13-234.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:231.13-234.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3: Relying on default #size-cells value You need to add this to the nct node: #address-cells = <1>; #size-cells = <0>; Did you see this with your testing? I'm building on top of v5.15 and my distro's dtc is 1.6.0. > --- > Changes from PATCH v1: > - Removed superfluous "status" from channels. > --- > arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > index 68f332ee1886..66734e4e2ea1 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > @@ -213,6 +213,25 @@ &i2c0 { > nct7802@28 { > compatible = "nuvoton,nct7802"; > reg = <0x28>; > + channel@0 { /* LTD */ > + reg = <0>; > + }; > + channel@1 { /* RTD1 */ > + reg = <1>; > + sensor-type = "temperature"; > + temperature-mode = "thermistor"; > + }; > + > + channel@2 { /* RTD2 */ > + reg = <2>; > + sensor-type = "temperature"; > + temperature-mode = "thermistor"; > + }; > + > + channel@3 { /* RTD3 */ > + reg = <3>; > + sensor-type = "temperature"; > + }; > }; > > /* Also connected to: > -- > 2.34.0.rc0.344.g81b53c2807-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DD8C433EF for ; Fri, 5 Nov 2021 01:41:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6460761246 for ; Fri, 5 Nov 2021 01:41:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6460761246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hSQLyT1go2jTZjnJq7A6ERo56VbkgO9ouP1znmShUIo=; b=CLTWPlypfaKsub qaJCvp0rDY0k6CIzMytaCSRoYRLYFG0Vn6vdpbhF8DavnrKq+vNx/tggnRjvKvGwWGynLEvrQQwCd amoIydxuSj7MXcuH8I8xwMX9V2DkSXJ/h0iEjjowDdpEo9iKdRJ4ywD0fBLhqD34zQ6VGOfBwoiG4 Lmic343xzSD8bk+B768hvHtt29/+5x3VuD+Ema/Gvtifyx/72mk7GF3wrBTRK5dZhbTLjzfe1kcIG hJiz34jJKZYQ4AJ73UizgGdqzFFvgcfRt2kfswdsJRFwbpi8iFJfKqI0F1LbShk+pELx/IvlxYDO4 aplGwHa2n7X+qwajaLyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mioDQ-00AKbi-R0; Fri, 05 Nov 2021 01:40:25 +0000 Received: from mail-qv1-xf33.google.com ([2607:f8b0:4864:20::f33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mioDM-00AKZz-E6 for linux-arm-kernel@lists.infradead.org; Fri, 05 Nov 2021 01:40:22 +0000 Received: by mail-qv1-xf33.google.com with SMTP id a24so6507923qvb.5 for ; Thu, 04 Nov 2021 18:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuiu0Wf4u9BEGXBoIO9WIUY1RtGLPv3KstdNH+skVn4=; b=OlHZHpMMlHlA2mvNmNLMVYTBkYoOu+wuDTNv26+y/aJr0eHbC+oJ3i8677sqJTiFUB kZAqRUaI8Q6V6+kY6V4NK/At2bdGiTfcJOC9WS5kJ1FLTQiZNgKrHm0bU7MQi+LOFOTK UScPeAhF0wmBZeDCZ4h5BYhKBppp4cAGLcT3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuiu0Wf4u9BEGXBoIO9WIUY1RtGLPv3KstdNH+skVn4=; b=4905q6uClCKIcuUiIC6mUp0h0kJTsraPZa1DLjodySnoHvxWD2n/C4q20Ve3+Jvs43 g72gdMKuvmhf836O1SrWlOohde7kvdJsn9x5B82c2pN94o7U7m16sdQbxXjVPpS7kfhF ldnAwDWbSQFoTrhyFBxwkhVlWGGoa7nmtmz4++zj9vKZ/V2AyJQQdkDOkojPG3KOaiKc vXDqpg9ve88yG9HvzXGnv6G9ibDIK+vwQ8R/1wD55kBoXAl9Lg8Ya+ZjIS6u0iOdL9tm UgtjWN8xZOXFI/Gd3o9dFU9wiwOWPrEa8qrvO3s4m4Gd658n6k6jn52hZru9qDmWst/U uD0A== X-Gm-Message-State: AOAM532wlf6L/5spqDSIW077vk/J6Jjh0pDEcxqnuiBIv+ej2lwcqfCy D+R8jZCLtRG43GoeoTDGMSaPV2nWGI36AOUDhVg= X-Google-Smtp-Source: ABdhPJwn7ltINiaTnafuAfwJf+9xnaLsMQM755UKrybz+o6veGW29/K/cs79Ln231Xya3DTp+gpEIBBL8k1kZK/4deQ= X-Received: by 2002:a0c:c784:: with SMTP id k4mr53964077qvj.43.1636076417159; Thu, 04 Nov 2021 18:40:17 -0700 (PDT) MIME-Version: 1.0 References: <20211105005955.107419-1-osk@google.com> In-Reply-To: <20211105005955.107419-1-osk@google.com> From: Joel Stanley Date: Fri, 5 Nov 2021 01:40:05 +0000 Message-ID: Subject: Re: [PATCH v2] ARM: dts: aspeed: tyan-s7106: Update nct7802 config To: Oskar Senft Cc: Linux ARM , linux-aspeed , Linux Kernel Mailing List , Rob Herring , Andrew Jeffery X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211104_184020_564469_7B3CD42E X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 5 Nov 2021 at 01:00, Oskar Senft wrote: > > This change updates the configuration for the nct7802 hardware > monitor to correctly configure its temperature sensors. > > Signed-off-by: Oskar Senft I applied this and tried comple testing, and got this warning: DTC arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:217.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:220.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:226.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:232.4-14: Warning (reg_format): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:216.13-218.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:216.13-218.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:219.13-223.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:219.13-223.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@1: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:225.13-229.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:225.13-229.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@2: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:231.13-234.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts:231.13-234.5: Warning (avoid_default_addr_size): /ahb/apb/bus@1e78a000/i2c-bus@40/nct7802@28/channel@3: Relying on default #size-cells value You need to add this to the nct node: #address-cells = <1>; #size-cells = <0>; Did you see this with your testing? I'm building on top of v5.15 and my distro's dtc is 1.6.0. > --- > Changes from PATCH v1: > - Removed superfluous "status" from channels. > --- > arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > index 68f332ee1886..66734e4e2ea1 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts > @@ -213,6 +213,25 @@ &i2c0 { > nct7802@28 { > compatible = "nuvoton,nct7802"; > reg = <0x28>; > + channel@0 { /* LTD */ > + reg = <0>; > + }; > + channel@1 { /* RTD1 */ > + reg = <1>; > + sensor-type = "temperature"; > + temperature-mode = "thermistor"; > + }; > + > + channel@2 { /* RTD2 */ > + reg = <2>; > + sensor-type = "temperature"; > + temperature-mode = "thermistor"; > + }; > + > + channel@3 { /* RTD3 */ > + reg = <3>; > + sensor-type = "temperature"; > + }; > }; > > /* Also connected to: > -- > 2.34.0.rc0.344.g81b53c2807-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel