From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB092C433DB for ; Wed, 31 Mar 2021 07:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 894B5619BD for ; Wed, 31 Mar 2021 07:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234032AbhCaHsz (ORCPT ); Wed, 31 Mar 2021 03:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbhCaHsg (ORCPT ); Wed, 31 Mar 2021 03:48:36 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24205C061574 for ; Wed, 31 Mar 2021 00:48:36 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id t16so9460396qvr.12 for ; Wed, 31 Mar 2021 00:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TcHTMg2iLIDJnGDB9Kaft4m85Uo8IfdtBj6klXtJpyE=; b=FJiZz4ZmH/G2Zr1F54iy3Jk5XSEWTppjpzEhglogAQpCbZhRhgxHSryf7yrAq/6fEQ hulNxBUeYQ251Hz6HWH2ceizKsDnY+YMdamrZjyXoSXYVAsu+rW/JGZXycpLNRAL2hGC 0vjiE8sJb8k04bajmkrFyh1bFirqDHAtUOvCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TcHTMg2iLIDJnGDB9Kaft4m85Uo8IfdtBj6klXtJpyE=; b=CGoAY6kEmrHlmahuaRB6AUDkBXIHIcDivXOFh0HY9RHSSVxo3uoOpPOozo51HspuF1 GGqaEaVsIwT9f/RfXq0FfiBHkAoTlPS8FPYDn4O8W0g64QjemiaQFhi1mjGirmWrloBh un3ESzcfv8yYU7ApMRNA2REYXZSZpTNtbeofl/kIZRmjM6/TcLrfKQALg3NdN/rs8eWS ewc5GUusgsHuyFl1b9WSUo8ePX5itqDrZg3IsabkUYjrF/cJen9pnnRGc6nYvif++CSh t9gwGDc34nFncjoxN81cCQZXwC0ttRlHwm0SvgUUaHf9OjBxg14hEM9UhW8W5wPHjZou EEtg== X-Gm-Message-State: AOAM533Ie0doMi7gLMNCwvFr++6Wx+smuByFT3Nif+xxAd74PK6y/OWN WZLdKCRKhrWDwejL451JX6DLO6TarQ4NA8j0/+0= X-Google-Smtp-Source: ABdhPJzT05GGq7j0qfFdXN+Ja7au989BTKlLZwclCpPbapyscqqlvve47u3FSHQH5b2onjQ2Y/8kGB/3Zw2/b9QOeqg= X-Received: by 2002:ad4:58e3:: with SMTP id di3mr1771117qvb.43.1617176915285; Wed, 31 Mar 2021 00:48:35 -0700 (PDT) MIME-Version: 1.0 References: <20210329094255.347713-1-rashmica.g@gmail.com> In-Reply-To: <20210329094255.347713-1-rashmica.g@gmail.com> From: Joel Stanley Date: Wed, 31 Mar 2021 07:48:23 +0000 Message-ID: Subject: Re: [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon To: Rashmica Gupta Cc: linux-aspeed , Rob Herring , Andrew Jeffery , devicetree , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 29 Mar 2021 at 09:43, Rashmica Gupta wrote: > Can you add a brief message about why we're adding a iio-hwmon bridge for these sensors? > Signed-off-by: Rashmica Gupta > --- > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index fefb0b8fd6d5..2dc72de07906 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -173,6 +173,16 @@ i2c2mux3: i2c@3 { > }; > }; > > + iio-hwmon-dps310 { > + compatible = "iio-hwmon"; > + io-channels = <&dps 0>; > + }; > + > + iio-hwmon-si7020 { > + compatible = "iio-hwmon"; > + io-channels = <&si 1>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -1972,9 +1982,10 @@ &i2c7 { > multi-master; > status = "okay"; > > - si7021-a20@20 { > + si:si7021-a20@20 { That's a very short name. How about we call it humidity (or something else)? Convention is to put a space after the colon. > compatible = "silabs,si7020"; > reg = <0x20>; > + #io-channel-cells = <1>; > }; > > tmp275@48 { > -- > 2.26.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EE2C433E0 for ; Wed, 31 Mar 2021 07:50:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F621619B1 for ; Wed, 31 Mar 2021 07:50:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F621619B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rshbhkyugsbjRv7VGKrE2vY7klyD1YuD35QuqIKm7Cs=; b=hqlhT7QlKEgWLFDJOHwKkyjaZ obOmi2Zk84WycruOi9LM4OxRpQUKXMjP+WVWyvyuyHPtEqFVDuDHP9hEcIsl7YvqL1WkkIAznNnr1 IdMAvWYiBaXWGfSdZJh4QyqG3PH86FarsGSMt5hmlCH5dRL1LHpAq2dElAC+zjSEQDwGY4BWdAyhg yp0v/6P0Y3VID6car48cNbXevJkadisJS0Ajhl+kCiWohjd1uBgM20PLavl2xC4KZjh4LnqI8I+Uh lGH6wxTq1fH7ejkEL+3Y9j0vuJBzV8CxLqKgPID6t+xqZ8UtVACexG1fAyK3TsusloZyLdDOHQWSM hsOE09amg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRVal-005qhB-Ot; Wed, 31 Mar 2021 07:48:43 +0000 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRVag-005qfw-5u for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 07:48:40 +0000 Received: by mail-qv1-xf32.google.com with SMTP id q12so9487059qvc.8 for ; Wed, 31 Mar 2021 00:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TcHTMg2iLIDJnGDB9Kaft4m85Uo8IfdtBj6klXtJpyE=; b=FJiZz4ZmH/G2Zr1F54iy3Jk5XSEWTppjpzEhglogAQpCbZhRhgxHSryf7yrAq/6fEQ hulNxBUeYQ251Hz6HWH2ceizKsDnY+YMdamrZjyXoSXYVAsu+rW/JGZXycpLNRAL2hGC 0vjiE8sJb8k04bajmkrFyh1bFirqDHAtUOvCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TcHTMg2iLIDJnGDB9Kaft4m85Uo8IfdtBj6klXtJpyE=; b=CLAG8oRUlb1ALZX93FjCpkGVxe5cZPa/R/8c3XbyesH8uvS6inzSREkfsapzQgk5DT 5gE8dQPc/XoAkqiWE3ozZK2+b/MindeW3NgTR7RXIntn5VOZTA9PxCi8ocIYvki+/rY9 9cnf87/pbqqCpegkd9Oc4NYSOhbgk784kRHOL7MolAdK+WGVvMaTNY6bEphCij5XYego edH9MxiDEtn5aXevV95dIhU6wiBym+40htvV9oaGhfO0JFv7h8Q+bA8s4eXDAmMYXkHX JXPBKehOoyUggyzsYL9eSPYVZUwOJmrD1C9uv6Yp1AezbszC06rrkTvIJKRYYv84LIeG edFQ== X-Gm-Message-State: AOAM532iFyG9ciYfvon2l8Rien9uNfM7thUdouh7v1/z5ngfcWUN9y9U 2XAgTyWMQxlUhj7GUcCwhQtXsORKboxBhEdXA6Vpa2pECNs+4Q== X-Google-Smtp-Source: ABdhPJzT05GGq7j0qfFdXN+Ja7au989BTKlLZwclCpPbapyscqqlvve47u3FSHQH5b2onjQ2Y/8kGB/3Zw2/b9QOeqg= X-Received: by 2002:ad4:58e3:: with SMTP id di3mr1771117qvb.43.1617176915285; Wed, 31 Mar 2021 00:48:35 -0700 (PDT) MIME-Version: 1.0 References: <20210329094255.347713-1-rashmica.g@gmail.com> In-Reply-To: <20210329094255.347713-1-rashmica.g@gmail.com> From: Joel Stanley Date: Wed, 31 Mar 2021 07:48:23 +0000 Message-ID: Subject: Re: [PATCH] ARM: dts: rainier: Update to access sensors via iio-hwmon To: Rashmica Gupta Cc: linux-aspeed , Rob Herring , Andrew Jeffery , devicetree , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_084838_339790_EFC664E0 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 29 Mar 2021 at 09:43, Rashmica Gupta wrote: > Can you add a brief message about why we're adding a iio-hwmon bridge for these sensors? > Signed-off-by: Rashmica Gupta > --- > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index fefb0b8fd6d5..2dc72de07906 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -173,6 +173,16 @@ i2c2mux3: i2c@3 { > }; > }; > > + iio-hwmon-dps310 { > + compatible = "iio-hwmon"; > + io-channels = <&dps 0>; > + }; > + > + iio-hwmon-si7020 { > + compatible = "iio-hwmon"; > + io-channels = <&si 1>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -1972,9 +1982,10 @@ &i2c7 { > multi-master; > status = "okay"; > > - si7021-a20@20 { > + si:si7021-a20@20 { That's a very short name. How about we call it humidity (or something else)? Convention is to put a space after the colon. > compatible = "silabs,si7020"; > reg = <0x20>; > + #io-channel-cells = <1>; > }; > > tmp275@48 { > -- > 2.26.3 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel