From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1222C55ABD for ; Mon, 16 Nov 2020 06:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CE19222B9 for ; Mon, 16 Nov 2020 06:14:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="fP6vSsOX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726802AbgKPGOW (ORCPT ); Mon, 16 Nov 2020 01:14:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbgKPGOW (ORCPT ); Mon, 16 Nov 2020 01:14:22 -0500 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5176C0613CF for ; Sun, 15 Nov 2020 22:14:21 -0800 (PST) Received: by mail-qk1-x742.google.com with SMTP id 11so15915083qkd.5 for ; Sun, 15 Nov 2020 22:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gviu029IUTZcefVLfZeomA1jSzTP/vwpt9wwXVnDh54=; b=fP6vSsOXqHI5ONHbB/LAyl/UeyOobLvy0HI1/nScnj3DBmvVynFilN5RwNPIGKujsc 8eEF/Q2hMYTN2F6B7Exk29xz7Kvic69142n2eZb49oyGvwJe724tOBDruBkS//jFrfMa c+YheYtF1HSLHaEAlwtvqDHMhluXFRYVwTLPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gviu029IUTZcefVLfZeomA1jSzTP/vwpt9wwXVnDh54=; b=sLmEACTrdfMml2Fr+j0KzrL2jz5MULXkJY/fdrIhJyk4XBMFGmCXj1Z3lQCvQD/HbK UlztGmS6xvAbBpzI8CZ35uACMaNGatPBEehjzATYBVjHSV610U6C2ZIHt2+Q/ZMSbnr4 BDckQ/TTfeRD/KdI9jpkLZcXGmReBJvoMWNQP+rAe+bRqijWyXM4TDCwffrF6DpmlYcY p1bZ3s9LIoo4VlXZQTt3qjkJD6FRFn28qybNKBZNFIHyYPbsUyd4eoDVI+/5bC+ZHZwu MwqUPId8TGW7IGVrc9bDCD9kphWb6wNU46vnG+E8BR8ZrMpiwkrK2KRiLGpU4Ckiahze KcXA== X-Gm-Message-State: AOAM5338WHohgrNu1O6dQJi1HxkoHldEqyWfIEeUd5m04AuPsb2KWxCy 8bUZ/gRNjWTuKluDlOBb7Grl6vM5MWnqHu8F8R8= X-Google-Smtp-Source: ABdhPJxHOxp6ldhR04za+G01MZh65Kwl3vECb6VAUk6UeqPvhFMIiZ5iyvG5qQhxKlB/nhuRZ8M1UXk4FMhMslivTcA= X-Received: by 2002:a05:620a:7e8:: with SMTP id k8mr12692677qkk.273.1605507261007; Sun, 15 Nov 2020 22:14:21 -0800 (PST) MIME-Version: 1.0 References: <1605247168-1028-1-git-send-email-vishwa@linux.vnet.ibm.com> In-Reply-To: <1605247168-1028-1-git-send-email-vishwa@linux.vnet.ibm.com> From: Joel Stanley Date: Mon, 16 Nov 2020 06:14:08 +0000 Message-ID: Subject: Re: [PATCH 1/6] ARM: dts: aspeed: rainier: Add Operator Panel LEDs To: Vishwanatha Subbanna Cc: linux-aspeed , devicetree , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 13 Nov 2020 at 05:59, Vishwanatha Subbanna wrote: > > These LEDs are on the operator panel and are connected via > a PCA9551 I2C expander. > > Signed-off-by: Vishwanatha Subbanna Reviewed-by: Joel Stanley > --- > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index 21ae880..64d8748 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -122,6 +122,38 @@ > reg = <3>; > }; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + /* System ID LED that is at front on Op Panel */ > + front-sys-id0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 0 GPIO_ACTIVE_LOW>; > + }; > + > + /* System Attention Indicator ID LED that is at front on Op Panel */ > + front-check-log0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 1 GPIO_ACTIVE_LOW>; > + }; > + > + /* Enclosure Fault LED that is at front on Op Panel */ > + front-enc-fault1 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 2 GPIO_ACTIVE_LOW>; > + }; > + > + /* System PowerOn LED that is at front on Op Panel */ > + front-sys-pwron0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 3 GPIO_ACTIVE_LOW>; > + }; > + }; > }; > > &ehci1 { > @@ -838,6 +870,56 @@ > }; > }; > > + pca_oppanel: pca9551@60 { > + compatible = "nxp,pca9551"; > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + gpio@0 { > + reg = <0>; > + type = ; > + }; > + > + gpio@1 { > + reg = <1>; > + type = ; > + }; > + > + gpio@2 { > + reg = <2>; > + type = ; > + }; > + > + gpio@3 { > + reg = <3>; > + type = ; > + }; > + > + gpio@4 { > + reg = <4>; > + type = ; > + }; > + > + gpio@5 { > + reg = <5>; > + type = ; > + }; > + > + gpio@6 { > + reg = <6>; > + type = ; > + }; > + > + gpio@7 { > + reg = <7>; > + type = ; > + }; > + }; > + > ibm-panel@62 { > compatible = "ibm,op-panel"; > reg = <(0x62 | I2C_OWN_SLAVE_ADDRESS)>; > -- > 1.8.3.1 >