Re: [PATCH linux dev-4.10] ARM: dts: aspeed: Add devices under FSI CFAM

[Joel Stanley <joel@jms.id.au>]

On Tue, Jun 6, 2017 at 3:16 PM, Jeremy Kerr <jk@ozlabs.org> wrote:
> Hi Joel,
>
>> This describes the SBE FIFO and OCC device that are attached via the FSI
>> bus.
>>
>> As this layout is common to all existing p9 machines, we add them via a
>> dtsi.  This dtsi requires the 'fsi' label be present.
>
> Sounds like a good idea, no need to replicate the p9 FSI topology in
> each BMC's device tree.
>
>> -     gpio-fsi {
>> +     fsi: gpio-fsi {
>>               compatible = "fsi-master-gpio", "fsi-master";
>> -
>> -             status = "okay";
>> +             #address-cells = <2>;
>> +             #size-cells = <0>;
>
> We might want to keep #address-cells and #size-cells in the common
> include, but then we're splitting properties (ie. compatible) between
> the two files. I'm happy either way though.

Ok. I will leave it as is for now, but as we extend the FSI dtsi we
may want to revisit.

> Acked-by: Jeremy Kerr <jk@ozlabs.org>

Thank you for taking a look!

Cheers,

Joel