From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457B7C433DB for ; Thu, 28 Jan 2021 00:51:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A9F764DCC for ; Thu, 28 Jan 2021 00:51:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A9F764DCC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4vXG-0007LD-Ey for qemu-devel@archiver.kernel.org; Wed, 27 Jan 2021 19:51:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4vUb-00067F-AS; Wed, 27 Jan 2021 19:49:01 -0500 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:33629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4vUX-0007Aw-IV; Wed, 27 Jan 2021 19:49:00 -0500 Received: by mail-qk1-x72a.google.com with SMTP id x81so3808333qkb.0; Wed, 27 Jan 2021 16:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HUC/1fjg07UbSP9RAoA40k5EZrQB3OgDlB10WbcOGwg=; b=NbqBhXlhJeXVT7Cfm8FBbfDZSDGtGjXVp1k1gSa2KreB4eVlZwaz+J4MDlqcmVKilZ qhnzCnMPFvgEq1PS/0c5dBGECyaXtyhXUk+79H/kHCnH5lsTpON3tq/aHvQLP6JzX9IH OcIQc/XRs4YEAwy7GQR89pdwU9ve36zu+dHU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HUC/1fjg07UbSP9RAoA40k5EZrQB3OgDlB10WbcOGwg=; b=gOZKmTN6j2U63qLtj/hiFxAIwcIPSjDJpAhoivWPilsMmTEFZMCx2gCePXyWCXiPzq GtbzaNwN3uUfCFTDhQR4HxQjYiFaAs4YrJxlJjVXBxGLInPbS2xVNkTwgFPoDg7uk/84 3sAf6oHxVyuLc4HZfZHs9qmF1TOAQFCLSP9dFYSes0VK3qy4Qx8AfbXDsyVvStSIkQ7d 9LWmtuTIjclp7jwb/gd+aKBGFHuu+SJtpdKc7CLgmSCFrUpfiW3OsblJe7jvO0VjtGmL De4qK/qlNuUT4rVvoxCgYkgj9GL0FcnmPyqC9/g1oQbua7GsSi1LPjf6ZQ+pvX1K/Rlp zALA== X-Gm-Message-State: AOAM5304VIgdl+RLPJWhRr0UC9+zRc2Xx1MWq+m8xcJp8NTqH0VSa6tu Jasv9SWzRix8VdObKq5ZnrnpHy0akcsuLwbP9k8= X-Google-Smtp-Source: ABdhPJzvotcjFLqtH6GMo0EgBlCjAi9YnXr74Z7054jl804vIw5C/Ah/8v5/U1cBz+ho8bHI3wSRGM5qlCECsE4FZH8= X-Received: by 2002:a37:ac10:: with SMTP id e16mr13353480qkm.465.1611794934932; Wed, 27 Jan 2021 16:48:54 -0800 (PST) MIME-Version: 1.0 References: <20210126171059.307867-1-clg@kaod.org> <20210126171059.307867-6-clg@kaod.org> In-Reply-To: <20210126171059.307867-6-clg@kaod.org> From: Joel Stanley Date: Thu, 28 Jan 2021 00:48:42 +0000 Message-ID: Subject: Re: [PATCH 5/7] ppc/pnv: Discard internal BMC initialization when BMC is external To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=joel.stan@gmail.com; helo=mail-qk1-x72a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , qemu-ppc@nongnu.org, Greg Kurz , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 26 Jan 2021 at 17:11, C=C3=A9dric Le Goater wrote: > > The PowerNV machine can be run with an external IPMI BMC device > connected to a remote QEMU machine acting as BMC, using these options : > > -chardev socket,id=3Dipmi0,host=3Dlocalhost,port=3D9002,reconnect=3D10 = \ > -device ipmi-bmc-extern,id=3Dbmc0,chardev=3Dipmi0 \ > -device isa-ipmi-bt,bmc=3Dbmc0,irq=3D10 \ > -nodefaults Should this information also go in docs/system/ppc similar to the descriptions we have in docs/system/arm? > > In that case, some aspects of the BMC initialization should be > skipped, since they rely on the simulator interface. > > Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Joel Stanley > --- > hw/ppc/pnv_bmc.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c > index 86d16b493539..b9bf5735ea0f 100644 > --- a/hw/ppc/pnv_bmc.c > +++ b/hw/ppc/pnv_bmc.c > @@ -51,6 +51,11 @@ typedef struct OemSel { > #define SOFT_OFF 0x00 > #define SOFT_REBOOT 0x01 > > +static bool pnv_bmc_is_simulator(IPMIBmc *bmc) > +{ > + return object_dynamic_cast(OBJECT(bmc), TYPE_IPMI_BMC_SIMULATOR); > +} > + > static void pnv_gen_oem_sel(IPMIBmc *bmc, uint8_t reboot) > { > /* IPMI SEL Event are 16 bytes long */ > @@ -79,6 +84,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt) > const struct ipmi_sdr_compact *sdr; > uint16_t nextrec; > > + if (!pnv_bmc_is_simulator(bmc)) { > + return; > + } > + > offset =3D fdt_add_subnode(fdt, 0, "bmc"); > _FDT(offset); > > @@ -243,6 +252,10 @@ static const IPMINetfn hiomap_netfn =3D { > > void pnv_bmc_set_pnor(IPMIBmc *bmc, PnvPnor *pnor) > { > + if (!pnv_bmc_is_simulator(bmc)) { > + return; > + } > + > object_ref(OBJECT(pnor)); > object_property_add_const_link(OBJECT(bmc), "pnor", OBJECT(pnor)); > > @@ -286,7 +299,7 @@ static int bmc_find(Object *child, void *opaque) > > IPMIBmc *pnv_bmc_find(Error **errp) > { > - ForeachArgs args =3D { TYPE_IPMI_BMC_SIMULATOR, NULL }; > + ForeachArgs args =3D { TYPE_IPMI_BMC, NULL }; > int ret; > > ret =3D object_child_foreach_recursive(object_get_root(), bmc_find, = &args); > -- > 2.26.2 > >