All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Brad Bishop <bradleyb@fuzziesquirrel.com>,
	 Christopher Bostic <cbostic@linux.vnet.ibm.com>,
	"Edward A. James" <eajames@us.ibm.com>
Subject: Re: [PATCH linux dev-4.10 3/3] dts: aspeed: witherspoon: Add FSI devices
Date: Mon, 5 Jun 2017 15:59:40 +0930	[thread overview]
Message-ID: <CACPK8XdMJANFCV8pfrbf=+oR5pzku5ARVs1fE39E5v=eP0p_tQ@mail.gmail.com> (raw)
In-Reply-To: <1494617900-32369-4-git-send-email-eajames@linux.vnet.ibm.com>

On Sat, May 13, 2017 at 5:08 AM, Eddie James <eajames@linux.vnet.ibm.com> wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 46 ++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index f20aaf4..4138c93 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -65,6 +65,8 @@
>
>         gpio-fsi {
>                 compatible = "fsi-master-gpio", "fsi-master";
> +               #address-cells = <2>;
> +               #size-cells = <0>;
>
>                 status = "okay";
>
> @@ -73,6 +75,50 @@
>                 mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
>                 enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
>                 trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
> +
> +               cfam@0,0 {
> +                       reg = <0 0>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;

Since this snippet will be shared by all power9 machines, I suggest we
put it in a dtsi file that is included by them all.

I will resend with my proposal.

Cheers,

Joel

> +
> +                       sbefifo@2400 {
> +                               compatible = "ibm,p9-sbefifo";
> +                               reg = <0x2400 0x400>;
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               occ@1 {
> +                                       compatible = "ibm,p9-occ";
> +                                       reg = <1>;
> +                               };
> +                       };
> +
> +                       hub@3400 {
> +                               compatible = "fsi-master-hub";
> +                               reg = <0x3400 0x400>;
> +                               #address-cells = <2>;
> +                               #size-cells = <0>;
> +
> +                               cfam@1,0 {
> +                                       reg = <1 0>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <1>;
> +
> +                                       sbefifo@2400 {
> +                                               compatible = "ibm,p9-sbefifo";
> +                                               reg = <0x2400 0x400>;
> +                                               #address-cells = <1>;
> +                                               #size-cells = <0>;
> +
> +                                               occ@2 {
> +                                                       compatible =
> +                                                               "ibm,p9-occ";
> +                                                       reg = <2>;
> +                                               };
> +                                       };
> +                               };
> +                       };
> +               };
>         };
>
>         iio-hwmon {
> --
> 1.8.3.1
>

      reply	other threads:[~2017-06-05  6:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 19:38 [PATCH linux dev-4.10 0/3] drivers: fsi: Add OCC driver with SBEFIFO in-kernel API Eddie James
2017-05-12 19:38 ` [PATCH linux dev-4.10 1/3] drivers: fsi: sbefifo: Add " Eddie James
2017-05-12 19:38 ` [PATCH linux dev-4.10 2/3] drivers: fsi: sbefifo: Add OCC driver Eddie James
2017-06-01  6:55   ` Jeremy Kerr
2017-06-01 15:18     ` Eddie James
2017-05-12 19:38 ` [PATCH linux dev-4.10 3/3] dts: aspeed: witherspoon: Add FSI devices Eddie James
2017-06-05  6:29   ` Joel Stanley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8XdMJANFCV8pfrbf=+oR5pzku5ARVs1fE39E5v=eP0p_tQ@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=bradleyb@fuzziesquirrel.com \
    --cc=cbostic@linux.vnet.ibm.com \
    --cc=eajames@linux.vnet.ibm.com \
    --cc=eajames@us.ibm.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.