All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc
Date: Wed, 6 Apr 2022 09:57:35 +0000	[thread overview]
Message-ID: <CACPK8XdUYqNuBpwPPMkjSz4rHxOD3JrrgCOH_3Wf=E06GrWnFA@mail.gmail.com> (raw)
In-Reply-To: <20220405213351.2487658-1-fontaine.fabrice@gmail.com>

Hi Fabrice,

On Tue, 5 Apr 2022 at 21:35, Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Set NSS_DISABLE_CRYPTO_VSX which is available since version 3.64 and
> https://github.com/nss-dev/nss/commit/9dab43371d4d924419523e18ba84f02804880533
> to avoid the following build failure on powerpc:
>
> cc1: warning: '-mvsx' requires hardware floating point
> cc1: error: '-mno-vsx' turns off '-mcrypto'
>
> Fixes:
>  - http://autobuild.buildroot.org/results/6bedb5b658f6c9c16c26c73a524a995e5e84fcc8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libnss/libnss.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
> index 2f7a265136..4582c55ada 100644
> --- a/package/libnss/libnss.mk
> +++ b/package/libnss/libnss.mk
> @@ -51,6 +51,7 @@ LIBNSS_BUILD_VARS = \
>         NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \
>         NSPR_LIB_DIR=$(STAGING_DIR)/usr/lib \
>         NS_USE_GCC=1 \
> +       NSS_DISABLE_CRYPTO_VSX=1 \

How about we introduce a BR2_POWERPC_CPU_HAS_VSX, in a similar fashion
to BR2_POWERPC_CPU_HAS_ALITIVEC?

I've prepared a patch to do that, and rebased your change to use it:

 https://github.com/shenki/buildroot/commits/powerpc-vsx

I did a build test of the autobuilder config you linked to and it succeeded.

I'll send them out tomorrow unless you have an alternative proposal.

Cheers,

Joel

>         NSS_DISABLE_GTESTS=1 \
>         NSS_USE_SYSTEM_SQLITE=1 \
>         NATIVE_CC="$(HOSTCC)" \
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-06  9:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 21:33 [Buildroot] [PATCH 1/1] package/libnss: fix build on powerpc Fabrice Fontaine
2022-04-06  9:57 ` Joel Stanley [this message]
2022-04-06 10:07   ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8XdUYqNuBpwPPMkjSz4rHxOD3JrrgCOH_3Wf=E06GrWnFA@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=joseph.kogut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.