From: Joel Stanley <joel@jms.id.au>
To: Patrick Venture <venture@google.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Hao Wu" <wuhaotsh@google.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
qemu-arm <qemu-arm@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes
Date: Wed, 9 Jun 2021 01:58:21 +0000 [thread overview]
Message-ID: <CACPK8XdXYXCnSW4Cs0+CbtDWe9csrtPGuZx3hvMedV6fR-un7Q@mail.gmail.com> (raw)
In-Reply-To: <CAO=notxHN_JVuyVTO7p+85zWOjeY_uxFfwdbjJXe94qdKhHD0A@mail.gmail.com>
On Tue, 8 Jun 2021 at 19:56, Patrick Venture <venture@google.com> wrote:
>
> On Wed, May 19, 2021 at 10:18 AM Patrick Venture <venture@google.com> wrote:
> >
> > On Tue, May 18, 2021 at 4:27 PM Joel Stanley <joel@jms.id.au> wrote:
> > >
> > > On Tue, 18 May 2021 at 19:41, Patrick Venture <venture@google.com> wrote:
> > > >
> > > > Enables the pca954x muxes in the bmc board configuration.
> > > >
> > > > Signed-off-by: Patrick Venture <venture@google.com>
> > > > Reviewed-by: Hao Wu <wuhaotsh@google.com>
> > >
> > > Not sure about this one, there's no device tree for it in Linux.
> >
> > Yeah, this was just a pick-up from grepping other BMC boards. I added
> > these going off the comment alone. I'd be okay with dropping this in
> > the series.
>
> In this case, the number of patches changed within a version change --
> should I start a fresh series or just bump the version and drop the
> last patch?
I wasn't saying we shouldn't include this change - it's good. I just
didn't have any information to say whether it was correct or not.
I see you chose to resend without this one, lets get Cedric to merge
those patches.
Cheers,
Joel
next prev parent reply other threads:[~2021-06-09 2:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 19:41 [PATCH 0/4] With the pca954x i2c mux available, enable it on aspeed and nuvoton BMC boards Patrick Venture
2021-05-18 19:41 ` [PATCH 1/4] hw/arm: gsj add i2c comments Patrick Venture
2021-05-18 23:22 ` Joel Stanley
2021-05-18 19:41 ` [PATCH 2/4] hw/arm: gsj add pca9548 Patrick Venture
2021-05-18 23:22 ` Joel Stanley
2021-05-18 19:41 ` [PATCH 3/4] hw/arm: quanta-q71l add pca954x muxes Patrick Venture
2021-05-18 23:26 ` Joel Stanley
2021-05-18 19:41 ` [PATCH 4/4] aspeed: sonorapass: enable " Patrick Venture
2021-05-18 23:27 ` Joel Stanley
2021-05-19 17:18 ` Patrick Venture
2021-06-08 19:55 ` Patrick Venture
2021-06-09 1:58 ` Joel Stanley [this message]
2021-06-09 5:23 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XdXYXCnSW4Cs0+CbtDWe9csrtPGuZx3hvMedV6fR-un7Q@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.