From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B81C433F5 for ; Fri, 8 Oct 2021 04:23:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F0EF60F6E for ; Fri, 8 Oct 2021 04:23:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F0EF60F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HQZn474X1z2ypk for ; Fri, 8 Oct 2021 15:23:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=VzzPzDQV; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::f32; helo=mail-qv1-xf32.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=VzzPzDQV; dkim-atps=neutral Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HQZmG28qkz2ynk; Fri, 8 Oct 2021 15:22:37 +1100 (AEDT) Received: by mail-qv1-xf32.google.com with SMTP id cv2so5626989qvb.5; Thu, 07 Oct 2021 21:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hzFQ+A2U60uu6SvNGVBqAvYNQ5Q6B46iZBnqQlLHj1M=; b=VzzPzDQV+Rnew/7Wal3mIc7Cbs/MJZaFsvG+EA/fmz8X1DnTu47KPTloiCw9NuE6Gy 1DktJGo4aniRIVQxyyVlDS8t0dGFDvNXpgs7sQ7ZxkMHIKFCNo8QMXXHqv4fYi+jZBc+ 7rbBms8EVfe7ED0JUGB/W7nhsqqw4+zPrEhio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hzFQ+A2U60uu6SvNGVBqAvYNQ5Q6B46iZBnqQlLHj1M=; b=O/Euw98wn9olXdOLlfVHkbVOfvU2Z9+TYpsuzM3zJ4XeVByEhQosMI+6HZPS/EzO9p H1b76idVoUukqMGqAnb3OAhV1qVzx/1Dg3fQSKFHJqmc/+9c3+wj2N38W6tejDfQmhxd TAO/E67V28z2opPrKRORSs3tmKLeBvo39YWPeHeN0xFU3UoHFGpZFOKTVgONI7MzKqa1 KghRw7fHwp7y7hM4hXZQV03z8ucBKQ8eL0HObChUZYdqji+Y8xU8zMpFGy2kE/3uJmzq GJVbmRGXMd/Dz3RRQTMrw44qfEA64JNzKaopElSXjEIjDaQdg6XZdjcc5/RrfemhEEJA ztWQ== X-Gm-Message-State: AOAM532DMR5FbeJmlI0sfSmPbnM06lLbEJfgTDLObhzcmtKU1o0tKHh6 YL7g5yMngOoCd7q1ktSdPPPbVxj/M+NeiDoPI+0= X-Google-Smtp-Source: ABdhPJyn7kxRjcwMEZhm6yPesmo9KHZuxqioSEsVuMTVQFDf85q7ttZJWPAo9Qq9ejrNShFgysFVRFukeJu/CuenlDU= X-Received: by 2002:a05:6214:98d:: with SMTP id dt13mr7861750qvb.13.1633666953691; Thu, 07 Oct 2021 21:22:33 -0700 (PDT) MIME-Version: 1.0 References: <20211005192226.213539-1-anoo@linux.ibm.com> In-Reply-To: <20211005192226.213539-1-anoo@linux.ibm.com> From: Joel Stanley Date: Fri, 8 Oct 2021 04:22:21 +0000 Message-ID: Subject: Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio To: Adriana Kobylak Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Spinler , Derek Howard , linux-aspeed , OpenBMC Maillist , Adriana Kobylak , Eddie James , Brandon Wyman , shawnmm@us.ibm.com, Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Adriana, On Tue, 5 Oct 2021 at 19:22, Adriana Kobylak wrote: > > From: Adriana Kobylak > > Add the power-config-full-load described in: > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load > > The power-config-full-load gpio is designed to be used to specify how > many power supplies the system should have, in rainier it is 2 or 4. If > enough power supplies fail so that the system no longer has redundancy > (no longer n+1), the hardware will signal to the Onboard Chip Controller > that the system may be oversubscribed, and performance may need to be > reduced so the system can maintain it's powered on state. > > Signed-off-by: Adriana Kobylak This looks good. I think the name is much easier to understand now. I notice you've dropped all of the other names. Do you not need them? It would be great if one of the people you cc'd could provide a reviewed-by before I merge this. Cheers, Joel > --- > > v2: Update commit message. > v3: Updated gpio name to power-config-full-load to match design doc. > > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index 33fae8ad1305..10bde77fb847 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -1998,6 +1998,19 @@ eeprom@51 { > reg = <0x51>; > }; > > + pca_pres3: pca9552@60 { > + compatible = "nxp,pca9552"; > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + gpio-controller; > + #gpio-cells = <2>; > + > + gpio-line-names = > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "power-config-full-load", ""; > + }; > + > pca_pres2: pca9552@61 { > compatible = "nxp,pca9552"; > reg = <0x61>; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095CCC433F5 for ; Fri, 8 Oct 2021 04:24:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1E9A61073 for ; Fri, 8 Oct 2021 04:24:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1E9A61073 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YeX7AcaDwffy9/4MmpemPrTO88g1ZSiK60MQW1c/zSk=; b=2st2lOFM1E4VB+ UGfjj4OmzBNXfzQvGEdGCM4DuJtSNWJbm23EMicorT6+X8nXh68+xiEcT3Y5k/xidpEO3CakifzxY cgrSLJ3LBB0irsIxyJWCRmnBE9Of03oaijuI7txiGjFqs8qQadrR5N4753GcWwPjJAgdw70MSU3Ip 1pNrzi7WYscJtj0xJRIEq+aUPsVFOjwhERjKirHNhAe4tuP6vkCxgCIoQ5dfE0J3qy/H+Y206vLeD v8+oUl/zWXdF4iic/VAwDTui9OvOVERXcD6d/BZ+wrzkz52UdZlhwTsAmWZZJJ4tc/bGAWctVbuQc RnrpIf8kAQz0T1loNqyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhP5-001YeP-Ti; Fri, 08 Oct 2021 04:22:40 +0000 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYhP2-001Ye4-VR for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 04:22:38 +0000 Received: by mail-qv1-xf32.google.com with SMTP id a9so5672477qvf.0 for ; Thu, 07 Oct 2021 21:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hzFQ+A2U60uu6SvNGVBqAvYNQ5Q6B46iZBnqQlLHj1M=; b=VzzPzDQV+Rnew/7Wal3mIc7Cbs/MJZaFsvG+EA/fmz8X1DnTu47KPTloiCw9NuE6Gy 1DktJGo4aniRIVQxyyVlDS8t0dGFDvNXpgs7sQ7ZxkMHIKFCNo8QMXXHqv4fYi+jZBc+ 7rbBms8EVfe7ED0JUGB/W7nhsqqw4+zPrEhio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hzFQ+A2U60uu6SvNGVBqAvYNQ5Q6B46iZBnqQlLHj1M=; b=56q3m/kzY67hYogccB0ltdvsYsnFcJxH70hRko2dyKVY7B9pft4d+Itl4SsnIiUpX1 bgfBsMX0ETSzf4SJcQHslIKz3PKddevSWRMUaY6u5Q3yDRVJ7bKfany2O48IQYyUeKTR Rg+NtyIpITHHig3talNc9dc7eXQxN+PGnLiIyrVQ4gpD0L8t0KLb8VKT2vNJivifv/i1 6dNZViaTte4qj8v61nGGpKE/ISFh5dCwt4XtPiIRswBsHin94MS56Yvt8dj5Uk+C6Dra +9qb5dYN5M+5aOGjRCVP3IvKIkteef4NyB6lNxc1VugjqcRGuGzgXIouXZ1TZ5V0BrGx WtHg== X-Gm-Message-State: AOAM530CXoYUCrfTc9bDqUxcVQifZWaaDXmc/y8rRtwUlgaDwoBmAJis kE+gvuTwZNCyCRLgBL9Odd/OBM1MKOwB8LdXV6o= X-Google-Smtp-Source: ABdhPJyn7kxRjcwMEZhm6yPesmo9KHZuxqioSEsVuMTVQFDf85q7ttZJWPAo9Qq9ejrNShFgysFVRFukeJu/CuenlDU= X-Received: by 2002:a05:6214:98d:: with SMTP id dt13mr7861750qvb.13.1633666953691; Thu, 07 Oct 2021 21:22:33 -0700 (PDT) MIME-Version: 1.0 References: <20211005192226.213539-1-anoo@linux.ibm.com> In-Reply-To: <20211005192226.213539-1-anoo@linux.ibm.com> From: Joel Stanley Date: Fri, 8 Oct 2021 04:22:21 +0000 Message-ID: Subject: Re: [PATCH v3] ARM: dts: aspeed: rainier: Add power-config-full-load gpio To: Adriana Kobylak Cc: Eddie James , Linux ARM , linux-aspeed , OpenBMC Maillist , Brandon Wyman , Matt Spinler , Derek Howard , shawnmm@us.ibm.com, Adriana Kobylak X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_212237_039115_E906C9E5 X-CRM114-Status: GOOD ( 21.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adriana, On Tue, 5 Oct 2021 at 19:22, Adriana Kobylak wrote: > > From: Adriana Kobylak > > Add the power-config-full-load described in: > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md#power-config-full-load > > The power-config-full-load gpio is designed to be used to specify how > many power supplies the system should have, in rainier it is 2 or 4. If > enough power supplies fail so that the system no longer has redundancy > (no longer n+1), the hardware will signal to the Onboard Chip Controller > that the system may be oversubscribed, and performance may need to be > reduced so the system can maintain it's powered on state. > > Signed-off-by: Adriana Kobylak This looks good. I think the name is much easier to understand now. I notice you've dropped all of the other names. Do you not need them? It would be great if one of the people you cc'd could provide a reviewed-by before I merge this. Cheers, Joel > --- > > v2: Update commit message. > v3: Updated gpio name to power-config-full-load to match design doc. > > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index 33fae8ad1305..10bde77fb847 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -1998,6 +1998,19 @@ eeprom@51 { > reg = <0x51>; > }; > > + pca_pres3: pca9552@60 { > + compatible = "nxp,pca9552"; > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + gpio-controller; > + #gpio-cells = <2>; > + > + gpio-line-names = > + "", "", "", "", "", "", "", "", > + "", "", "", "", "", "", "power-config-full-load", ""; > + }; > + > pca_pres2: pca9552@61 { > compatible = "nxp,pca9552"; > reg = <0x61>; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel