* [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
@ 2017-06-28 14:23 Patrick Venture
2017-06-29 5:10 ` Joel Stanley
2017-06-29 12:30 ` Mykola Kostenok
0 siblings, 2 replies; 4+ messages in thread
From: Patrick Venture @ 2017-06-28 14:23 UTC (permalink / raw)
To: venture, joel, openbmc
Signed-off-by: Patrick Venture <venture@google.com>
---
v3: lowercased hex address
v2: Moved pwm_tacho_fixed_clk to clocks.
---
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51 ++++++++++++++++++++++++++++
arch/arm/boot/dts/aspeed-g4.dtsi | 5 +++
2 files changed, 56 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
index e609c53d58f5..3abc2954d26e 100644
--- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
@@ -46,6 +46,57 @@
gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;
};
};
+
+ pwm_tacho: pwm-tacho-controller@1e786000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ reg = <0x1e786000 0x1000>;
+ compatible = "aspeed,ast2500-pwm-tacho";
+ clocks = <&pwm_tacho_fixed_clk>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+ &pinctrl_pwm2_default &pinctrl_pwm3_default>;
+
+ fan@0 {
+ reg = <0x00>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x00>;
+ };
+
+ fan@1 {
+ reg = <0x01>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x01>;
+ };
+
+ fan@2 {
+ reg = <0x02>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x02>;
+ };
+
+ fan@3 {
+ reg = <0x03>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x03>;
+ };
+
+ fan@4 {
+ reg = <0x00>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x04>;
+ };
+
+ fan@5 {
+ reg = <0x01>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x05>;
+ };
+
+ fan@6 {
+ reg = <0x02>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x06>;
+ };
+
+ fan@7 {
+ reg = <0x03>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x07>;
+ };
+ };
};
&fmc {
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index a998a00a2728..9cc959fccfa0 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -36,6 +36,11 @@
};
clocks {
+ pwm_tacho_fixed_clk: fixedclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <24000000>;
+ };
};
ahb {
--
2.13.1.611.g7e3b11ae1-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
2017-06-28 14:23 [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans Patrick Venture
@ 2017-06-29 5:10 ` Joel Stanley
2017-06-29 12:30 ` Mykola Kostenok
1 sibling, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2017-06-29 5:10 UTC (permalink / raw)
To: Patrick Venture; +Cc: OpenBMC Maillist
On Wed, Jun 28, 2017 at 11:53 PM, Patrick Venture <venture@google.com> wrote:
> +
> + pwm_tacho: pwm-tacho-controller@1e786000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
Oops, this should have been #size-cells = <0>.
This is because the child fan nodes have one cell for the address
<0x??> and nothing else (no size).
I fixed this up for you and applied to dev-4.10.
Cheers,
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
2017-06-28 14:23 [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans Patrick Venture
2017-06-29 5:10 ` Joel Stanley
@ 2017-06-29 12:30 ` Mykola Kostenok
2017-06-29 13:40 ` Patrick Venture
1 sibling, 1 reply; 4+ messages in thread
From: Mykola Kostenok @ 2017-06-29 12:30 UTC (permalink / raw)
To: Patrick Venture, joel, openbmc
[-- Attachment #1: Type: text/plain, Size: 4200 bytes --]
Hi!
We want to add pwm_tacho for msn platform too.
Is there some special reason why you add pwm_tacho: pwm-tacho-controller@1e786000 to .dts not .dtsi file?
What about add this:
pwm_tacho: pwm-tacho-controller@1e786000 {
#address-cells = <1>;
#size-cells = <1>;
reg = <0x1e786000 0x1000>;
compatible = "aspeed,ast2500-pwm-tacho";
clocks = <&pwm_tacho_fixed_clk>;
pinctrl-names = "default";
to aspeed-g5.dtsi?
And specific like pinctrl and fan:
pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
&pinctrl_pwm2_default &pinctrl_pwm3_default>;
fan@0 {
reg = <0x00>;
aspeed,fan-tach-ch = /bits/ 8 <0x00>;
};
to .dts file.
Thanks.
Best regards, Mykola Kostenok.
________________________________
От: openbmc <openbmc-bounces+c_mykolak=mellanox.com@lists.ozlabs.org> от имени Patrick Venture <venture@google.com>
Отправлено: 28 июня 2017 г. 17:23:04
Кому: venture@google.com; joel@jms.id.au; openbmc@lists.ozlabs.org
Тема: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
Signed-off-by: Patrick Venture <venture@google.com>
---
v3: lowercased hex address
v2: Moved pwm_tacho_fixed_clk to clocks.
---
arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51 ++++++++++++++++++++++++++++
arch/arm/boot/dts/aspeed-g4.dtsi | 5 +++
2 files changed, 56 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
index e609c53d58f5..3abc2954d26e 100644
--- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
@@ -46,6 +46,57 @@
gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;
};
};
+
+ pwm_tacho: pwm-tacho-controller@1e786000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ reg = <0x1e786000 0x1000>;
+ compatible = "aspeed,ast2500-pwm-tacho";
+ clocks = <&pwm_tacho_fixed_clk>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
+ &pinctrl_pwm2_default &pinctrl_pwm3_default>;
+
+ fan@0 {
+ reg = <0x00>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x00>;
+ };
+
+ fan@1 {
+ reg = <0x01>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x01>;
+ };
+
+ fan@2 {
+ reg = <0x02>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x02>;
+ };
+
+ fan@3 {
+ reg = <0x03>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x03>;
+ };
+
+ fan@4 {
+ reg = <0x00>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x04>;
+ };
+
+ fan@5 {
+ reg = <0x01>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x05>;
+ };
+
+ fan@6 {
+ reg = <0x02>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x06>;
+ };
+
+ fan@7 {
+ reg = <0x03>;
+ aspeed,fan-tach-ch = /bits/ 8 <0x07>;
+ };
+ };
};
&fmc {
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index a998a00a2728..9cc959fccfa0 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -36,6 +36,11 @@
};
clocks {
+ pwm_tacho_fixed_clk: fixedclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <24000000>;
+ };
};
ahb {
--
2.13.1.611.g7e3b11ae1-goog
[-- Attachment #2: Type: text/html, Size: 19276 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
2017-06-29 12:30 ` Mykola Kostenok
@ 2017-06-29 13:40 ` Patrick Venture
0 siblings, 0 replies; 4+ messages in thread
From: Patrick Venture @ 2017-06-29 13:40 UTC (permalink / raw)
To: Mykola Kostenok; +Cc: joel, openbmc
On Thu, Jun 29, 2017 at 5:30 AM, Mykola Kostenok <c_mykolak@mellanox.com> wrote:
> Hi!
>
>
> We want to add pwm_tacho for msn platform too.
>
> Is there some special reason why you add pwm_tacho:
> pwm-tacho-controller@1e786000 to .dts not .dtsi file?
>
>
> What about add this:
>
> pwm_tacho: pwm-tacho-controller@1e786000 {
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x1e786000 0x1000>;
> compatible = "aspeed,ast2500-pwm-tacho";
> clocks = <&pwm_tacho_fixed_clk>;
> pinctrl-names = "default";
>
>
> to aspeed-g5.dtsi?
>
I believe that's completely do-able. I submitted patches for the way
we had it configured here. Defining the fans in a big group with the
pwm specific to the platform. But you're right, I do believe the
primary details are the same across all aspeed-g4/g5 for the
pwm-tacho-controller.
>
> And specific like pinctrl and fan:
>
> pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
> &pinctrl_pwm2_default &pinctrl_pwm3_default>;
>
> fan@0 {
> reg = <0x00>;
> aspeed,fan-tach-ch = /bits/ 8 <0x00>;
> };
>
>
> to .dts file.
>
>
> Thanks.
>
> Best regards, Mykola Kostenok.
>
> ________________________________
> От: openbmc <openbmc-bounces+c_mykolak=mellanox.com@lists.ozlabs.org> от
> имени Patrick Venture <venture@google.com>
> Отправлено: 28 июня 2017 г. 17:23:04
> Кому: venture@google.com; joel@jms.id.au; openbmc@lists.ozlabs.org
> Тема: [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
> v3: lowercased hex address
> v2: Moved pwm_tacho_fixed_clk to clocks.
> ---
> arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 51
> ++++++++++++++++++++++++++++
> arch/arm/boot/dts/aspeed-g4.dtsi | 5 +++
> 2 files changed, 56 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> index e609c53d58f5..3abc2954d26e 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts
> @@ -46,6 +46,57 @@
> gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_LOW>;
> };
> };
> +
> + pwm_tacho: pwm-tacho-controller@1e786000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x1e786000 0x1000>;
> + compatible = "aspeed,ast2500-pwm-tacho";
> + clocks = <&pwm_tacho_fixed_clk>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
> + &pinctrl_pwm2_default &pinctrl_pwm3_default>;
> +
> + fan@0 {
> + reg = <0x00>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x00>;
> + };
> +
> + fan@1 {
> + reg = <0x01>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x01>;
> + };
> +
> + fan@2 {
> + reg = <0x02>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x02>;
> + };
> +
> + fan@3 {
> + reg = <0x03>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x03>;
> + };
> +
> + fan@4 {
> + reg = <0x00>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x04>;
> + };
> +
> + fan@5 {
> + reg = <0x01>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x05>;
> + };
> +
> + fan@6 {
> + reg = <0x02>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x06>;
> + };
> +
> + fan@7 {
> + reg = <0x03>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x07>;
> + };
> + };
> };
>
> &fmc {
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> index a998a00a2728..9cc959fccfa0 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -36,6 +36,11 @@
> };
>
> clocks {
> + pwm_tacho_fixed_clk: fixedclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24000000>;
> + };
> };
>
> ahb {
> --
> 2.13.1.611.g7e3b11ae1-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-29 13:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 14:23 [PATCH linux dev-4.10 v3] ARM: dts: aspeed: quanta: Enable pwm fans Patrick Venture
2017-06-29 5:10 ` Joel Stanley
2017-06-29 12:30 ` Mykola Kostenok
2017-06-29 13:40 ` Patrick Venture
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.