From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 045EBC433E0 for ; Tue, 22 Dec 2020 02:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30FD22ADC for ; Tue, 22 Dec 2020 02:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbgLVC1T (ORCPT ); Mon, 21 Dec 2020 21:27:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgLVC1S (ORCPT ); Mon, 21 Dec 2020 21:27:18 -0500 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3776EC0613D3; Mon, 21 Dec 2020 18:26:38 -0800 (PST) Received: by mail-qt1-x829.google.com with SMTP id g24so8084403qtq.12; Mon, 21 Dec 2020 18:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aa+IvQkdl3mH7p3cqCA6yyl0vf5PDrQXGE5A+/Y+ABg=; b=P6MASFHFpHgisvCiEOOTFT8p7oFaacE7DqQoeEjzP0Xzw9S9mPkWPqrRM1tw+zpODd HTIwbN3O6U75aAoeXuCcKPDYwaBTZSJwm7gFqFQf+thhxhbq0MVAjbFdAmw3BR66iG7h eXQdiUjdyDN8tV2uj3QgCUT1s+QaijuJo6iFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aa+IvQkdl3mH7p3cqCA6yyl0vf5PDrQXGE5A+/Y+ABg=; b=dVgeLqr+C1gYybS7HBGX7FemBCdAG0Df6ppHtSqfJslgu8AT30XzBqZ68KhpmK9mVd E38nm06IC9J2nNy8cbuFZywu9J10GYUxLpiIH9xBMILh6gp1us+Y/hL9iVl3JNJuy4X8 Lb7NEiylq0X7eLKOFc288kVNn48OiX21zy4wtc9VLwaMbKYgkIrso8JQEftixNRrDMpx 4/GlS27nLbHM0fKHorU2XMqQsPiK1EzneKtiirwWmb1URCO1Gqa/Tl1+Zudk+OWTUclT gyzosV41IziKhZzLqqCCCdqudLVHghyyAJGe6VSlRz8uMnVmeJXnhMHBn0px/GqB7cOd RBlA== X-Gm-Message-State: AOAM5328NOeo3KW5kJU5L2FGG2IJPyDIHVAYj34u+2zSoY0273WjejOn uvnaxMNxcM/0J1bVIyTNa8s9PGO+Bxpd9KzSMXY= X-Google-Smtp-Source: ABdhPJwGR2vgLN7ROSkmHZPeIAhNHAr7DPrUSxxLCNmQt5gYuzcx/x+eKJdJqgk/KG2Oz3Gx3EYqX3V4Rj9uV5yoiPg= X-Received: by 2002:ac8:4d4d:: with SMTP id x13mr19211754qtv.385.1608603997385; Mon, 21 Dec 2020 18:26:37 -0800 (PST) MIME-Version: 1.0 References: <20201215192323.24359-1-hongweiz@ami.com> <20201221170048.29821-1-hongweiz@ami.com> In-Reply-To: <20201221170048.29821-1-hongweiz@ami.com> From: Joel Stanley Date: Tue, 22 Dec 2020 02:26:25 +0000 Message-ID: Subject: Re: [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue To: Hongwei Zhang , Ryan Chen Cc: linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Jakub Kicinski , David S Miller , netdev , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Dec 2020 at 17:01, Hongwei Zhang wrote: > > Dear Reviewer, > > When FTGMAC100 driver is used on other NCSI Ethernet controllers, few > controllers have compatible issue. One example is Intel I210 Ethernet > controller on AST2600 BMC, with FTGMAC100 driver, it always trigger > RXDES0_RX_ERR error, cause NCSI initialization failure, removing > FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR fix the issue. I work with a few systems that use the i210 on the 2600. We haven't seen this issue in our testing. Is there something specific about the setup that you use to trigger this? Ryan, is this an issue that Aspeed is aware of? Cheers, Joel > > Here are part of the debug logs: > ...... > [ 35.075552] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.080843] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 55 > [ 35.087141] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.094448] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.101498] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.108205] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 35.287808] i2c i2c-1: new_device: Instantiated device slave-mqueue at 0x12 > [ 35.428379] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.433624] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 56 > [ 35.439915] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.447225] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.454273] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.460972] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 35.797825] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.803241] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 57 > [ 35.809541] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.816848] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.823899] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.830597] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 36.179914] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 36.185160] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 58 > [ 36.191454] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 36.198761] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 36.205813] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 36.212513] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 36.593688] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 36.602937] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 59 > [ 36.609244] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 36.616558] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 36.623608] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 36.630315] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 37.031524] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready > [ 37.067831] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready > ............ > > This patch add a configurable flag, FTGMAC100_RXDES0_RX_ERR_CHK, in FTGMAC100 > driver, it is YES by default, so keep the orignal define of > RXDES0_ANY_ERROR. If it is needed, user can set the flag to NO to remove > the RXDES0_RX_ERR bit, to fix the issue. > > Hongwei Zhang (1): > net: ftgmac100: Fix AST2600 EVB NCSI RX issue > > drivers/net/ethernet/faraday/Kconfig | 9 +++++++++ > drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++ > 2 files changed, 17 insertions(+) > > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C54C433E0 for ; Tue, 22 Dec 2020 02:28:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02B5122ADC for ; Tue, 22 Dec 2020 02:28:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02B5122ADC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4D0Kxw56nszDqR5 for ; Tue, 22 Dec 2020 13:28:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::833; helo=mail-qt1-x833.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=P6MASFHF; dkim-atps=neutral Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D0KwK2HknzDqGb; Tue, 22 Dec 2020 13:26:41 +1100 (AEDT) Received: by mail-qt1-x833.google.com with SMTP id u21so8091392qtw.11; Mon, 21 Dec 2020 18:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aa+IvQkdl3mH7p3cqCA6yyl0vf5PDrQXGE5A+/Y+ABg=; b=P6MASFHFpHgisvCiEOOTFT8p7oFaacE7DqQoeEjzP0Xzw9S9mPkWPqrRM1tw+zpODd HTIwbN3O6U75aAoeXuCcKPDYwaBTZSJwm7gFqFQf+thhxhbq0MVAjbFdAmw3BR66iG7h eXQdiUjdyDN8tV2uj3QgCUT1s+QaijuJo6iFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aa+IvQkdl3mH7p3cqCA6yyl0vf5PDrQXGE5A+/Y+ABg=; b=QHQzHgYdJ8NL0ZY0OEfR2ec6DtO59ps8pEskBdxxostDx78BFrrwAGYrvM9s65u//P 6TCl2mqCxsQs7ftoOtRiyX/RVqKDzo9WgD819/FbUqZmWo1hewLXtP0B/7Df8/jGvgo0 NfALECUEA82GWYDsHjzqBEA9xY5OGl+A3AkPLaWLVpgb6NdFyUaDTkDzbQqso6DArNSA ghEauNQFOr9M03aAe3+Ww/umA9/BKeC5b8QOT7E9P6lA/7imq0ZthZJc+4G9QpGjYSQm jTpRSBPSiCfIBPOM6jOjgTZL5G7wqHO+ZG+iSmy7RL6jNSAMNNjUtyVePmXp2bYIPuSH iXNg== X-Gm-Message-State: AOAM5339CN6I5o+LyQQCFC62IOt9cQOXTCWjXwZhmaN3kdO9LPyeauAZ Md8Vfk3KBTJk5FFRWL7/FvztP1fdbZo0QvhDo7k= X-Google-Smtp-Source: ABdhPJwGR2vgLN7ROSkmHZPeIAhNHAr7DPrUSxxLCNmQt5gYuzcx/x+eKJdJqgk/KG2Oz3Gx3EYqX3V4Rj9uV5yoiPg= X-Received: by 2002:ac8:4d4d:: with SMTP id x13mr19211754qtv.385.1608603997385; Mon, 21 Dec 2020 18:26:37 -0800 (PST) MIME-Version: 1.0 References: <20201215192323.24359-1-hongweiz@ami.com> <20201221170048.29821-1-hongweiz@ami.com> In-Reply-To: <20201221170048.29821-1-hongweiz@ami.com> From: Joel Stanley Date: Tue, 22 Dec 2020 02:26:25 +0000 Message-ID: Subject: Re: [Aspeed, ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue To: Hongwei Zhang , Ryan Chen Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , Andrew Jeffery , netdev , OpenBMC Maillist , Linux Kernel Mailing List , Jakub Kicinski , David S Miller Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, 21 Dec 2020 at 17:01, Hongwei Zhang wrote: > > Dear Reviewer, > > When FTGMAC100 driver is used on other NCSI Ethernet controllers, few > controllers have compatible issue. One example is Intel I210 Ethernet > controller on AST2600 BMC, with FTGMAC100 driver, it always trigger > RXDES0_RX_ERR error, cause NCSI initialization failure, removing > FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR fix the issue. I work with a few systems that use the i210 on the 2600. We haven't seen this issue in our testing. Is there something specific about the setup that you use to trigger this? Ryan, is this an issue that Aspeed is aware of? Cheers, Joel > > Here are part of the debug logs: > ...... > [ 35.075552] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.080843] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 55 > [ 35.087141] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.094448] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.101498] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.108205] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 35.287808] i2c i2c-1: new_device: Instantiated device slave-mqueue at 0x12 > [ 35.428379] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.433624] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 56 > [ 35.439915] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.447225] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.454273] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.460972] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 35.797825] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 35.803241] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 57 > [ 35.809541] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 35.816848] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 35.823899] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 35.830597] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 36.179914] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 36.185160] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 58 > [ 36.191454] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 36.198761] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 36.205813] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 36.212513] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 36.593688] ftgmac100_hard_start_xmit TXDESO=b000003c > [ 36.602937] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 59 > [ 36.609244] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 > [ 36.616558] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 > [ 36.623608] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 > [ 36.630315] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR > [ 37.031524] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready > [ 37.067831] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready > ............ > > This patch add a configurable flag, FTGMAC100_RXDES0_RX_ERR_CHK, in FTGMAC100 > driver, it is YES by default, so keep the orignal define of > RXDES0_ANY_ERROR. If it is needed, user can set the flag to NO to remove > the RXDES0_RX_ERR bit, to fix the issue. > > Hongwei Zhang (1): > net: ftgmac100: Fix AST2600 EVB NCSI RX issue > > drivers/net/ethernet/faraday/Kconfig | 9 +++++++++ > drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++ > 2 files changed, 17 insertions(+) > > -- > 2.17.1 >