From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FEAC433B4 for ; Fri, 21 May 2021 00:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2156C61090 for ; Fri, 21 May 2021 00:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235811AbhEUBBA (ORCPT ); Thu, 20 May 2021 21:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235596AbhEUBA7 (ORCPT ); Thu, 20 May 2021 21:00:59 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBA8C061574; Thu, 20 May 2021 17:59:34 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id c20so18237618qkm.3; Thu, 20 May 2021 17:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/0aFTfAprVVOTOCs/KR4CC/94aej7JpddKXuVpnZ6g=; b=gEX1PhKjxUNcZhruCsw9euBMfZTaMTfSw09jtMO0vu65Hc39DgRYS0mBz+THLpaHuq m2O3HM0FkvpWu3fxirPKwP8W7nlDVG4cby1czMlBnx223XJ2jPnX6uRCcJt+X/Pqyy0o QWVmm7/6JmyUE5O1hu6A9N6/tWL2ym3WiFaHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/0aFTfAprVVOTOCs/KR4CC/94aej7JpddKXuVpnZ6g=; b=YxfVZ4dcWwJQmHj0tL6OoOjFsxNGWH9jls8I3Dw2ujIwnFgSGguZ0uR038lQBMY0HX 0GNhBt8lhMu9kJPWX9jgs+FIhrpSWkYSfLumoEwl908nF0nTw/mzHbFPF/8MgvWfXvO1 WpG8fRolgWUvqu6eNrh3P6VSBRx1Lc7Lij1gnFX6i3mZU9NeujTJj8HDS6LxvkptGnAC lOqJZ3dtMyYmF5X09sGyleJvKyoRl77Xujxz2gco/n+jE2U3zj1wxgQVOAE9zf82X/gM FTUzRU4hGGNQYxCmhPjPkBn+SHPrpqp/+398+GNcKJXmyOJk8Q9LiXxu1XgbqSDN1rRu Duvw== X-Gm-Message-State: AOAM532w8NO4NhGPud8GYH+/S/pCoXdOXG6stWuCiW4enuqpPc4apo9i lZlYua0wh/+T2+Yc/XBvXlIzMo2FI+0jBxxiUQ0= X-Google-Smtp-Source: ABdhPJyOg85pbVP5qfGdda8bH9eLGYzaTgxUlVuD+D9zPYeernDU9rP22PyLTRyI8fLkxDMPzeS683iOIZwwY1pD25s= X-Received: by 2002:a05:620a:704:: with SMTP id 4mr7822674qkc.66.1621558773301; Thu, 20 May 2021 17:59:33 -0700 (PDT) MIME-Version: 1.0 References: <20210520093949.511471-1-andrew@aj.id.au> In-Reply-To: <20210520093949.511471-1-andrew@aj.id.au> From: Joel Stanley Date: Fri, 21 May 2021 00:59:20 +0000 Message-ID: Subject: Re: [PATCH v2] Documentation: checkpatch: Tweak BIT() macro include To: Andrew Jeffery Cc: linux-doc@vger.kernel.org, dwaipayanray1@gmail.com, Lukas Bulwahn , Joe Perches , Jonathan Corbet , Linux Kernel Mailing List , OpenBMC Maillist , Jiri Slaby Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 May 2021 at 17:14, Andrew Jeffery wrote: > > While include/linux/bitops.h brings in the BIT() macro, it was moved to > include/linux/bits.h in commit 8bd9cb51daac ("locking/atomics, asm-generic: > Move some macros from to a new file"). > > Since that commit BIT() has moved again into include/vdso/bits.h via > commit 3945ff37d2f4 ("linux/bits.h: Extract common header for vDSO"). > > I think the move to the vDSO header can be considered an implementation > detail, so for now update the checkpatch documentation to recommend use > of include/linux/bits.h. > > Cc: Jiri Slaby > Acked-by: Jiri Slaby > Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley ...just a little bit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B606C433B4 for ; Fri, 21 May 2021 01:00:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D7CC61090 for ; Fri, 21 May 2021 01:00:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D7CC61090 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FmSvL0nXFz3085 for ; Fri, 21 May 2021 11:00:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=gEX1PhKj; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::736; helo=mail-qk1-x736.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=gEX1PhKj; dkim-atps=neutral Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FmStd6Y43z2yXy for ; Fri, 21 May 2021 10:59:36 +1000 (AEST) Received: by mail-qk1-x736.google.com with SMTP id x8so18240325qkl.2 for ; Thu, 20 May 2021 17:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/0aFTfAprVVOTOCs/KR4CC/94aej7JpddKXuVpnZ6g=; b=gEX1PhKjxUNcZhruCsw9euBMfZTaMTfSw09jtMO0vu65Hc39DgRYS0mBz+THLpaHuq m2O3HM0FkvpWu3fxirPKwP8W7nlDVG4cby1czMlBnx223XJ2jPnX6uRCcJt+X/Pqyy0o QWVmm7/6JmyUE5O1hu6A9N6/tWL2ym3WiFaHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/0aFTfAprVVOTOCs/KR4CC/94aej7JpddKXuVpnZ6g=; b=RCO3Lah0ws7yFRuaH5GeVVqMW2+/FoZQZk0FBBv451D4Wk7I4yNf84Wq430W5YNoFb cn7kXWEl5lMviOf4qRZjJrL7mojOVXjHJWnTCNiGNtXHk4iWNfrM1y6ecPEb3+gChtfu pN/e4tEd4diA3crFdSb4U3HFg4+HQhXOAZ60uOHq0xtaAt2zaf2QRn5XFNYdkePvaAUz Ru7pOzAl+kdUwtQltD+OoTnz+pwxy0Ci1VfkqgP5cVqdmGi1SZZIrNkK6jIewBp4LE5l dAKUyVTADtqHrZOmWsbWhY/ZoMl8JTuJmQYhpRGplarVYmeujEtGx8jr9dvoxy1ldAav Os0w== X-Gm-Message-State: AOAM530PPC1xPV8XseSCCv5CYYOqHGIB1bu3dS1yKeFXfiijChWncY+A clODi+vXIbnAyZacNmd3jlFv+aSBXFXvtEBvgB0= X-Google-Smtp-Source: ABdhPJyOg85pbVP5qfGdda8bH9eLGYzaTgxUlVuD+D9zPYeernDU9rP22PyLTRyI8fLkxDMPzeS683iOIZwwY1pD25s= X-Received: by 2002:a05:620a:704:: with SMTP id 4mr7822674qkc.66.1621558773301; Thu, 20 May 2021 17:59:33 -0700 (PDT) MIME-Version: 1.0 References: <20210520093949.511471-1-andrew@aj.id.au> In-Reply-To: <20210520093949.511471-1-andrew@aj.id.au> From: Joel Stanley Date: Fri, 21 May 2021 00:59:20 +0000 Message-ID: Subject: Re: [PATCH v2] Documentation: checkpatch: Tweak BIT() macro include To: Andrew Jeffery Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Corbet , dwaipayanray1@gmail.com, OpenBMC Maillist , linux-doc@vger.kernel.org, Linux Kernel Mailing List , Joe Perches , Lukas Bulwahn , Jiri Slaby Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 20 May 2021 at 17:14, Andrew Jeffery wrote: > > While include/linux/bitops.h brings in the BIT() macro, it was moved to > include/linux/bits.h in commit 8bd9cb51daac ("locking/atomics, asm-generic: > Move some macros from to a new file"). > > Since that commit BIT() has moved again into include/vdso/bits.h via > commit 3945ff37d2f4 ("linux/bits.h: Extract common header for vDSO"). > > I think the move to the vDSO header can be considered an implementation > detail, so for now update the checkpatch documentation to recommend use > of include/linux/bits.h. > > Cc: Jiri Slaby > Acked-by: Jiri Slaby > Signed-off-by: Andrew Jeffery Reviewed-by: Joel Stanley ...just a little bit