From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmlSo-0000Y4-KF for qemu-devel@nongnu.org; Thu, 24 Jan 2019 15:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmlSn-0005OZ-Ur for qemu-devel@nongnu.org; Thu, 24 Jan 2019 15:19:02 -0500 MIME-Version: 1.0 References: <20181211031044.27628-1-joel@jms.id.au> <20181211031044.27628-3-joel@jms.id.au> In-Reply-To: From: Joel Stanley Date: Fri, 25 Jan 2019 07:18:45 +1100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 2/2] aspeed/scu: Implement power off register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Andrew Jeffery , qemu-arm , QEMU Developers On Fri, 4 Jan 2019 at 03:26, Peter Maydell wrote: > > On Tue, 11 Dec 2018 at 03:11, Joel Stanley wrote: > > > > This register does not exist in hardware. It is here to allow the guest > > code to cause Qemu to exit when required. > > > > The register address chosen is unused in the emulated machines > > datasheets. > I'm always a bit dubious about adding things to QEMU devices > which don't exist in the real hardware we're emulating. If we > do want to do that, I think we should clearly flag them up as > being QEMU-specific with suitable comments and naming of > the #define, etc. Since writing this patch I was made aware of -no-reboot. That flag solves the problem I had so we can drop these patches for now. Cheers, Joel