From: Joel Stanley <joel@jms.id.au>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pflash: new package
Date: Tue, 26 Jul 2016 11:57:17 +0930 [thread overview]
Message-ID: <CACPK8XeOj5AyLk6iNZZ2-0ouc2O5W30YRfpZTLAQ=nPxEPZ1cw@mail.gmail.com> (raw)
In-Reply-To: <20160726000756.560aa52e@free-electrons.com>
On Tue, Jul 26, 2016 at 7:37 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 25 Jul 2016 15:31:27 +0930, Joel Stanley wrote:
>
>> diff --git a/package/pflash/Config.in b/package/pflash/Config.in
>> new file mode 100644
>> index 000000000000..315989724088
>> --- /dev/null
>> +++ b/package/pflash/Config.in
>> @@ -0,0 +1,6 @@
>> +config BR2_PACKAGE_PFLASH
>> + bool "pflash"
>> + depends on BR2_arm || BR2_powerpc64 || BR2_powerpc64le || BR2_x86_64
>
> Is there something that makes it inherently usable only on those
> architectures?
Yeah, the 'libflash' library selects different backends depending on it's
>
>> diff --git a/package/pflash/pflash.mk b/package/pflash/pflash.mk
>> new file mode 100644
>> index 000000000000..ab19ad699866
>> --- /dev/null
>> +++ b/package/pflash/pflash.mk
>> @@ -0,0 +1,32 @@
>> +################################################################################
>> +#
>> +# pflash
>> +#
>> +################################################################################
>> +
>> +PFLASH_VERSION = skiboot-5.2.4
>> +
>> +PFLASH_SITE = $(call github,open-power,skiboot,$(PFLASH_VERSION))
>
> So skiboot is a much much larger repository, with lots of other things,
> and you're building just the external/pflash subdirectory of it.
>
> Are you sure we'll never want to have a package for other things in the
> skiboot repository?
We might want to package other tools in the future.
How should I change the packaging of pflash?
>
>> +PFLASH_INSTALL_STAGING = YES
>
> You're not specifying any PFLASH_INSTALL_STAGING_CMDS, so this is
> useless.
Thanks for clearing that up. I've fixed it in v2.
>
>> +PFLASH_LICENSE = Apache 2.0
>> +PFLASH_LICENSE_FILE = LICENCE
>> +
>> +PFLASH_MAKE_OPTS += CROSS_COMPILE="$(TARGET_CROSS)" \
>> + PFLASH_VERSION=$(PFLASH_VERSION) \
>> + DESTDIR=$(TARGET_DIR) \
>
> DESTDIR should only be passed at install time.
Okay.
>
>> + -C $(@D)/external/pflash \
>
> Unneeded trailing \
Okay.
>
> Also, we prefer the -C option and its argument to be part of the build
> and install commands themselves.
Even though we would be replicating them for every invocation of make?
I think it's better placed in a variable so changes can be made in one
place.
Cheers,
Joel
next prev parent reply other threads:[~2016-07-26 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 6:01 [Buildroot] [PATCH] package/pflash: new package Joel Stanley
2016-07-25 6:14 ` Bernd Kuhls
2016-07-25 6:20 ` Joel Stanley
2016-07-25 6:38 ` [Buildroot] [PATCH v2] " Joel Stanley
2016-07-25 22:07 ` [Buildroot] [PATCH] " Thomas Petazzoni
2016-07-26 2:27 ` Joel Stanley [this message]
2016-07-26 7:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XeOj5AyLk6iNZZ2-0ouc2O5W30YRfpZTLAQ=nPxEPZ1cw@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.