* [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree
@ 2019-07-08 2:47 Joel Stanley
2019-07-09 0:03 ` Andrew Jeffery
2019-07-09 21:04 ` Adriana Kobylak
0 siblings, 2 replies; 5+ messages in thread
From: Joel Stanley @ 2019-07-08 2:47 UTC (permalink / raw)
To: Adriana Kobylak, Hongwei Zhang, John Wang, openbmc
This device driver was never upstreamed and so it has been dropped from
the tree. Remove the node from systems that had it enabled.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ----
arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ----
arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ----
3 files changed, 12 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
index c762c02dc716..628195b66d46 100644
--- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
@@ -235,10 +235,6 @@
flash = <&spi1>;
};
-&mbox {
- status = "okay";
-};
-
&mac0 {
status = "okay";
pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
index a3d6b71518fc..73319917cb74 100644
--- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
@@ -163,10 +163,6 @@
status = "okay";
};
-&mbox {
- status = "okay";
-};
-
&pwm_tacho {
status = "okay";
pinctrl-names = "default";
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
index 270c9236deff..caac895c60b4 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
@@ -317,10 +317,6 @@
flash = <&spi1>;
};
-&mbox {
- status = "okay";
-};
-
&mac0 {
status = "okay";
pinctrl-names = "default";
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree
2019-07-08 2:47 [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree Joel Stanley
@ 2019-07-09 0:03 ` Andrew Jeffery
2019-07-10 16:17 ` Adriana Kobylak
2019-07-09 21:04 ` Adriana Kobylak
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2019-07-09 0:03 UTC (permalink / raw)
To: openbmc
On Mon, 8 Jul 2019, at 12:18, Joel Stanley wrote:
> This device driver was never upstreamed and so it has been dropped from
> the tree. Remove the node from systems that had it enabled.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ----
> arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ----
> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index c762c02dc716..628195b66d46 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -235,10 +235,6 @@
> flash = <&spi1>;
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &mac0 {
> status = "okay";
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> index a3d6b71518fc..73319917cb74 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> @@ -163,10 +163,6 @@
> status = "okay";
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &pwm_tacho {
> status = "okay";
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> index 270c9236deff..caac895c60b4 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> @@ -317,10 +317,6 @@
> flash = <&spi1>;
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &mac0 {
> status = "okay";
> pinctrl-names = "default";
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree
2019-07-08 2:47 [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree Joel Stanley
2019-07-09 0:03 ` Andrew Jeffery
@ 2019-07-09 21:04 ` Adriana Kobylak
2019-07-09 22:24 ` Joel Stanley
1 sibling, 1 reply; 5+ messages in thread
From: Adriana Kobylak @ 2019-07-09 21:04 UTC (permalink / raw)
To: Joel Stanley; +Cc: Adriana Kobylak, Hongwei Zhang, John Wang, openbmc, openbmc
On 2019-07-07 21:47, Joel Stanley wrote:
> This device driver was never upstreamed and so it has been dropped from
> the tree. Remove the node from systems that had it enabled.
Seems there are other systems that have it enabled, like witherspoon,
palmetto, zaius, and lanyang, should this be removed from their tree as
well?
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ----
> arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ----
> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index c762c02dc716..628195b66d46 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -235,10 +235,6 @@
> flash = <&spi1>;
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &mac0 {
> status = "okay";
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> index a3d6b71518fc..73319917cb74 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> @@ -163,10 +163,6 @@
> status = "okay";
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &pwm_tacho {
> status = "okay";
> pinctrl-names = "default";
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> index 270c9236deff..caac895c60b4 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> @@ -317,10 +317,6 @@
> flash = <&spi1>;
> };
>
> -&mbox {
> - status = "okay";
> -};
> -
> &mac0 {
> status = "okay";
> pinctrl-names = "default";
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree
2019-07-09 21:04 ` Adriana Kobylak
@ 2019-07-09 22:24 ` Joel Stanley
0 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2019-07-09 22:24 UTC (permalink / raw)
To: Adriana Kobylak
Cc: Adriana Kobylak, Hongwei Zhang, John Wang, OpenBMC Maillist, openbmc
On Tue, 9 Jul 2019 at 21:02, Adriana Kobylak <anoo@linux.ibm.com> wrote:
>
> On 2019-07-07 21:47, Joel Stanley wrote:
> > This device driver was never upstreamed and so it has been dropped from
> > the tree. Remove the node from systems that had it enabled.
>
> Seems there are other systems that have it enabled, like witherspoon,
> palmetto, zaius, and lanyang, should this be removed from their tree as
> well?
Thanks for taking a close look. The systems I remove it from in this
patch are ones that enabled it in the patch that adds the device tree.
Others had it enabled in a separate patch, which I dropped from
dev-5.2.
Cheers,
Joel
>
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ----
> > arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ----
> > arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ----
> > 3 files changed, 12 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > index c762c02dc716..628195b66d46 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > @@ -235,10 +235,6 @@
> > flash = <&spi1>;
> > };
> >
> > -&mbox {
> > - status = "okay";
> > -};
> > -
> > &mac0 {
> > status = "okay";
> > pinctrl-names = "default";
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> > b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> > index a3d6b71518fc..73319917cb74 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
> > @@ -163,10 +163,6 @@
> > status = "okay";
> > };
> >
> > -&mbox {
> > - status = "okay";
> > -};
> > -
> > &pwm_tacho {
> > status = "okay";
> > pinctrl-names = "default";
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> > b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> > index 270c9236deff..caac895c60b4 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
> > @@ -317,10 +317,6 @@
> > flash = <&spi1>;
> > };
> >
> > -&mbox {
> > - status = "okay";
> > -};
> > -
> > &mac0 {
> > status = "okay";
> > pinctrl-names = "default";
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree
2019-07-09 0:03 ` Andrew Jeffery
@ 2019-07-10 16:17 ` Adriana Kobylak
0 siblings, 0 replies; 5+ messages in thread
From: Adriana Kobylak @ 2019-07-10 16:17 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: openbmc, openbmc
On 2019-07-08 19:03, Andrew Jeffery wrote:
> On Mon, 8 Jul 2019, at 12:18, Joel Stanley wrote:
>> This device driver was never upstreamed and so it has been dropped
>> from
>> the tree. Remove the node from systems that had it enabled.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
>
Acked-by: Adriana Kobylak <anoo@us.ibm.com>
>> ---
>> arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 4 ----
>> arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts | 4 ----
>> arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 4 ----
>> 3 files changed, 12 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
>> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
>> index c762c02dc716..628195b66d46 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
>> @@ -235,10 +235,6 @@
>> flash = <&spi1>;
>> };
>>
>> -&mbox {
>> - status = "okay";
>> -};
>> -
>> &mac0 {
>> status = "okay";
>> pinctrl-names = "default";
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
>> b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
>> index a3d6b71518fc..73319917cb74 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-microsoft-olympus.dts
>> @@ -163,10 +163,6 @@
>> status = "okay";
>> };
>>
>> -&mbox {
>> - status = "okay";
>> -};
>> -
>> &pwm_tacho {
>> status = "okay";
>> pinctrl-names = "default";
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> index 270c9236deff..caac895c60b4 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-swift.dts
>> @@ -317,10 +317,6 @@
>> flash = <&spi1>;
>> };
>>
>> -&mbox {
>> - status = "okay";
>> -};
>> -
>> &mac0 {
>> status = "okay";
>> pinctrl-names = "default";
>> --
>> 2.20.1
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-10 16:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 2:47 [PATCH linux dev-5.2] ARM: dts: aspeed: Remove mbox node from device tree Joel Stanley
2019-07-09 0:03 ` Andrew Jeffery
2019-07-10 16:17 ` Adriana Kobylak
2019-07-09 21:04 ` Adriana Kobylak
2019-07-09 22:24 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.