From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932346AbeAKXzB (ORCPT + 1 other); Thu, 11 Jan 2018 18:55:01 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:38635 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbeAKXy6 (ORCPT ); Thu, 11 Jan 2018 18:54:58 -0500 X-Google-Smtp-Source: ACJfBov0ejvxNcPSriHwz3HGvscrhThIsbuGZIH/56fwR6r2GD3ZW2D+B48zr4PVdUcx0HgbLStXZFMKvO1YfdKhHBM= MIME-Version: 1.0 In-Reply-To: References: <1514202808-29747-1-git-send-email-oleksandrs@mellanox.com> <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> From: Joel Stanley Date: Thu, 11 Jan 2018 15:54:36 -0800 X-Google-Sender-Auth: 61Yq5AIjBVL7YkgizB2b5ZHYMCY Message-ID: Subject: Re: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver To: Oleksandr Shamray Cc: Greg KH , Arnd Bergmann , Linux Kernel Mailing List , Linux ARM , devicetree , OpenBMC Maillist , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial@vger.kernel.org, Vadim Pasternak , system-sw-low-level@mellanox.com, Rob Herring , openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, "David S . Miller" , mchehab@kernel.org, Jiri Pirko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 9:50 AM, Joel Stanley wrote: > On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray wrote: >> +jtag: jtag@1e6e4000 { >> + compatible = "aspeed,ast2500-jtag"; >> + reg = <0x1e6e4000 0x1c>; >> + clocks = <&clk_apb>; > > We've now got a proper clock driver upstream. Can you update the > example to match the newly added bindings? > > clocks = <&syscon ASPEED_CLK_APB>; > I think we need to ensure the reset is deasserted as well. You will need: resets = <&syscon ASPEED_RESET_JTAG_MASTER>; In addition, we need to make sure the reset line is deasserted in the driver. Take a look at how I did this in the i2c driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edd20e95bca4a5434f264d8ab40d729761479825 + bus->rst = devm_reset_control_get_shared(&pdev->dev, NULL); + if (IS_ERR(bus->rst)) { + dev_err(&pdev->dev, + "missing or invalid reset controller device tree entry"); + return PTR_ERR(bus->rst); + } + reset_control_deassert(bus->rst); Please give this a test with an upstream kernel from a fresh power on. Cheers, Joel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Stanley Subject: Re: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver Date: Thu, 11 Jan 2018 15:54:36 -0800 Message-ID: References: <1514202808-29747-1-git-send-email-oleksandrs@mellanox.com> <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oleksandr Shamray Cc: Greg KH , Arnd Bergmann , Linux Kernel Mailing List , Linux ARM , devicetree , OpenBMC Maillist , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vadim Pasternak , system-sw-low-level-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Rob Herring , openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S . Miller" , mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Jiri Pirko List-Id: devicetree@vger.kernel.org On Thu, Jan 11, 2018 at 9:50 AM, Joel Stanley wrote: > On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray wrote: >> +jtag: jtag@1e6e4000 { >> + compatible = "aspeed,ast2500-jtag"; >> + reg = <0x1e6e4000 0x1c>; >> + clocks = <&clk_apb>; > > We've now got a proper clock driver upstream. Can you update the > example to match the newly added bindings? > > clocks = <&syscon ASPEED_CLK_APB>; > I think we need to ensure the reset is deasserted as well. You will need: resets = <&syscon ASPEED_RESET_JTAG_MASTER>; In addition, we need to make sure the reset line is deasserted in the driver. Take a look at how I did this in the i2c driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edd20e95bca4a5434f264d8ab40d729761479825 + bus->rst = devm_reset_control_get_shared(&pdev->dev, NULL); + if (IS_ERR(bus->rst)) { + dev_err(&pdev->dev, + "missing or invalid reset controller device tree entry"); + return PTR_ERR(bus->rst); + } + reset_control_deassert(bus->rst); Please give this a test with an upstream kernel from a fresh power on. Cheers, Joel From mboxrd@z Thu Jan 1 00:00:00 1970 From: joel@jms.id.au (Joel Stanley) Date: Thu, 11 Jan 2018 15:54:36 -0800 Subject: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver In-Reply-To: References: <1514202808-29747-1-git-send-email-oleksandrs@mellanox.com> <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 11, 2018 at 9:50 AM, Joel Stanley wrote: > On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray wrote: >> +jtag: jtag at 1e6e4000 { >> + compatible = "aspeed,ast2500-jtag"; >> + reg = <0x1e6e4000 0x1c>; >> + clocks = <&clk_apb>; > > We've now got a proper clock driver upstream. Can you update the > example to match the newly added bindings? > > clocks = <&syscon ASPEED_CLK_APB>; > I think we need to ensure the reset is deasserted as well. You will need: resets = <&syscon ASPEED_RESET_JTAG_MASTER>; In addition, we need to make sure the reset line is deasserted in the driver. Take a look at how I did this in the i2c driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=edd20e95bca4a5434f264d8ab40d729761479825 + bus->rst = devm_reset_control_get_shared(&pdev->dev, NULL); + if (IS_ERR(bus->rst)) { + dev_err(&pdev->dev, + "missing or invalid reset controller device tree entry"); + return PTR_ERR(bus->rst); + } + reset_control_deassert(bus->rst); Please give this a test with an upstream kernel from a fresh power on. Cheers, Joel