From: Joel Stanley <joel@jms.id.au>
To: John Wang <wangzhiqiang.bj@bytedance.com>
Cc: "OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
郁雷 <yulei.sh@bytedance.com>,
xuxiaohan@bytedance.com
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio
Date: Fri, 11 Dec 2020 10:47:50 +0000 [thread overview]
Message-ID: <CACPK8Xep2sN0JMh1HUVtfSFc-erOyPv1Tu8tjep8SYEHPB6Mew@mail.gmail.com> (raw)
In-Reply-To: <20201211040002.1030-2-wangzhiqiang.bj@bytedance.com>
On Fri, 11 Dec 2020 at 04:00, John Wang <wangzhiqiang.bj@bytedance.com> wrote:
>
> The NCSI_BMC_R_SEL and EN_NCSI_SWITCH_N should be active-high
>
> Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> index 3a4bf3db400c..8baefd2d6962 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-bytedance-g220a.dts
> @@ -912,14 +912,14 @@ fan@5 {
> &gpio {
> pin_gpio_i3 {
> gpio-hog;
> - gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_LOW>;
> + gpios = <ASPEED_GPIO(I, 3) GPIO_ACTIVE_HIGH>;
> output-low;
> line-name = "NCSI_BMC_R_SEL";
> };
>
> pin_gpio_b6 {
> gpio-hog;
> - gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_LOW>;
> + gpios = <ASPEED_GPIO(B, 6) GPIO_ACTIVE_HIGH>;
> output-low;
> line-name = "EN_NCSI_SWITCH_N";
> };
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-12-11 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 4:00 [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb John Wang
2020-12-11 4:00 ` [PATCH 2/2] ARM: dts: aspeed: g220a: Fix some gpio John Wang
2020-12-11 10:47 ` Joel Stanley [this message]
2020-12-11 10:47 ` [PATCH 1/2] ARM: dts: aspeed: g220a: Enable ipmb Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xep2sN0JMh1HUVtfSFc-erOyPv1Tu8tjep8SYEHPB6Mew@mail.gmail.com \
--to=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=xuxiaohan@bytedance.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.